From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C8C8A0546; Wed, 7 Apr 2021 04:31:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 208D8141042; Wed, 7 Apr 2021 04:31:01 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id CF061407FF; Wed, 7 Apr 2021 04:30:59 +0200 (CEST) IronPort-SDR: 1RbNMrikhQfVJ7Qcx2c5cZLQ9+93F8n5SalqhrJ7zXnQA7ZlZfqti+khgdHfAQUQnS0vMCxdES iLUKPIhBC5zA== X-IronPort-AV: E=McAfee;i="6000,8403,9946"; a="173281035" X-IronPort-AV: E=Sophos;i="5.82,201,1613462400"; d="scan'208";a="173281035" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2021 19:30:58 -0700 IronPort-SDR: +Ow9AdZ3byc3GeZcPSg6PfcWQ8NJoq7QXpqP9Bu89v/UCSpNOOxlX1wqtqVbDkbAN1fDql+Qu/ N0tPIFBuk64g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,201,1613462400"; d="scan'208";a="530035564" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga004.jf.intel.com with ESMTP; 06 Apr 2021 19:30:57 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 6 Apr 2021 19:30:57 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 6 Apr 2021 19:30:57 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 6 Apr 2021 19:30:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M4gg+EvVmnaMRgiciBT89jAPKt4OErOJjOdz6U97asT7FdAPpMmDcb+ViKOQl8IFyOVgj/Nfr14Ep2/g3eGkSYeLOnD4m3GdvuDCxFADtqIpinE8pqswtQuk4lLNRIVmHxpEG/7fzgIMDHmhcLxXLqxRqSoV1wLgFrjhqWHCU12c0mLpYeAbLAND9ZCi9FpmiZPYlpD+RCJPqt3OtEDEtTW4/grwo2a1PmodYqQsyJzZ/46TcPLjQAzC+5prVeAMMviWGjnas7UPzOHds9gjmZ7aj/08sxg8UUA2vhNcTlHgPVrgXdb+fBDGPw281S922JUDpCORayETx098V31+nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ICUkmsYbCH7OHBbWjEc7w1FhTLUJYk8VcEwmrfkYI0=; b=bE91PM+UHKmwimaRRdgUjJXUGjObgFpCw4EKP1vdFzvLz2cvJhX8Xc3TQTJabC4P0h72VZn2er/MLyzODBPr38lE2zHyPf2xlN4h35SY9UcrnaIwsP+BNyMvRj0uk8BtLtXC70ezmEsm8Qrn97bAV5blZgcl9z3v0Jpayvr/uIVzjmy52F8QygSSpeQYDVwmHrWL7+I/G8IWIvOXJ4iKWKB6uTt/PBIIcbRhFCpvhd1Khtlt/f8Yr6QkWL9XHPMg1OGlKR85vtHD8xiYMU6KzHtNvhXyuPKI0C0R0y8XsC5svRHPIt3F4zKMa5dsAivRuRidErwRcrUi+qfl/NZV4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ICUkmsYbCH7OHBbWjEc7w1FhTLUJYk8VcEwmrfkYI0=; b=SW0JhMDMui7jyRui+1mgtTG+2tzYi9ERk6C90qJyIpFB816CTf3hpZuRpt411Ni2vzBJ5OV4qjI5k0mTF8xep+B1oWtsHBaipVU/7B/siCcWhJiA/U21U67KpzOlLec7vQlOnktvJiZgLuVieG1Mj2O34mJaKWB8E03TbIGAspU= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM5PR1101MB2249.namprd11.prod.outlook.com (2603:10b6:4:5a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.32; Wed, 7 Apr 2021 02:30:54 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c%6]) with mapi id 15.20.4020.017; Wed, 7 Apr 2021 02:30:54 +0000 From: "Li, Xiaoyun" To: "Yu, DapengX" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd Thread-Index: AQHXJtETGJ3/xVRznkCZQT2lAwB5Y6qoXjVw Date: Wed, 7 Apr 2021 02:30:54 +0000 Message-ID: References: <20210401082844.401918-1-dapengx.yu@intel.com> In-Reply-To: <20210401082844.401918-1-dapengx.yu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d565d89f-02f1-46d9-377a-08d8f96d2b2a x-ms-traffictypediagnostic: DM5PR1101MB2249: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7hS/NYPyEpJzTUMgigt7qmBC6zGeNNPQUcrK9m1m/NTP/Jq7AQlmCBjL37kThrpx2TuBoaVidwKXrTUyp2CYgAYDvrycbs5EMnX/ovDwdV7gazCoovj8CrFk2Cg0Yzff/Jr0upheUkHPn2LMtEbKWSm3/R6Yf47lcVhsJFAp+KbzgCJxY1goVwBFBLwprNj6ipTyYWSA/ksBVrmP9V/viUo8s7r1hW6X5rBCq7/dVlRGiXrCGTYQenV08AbKuvyOgQkbEZ4V7CH5Y2s69l+I9HscsPPz0Y6SA9d9SSV/k6ygMS8/Ln+G3qDUtYJAOSgQDhbsN68UgfY1o7cLVpQVN/tP+Fa3JGY5A+d/GbV4Jd0clnl1mzfyckT0J3d1ykIWGJhD4+ufiFqm+k7t/4HsCUQwHMMgWOeMuT0bv6tzRF2Hi1PtCfLokt576bO/gk9Bt8mukwUE4ndmXV2p8gAtsFmZfl+Ygm7FLr8q/MPdZu8FauAwWcNi/kJWOi/Jlz81ZwI0wO15LbNxRtlUzlg4AA23VUusPdJZ0IsdqCJIhf5YfgwitiH9A01NUUY5k/gVCufvqsaUruxvMiSwW/Ok1oxP6pbFXQQIiFCP+r96Lct/ascK1J62G1yHnufF4G50Aq7QIEBXO4epz3l61VM/nJq7sP8XZ8Xu0MXrvBAPWXY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(136003)(39860400002)(376002)(396003)(366004)(71200400001)(8676002)(478600001)(76116006)(64756008)(52536014)(66556008)(5660300002)(450100002)(55016002)(9686003)(6636002)(4326008)(33656002)(66446008)(186003)(86362001)(54906003)(316002)(110136005)(6506007)(53546011)(66946007)(26005)(2906002)(38100700001)(83380400001)(66476007)(8936002)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?mxyD28EvXJuLTy6trTqPd0q3fUjFi468qM3WCQ+FB1q2MdvZS/U5N3puKyDc?= =?us-ascii?Q?9+pQU94cPNb4nBG5uahu33vSWq3+K5sriTO5YonAXDOqQSZpSJMAZNPI81JH?= =?us-ascii?Q?KOrk3tgm0CyRLQlBoKh6l/MT4zS49RfaKFqFS8b/cTK3x7LNhW2hgCg9dFN9?= =?us-ascii?Q?9YBCXXnCrJuQSUENiQKju0b/yCR1S/8GBU3Sg95AM06LJhKESiYpEnh+SwbB?= =?us-ascii?Q?Gsm/kIzuF5p09Y4gdgmsUFX6k0JsJK0+WOHyueo2CdzkVopSAlVMQ04zQKL7?= =?us-ascii?Q?EG05KIMnLHakEoRO4Vs4OCf+2uUF2453izwUd7Yv0VfbMv1rAw6SwH9L4i/s?= =?us-ascii?Q?OLwoyWDEwXwFk+2sfpw9tzFuewNdrfRck01d52S24+RZrauCh5KO6RSut3l9?= =?us-ascii?Q?8vIejVOKdfmCKmpaln7HJam2v5YKEHC4oTEfAoRRuoQBYS7H39kgu4Qvj4GR?= =?us-ascii?Q?Hn5eSlfwxYojFSWjA/mimmPnExmKL/gnN/tv1eRstWVRj8In8NUCDpZLSjkk?= =?us-ascii?Q?CUEz8rsrfrG0Tymwrn2WMGpaXQDgr6UUwKQAjw/msJ898a1AHQPUFtX6N0bZ?= =?us-ascii?Q?9N2EFkbn0ZZ/YIty+0yRovJQv3fWikeCO4pkpWz22uhQwb++bdxpFLB8amaR?= =?us-ascii?Q?28MBfPXJhpWv7C+HaaPNvte2jmMKItfIuE2JOd0cc+phGEf/jIVa2c/p10ob?= =?us-ascii?Q?tUBjCAzbcLH5/g653dk3bF+SyKar3S5YAlQx72m4UUD2bu/1l9C1/duSMIki?= =?us-ascii?Q?I3B38eDUV14eFiHrlLC6eIAmfsM3XBWOJ8d3j+NpmFqvSCnnxZ04znPGtqBc?= =?us-ascii?Q?6wiTkBRcccGc1/k6wNRTsX6bpN/AKFAzpf4vQSIypNhMSQQC9kpoQtkV6A20?= =?us-ascii?Q?qyW02bdgHu1FQL85RNez2IQovU7cfNI2Q4X5FornDJH2a44r7Gfh3i/QoNvd?= =?us-ascii?Q?4s6ncLqfd+G9sX6jn3fQktYA3nl8dCBCuIzSV/4b3VXZGR0vT1gXDPL9QKWz?= =?us-ascii?Q?aOIr1Z4SiZmjtYrmGr3i/EUnR48jpNOcmNR4ViYdeGyZ7yGLr6ft6ti40P6T?= =?us-ascii?Q?Wz8U9J6QDIpz5/EW4e16vPhpLDZmMgqKT9w3dsz6egZle1cpp5En9zk+eBTH?= =?us-ascii?Q?lTdep1Jquxh45sCjArkYPFZ3voSuIMwbIKaYwtH+dgMv70TgkDEtlQKWaRFt?= =?us-ascii?Q?Eu7ytELu8Bm2XEj0V6C8lAO1BxTd8yNCJ3GukPCTfbjITvlZds0okbgjMZgt?= =?us-ascii?Q?UCZDsxrLqtWtguSjZNdBkg/rRpQE0GFZ6NrtdWJqWrMsQHHRJTCLMaT/XFUn?= =?us-ascii?Q?sdvR/i3ks3sJQqvYyKgu+yw7?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d565d89f-02f1-46d9-377a-08d8f96d2b2a X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2021 02:30:54.1474 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T4Oco0urmq0YIO5UfNMb7she3+uEoRyd6q9JkP2aR3NNylkv3mtEb7C41gqj0XVLEwlhNAGg+LHa1D8d+6Ycjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2249 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Yu, DapengX > Sent: Thursday, April 1, 2021 16:29 > To: Li, Xiaoyun ; Zhang, Qi Z > Cc: dev@dpdk.org; Yu, DapengX ; stable@dpdk.org > Subject: [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd >=20 > From: Dapeng Yu >=20 > Configure per queue rx offloading and per queue tx offloading command > shouldn't trigger the rte_eth_dev_configure() to reconfigure device. >=20 > The patch sets the queue reconfiguration flag only, and does not set the = device > reconfiguration flag. Therefore after port is restarted, > rte_eth_dev_configure() will not be called again. >=20 > Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dapeng Yu > --- > app/test-pmd/cmdline.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 14110eb2e..b49e9f52b 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -15626,7 +15626,7 @@ cmd_config_per_queue_rx_offload_parsed(void > *parsed_result, > else > port->rx_conf[queue_id].offloads &=3D ~single_offload; >=20 > - cmd_reconfig_device_queue(port_id, 1, 1); > + cmd_reconfig_device_queue(port_id, 0, 1); > } >=20 > cmdline_parse_inst_t cmd_config_per_queue_rx_offload =3D { @@ -16044,7 > +16044,7 @@ cmd_config_per_queue_tx_offload_parsed(void *parsed_result, > else > port->tx_conf[queue_id].offloads &=3D ~single_offload; >=20 > - cmd_reconfig_device_queue(port_id, 1, 1); > + cmd_reconfig_device_queue(port_id, 0, 1); > } >=20 > cmdline_parse_inst_t cmd_config_per_queue_tx_offload =3D { > -- > 2.27.0 Acked-by: Xiaoyun Li