From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15DA4A0548; Tue, 27 Apr 2021 12:18:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F5424067E; Tue, 27 Apr 2021 12:18:50 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 641EE40150 for ; Tue, 27 Apr 2021 12:18:47 +0200 (CEST) IronPort-SDR: NK0QfRl7rRB0aRbEeuUezPZphdhbyhQQf5lvOghCAnPKZ5vbvckhOrWtuODGA6lgqq7FsUFe+z Uf6tSZr+qV4Q== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="175966289" X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="175966289" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 03:18:46 -0700 IronPort-SDR: d43k2MItXf/dfU5ymJTP07RUCeUTpAYmCHDi0EaNXHJbK8u7V64XAJcUU3p6cXSdqmn5sD36Uv aqyVtrEDfBeQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="457567984" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 27 Apr 2021 03:18:46 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 27 Apr 2021 03:18:45 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 27 Apr 2021 03:18:45 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 27 Apr 2021 03:18:45 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 27 Apr 2021 03:18:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h3JR0CYDjLMWqz3k39LKWsCeD6PgjFY3rQThzJiEtJSbRUHiHhi3Hzi0EBJlF/z8ZwQ4Szi+Zz5axgTcp0n3KFTqzogfFc3Qh055H0qxz4C/89ax5p6/brw6oXZSDzOBS2tpKYH9YvZddfw1l0nPm8Z7UUMVSq3UkcPLzM/yj4m1GQJzq0By/EAV1zrcYNsHxFd4ge8rMi6SqNDSMCIEv1LwUWV5BI2sW6NGkICWfcO7tt0d5EYGlJm4+SDdTaSCkVwT1mEdL3+wUxSFdqyD3L9d+rqQ1TavhhwqV9Z9/WYODiXeDasec6dlPGAG2QFDdkLYnI7aK9V3gFxSnd4Ttw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+x60Wy8UD3DULwp6CHNAH8bLrd2bXZTvDTY6PZPmXJg=; b=f/bd66HA9goTbuZhnxTzGr+KTlPCLQkGrbSaGGpJafXvfckpCwJap/j9EGdCqpRiCSm/qE2mhoP/VKbToIgbsG2pXhVbVTVjubKFw/4VCVTl2V3Hyevk0RHLYn8pLlnyjwotDfMltZg2t5mAP09aToUp92/wW4wJfNU6vDi449MKYvxPApHpGALr+hY4jG7DpGMQ3lsugY4gouixHK0Bc5GQ39bw8AixvGuUVU/fnbTf+ZFbH4bTSu6LsLtCm5tJz5ELZHDHfp+nSi+7tvf2EgoKjv6nfPkMQU2eKTZO4OjJYHKYfE8Yv2SjvyJcsz5uaUXZ3XwSF1QCCgTp42/IpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+x60Wy8UD3DULwp6CHNAH8bLrd2bXZTvDTY6PZPmXJg=; b=zJLa2pmeDabFz5R7yjIyB2HSOe3JSa5wu2PyQFFa8LLQd1hQztlCGiymU94g6hXGs5k/o/7urr2Luw/PXyABmnyR8XKRlP8lFj7rS3rXZvkavNQzlLWLdhWHqwF8chWCOd6wNFxFuVlskz3+gl6BIZGQpqpJcBKB9lVWW0xoPaw= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM6PR11MB2764.namprd11.prod.outlook.com (2603:10b6:5:bf::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Tue, 27 Apr 2021 10:18:43 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::9034:15e:7cf3:4b78]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::9034:15e:7cf3:4b78%4]) with mapi id 15.20.4065.027; Tue, 27 Apr 2021 10:18:43 +0000 From: "Li, Xiaoyun" To: Huisong Li , "dev@dpdk.org" CC: "Yigit, Ferruh" , "linuxarm@openeuler.org" Thread-Topic: [PATCH V3 1/7] app/testpmd: fix forward lcores number when DCB test Thread-Index: AQHXNcO8es6i760E2k+KDt1Lan4Wc6rIMZsQ Date: Tue, 27 Apr 2021 10:18:43 +0000 Message-ID: References: <1614939741-63927-1-git-send-email-oulijun@huawei.com> <1618909266-17584-1-git-send-email-lihuisong@huawei.com> <1618909266-17584-2-git-send-email-lihuisong@huawei.com> In-Reply-To: <1618909266-17584-2-git-send-email-lihuisong@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.53] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 399268b0-d8cd-4005-1b57-08d90965d5ea x-ms-traffictypediagnostic: DM6PR11MB2764: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MxrdTMWHV37NRgWCbs8g8PiiZkPCJ7/5h3sanrRxdhwcvY87Pw4oLgOBCOhpPxE5uUbd3x9dcnK2lqe+XMl2OB2NuYGxLnWxu9aYzc5Ek2BJ5Yib5CeGyfhRua+8D6UnXMtcAP6SFJBJk3TkVQKGGqjKR4ixN0pIHqvwqH62p089pJPA674p5dDatKOnnHCvokbtbhtKPm7N2E1M780jB+Uh+9cF5XfcBjNY09hcNu2JsFb/PLa/XPfEHhUqTDez9dcPUECYhDboz1Ono7NSw1G8vXjeqGxGw0AUgexM1Ok4ysy6vKziUHpMSlolU+BwrDpI31JmVJpciFGLQrieabCOuFy3x9scK+nrUGnYm51q3iTtGXxITyTItn0OwPyNayUoGsOSkqJI9jyUhMZYSW+KpX/DeGGEjAwQjmIpSsoa+LHWstZPrQSL6jIygl/W7Y9VNocZseho76ek1rzVo7QCTAhEx3f7z5Lea/1mxU+WESYWWU33u5gg5chlhoiREL9vM4YS8wO81tdenp9mxUXhl5eSOA0yz0xIZiNq0zv4KbvYn1Nuy1YcCBjZRjl/nB8tBadU+72wuVtDld3eVAuh6xEe9cU/Ju+kHndZvEo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(376002)(366004)(136003)(39850400004)(53546011)(52536014)(86362001)(38100700002)(2906002)(33656002)(71200400001)(4326008)(6506007)(26005)(316002)(186003)(122000001)(110136005)(55016002)(76116006)(478600001)(7696005)(66446008)(54906003)(66476007)(5660300002)(66556008)(66946007)(64756008)(9686003)(8936002)(8676002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?3YV0IlUss31s2r+yS+OCErVrMvkht6fWbR9k3Bw+6aIeDKfPe6zITFsqjMVY?= =?us-ascii?Q?qCAx0XAwUuO6KieIii6KdFVANsWzGXvGcLpfMFVhXTpq0PXp/J7wcDlkOLKc?= =?us-ascii?Q?Lce/ADLrb0XeQes5iN/i8XG7O2oMsuWvj86gL5OgJKeBNUcfvFBkQjQTnGPE?= =?us-ascii?Q?VDSQ1YflNbLXfsm/MjaTHQq9TZviWGLwU20+8SB7Uwjh6tCEscMVXaKI8psU?= =?us-ascii?Q?APKO4fLyqxQg3nRqPK3M+8+F18r64azO4+fs6/gMgKTM5ILDucJ43asUMKp3?= =?us-ascii?Q?CXQpfXc+bIUkEcPWBL+wKFKGPmAmnlRe6jzJHIE1c6F8d686SQuKSnWsFp1i?= =?us-ascii?Q?6Cz2r/+/3i3aLAgh6schnddhFGMF3EbQVjx3DSpYignFgM/AoyG7i05VYAYb?= =?us-ascii?Q?heeh38zQPfEoU+UoYxzUjq3BPz/ZJveZnqdi63kQxCpnjXdTaERfKbKQ1olS?= =?us-ascii?Q?BlVa2I0nB7R54ZjNt+nYwSzcyD8f7CNcm6FNkW7o9bxn5XPpuuTHEnRByQcv?= =?us-ascii?Q?QSKiSChhH7cE2DQswOcDvSEQOLXW2ezcY6xuqj9XA1VDsFYz4WjxcSgJB6XU?= =?us-ascii?Q?DlnLTAGeamvON+N4ipFoWL+nDr6KxuPpIY8d9gtW9zJWNBYozxzzVK/a5I30?= =?us-ascii?Q?ApXwGv/XM2frrP4fY6q66sSBWv7hLFfCeVeMklNX+H+fsQzFxgoIli8e6MU3?= =?us-ascii?Q?SknebOGvDiJz4Tq9F38D47gxK0omdYNYSvbXbOE30BDl8bE/3XdteDxWbf+h?= =?us-ascii?Q?ZsAshcCV5CAYZRiVIRKyyIMcc2JJ7eBAeTWmwK+g9iLPHRa/JhtnFWA3KqTo?= =?us-ascii?Q?EDjnqtlSlfn4JEsJOrEt2VeD6i4Z8ZrW7CrPS5tqRbbob1iy71fMmFHI+Iuu?= =?us-ascii?Q?vaZyQbRj+98g6o7OVwgh5hshxelEATKPwBHxCFlRDIofJ5bpKdCuqx9R8Ebz?= =?us-ascii?Q?PLGrSfnCuaszQThRI9kRHA9lIl+MzvduI59fronO6DJBO2BdVQ62uEiaFm7T?= =?us-ascii?Q?7mMrFY2bcSTKDeAEcD0I0ZGcaj4Jyko6wTYl01JEP1CpibrRgInMzDAnwx9n?= =?us-ascii?Q?hUTa+aIJrMBQi1So2Ph3pW2SxwVrzop7ku15ptV/0s41WyRFgZSuAggsr4lx?= =?us-ascii?Q?1zYK+0zFwA+q933nCsVgFR5WmUhC8ExXXzhvuAHWkDZWD3Z/aOV5+KHK/LF4?= =?us-ascii?Q?who3wrtlF7M3yd2yN36XGILirHIplHmQH6RwiHAqCz9ZWwNriqU4m7KUunHR?= =?us-ascii?Q?oYMoTmw/golRY32LFnNaO2hgc2/QUg5bmp2WvLMLCpxSkdGXpY//ys5nS2ep?= =?us-ascii?Q?/IfVOwzUMp8jho8Os5r90B5Z?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 399268b0-d8cd-4005-1b57-08d90965d5ea X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2021 10:18:43.3577 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xXlwTSHXgo1IM4swI0Qy1NR/LR5QpVkRwR8xTuHRdv/9TSYNh6U6IdQOacqJfct0LnCJAvnlLoJw8YOEUxkkaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2764 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH V3 1/7] app/testpmd: fix forward lcores number when DCB test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Huisong Li > Sent: Tuesday, April 20, 2021 17:01 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Li, Xiaoyun ; > linuxarm@openeuler.org; lihuisong@huawei.com > Subject: [PATCH V3 1/7] app/testpmd: fix forward lcores number when DCB t= est >=20 > Currently, 'nb_fwd_lcores' value are both adjusted based on 'nb_fwd_strea= ms' in > rss/simple/icmp_echo_fwd_config_setup. > But the operation is missing in dcb_fwd_config_setup, which may lead to a= bad > behavior in which multiple polling threads operate on the same queue. In = this > case, the device sends and receives packets, causing unexpected results. = The > procedure is as follows: > 1/ run testpmd with "--rxq=3D8 --txq=3D8" > 2/ port stop all > 3/ set nbcore 8 > 4/ port config 0 dcb vt off 4 pfc on > 5/ port config all rxq 16 > 6/ port config all txq 16 > 7/ port start all > 8/ set fwd mac > 9/ start >=20 Same as v2 comment. Please check that. > For the DCB forwarding test, each core is assigned to each traffic class = and each > core is assigned a multi-stream. > Therefore, 'nb_fwd_lcores' value needs to be adjusted based on 'total_tc= _num' > in all forwarding ports. >=20 > Fixes: 900550de04a7 ("app/testpmd: add dcb support") > Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") > Cc: stable@dpdk.org >=20 > Signed-off-by: Huisong Li > Signed-off-by: Lijun Ou > --- > app/test-pmd/config.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > ccb9bd3..03ee40c 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -2961,6 +2961,21 @@ rss_fwd_config_setup(void) > } > } >=20 > +static uint16_t > +get_fwd_port_total_tc_num(void) > +{ > + struct rte_eth_dcb_info dcb_info; > + uint16_t total_tc_num =3D 0; > + unsigned int i; > + > + for (i =3D 0; i < nb_fwd_ports; i++) { > + (void)rte_eth_dev_get_dcb_info(fwd_ports_ids[i], &dcb_info); > + total_tc_num +=3D dcb_info.nb_tcs; > + } > + > + return total_tc_num; > +} > + > /** > * For the DCB forwarding test, each core is assigned on each traffic cl= ass. > * > @@ -2980,12 +2995,16 @@ dcb_fwd_config_setup(void) > lcoreid_t lc_id; > uint16_t nb_rx_queue, nb_tx_queue; > uint16_t i, j, k, sm_id =3D 0; > + uint16_t total_tc_num; > uint8_t tc =3D 0; >=20 > cur_fwd_config.nb_fwd_lcores =3D (lcoreid_t) nb_fwd_lcores; > cur_fwd_config.nb_fwd_ports =3D nb_fwd_ports; > cur_fwd_config.nb_fwd_streams =3D > (streamid_t) (nb_rxq * cur_fwd_config.nb_fwd_ports); > + total_tc_num =3D get_fwd_port_total_tc_num(); > + if (cur_fwd_config.nb_fwd_lcores > total_tc_num) > + cur_fwd_config.nb_fwd_lcores =3D total_tc_num; >=20 > /* reinitialize forwarding streams */ > init_fwd_streams(); > -- > 2.7.4