From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1DA1437B1; Thu, 28 Dec 2023 11:50:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B702B402C4; Thu, 28 Dec 2023 11:50:14 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 7E7B0402BA for ; Thu, 28 Dec 2023 11:50:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703760613; x=1735296613; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PzdZsJC1xM1mtNoWDwTg5yZn3JT5r+JG60Wv4MjeXLc=; b=DhM3kl1HYgnvJZkfoCHXzWkIDIGSDQKT+xkgEYSvvCX6Z2Im3Aal4ypm 6bN/hqB98J1CEghyB8d7n/rIovpI6u1wNrX4hQn/4qoZoywT3E21pEduJ WdiAGAOHdS6RKAA00AFRiTyMM4ZplSc5tm1yHDBxAKTmZ+7gW1EFCLNsm h2tVVluYWw+I45N+L+vB6viyCiM3vcV2AYpYV8e6qhUod7fjk5OPtzWiy kQYU296aTAQYiJcAZ6x864Bzm/Aw5tSrlU+UxU2CFPmSZGe15K1f/w26i 4uF2g/EtA0UQLT0aPzfcgCpwPvuR2zpUMrY38k1LLdAhyf/RPa4x2+4xN w==; X-IronPort-AV: E=McAfee;i="6600,9927,10936"; a="386969902" X-IronPort-AV: E=Sophos;i="6.04,311,1695711600"; d="scan'208";a="386969902" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2023 02:50:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10936"; a="807396306" X-IronPort-AV: E=Sophos;i="6.04,311,1695711600"; d="scan'208";a="807396306" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Dec 2023 02:50:12 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 28 Dec 2023 02:50:12 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 28 Dec 2023 02:50:11 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 28 Dec 2023 02:50:11 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 28 Dec 2023 02:50:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GbQCbbkpmp8xLf2p1LuhP/jKc9RthmZ+zmVSBlOc9oZg8KoCfYbG6+BWK6PIZoLuRcgbxyE6yYrgU5vFkTB6vF03ccIz7jDjD5iJeIAj0hfS1TppsGJAFVcaO/DtYjoZ2ZTZ3Vy8TGrRiEIuJU7EZkG3Fc+7pOVvN576Mnhkp3Sbmb8ok2PFJdioPa0khWAPvzWlGN60iVpz8W6kX1GC5t4LjghGs51VAX7oWIlIf/+cb/1C3rPsXehrcdzae6hJ7aH4+QbcPQZXa5RUIHwtprZI1+oGSFZlSSOcjcA+PZBA0cpEGiKTfyJOGHMo+APDZa6xROHFvvq8SEF7dWToLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f9EDdEs+TnPDUIjiNA1fdhVr6sqZtNdyQ+xnOsOJNr4=; b=Kf94VMp70Vw21qNOhFcHIXOES6ljNRkqquTPZhNtS7u1S99cFgSzBgJf6DfDRP77XRGlv6iKLzk9QzuV0yP+++aS8L+KpW1+jSxfNPgJqutVOPUOK0PWtn4noTYpXTWderW7CLixGn2geE52Y+9aTnMHez/lKFvnaqgi4cBg7rh43eJYYXuh+F15/GXNijcG138qo6xB8Vo9+2cj6PPPtQsXuoCndTvdswEQ05fsolvPELVEShy5WACSCisMphw/mYPEbi6WQFt31iDELi4+GGfsMjFeya7QU2LVPUD4yTHpGrBWvaNmOk71XLHMGwtRd41GlbxmwD/JeKvZOAnmTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by PH8PR11MB6832.namprd11.prod.outlook.com (2603:10b6:510:22c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.28; Thu, 28 Dec 2023 10:50:06 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::fc91:526:bead:4f73]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::fc91:526:bead:4f73%4]) with mapi id 15.20.7135.019; Thu, 28 Dec 2023 10:50:05 +0000 From: "Zhang, Qi Z" To: "Ye, MingjinX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Ye, MingjinX" , "stable@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" Subject: RE: [PATCH v5 1/2] net/iavf: fix Tx path error in multi-process Thread-Topic: [PATCH v5 1/2] net/iavf: fix Tx path error in multi-process Thread-Index: AQHaOXqj0extTLEcLEOgLx770gDzDrC+g4Lg Date: Thu, 28 Dec 2023 10:50:05 +0000 Message-ID: References: <20231227101655.799560-1-mingjinx.ye@intel.com> <20231228102611.921850-1-mingjinx.ye@intel.com> <20231228102611.921850-2-mingjinx.ye@intel.com> In-Reply-To: <20231228102611.921850-2-mingjinx.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|PH8PR11MB6832:EE_ x-ms-office365-filtering-correlation-id: 5b0a0883-d132-4cd3-e57b-08dc0792c085 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kt3KpnpmoY6d6WvHkZMYbiKT5LV+5Xx8yM2ZePbunL0Tdj3q5oTBAgS6U+/Qt67yEoGmCT379LIF/V1MaFZwjzsCG1YPnB6Un3exbGQTjZBB6AzJlSYYAInI3wYnXwj3u2Mo0BEXIoBcWQr56Lya2UzQrqTqaIib0u55jqbCq6shp36tqvaCoOqyW2wLoFMlCXOQr1vxhnGoCGX1Ytw+OcbvKzF85a5q5U6YAPVtOGa2ynkHGxq3u3YhDEPeqTBMkPm3NG537suvnFi2Q7dzrAuWUN4x2rD6DOmouUQAuq6zrswt6Ydb1/NtuOAg9scR5wobjJ6QtBaiW34ZBXRMNyWhTjvqJcmNBZNEZcrIkDiQwS0moyXoCRJ8t0P1NcFjQ6YBVXIo9WKkPzLsw8whqM99cFJtXLALGNq6oWDKleCIhyj9yiXJVsZMB9eZ6vhF1XsXknEQc59FmfJKoSAfwWXxtIJIx4V7REjsOzqC2nKA+xVL6h+5Ku4QRqkIZeXlq8zYx10gCWHzDM537+cANCa68cduUhq3XsvCfvBB1ii3l9ejMKztDQ5kvASDqLsHX1bApxUYz1gpMstJ9pvhvagJd3MFS/3T3ntDxS2DalihO+nW63sK6hOhqjR9vxW4brgJI5JZ6X7IJVI0K+MPKA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(396003)(376002)(366004)(39860400002)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(71200400001)(33656002)(478600001)(82960400001)(53546011)(76116006)(9686003)(6506007)(110136005)(86362001)(66476007)(66946007)(66446008)(64756008)(7696005)(66556008)(54906003)(316002)(41300700001)(55016003)(8676002)(8936002)(83380400001)(38100700002)(52536014)(450100002)(2906002)(122000001)(4326008)(38070700009)(107886003)(5660300002)(26005)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WFke1iQQtXr4Vzaf5HAmtW5A+mJytz0a5exJjcZrgzi5/sT8H40zkv87TzGT?= =?us-ascii?Q?2wAwyzjhXPZ+3Sok7ygyvrhiINfBWa+/QJ80p2/yArdepX5eDrIimS2xmSdm?= =?us-ascii?Q?G4TbS1wdKj12oeYTs/xS1u+6VQWsunoeieSUzibU9N+doHCGXK8qWMrVwyOw?= =?us-ascii?Q?Eub+LDVJ2vEx2ARvUius+YQXIsl6WzHmCZg7LXC6T5BcaEoD7GK9FP5YsD7N?= =?us-ascii?Q?cI2httrDtmBrR1A2qW5+jFCj+OX4w4x2jBGZDaTgzJyQljvVdILTOhn9eSmn?= =?us-ascii?Q?DLqpP/KRqVg5f94AkrGovnr13wH9QxcZ2WPkxfEzHRfn8pNVghSBNuT6XEeX?= =?us-ascii?Q?cNiX/ucr0oL8ydRgl1sLAO/0lzeWsdz5+U0Uob7GpOP5v74dsQ5SiwPVvVBn?= =?us-ascii?Q?Hcbra4iH4vzOqk528mcIqrICaFLAZGtbRNo55dXd7dZU00otPsRcD7k1oweN?= =?us-ascii?Q?L6YvSzlVAAjUhyKzToSAFfVMR8AWgKcm/sIoK8SIVx3hpVayfHtlhK6DFxCS?= =?us-ascii?Q?V1GFOgXaepAHXPWDL9BclPMTxNSL6om4jNS6vfTKxJvTW/AUO36WSBWz6RtI?= =?us-ascii?Q?7evCyt27XedT3JmN9niNOn1zXj/Y1dJAfTbOdZPwe/1cCAYJEEvcRQnrEie4?= =?us-ascii?Q?CcOpcBl6zq2eTKBGEMuBe+hXhkrNr4Ja5k9fdcJ7NyXuyGc8nQlWltTmFnmr?= =?us-ascii?Q?6FFlumwYvxXlbmJ1C5KwIndgDLoDkAGI2TGr8jG05dOJjZ6Zii/6nzOR+f5V?= =?us-ascii?Q?IJHXMwp0E89NUrS8XLLWsD/ZQhP6hkx+zk7JlwHdktjabM5E1Ve6CwSByljF?= =?us-ascii?Q?yQE/YnfEgiLUTMxioL0XVERdGb//fDQ9BjwTra1LF+jDXAcDAuo5FOZFhTYB?= =?us-ascii?Q?5eY0HcRRF7DbtNP4da7ZNvHaCWAvk3Zf+XbV6j22LpOLGDhOH/Ve9FKsJTj4?= =?us-ascii?Q?fxoydRghbv3qTwVhdKiULGUHYXG7NFAKbspVQqA/GD19ugsyIkVCnZ/32iix?= =?us-ascii?Q?88PPqsmlXQ36VVhbYMlmx7DPfrsyQbiOfF+X9Y1V/CaEMQWu1Sz/Ty/egJm6?= =?us-ascii?Q?nnO81qQMdYzF+1yXOfuiOwffWX6IxHN/xic3k02E4dlMgXKkHWQjD0SPWXBl?= =?us-ascii?Q?2fLey/TrgCxV13ArGdA3agtOBDYaLDufK3lxi5ISMYajSi1fGqtck0uzo5Sx?= =?us-ascii?Q?lwrNzDv27I6/eEi/MV+u8gXDGiH1wC12srcBMd2grZAC9aiMXHV75XW42LMt?= =?us-ascii?Q?oyQIdZz3eM8lhgGIiJB54TgFVNISMV8RCtzyssWh/TNyEXZ8XzqEIzk6ZAEe?= =?us-ascii?Q?jCwn+Jw+h/s6coZKo17GQAYiBZIwIwUFnVlLsAXLk6ie3RdBhn2cjcVpUMds?= =?us-ascii?Q?TJVA01yiGUXFi3C0ajNS0sDSHYdlkfZR3yGZMLeQEqtxmgkpxG4PF4SscK66?= =?us-ascii?Q?EA8AVzlCIg+NG3PaTjBUvueFmd52qp70fMmbA6xwp6TfZfUcoz+GZs5bd0av?= =?us-ascii?Q?iKCMvB0dS0q8w8Zz2Cey9ljhd21bCcxIACJG5+olSUc/aeYPP9b7vZxuRsrK?= =?us-ascii?Q?kggUjbOkaAbRLJxwAcrkEtXzdxgtF32Vhd+yHBKz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b0a0883-d132-4cd3-e57b-08dc0792c085 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Dec 2023 10:50:05.6165 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yFcAp2zmCA1T6NxR5ekhNMYAJ/hzIfQYeLKlyD56Q7Ao4MC/6nKGzlmkUPOzAw1AKPpqlCZiH3xw9WmMP+MuXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6832 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Mingjin Ye > Sent: Thursday, December 28, 2023 6:26 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Ye, MingjinX > ; stable@dpdk.org; Wu, Jingjing > ; Xing, Beilei > Subject: [PATCH v5 1/2] net/iavf: fix Tx path error in multi-process >=20 > In a multi-process environment, a secondary process operates on shared > memory and changes the PMD transmit function pointer of the primary > process, causing the primary process to send pkts without being able to f= ind > the function address, resulting in a crash. >=20 > Fixes: 5b3124a0a6ef ("net/iavf: support no polling when link down") > Cc: stable@dpdk.org Should Rx also need to be fixed? please make a complete fix. >=20 > Signed-off-by: Mingjin Ye > --- > drivers/net/iavf/iavf.h | 12 +++++++++++- > drivers/net/iavf/iavf_rxtx.c | 34 +++++++++++++++++++++++++++++++--- > drivers/net/iavf/iavf_rxtx.h | 3 +++ > 3 files changed, 45 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h index > 10868f2c30..4cd5bea167 100644 > --- a/drivers/net/iavf/iavf.h > +++ b/drivers/net/iavf/iavf.h > @@ -313,6 +313,16 @@ struct iavf_devargs { >=20 > struct iavf_security_ctx; >=20 > +enum iavf_tx_pkt_burst_type { > + IAVF_PKT_BURST_DEFAULT =3D 0, > + IAVF_PKT_BURST_VEC =3D 1, Better to rename with xxx_VEC_SSE