From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA70C42C99; Mon, 12 Jun 2023 17:15:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 946084114A; Mon, 12 Jun 2023 17:15:58 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id A400740698 for ; Mon, 12 Jun 2023 17:15:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686582956; x=1718118956; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=mWvEBrMFdJOvkQXNafnlvMtNirhkWvfKnUPq0JhEAGE=; b=JgL033x2p4jDtzoNvHfoB9TBP7FLCpFkyb9qxDleiBLpSFQtUTppjxB5 PP99kDGbsWNk4QtUHypdVw8liASJVaugwGsI1R4lmRBk+o/b/e8KAToza VfjNzGpVP8jljJY5oggslzySJryN7CjVrRyQBVfDXBBNV6VaHH1Ad4c++ JAm2vu3C5pcF938+/3N1bgfW1lpoRM4Jm8p6ZeDOs2gBtc1FVoOK9z1fR pZjXjuR9Mxv2JkNoBFuuSA4gTCNNI2+t70ZlkZL/1xGB4bCFiF6KiZLXY 4btDI8wKFQZJ/36HsG8FzBgM/oML9Q/OKhyTytKvxtyHLWa/GlhtzST6Y Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="347722735" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="347722735" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 08:09:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="958055732" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="958055732" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 12 Jun 2023 08:09:02 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 12 Jun 2023 08:09:01 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 12 Jun 2023 08:09:01 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 12 Jun 2023 08:09:01 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 12 Jun 2023 08:09:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OUlTo1a3N+GFLqjWp0ET3GgztCTfakgdPK9teXdI93RylUkqQ7PnjAHOUvkHpDtQm9a6UKhTeJxmAv8ef8h6ygE1lpm3Uq/HSPZ3tJcf1nxtFX5x8oB+yRDXXSy12pC91ccRyfJpOci0pN2RnBXCB54KEB8UeVoeDx1tFD6TrjeIRU85TLHVTRIAePWm5pgCHWrdydQRcCJMVNL1kmcwBs78l5S5GQK2C1tBUa6XvNCW6KYZ+ReZWYBgyHzC8H/W05sRmsJMsXsDIZEWjFCe3WwKUmhSg7jinVYr+8xS4FszwpvJJRbSPbBe0AY8FS4Pk05B3D4eQtxcwnDHMIfkhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8wKPuU1qkdMlKbts/tTEmfEuyqfGfApwJMwdJgROYsc=; b=HhQtnxnbe2weqvNw255TpGdbJ048O943SEaxkrAF7j+NYZg266CRCy86a66kA+siqevrp69LcvAWg9DctotbbfofOyIPxV0XsFlWVFOu/QNtCu0r0Is0raQkYoZ3GkgyU3oulyf509S8vJH3bdxxIiMSeImM9FQyy1ckz7EpsiBANrSr8+rK7kSeCv/uyz0BbcynVy93e7AKqtABDofckjKaUWv29qQVvxY0enIZ79tHsfJC/wC9IPBjaGvHpCF/b76L6LV1njhVwDuuxF9W+zHFuGCbVxh4SZIYhHq+UTfyzWJqhrnWQPD4BmHGiZV3zFayvrl0W4yzxC2MrBs33A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by CH3PR11MB7345.namprd11.prod.outlook.com (2603:10b6:610:14a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.36; Mon, 12 Jun 2023 15:08:53 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6455.030; Mon, 12 Jun 2023 15:08:53 +0000 From: "Zhang, Qi Z" To: Thomas Monjalon CC: "Zeng, ZhichaoX" , "dev@dpdk.org" , "Richardson, Bruce" , Konstantin Ananyev , "Wu, Jingjing" , "Xing, Beilei" , "Wu, Wenjun1" , "Gao, DaxueX" , "david.marchand@redhat.com" , "Mcnamara, John" , "Zhang, Helin" Subject: RE: [PATCH v2] net/iavf: fix compilation warnings Thread-Topic: [PATCH v2] net/iavf: fix compilation warnings Thread-Index: AQHZmrBH1DhBbqqbOUSJWW0QbAeoIK+G23iAgAAIH4CAADoT4IAAHYmAgAAM9YA= Date: Mon, 12 Jun 2023 15:08:52 +0000 Message-ID: References: <20230609054156.605581-1-zhichaox.zeng@intel.com> <13281832.dW097sEU6C@thomas> <3196107.aV6nBDHxoP@thomas> In-Reply-To: <3196107.aV6nBDHxoP@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|CH3PR11MB7345:EE_ x-ms-office365-filtering-correlation-id: 481b4a44-d1de-4b22-476d-08db6b56ef48 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aeuKubgbnoDhrSxUp+onuSLxwmeC6mtOKEIjuJrY/vQQk9HHu91mNYi3RPc54BbUXWnz5vmu9gwuJ5+TwumrECRYKI8WoBGyejgGE6TMYGR6LXMNbCbQRPFp4I/UVRHw2mJNNWuF4nZEXOpsU35J00TRMZ2pQuVf+9LGQcsroR6CTmCuoxLTEh2Qjj44Y5sao47owX/SQ6NMd8ItRCdymLApVU0TI4zdWgqiRzsxJ+hmz3+dJ0cxHUuO66sF995IhHZLB+Njj4ihoLFNct/ovCGKNAyrfTn4jEvh6x0mpHUmaUxkJdhVQGrfOjqGmCWpdInC0HddbDEIvy+riRFCPlFC7AqYTg3AOlYIhX/Ep8OQcm7R44R2ejH7N2umKlIe5W8leQwskZGyXJnCqJwyATFpL9y/NX1vWS6k+EQ1M/Q8PEEZMlzVDtpbdaHNivaDy5n/53+f//xx7OfdtY8bTmj+2cofKzFKENjVeK4+6Nmo8SZeC5Q5NZkZrR3Gpkpf9Jl1li+jENY2+0oVNF2+vT1xKEN883TnypFkVkm5InKUEquPs/UVfoUkspB+B9b6AwqjfoYe9YYI8yHswJvUFFuN0nwXogFEfioDTzmyKfH1ZhDxTLzjLvn674iyuJ4h x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(346002)(39860400002)(396003)(136003)(366004)(451199021)(41300700001)(71200400001)(8936002)(8676002)(6916009)(5660300002)(52536014)(54906003)(64756008)(66476007)(66556008)(76116006)(316002)(4326008)(66946007)(66446008)(478600001)(2906002)(7696005)(38100700002)(55016003)(83380400001)(6506007)(33656002)(26005)(9686003)(107886003)(186003)(38070700005)(122000001)(82960400001)(86362001)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?urOvBMz9FX80fsftETJBzPzsmbp9I59qAwshhZnP5FENJBEiVTWQdluf8dxc?= =?us-ascii?Q?xKxZUVyuQeRvLsEZD093oZxEma2kxBJM89kCLUToJSpjHRnp7LpqzkqAFTkZ?= =?us-ascii?Q?HG/SwEDAVF82bTwsNCfokEkLNV6F1mrDqrTx22kx1xKhj2158xG5QQLugjeC?= =?us-ascii?Q?nnL3auwLvffzFCzOX8x7V9vFoC9DvvL2axE+yYmn4EQGVBOH/rOUu3rAvZxR?= =?us-ascii?Q?harVV3IcgiCSUpyOTHql3eSNIMOppx3I2gciqjd3BEmWF+vCL+Q5HM7kPpS4?= =?us-ascii?Q?t18+d65p1egaxUaDxZjoN1GbzEHziQbj8jk+6XuuPpbv5OGHzpgOGLjGIiyQ?= =?us-ascii?Q?y+AY1y3ilqp0uaz8MU0rz37RG8aeNByIcO//RsrhKz1dJrp9yAJMU54i6fYO?= =?us-ascii?Q?DAvC+BVKpji2d5JWJQSJGuys1y9kaDse0zR0DfPDD/0N++GSNnKotNh2dBLl?= =?us-ascii?Q?4rm+04is9D76PgjjQ/ApmzAc6zJdHpcYNhSBcrOZ2Gs8j333g6eW5cShsjh+?= =?us-ascii?Q?xO4n8R5TfO9IwpqBqARUamtUh2l8RTjfPTIGa33n7VrVlA4R5MT2mpl49G71?= =?us-ascii?Q?kqxeDO75yMqhzK7CF752gPfzipD41LSjbALvWw7FJCxwvsI0k6KRfYS+Bg8E?= =?us-ascii?Q?lM8at0r6iU8epLsVDqmJ4/9YydUY9YmNkjpff9XpyXHDrl815gXcJrUfycUD?= =?us-ascii?Q?rigZxJyeE+m91Dh3CiB1yoTycB6CTnu06VG21WshEHrxQCpPyYaPtwig6383?= =?us-ascii?Q?ovhGcbwaghoASUbCkgXdURI5J6cZN8nJ/z6U7Z7FMOwbRnnBEpkQH+HSiHdd?= =?us-ascii?Q?sbf8lojwZfnO9l9Yn7nlckWsvgW4wsp+cKqefPCpgOsicYbS7imThfbpm3UW?= =?us-ascii?Q?dITHDf7gmIQS9t4Z9yJcYvcH+JWNVZYSOugwVL9Ixi81z02qhPoIWnTZMHxE?= =?us-ascii?Q?WK6qZEbPxlwmvOR6eT7C2xrI4rissunE6TUPkn9OVg1AdSoCU+W8Z+tOWLlE?= =?us-ascii?Q?vmbcYgpHucfu+mH7i3twcXpxr1u0P44V51+IeHfzY/rRDcDyVjAjoyCC0tz9?= =?us-ascii?Q?Ur0wnuVUqEI1sOi/yDvvj24uXBIV/VlcchfzxvEKAkuuKTeGlzc1KMamDxkG?= =?us-ascii?Q?ou6OebpzNOIen93E9n+1hexORmedj5IvJ/DRWhBFAvZzAVbrUPq5YBKWtj6I?= =?us-ascii?Q?P1bZ0L0zES2EnMjd+GIpGlTUpYveXiDHdzFJVl2VQ3iS5iXM5tBpjNeV/8E4?= =?us-ascii?Q?7fiOpyxiyltQLayUS8qBPacfV5rYWEi4jQmrsDdE+2dNCLe1HFFJmCHf0Dw+?= =?us-ascii?Q?vfU1UWVT3ZjB2oB5xbiVvrlxoCBoWVtbCB+NP1yPPsqTH6mQM9KKlBYCCFvj?= =?us-ascii?Q?jDkSfM4ztpk3AplyWaJcgDUlti2wkaP8OnXNjMf4PV3Qsvk3O9VUK0M06vf+?= =?us-ascii?Q?LzjhJUX7YCtifobDOnvzfdxvmmleoxH5jlKl8Bgu1rRPZGMLV9SiyIp+G3qp?= =?us-ascii?Q?9PqhSkz/zUOT2ularxdK3su/Djwzita5Pr4reydVgsaaE2SQwYzvAnpN6CwI?= =?us-ascii?Q?Sl0A0T4vZxeq/7ae523IaLnqU6iPG7qpmS9yKGUP?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 481b4a44-d1de-4b22-476d-08db6b56ef48 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2023 15:08:52.8773 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VmObKuypgDLnzrmHcG/PlL37GnmygSVm+PlJkiQ5pyBjpkxdef9g1Ld41mR7zEKGDM4Nzn/igHcwXty8I37uLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7345 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, June 12, 2023 10:15 PM > To: Zhang, Qi Z > Cc: Zeng, ZhichaoX ; dev@dpdk.org; Richardson, > Bruce ; Konstantin Ananyev > ; Wu, Jingjing ; > Xing, Beilei ; Wu, Wenjun1 ; > Gao, DaxueX ; david.marchand@redhat.com; > Mcnamara, John ; Zhang, Helin > > Subject: Re: [PATCH v2] net/iavf: fix compilation warnings >=20 > 12/06/2023 14:29, Zhang, Qi Z: > > From: Thomas Monjalon > > > 12/06/2023 10:32, Gao, DaxueX: > > > > From: Zeng, ZhichaoX > > > > > Use fallthrough comments to ignore compilation warnings instead > > > > > of diagnostic pragmas, which are not recognized by old GCC(below > GCC7). > > > > > > > > > > Fixes: 95a1b0b23140 ("net/iavf: support Rx timestamp offload on > > > > > SSE") > > > > > Fixes: 4f58266da4d3 ("net/iavf: support Rx timestamp offload on > > > > > AVX2") > > > > > Fixes: d65eadb9e178 ("net/iavf: support Rx timestamp offload on > > > > > AVX512") > > > > > Signed-off-by: Zhichao Zeng > > > > Tested-by: Daxue Gao > > > > > > Please squash the fix in the original commits above, so we won't > > > have any compilation issue when doing "git bisect". > > > > > > In the meantime, I am pulling the branch next-net-intel without the > > > Rx timestamp support for SSE/AVX2/AVX512. > > > > > > > Squashed to original patches in dpdk-next-net-intel. >=20 > It is still not compiling: >=20 > In function '_mm_testz_si128', > inlined from '_recv_raw_pkts_vec_flex_rxd' > at ../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c:1070:12: > /usr/lib/gcc/x86_64-pc-linux-gnu/13.1.1/include/smmintrin.h:69:10: error: > 'mask_low' may be used uninitialized [-Werror=3Dmaybe-uninitialized] > 69 | return __builtin_ia32_ptestz128 ((__v2di)__M, (__v2di)__V); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c: In function > '_recv_raw_pkts_vec_flex_rxd': > ../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c:1058:49: note: 'mask_low'= was > declared here > 1058 | __m128i mask_low; > | ^~~~~~~~ > In function '_mm_testz_si128', > inlined from '_recv_raw_pkts_vec_flex_rxd' > at ../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c:1072:13: > /usr/lib/gcc/x86_64-pc-linux-gnu/13.1.1/include/smmintrin.h:69:10: error: > 'mask_high' may be used uninitialized [-Werror=3Dmaybe-uninitialized] > 69 | return __builtin_ia32_ptestz128 ((__v2di)__M, (__v2di)__V); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c: In function > '_recv_raw_pkts_vec_flex_rxd': > ../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c:1059:49: note: 'mask_high= ' was > declared here > 1059 | __m128i mask_high; > | ^~~~~~~~~ > cc1: all warnings being treated as errors >=20 >=20 The question is if "apply patch failure" happens, the CI build will not be= executed and we may not able to figure out the error early, any BKM we sho= uld follow? Thanks.=20