From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A3B941C7F; Mon, 13 Feb 2023 02:31:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B8D240EE7; Mon, 13 Feb 2023 02:31:23 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id DBEF040E09; Mon, 13 Feb 2023 02:31:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676251881; x=1707787881; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=GpCaoW03IUznURik9u4FqHoFsuCmK19XO1YeFmsN0r0=; b=LpcCAkoq+QgAVPMNFCtMhjBo9jW/0xopiQCb5QkuKoC9xwipkTZhdo/3 JbT9I7sQNhohKvrnv2TW/jNJoK1++4ZBY3UKtx9WcmaWi0zHhcjG3z7MD rX8yq1Bl0D1V6Vh3fx/jOqpXghOdv3NCRNsej2AUFaQ1rVUXaP7aRMSRX 9W98QuLnvPdMVOgq4wYg49mRRkpPoXSwSu2N9gLBWcMn84JxaQKtpbfpN SvfVP7+F3Teo7/Pdh1adqnvmx2poBNKXpJ7IQPB7BeRn5Us8aRW0pmSii zaf09WjWdC0KWThoxfuboLpwq1Nz/AP/dxHzTeKMk/KdFvwVLekSgD3L2 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10619"; a="358194538" X-IronPort-AV: E=Sophos;i="5.97,291,1669104000"; d="scan'208";a="358194538" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2023 17:31:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10619"; a="997526438" X-IronPort-AV: E=Sophos;i="5.97,291,1669104000"; d="scan'208";a="997526438" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga005.fm.intel.com with ESMTP; 12 Feb 2023 17:31:18 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 12 Feb 2023 17:31:17 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 12 Feb 2023 17:31:17 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 12 Feb 2023 17:31:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZvlASNo1Erx8bzP2Oo9xH2nk+t2/4aID51n3XbAJMsT2BPo4Z5HXBqRJ+537UZ8SPTeBf8WJ1BqyZ9LyXKUKPTCSCm/jSvTBAinv0+Gc8UVw4zN2AHsPXNTBiKBkBv4so0SNdweEWUVsyaFgK5X4yNOE1YNGgCPY3mMTQ9hd1jAYSPWLhivmcda8CExdl0BL9+KJRJiMZYrEtv7lpkhKZFrZ2jA+bnlH2nNOOQfvbnF6ksBdqrn2BlrryZsc7t1G1BimfL+CdCBaiCZ2o3wPgyQ7BplaVvCMnjSBAwO2FPXWdnBG5on1HW2hXdAe4BCEWNoToWPMwFKlVnRKd5mIug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GpCaoW03IUznURik9u4FqHoFsuCmK19XO1YeFmsN0r0=; b=L3U6HwWAPOgnLtnE6x3anxQ1oQqmA0Du+8GCKEOFRSzi0P36sae4J2Qu6HodUVwojCMxOdBsk/cWkIrv+VpClnjBAI22AaG0aLvA3jh6/owIx42dgEmgDfAPH/NGgjGIw6phcagszzm5lPCQcdyBVOznD62gvZH7w/t7Sck+Fwgi5XHCoAYevJ/NFHBgB7WczakqzVAVuOJTeIZSunaH6XN4+HVfx4oY7lrkqjmPltTZz8i5kwNGTxq7GqdTZLaCRcZVY0EmF07p0ZTbgNwM2KUQJ9zXDgTBXI0HqzJjC9wniKfonHiXtV+qquvsL3znb02hmdvvVqeh7oJmlrxHYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by PH0PR11MB5046.namprd11.prod.outlook.com (2603:10b6:510:3b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Mon, 13 Feb 2023 01:31:09 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::eb70:80e0:1b88:3ca5]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::eb70:80e0:1b88:3ca5%9]) with mapi id 15.20.6086.023; Mon, 13 Feb 2023 01:31:09 +0000 From: "Zhang, Qi Z" To: Vipin P R , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address Thread-Topic: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address Thread-Index: AQHZKR3BexqaAWwVdUy+DfGRRDUDEa6h16LAgCGYAACACNHCgA== Date: Mon, 13 Feb 2023 01:31:09 +0000 Message-ID: References: <1673615963-21216-1-git-send-email-vipinp@vmware.com> <1673615963-21216-2-git-send-email-vipinp@vmware.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|PH0PR11MB5046:EE_ x-ms-office365-filtering-correlation-id: bdfd1547-1872-4317-6d3d-08db0d61fc45 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sIYNuqg1f6hClIZp8eVDtgyWbm9lVe47dP062QPrfec/HPSjeE7JL/uCVAFYDXsI7ylRRr7p4K9SxzI1UpnC0xcW9QRpToiNeEws2tdTU3Q/8enF/nDta0R4dWbXttYr2+v/t/0uyRQUQxKldfuWeNP5Eopa+EG4UODmDrI0kw492SgaRZEU+pm/YVpjJ/1+m1rrDrXHiwbBxWkhtVkPaAs+sLw2HmoqRmq4dsfmBOJs5lrTapivRE0EYlyHFl4lDX+SOP7+zJPAISiLxVyx3Jaylg/gk1Eg/iyxKQbveHfmg4JT1Xb04D+XTsBJX7u2/61DSrpYs7/+9b3GCJzYLw0k07fYQsKEol+OMh1nBpwarTUsrNU0LWA2kJq9JyraTNvAMc8d2QRG/bDOVKuz2PYR+P3q5vY1UXVEYcllfUwpWc9Xz0g042MMsDSHKD7Rl26vEQpydqDxXz1dyznBvnzEHX5DG4trBtUotvdLlZgSWT8UhFRROX3Tb15yIBasTT0Kkwswa9uPta9nCPKWlUL6aqtpjQkZu9c6TWDxYF09ivv9UoqxIIponvxFl/gvIV2DaHb99NxdXi4dphwggAkpnqrBPFLGoxMoNT62ChxCV6u1BSbt+CgWMA+lj3BW9Xoa4KxKk80QBUMPVUHmZvfUA3jasnsWkcZWS6TqF+PMbG78INV33auwlYAOj0KjGddB1RgwmsPCwtV42bVF4g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(366004)(346002)(136003)(396003)(376002)(39860400002)(451199018)(122000001)(82960400001)(38100700002)(38070700005)(33656002)(55016003)(86362001)(4326008)(64756008)(8676002)(66446008)(66476007)(66946007)(316002)(6636002)(110136005)(66556008)(76116006)(478600001)(53546011)(6506007)(186003)(9686003)(26005)(54906003)(7696005)(71200400001)(2906002)(41300700001)(52536014)(8936002)(83380400001)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?s9DpJ+Fu2E0rXPO4RwtDJYisfOQTwHtqsB2XLG2gOkLQNU6k1Q3FCigso1?= =?iso-8859-1?Q?qO4PXgheK4HM+eDbzICejyZvccuux28B6NE2T4LFHG5up1Ggm+QTN25j7J?= =?iso-8859-1?Q?NVI2uZqDgFwmrN4pWb3Q8T8n1CQ6KQCiX9+vQT+WJUJWBrY51VZfIwDXnA?= =?iso-8859-1?Q?mZXmU21Ho4CNO+hUI55xNIUNREJZ/P0qWb6PE0GAS+64B5+yeWl5fb8y7N?= =?iso-8859-1?Q?CB2RaaiMNOemYvwqe48ujgTUeXN4bFB2FcAKN/+micEQExdt8HBmyabZku?= =?iso-8859-1?Q?LSRw4L1h+QHjVopuKQy0Z5/SNrRaj9lBcNgC9nGp2+iLNp0P2b76Szo6c1?= =?iso-8859-1?Q?AnpTAUm4SoTTHNZPDHQQUKUPeI7trgglZcDwxWPr/eogxXL33X5bcaABRP?= =?iso-8859-1?Q?OzQAnJk9ZUpyGzTc+o0Gszwqb4aUf+RhV+f0woFQi1kEETbVf6gd6MdMue?= =?iso-8859-1?Q?PUDNgdtZSivMvWZ15eQh9lSq1c6DrFCVBm4zSOtyV9S5u7KqZVJe9c4FsX?= =?iso-8859-1?Q?1Z2k+M1qP9BpjR8C+ehMsycxziB7vPz7aly/ap8iBWKAlWLv2Q7adVzI4p?= =?iso-8859-1?Q?GHYDef1BHtQOdkrFdSGfSTONZoYfDDn77vhmQX5VQvZv3OJqjKWKDd47Uu?= =?iso-8859-1?Q?glG8dhkrZrhFNt5moFhx6eK5hgVgs900BokrO5FkQvkdNOLW/hnr116m5d?= =?iso-8859-1?Q?3XHG842i+kHX5TyrlN6SHBq2flEVxtGbiEm4B2W73KLXQE5jf4Qq+g4fw2?= =?iso-8859-1?Q?1zusLRGbF9zLleY0C25RC3mxCs3aPBSV4TZh9m7bnYy/1RWY/KodfdwsNT?= =?iso-8859-1?Q?AwRVGG3VvwE7GRvGDoFSJyRZmfB596pxvaWNafLn2fr6mLJwC8qGiJl87G?= =?iso-8859-1?Q?eITvMrawkFkp3YMWlktx07JHiyeqKKlMeQ8AMhnWQMjwBpC+rPCnv+f5z/?= =?iso-8859-1?Q?Jr4RM2iyskQnBOAY2sGmkSs1MOQwvwR3Vwyfqgv8EJTlsI0oGNPyoVVdFe?= =?iso-8859-1?Q?VFiDjSfczGaZQiFSr++LRsXABbWqdYPgTsDGGx0nzW3ohDUfOy7SxlE0bG?= =?iso-8859-1?Q?bff3w93/8T+tWNTt5gSpf+l2b9C5mEeWJR5b42L9kknzd6L73FKWoEndRI?= =?iso-8859-1?Q?MKO1ufNYKdWcoAG6KXb9pDdMcChzTzVnE+ST7UJAkjAzTYbYiemHp1Phxq?= =?iso-8859-1?Q?snu+Lwvtn75mXEf8RK9rW76OoJSVz8MMdNVuJ1XQKGO1OIVRjXcUmMIZui?= =?iso-8859-1?Q?h62Zs3b3UmflZm92YJ5JkKqLLqyRO1Wf7Mx9fZ2tqyzuPhg4fFnBpaw0nh?= =?iso-8859-1?Q?4T2Ktp2TSC7CpNRrBjvwb1Sxl6boE2tKL5rt6rpHr+PzurCFKdJpi2f8yr?= =?iso-8859-1?Q?20JWLroMCvPbu+2l3RXB2B8G2CnDINYFXT9oBAVa1Mc0FyybYTZPP0fBS1?= =?iso-8859-1?Q?gqwunZyXLaiaovq8mU75K7DMS/Z9lWMw4Hsmb820tEq+ucSm74F1OiAKTu?= =?iso-8859-1?Q?SWNxz9fVmBbsySYyHYGd5GPPr5ZnlnmsahGMUaIQvlVnDfkAFtXrXrRXIx?= =?iso-8859-1?Q?xjj8bitl1eJ3cn7NTtr1H84Hbq1NQpghyZa2vNJth6GoC0WYoZd/N4gqZm?= =?iso-8859-1?Q?d7snCKFSsn2gEyt/NDookdzKwLB9Ei9CLr?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdfd1547-1872-4317-6d3d-08db0d61fc45 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2023 01:31:09.7829 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SmK5XrSg4OYHI/P4el12aoJwuW7Es1CMrS/2x3CpEEIpZVYAQ98Db9wVi3GVCwuceyGHfXmZjB75wIYj9qEWvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5046 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Please always apply text format in mailing list. Sorry I have to reject this patch, as a device agnostic driver, iavf can't = just simply assume kernel PF driver don't support VIRTCHNL_OP_DEL_ETH_ADDR = and VIRTCHNL_OP_ADD_ETH_ADDR. A better solution is to introduce some VF/PF negotiation during init or lea= rning from runtime.(if get an unsupported error from PF after the first cal= l) From: Vipin P R =20 Sent: Tuesday, February 7, 2023 6:43 PM To: Zhang, Qi Z ; Wu, Jingjing ; Xing, Beilei Cc: dev@dpdk.org; stable@dpdk.org Subject: Re: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address ________________________________________ From: Zhang, Qi Z Sent: 17 January 2023 07:24 To: Vipin P R ; Wu, Jingjing ; Xing, Beilei Cc: mailto:dev@dpdk.org ; mailto:stable@dpdk.org Subject: RE: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address= =20 =A0 !! External Email > -----Original Message----- > From: Vipin P R > Sent: Friday, January 13, 2023 9:19 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: mailto:dev@dpdk.org; Vipin P R ; mailto:sta= ble@dpdk.org > Subject: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address > > In case of i40vf, VIRTCHNL_OP_DEL_ETH_ADDR and > VIRTCHNL_OP_ADD_ETH_ADDR are unsupported. > i40evf_execute_vf_cmd is invoked with these operations as part of > i40evf_set_mc_addr_list() > > The cases are not handled in i40evf_execute_vf_cmd() thus hitting the > default case. > There is a retry logic of upto 200 times (2000 in iavf) with a delay of 1= 0ms (1ms > in iavf). > This results in a needless delay of 2s in the init phase for each VNIC. > Sorry I didn't get this, why this is related with i40evf? I40evf PMD has be= en replaced by iavf PMD. The iavf PMD works with both i40e and ice, does this will break ice's usage= ? Hi, this is problem was discovered while using i40vf (which was deprecated = and replaced by iavf). Upon inspecting the code, this problem would also be= hit in iavf, if the=A0VIRTCHNL_OP_DEL_ETH_ADDR and=A0VIRTCHNL_OP_ADD_ETH_A= DDR are not supported. > The patch aims to rectify that delay. > In fe2a571c70cc397f2ad4e280f8d084148fea5d62, i40e_ethdev_vf.c was > deleted. Hence adding this in iavf_vchnl.c. > > Cc: mailto:stable@dpdk.org > > Signed-off-by: Vipin P R > --- >=A0 drivers/net/iavf/iavf_vchnl.c | 8 ++++++++ >=A0 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.= c index > f92daf9..e2f65f5 100644 > --- a/drivers/net/iavf/iavf_vchnl.c > +++ b/drivers/net/iavf/iavf_vchnl.c > @@ -367,6 +367,14 @@ iavf_execute_vf_cmd(struct iavf_adapter *adapter, > struct iavf_cmd_info *args, >=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 } >=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 _clear_cmd(vf); >=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 break; > + > +=A0=A0=A0 case VIRTCHNL_OP_ADD_ETH_ADDR: > +=A0=A0=A0 case VIRTCHNL_OP_DEL_ETH_ADDR: > +=A0=A0=A0=A0=A0=A0=A0 PMD_DRV_LOG(WARNING, "OP_{ADD/DEL}_ETH_ADDR > unsupported"); > +=A0=A0=A0=A0=A0=A0=A0 err =3D 0; > +=A0=A0=A0=A0=A0=A0=A0 _clear_cmd(vf); > +=A0=A0=A0=A0=A0=A0=A0 break; > + >=A0=A0=A0=A0=A0=A0 default: >=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 /* For other virtchnl ops in ru= nning time, >=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 * wait for the cmd done flag= . > -- > 2.7.4 !! External Email: This email originated from outside of the organization. = Do not click links or open attachments unless you recognize the sender.