From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E680A00C2; Mon, 8 Aug 2022 03:13:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E580E427F9; Mon, 8 Aug 2022 03:13:30 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id B74EF4014F for ; Mon, 8 Aug 2022 03:13:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659921208; x=1691457208; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=DkZ+tIWmPb+LVSbG3Kp3zXFVKD6eMU4qbyYFJixX7EA=; b=MwF/uqr2MtXpFcT1yk51OuX0dnoSXh7uNBp7Kz/b2w+PMh/AAT2zncT5 m4rKX+HFLPj8EGQt4PswHa9iqlVvTboffI4/A6nnOtE95yaGWOtIxJSVG ftqb8J7dFamLiUXPPAFQ1CuIjZsz7CG32F2XtuSEtb/ImRTmq1QowmMWa cTKsV2+zYgTE5+6NySHUumKr8bV4MsVB7pCRvSAbRwIzFHwFtbHRkmBPi SwDntnhgB4AK+S6iczmB8usULrtMQSUlZxyg+zenCI9NHZWN9NCFDZJKf kZk7/AtU5aNCrWBh1eOTniHQgzIeCsE79U+cIO6niYxeqr4D7w5Uk+ZhF g==; X-IronPort-AV: E=McAfee;i="6400,9594,10432"; a="316382305" X-IronPort-AV: E=Sophos;i="5.93,221,1654585200"; d="scan'208";a="316382305" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2022 18:13:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,221,1654585200"; d="scan'208";a="746445184" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 07 Aug 2022 18:13:27 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sun, 7 Aug 2022 18:13:27 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sun, 7 Aug 2022 18:13:26 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Sun, 7 Aug 2022 18:13:26 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Sun, 7 Aug 2022 18:13:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=isPsS6CXW/f0M3zX6ARWAA6KEwtHzfr4Y+YbFKFrtGQ1IpcgJgghCnYLN9UmrNIMtHZik+HUJTNt/GjpBW1bjw34fffFAOwwFD978xHuB8aGSmAU+u9TD880vbrc8CbLxD2CCDVv6hRk2D+mN7j7yZfd//BsMCpyjGHXv8/GUcsRBx1sg1n3OT+kxHBvx9U7Da1vvpc/FYRmCRkboTBjeLghK7mVGsUR9oDC1eBZnl3TQFNPqYKjOgb0yabOnMJBjEfg3105ARMr0RO9fiRJRBMRTLXBa30qzF837Jwo5CkyKy1m3Iv6pnY2VV+eDcOLfS+wIUHqHz3+LVdDJxyF/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Srk0C/m2vDjdchtLlTC892w6cTYEQ95VJ5C0iffdy7g=; b=XICfRypwN3stw/mItAO+C9wKur+dknYKJOjKIVs7ZZKOLUVvYgN07D2MLp2Da1oNDOaQihy4hD3+BrLnJSrhUAo1l4qSrCousNOkLlNeENDz72jYl20bka9GrxxQ6oA3S6xriCuxXeB8wjah2hTWX1T6kZ3YowxgZoCD9qL5cQ5Es80jRgCD4zjdBzaXCY7goo6tromzRsqh2bDNjeO0rIqFB/LMD/XlmjlpLR6yVt7haHIcHagNZAXlWWAFZX5gTGg9HgF9y2SVoAKNtzq4Wgn7+ilGtE3Q+QGGVKu5aprFZBXdAm0eDp8bTvBMZ9XVfbcJJDT8dWCL8a+IVK0sUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by BYAPR11MB3222.namprd11.prod.outlook.com (2603:10b6:a03:79::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Mon, 8 Aug 2022 01:13:24 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::dd15:c17:27dd:47f8]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::dd15:c17:27dd:47f8%5]) with mapi id 15.20.5504.020; Mon, 8 Aug 2022 01:13:23 +0000 From: "Zhang, Qi Z" To: "Zhang, Ke1X" , "Li, Xiaoyun" , "Wu, Jingjing" , "Xing, Beilei" , "dev@dpdk.org" CC: "Zhang, Ke1X" , "stable@dpdk.org" Subject: RE: [PATCH] net/iavf: fix Tx path Thread-Topic: [PATCH] net/iavf: fix Tx path Thread-Index: AQHYp9XFBwmVMZ1MZUqJSO/xW1lMQ62kN+MA Date: Mon, 8 Aug 2022 01:13:23 +0000 Message-ID: References: <20220804073300.402973-1-ke1x.zhang@intel.com> In-Reply-To: <20220804073300.402973-1-ke1x.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bf0dc296-b7e8-46e1-a988-08da78db30c5 x-ms-traffictypediagnostic: BYAPR11MB3222:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1rx9cxy8A7+Yd22J5qy+wsz5JCZiVEfBX7gK48HLfh8Bj/da9buLnTWy/aaojB3MLIL6pUp5NvY2eHsbHi3zD6vuTSQHXJLvgqqxCFyNta4dL5q6aerciDCuaaHpfkSwFDwjXGzP1IyoEG52yWc4MkU0u/xFXfVv94/pkRce59CQkIbIpgHMAsA0/FwDXxC2Q/Baqg5RSAucR7QOQldnBCScm+XOwjGidOhTfc9VBbwvxLca2mI2SJcBqfCHTdRpx4Qjkk5RzcyiMKEMRTks9WvRxeZLUrPXuRx0dh9G37V9S0xfIDnAteYXp6ua//oOO2Rc/6iB779hzgkH5OG75EqgFC+i9hk7KHt6fYsOH1ZKrN0HSxeKbuMNInvuvVqrBMxUBqJPG0d/RQdVEByRU6tOGhHF5VZhIc0DL5ryaHsQU+G8yd2dc1JwWFpZZ/3/MDsqiZD9vvcm8VqopHFPC91+AoiSXMZiGu7hLAotzq2uh5KOfglN9iTMikhxMvPCtDrBHmcjYFJ/srH77ZA3mbYH0pWTkfLN1GnpUB+/jmqnrUoMU1rA3Ktd0MTUpVa4DTCKGLIHEQUcRtx/tMmgUc4d7a6s3Iglrg8bTRB25QqccUq6/nQMD5vIN3razGD6+3STlKbNRftySrKOTFgm6Zj6F1BMkjRQ1/yyFz5B5m5hxovgkuCkCi4tiUpx0+ovDa9zT/itAVqo9N8glMT2SU7HsqxbfRnYDnlAltAwiQooR9ZPd+aUXNuG/pZcsCmZEuMx7ICjYYoKumpUXk21aBgiurTpu5IVc8zz3tt8DTPBTysOr6zuX2ryQlrFYKjn x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(366004)(346002)(376002)(396003)(39860400002)(4326008)(38100700002)(86362001)(122000001)(66446008)(8936002)(54906003)(71200400001)(5660300002)(66946007)(450100002)(64756008)(66556008)(110136005)(8676002)(76116006)(66476007)(52536014)(41300700001)(9686003)(6506007)(53546011)(7696005)(316002)(33656002)(478600001)(186003)(2906002)(26005)(55016003)(83380400001)(82960400001)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pMVVWC1Kj9Z5sgf8nzkAb2Nv3herJQ3IaEJiMPJvbJQxetooVDm+mHfjRDoq?= =?us-ascii?Q?bYtRTs249rqrwW4TwtQrX1bZAO8VEkOD4uWC9Mk0iagDU4OFuXtFCM1ckFkI?= =?us-ascii?Q?89GIu4h9RhZRx9UxwsT0Eoa0nFvPQTWzQSe3PqM2XAYGbkLOy6RvPWYKtnfW?= =?us-ascii?Q?DTQF86xGbQOx/tcFBmTWy/pnKrFEeryzcXj8Jcqr+4LgnMfDKWeOAFB2vjGX?= =?us-ascii?Q?qq5UHYqy+F6MyitAQlXkdqXNm+xi3daiCCth2Wt/HIv6vR7dSr580ujz1dgK?= =?us-ascii?Q?6/V6/XU04AfccdXfpddzFN7Ywffc5G3Hm8sxmgZKT4ylZlNmKnfPJvTzmjaz?= =?us-ascii?Q?dzoWznxF6MSPV72kDphDWNMVHfaSKgZa2SmKLyd1wAGCPkSmlDAkRUo62x5T?= =?us-ascii?Q?JdTe4UN5x/1hjZh7rj/0SXVtVsR8Zv+7ZwAo+emUydr7lyyxklqHkaVghN5P?= =?us-ascii?Q?fx8DoHQG94ZSMZlp9BiIrW4r6W5lNMty53ipsVOeOdLLr8tOQN83sWDMuXte?= =?us-ascii?Q?rnjihXZKD4UjYONCDFlpec2NHxwOWGOpQtvOBxatP++Wksk8dYyfffqbaqYm?= =?us-ascii?Q?I1HadAruPMFbx7wPKGbwNxsgqQEGD8JKO73f7UPByd1DIpXHVFV05dPPd1pn?= =?us-ascii?Q?Yv9aY5F+EuiaU6wDXFEMTobctMpJLpmhnjyNb/EvbclPqqaI9ggPO+lkGuGx?= =?us-ascii?Q?At3Zi3KYXo9DJoH2O9b2hno4Q/gFAvSKXc7sJ0cvsEckPe5YxCozefoclR16?= =?us-ascii?Q?q+o4vjAUoKT8KLqNFYiObIURqY/zDtCrCp7DLeHSdvraesjiFhb2kXZmv9EO?= =?us-ascii?Q?wR2EJFvAOegL1nvMfvculTVYb6S93rjJtzjnmGBm3Bv+Fp32Mo1c9NkcLVmO?= =?us-ascii?Q?m1WO5oaC+aqHGWw0cL26wO7PDHiUcuvlK4PZCF8Rf6o1GyZlZK2bqv3SxM3P?= =?us-ascii?Q?C7lOT22F9TFvJZNFcNsqZ7dfnjgkeRZbE+oNpL+M5nSqBcxzyimwC4WOSI4W?= =?us-ascii?Q?HghhWgnY1x3oMGUSGqX/XIpG1Z5xpx0rGndz7crkCLaCHTfKm2ifSeI345sg?= =?us-ascii?Q?eDIpDdvrZR8ZXvhOABd+0vklRNy5hb5jmTKQCGPEOfIjEmjhAV7O5vJNuoLs?= =?us-ascii?Q?JxvevlToXQWzT+gcKytlF55DRRAgwkMFNzd29k4gGis+BEuEBVcANMccncEr?= =?us-ascii?Q?2rJ+bBaYJI0a3+JMzCr4TbMtsjc5ugFGBnwhyNdiLdISXndpTT4PloleY+9y?= =?us-ascii?Q?SNcbrGt4L0G40N5KnWC5NbzEWi9UWPolYC3EO+DWl8hmkmYR8Aq1HAOuNEYJ?= =?us-ascii?Q?MbSUTefI7Vtdwc2tKWJQHZPQxdBt/bAWbZzAjydoH6JGxQzoH98c7McYhZtp?= =?us-ascii?Q?oY9h9bBu+2p4FFB7H20XlnMysB10jqFa3WJ5KA9hqzf7UTmu6k5CBgWyAuz2?= =?us-ascii?Q?M0N7PQyodR2fd/Ae38yWz97oCz/P4fO55fjCH/hNMfXvZ32Lb5i1Q+KmBSKX?= =?us-ascii?Q?gzxZu4wKgF9vk+8heuVVTwS7tk7sK/bB09JsT/lYWrbVf2zLngo8i/sTDzpN?= =?us-ascii?Q?5eIZEGVc+C4SK5iUElW/N/uayhLL4NyFy/eCsMZx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf0dc296-b7e8-46e1-a988-08da78db30c5 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2022 01:13:23.7465 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aZXSiKImOe3xYqt2f33lx296zOuIZvH6LCBR6wg17nsQpXGcwQ6IMVRmz07VMFXdH5aNfQq0m7w9R+AMT58Epg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3222 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ke Zhang > Sent: Thursday, August 4, 2022 3:33 PM > To: Li, Xiaoyun ; Wu, Jingjing > ; Xing, Beilei ; > dev@dpdk.org > Cc: Zhang, Ke1X ; stable@dpdk.org > Subject: [PATCH] net/iavf: fix Tx path >=20 > Fix the Tx path and Tx descriptor usage in order to make the Tx offload f= lags > and Tx data descriptor consistent. Seems all the changes are about fix Tx l3 checksum offload, the title and c= ommit log can be more specific. >=20 > Fixes: 1e728b01120c ("net/iavf: rework Tx path") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ke Zhang > --- > drivers/net/iavf/iavf_rxtx.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c = index > 109ba756f8..dfd021889e 100644 > --- a/drivers/net/iavf/iavf_rxtx.c > +++ b/drivers/net/iavf/iavf_rxtx.c > @@ -2538,9 +2538,11 @@ iavf_build_data_desc_cmd_offset_fields(volatile > uint64_t *qw1, > offset |=3D (m->l2_len >> 1) << > IAVF_TX_DESC_LENGTH_MACLEN_SHIFT; >=20 > /* Enable L3 checksum offloading inner */ > - if (m->ol_flags & (RTE_MBUF_F_TX_IP_CKSUM | > RTE_MBUF_F_TX_IPV4)) { > - command |=3D IAVF_TX_DESC_CMD_IIPT_IPV4_CSUM; > - offset |=3D (m->l3_len >> 2) << > IAVF_TX_DESC_LENGTH_IPLEN_SHIFT; > + if (m->ol_flags & RTE_MBUF_F_TX_IP_CKSUM) { > + if (m->ol_flags & RTE_MBUF_F_TX_IPV4) { > + command |=3D IAVF_TX_DESC_CMD_IIPT_IPV4_CSUM; > + offset |=3D (m->l3_len >> 2) << > IAVF_TX_DESC_LENGTH_IPLEN_SHIFT; > + } > } else if (m->ol_flags & RTE_MBUF_F_TX_IPV4) { > command |=3D IAVF_TX_DESC_CMD_IIPT_IPV4; > offset |=3D (m->l3_len >> 2) << > IAVF_TX_DESC_LENGTH_IPLEN_SHIFT; > -- > 2.25.1