From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 724294383C; Fri, 5 Jan 2024 13:50:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09897402F2; Fri, 5 Jan 2024 13:50:06 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 37237402E7 for ; Fri, 5 Jan 2024 13:50:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704459004; x=1735995004; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=NKx7QkQdbXPth2sPZVuy/zrTgKyMlKMHIjTbHBRp/dw=; b=hwpupPrBSJ2Q7N97gIYDRU0qNJX/bQs+vXMELxU5+Vs8CV6rL6hjzB1N jNTTWaJcRM4G0kB4wysfjd+zeZEOgEWXHAe4ecTpSBNqtwfi4XheaPzn1 htZp65gu+SANubGUcyQmk5UKKhIhuKRbWDv7BNCg6BoZ2urRIbdkf1Wdz Ua7KYKJBYY+KeRrPU3E9yua08pOtoxqZdaxnbTCGwiHz385Sg+HI5fGHw ygG1TtwwFlrhGxhuZCNJTLwWmsUv4OK+dXUipkf8ymUJnSUcJ32xFDjYG rGo2wYlY+zj7J5cM0IcNPLHX/QmpPqv4ktsoE0awO5VRSOSYF/gBKZAAv w==; X-IronPort-AV: E=McAfee;i="6600,9927,10943"; a="387950032" X-IronPort-AV: E=Sophos;i="6.04,333,1695711600"; d="scan'208";a="387950032" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2024 04:49:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10943"; a="871229604" X-IronPort-AV: E=Sophos;i="6.04,333,1695711600"; d="scan'208";a="871229604" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Jan 2024 04:49:46 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 5 Jan 2024 04:49:45 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 5 Jan 2024 04:49:45 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 5 Jan 2024 04:49:45 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 5 Jan 2024 04:49:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dESzZqeT3Sm3RA34IGWmqYAcmxN4TjLCNuiKIdVKH+QpcC/4AazcnsdR0LTVQK37J0kT4I17MEaPF/293E1I/as9M1R3fAsJBuAlI5VY52HvnHuOYnxn92SHtBmynNHfZZAV79lMLHDmun//owqIjseT+kcJMJvBMGcFrBJZ2bnoCkn7EmcvQZvLI43Pl4ursr+soiSvUnedOkNtla6uqX9thk67KmjOIen3p210B1E/n50J0Fqj/34rJTERut44Kxw0PI5nLg+ISF51NDAzuy2Z5GHjxW1ZvqT1QkjwTkZIXI3V5D1ind4E/OjFZsZIM4qNRcN/WxfL9vqIy2qpyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EFeOXGPLU7CDHJpnS9pINhRXvOSp1G09spfN40YqPS4=; b=aG0qb8YEsOUUE1eBGyISR18hnHg3++86nhgXvkRhNoUIM73JswOpnEuSnZwaslKJ4Xi4jVT/xvADZN4WddW0GYzGYofX7sDPY8ipLMBLP1qLaMhuzZz+dEr2qAYApk9OyawJtEY835LS/Bmr1f6MSKhf3eFvuoKvQD6ABRBnoFxHFUctnAg2RoFPgJFQRcVdw2y6kBkLLyEBZNiXwAXADrz5mRFX06brdnX/WrH2QoiP/WziuekGFi5ehbDipByTB7T+1lv9IJGGMv9kQ29WgcVOO6CebCehtU5YEQaOtPlZg+oWoF1vY4xaB8CIh+nTCUInUv40pb1UbtaaQlqvhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by MN2PR11MB4711.namprd11.prod.outlook.com (2603:10b6:208:24e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.16; Fri, 5 Jan 2024 12:49:43 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::fc91:526:bead:4f73]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::fc91:526:bead:4f73%4]) with mapi id 15.20.7159.015; Fri, 5 Jan 2024 12:49:43 +0000 From: "Zhang, Qi Z" To: "Wu, Wenjun1" , "Yang, Qiming" CC: "dev@dpdk.org" Subject: RE: [PATCH] net/ice: refine queue start stop Thread-Topic: [PATCH] net/ice: refine queue start stop Thread-Index: AQHaP5Vle9v7dtinYESvb/Zs1+LBOrDKumsAgABxpBA= Date: Fri, 5 Jan 2024 12:49:42 +0000 Message-ID: References: <20240105133705.360750-1-qi.z.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|MN2PR11MB4711:EE_ x-ms-office365-filtering-correlation-id: 01fd09b4-c6ba-4603-0228-08dc0decc9de x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yEQhzxblIpjL/WE9a2GNFGPI3MjATFl7Lwh39/Xrpw1CBfV+tp5K0AMRmv0L5Fnl9eJK+fA+juAnmiu0UXAnVHdFi0AhcYy/GmC94rUDDtoyMAE8yK38PprVYRQ/t7JjSggU76LHBjmAQSWLnIMDnRibGXXG42MoqGesVNZ+LjMjdMfGPXjpRK6BzvTk/aQ+9WFMtX5GQFvGZAPFXwXmwJXBk8TEcKjuy7LzbfmlMPicDNDyZD7l94jkefAc3MpA6i5mWPD0mhMGFiJoWF7P+uKbe4oHQ3LmG7vuEAZXgQg+1jZRS9tYhyL/6LDyNxI8Cph1xXsZRIHNXgHftdeOFavlY4nugQLM+pITdjoiyx8HIZ5dKbA600GMcZH1fZ5y4289ayAfTmzR4Kb3QBXlSrVGC4U+ryI0XVM2ahVsAvi5HoJtRzHAfVwTCBIxbBU1bZtf75LCwMefVje1pBTjovdcVDWvVNaDOpcNj+Mhif5ZvWV2YbdKJDXF+ALuFbLgHZXLDgsxnlgfGRVyKFC5oBuZsyMLYI/qAHzzeKkutOOdVt0vEbatY/suHkVkcrQWxvAaQp99VoWwd5FoCI4rgZIUGa+KW/lUKzOxNzfb3fl5MzvCtzTle/4uPtMuQhzZ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(39860400002)(346002)(136003)(396003)(230922051799003)(1800799012)(451199024)(186009)(64100799003)(83380400001)(71200400001)(4326008)(52536014)(7696005)(6506007)(53546011)(55016003)(38100700002)(478600001)(26005)(9686003)(122000001)(8936002)(82960400001)(66476007)(316002)(76116006)(64756008)(66556008)(66446008)(66946007)(8676002)(6636002)(110136005)(38070700009)(86362001)(41300700001)(33656002)(2906002)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0BXqpPt9HoTAggbqiyvV42PvUIxPmJMGXtEq4H9c45N/ZF/ObItdB4UU8y5I?= =?us-ascii?Q?ugRDZp5TYKpkhZ36GjROhzFFGuNocGdx4qMMTSIH3rIcsMCScbH5a6opjevp?= =?us-ascii?Q?ucMcNenfEhpL0NPKSqQWf+B9yivaSicxYA6/Ru97e4C2SEmn4NTNOosNdx0J?= =?us-ascii?Q?xX3KlrTPjGlWai1WN60CrJ2xJdRcZPdXMJRsys+7QInt2cMz+oynhNvBf1oo?= =?us-ascii?Q?HQssbVDqrVENVnOgCSttThAbMODaYoLe4CPeh/2SrgDTQ7uydXg7DTactBZZ?= =?us-ascii?Q?yVFozc3ieWJJkKxX7ISwipWW9GkliHtY8ARlF9vVmWU/x//f8avsR6XLms/s?= =?us-ascii?Q?TaZgPUI0KU1U6valc0e2gciki5mCmQQ63JZl2GTOZrV7ic0Mt+b7I1fOV0sW?= =?us-ascii?Q?qclOhQQ8iltCK63ToI5EJDjhTq0gW0GrwbgbtSbsI4IjYhQ97unCd0Dzaa0K?= =?us-ascii?Q?WMeQfHNbPJK4vj1euTHLhhs9OFmHaIBdcev9AMjcF4u4oAowxxJQpqX07n+s?= =?us-ascii?Q?rE6UXzxPd3QR+77v+qf0DdOsoi0dxbT3rIy3HXSSmAosDds+ikLPOX/e30Vm?= =?us-ascii?Q?8F2nYS+UhhhHY8W6KtILFb5Qn5DcLahR4WmxV2fknbjzr1i6uEKyEVer8aPW?= =?us-ascii?Q?QIVLu2FWDVrT7uD+OXd0knBglNkcWLvdpLVTgCDLQIRDHsvWoTeReIkgSPkv?= =?us-ascii?Q?xq+6BvpenePXm+sKNg644wanpzgkAP/jncKBeof+/cjY0qF4aZp12TjjYflj?= =?us-ascii?Q?zBQomdZyvA55+2/6gh86EgyKl59euB0OGnOyU5H+JGvpN1zEqAFvhb15L04N?= =?us-ascii?Q?j1lmesArAnlsGCSR+3hNt6wSpozQ3oqAxWMH59pjp1rlxv8vfIMY9TCPvOfz?= =?us-ascii?Q?XhJ73m17d3UcvGe/SEudfNukpzGRohxZKzcwLnKu4Pb/YAVM39WcbeDN2ffT?= =?us-ascii?Q?owUrBQN4I8dBHwnKpnFpsyBlogL8Ylxx0CUo+pO2s0PR6RA80jdx4iipjRCK?= =?us-ascii?Q?CnOvVpBDG5S5Q0c28F+XIwpE9Emp/AOES+dHWFS5U2sJzuAfErHsOpC75LmV?= =?us-ascii?Q?rK3rDPiwDj0s6IyeWRjdHApOxG2mIbcPZ1E/GI37St2RtgkpmFVINZe6VaPR?= =?us-ascii?Q?NHGPsvxepaQoerXdJBhvMbOouLAdSdwMX4FCEXFsUxCa6fSZzvV1A+0xsYJw?= =?us-ascii?Q?Zap79Zn2V18/TgcWRuAhEZUM10p8CdW8wkNGu+Nu0SWE92qgtYkkJ86diXtw?= =?us-ascii?Q?8EzDGowsU1QOW6NCk5WWYOTGto8PHyKqgWpS7ik1rbJhq+PsBPmDVWsKKTGU?= =?us-ascii?Q?dZUBemvpyqWv0iWF+GTpiaaKz6AIaIBZraN94VQBJST1ksPrdUY65vI55a1b?= =?us-ascii?Q?za6UiXLdaUcje3RBeNF+rVFuJVDPlATC97+nTWEWEgwlNX8yyYDf0VuXGL4X?= =?us-ascii?Q?Txt4PWhdyTloE5X8OibWPTVPkasYVbNt9M3f0cNY2PFMOezRI/IRcfpD2PQm?= =?us-ascii?Q?KmrVR6UZb4v1mVDbNBd7ki7fh0lkKxslJaD2/7osOGMp+1T6k/A08V+o3ljY?= =?us-ascii?Q?B+BLqARbqFAWDD6BWKqMUe7llzH4fl5PdZi3P5nI?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01fd09b4-c6ba-4603-0228-08dc0decc9de X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2024 12:49:42.9492 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cLcnEJqQG7y8dzpKqBTWV6TCZNdV/6qN7M6vZsbgd80a1mRmxNo7naCiSydrPyM360pI/z2N5Xglz6aM0U/Xlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4711 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wu, Wenjun1 > Sent: Friday, January 5, 2024 2:03 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/ice: refine queue start stop >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Friday, January 5, 2024 9:37 PM > > To: Yang, Qiming ; Wu, Wenjun1 > > > > Cc: dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH] net/ice: refine queue start stop > > > > Not necessary to return fail when starting or stopping a queue if the > > queue was already at required state. > > > > Signed-off-by: Qi Zhang > > --- > > drivers/net/ice/ice_rxtx.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c > > index 73e47ae92d..3286bb08fe 100644 > > --- a/drivers/net/ice/ice_rxtx.c > > +++ b/drivers/net/ice/ice_rxtx.c > > @@ -673,6 +673,10 @@ ice_rx_queue_start(struct rte_eth_dev *dev, > > uint16_t rx_queue_id) > > return -EINVAL; > > } > > > > + if (dev->data->rx_queue_state[rx_queue_id] =3D=3D > > + RTE_ETH_QUEUE_STATE_STARTED) > > + return 0; > > + > > if (dev->data->dev_conf.rxmode.offloads & > > RTE_ETH_RX_OFFLOAD_TIMESTAMP) > > rxq->ts_enable =3D true; > > err =3D ice_program_hw_rx_queue(rxq); > > @@ -717,6 +721,10 @@ ice_rx_queue_stop(struct rte_eth_dev *dev, > > uint16_t rx_queue_id) > > if (rx_queue_id < dev->data->nb_rx_queues) { > > rxq =3D dev->data->rx_queues[rx_queue_id]; > > > > + if (dev->data->rx_queue_state[rx_queue_id] =3D=3D > > + RTE_ETH_QUEUE_STATE_STOPPED) > > + return 0; > > + > > err =3D ice_switch_rx_queue(hw, rxq->reg_idx, false); > > if (err) { > > PMD_DRV_LOG(ERR, "Failed to switch RX queue %u > off", @@ -758,6 > > +766,10 @@ ice_tx_queue_start(struct rte_eth_dev *dev, uint16_t > > tx_queue_id) > > return -EINVAL; > > } > > > > + if (dev->data->tx_queue_state[tx_queue_id] =3D=3D > > + RTE_ETH_QUEUE_STATE_STARTED) > > + return 0; > > + > > buf_len =3D ice_struct_size(txq_elem, txqs, 1); > > txq_elem =3D ice_malloc(hw, buf_len); > > if (!txq_elem) > > @@ -1066,6 +1078,10 @@ ice_tx_queue_stop(struct rte_eth_dev *dev, > > uint16_t tx_queue_id) > > return -EINVAL; > > } > > > > + if (dev->data->tx_queue_state[tx_queue_id] =3D=3D > > + RTE_ETH_QUEUE_STATE_STOPPED) > > + return 0; > > + > > q_ids[0] =3D txq->reg_idx; > > q_teids[0] =3D txq->q_teid; > > > > -- > > 2.31.1 >=20 > Acked-by: Wenjun Wu Applied to dpdk-next-net-intel. Thanks Qi