From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C678432D6; Wed, 8 Nov 2023 13:02:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0A0140A73; Wed, 8 Nov 2023 13:02:39 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 4967D402DA; Wed, 8 Nov 2023 13:02:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699444957; x=1730980957; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PG6HBfGkl2B7FrjuYIOuX2V+C+vyN6z+kM46wfQhhsA=; b=fz48L4qhLEFLC5zkfbHnZMbJ+I4eIf6V9Z+0A/ykRpYopMfHLmJr4Y9U iz4ZHEOqpDZfe79GXkMX7U6fvQLdNPagoA3soaSI0/ffilMXsYriVXQbA +jXRLG88i+IKZEHV3rpat8BJmSNAoPseSEIWSgE7ZCdBKm4UmJDebuCU5 YuKP1iEBvph7KF/hpqmY66OsTlXJQSeTA89Wrn/v3kXxBe0yu2mlGQK8a zVS34/df+uH2pMdc4CNxBIa4hSDi6w97R4XE9wfTAanhfWd9zF0D5m2E+ eVX8kw7hTT4gTxN7IvR9Gaigeejcm+ahExm5bVAqLv+uZpnopvRIBLBcO w==; X-IronPort-AV: E=McAfee;i="6600,9927,10887"; a="420855411" X-IronPort-AV: E=Sophos;i="6.03,286,1694761200"; d="scan'208";a="420855411" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2023 04:02:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10887"; a="792175113" X-IronPort-AV: E=Sophos;i="6.03,286,1694761200"; d="scan'208";a="792175113" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Nov 2023 04:02:34 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 8 Nov 2023 04:02:34 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 8 Nov 2023 04:02:34 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 8 Nov 2023 04:02:34 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 8 Nov 2023 04:02:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H89JvU7Yb8Fj6p7ZKBlnPFvk/3eh+BITyVpcQVrb73PcgQ7BVv+6ilvZIfcVYF/ERs2dd9X/hQHRVzcsB17ilELk4fZGQbzDAtf3Wu1Zz4p0Ydp5At8f4hHzTjBUMb4h/3KmHMEZ5ncqcigA3B2f+DTQs253aF1Y3s8iSF9Ctkj1N18YHhdwFozGvVMxlBQKCjUOvI6X1V2KXPka50n0573uCBYk7VENBiY2NLAUfslH93x6xUJqwZmJNmGK67FgxiA3j8wrcR7cbq5gXFbQGUXNQtZsD+T38A8gsnRkfgT9NMkgKBwbwtdHv1rq3ZJny65WJtU1QSvUHGXCbCS2+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yWkjx67jFZb1JkAzUyKDem7UzVuR0XEjWk8z5sWH1NY=; b=SDb8FbuI65jVgCLXEyMbvY6RLhR6nE4Ln6qmZh7caZ3H5YnCUxEb0aZaZl0zclqDx7BjDaKAst38ZTsy4UJpEQlCYxeCIT7h8+ylizJcBqBCZT8IE+dK7U+8i0WvolrDqkRwE4KJuqP3JnEEeYfFKmpGA/Kp32N0UuFg9J9xJyjkgCCXnjL2kS82v5ADKvRojL9/WWa/emWOH7c6o3AGiSLCfky1zphFbtW4FeEKsubPcVnaYuK3API0N/Hecb2tTRlAX5uIt70hB2MRtb7NKIIdyl2id5L6dbTby4gUMS3bZEFWK++AVrE9XaBe6P6OP0y29g5/uZOCYlTWe4oz1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by MW3PR11MB4635.namprd11.prod.outlook.com (2603:10b6:303:2c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.18; Wed, 8 Nov 2023 12:02:30 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136%6]) with mapi id 15.20.6954.024; Wed, 8 Nov 2023 12:02:30 +0000 From: "Zhang, Qi Z" To: "Zhang, Qi Z" , "Deng, KaiwenX" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" , "Zhou, YidingX" , "Deng, KaiwenX" , "Wu, Jingjing" , "Xing, Beilei" , "Zeng, ZhichaoX" Subject: RE: [PATCH v3] net/iavf: fix mbuf release API selection Thread-Topic: [PATCH v3] net/iavf: fix mbuf release API selection Thread-Index: AQHaDUyvc+aNMNRdCUibDRJ8yPWh8LBwMRfggAAqo1A= Date: Wed, 8 Nov 2023 12:02:30 +0000 Message-ID: References: <20231101013433.534399-1-kaiwenx.deng@intel.com> <20231102044316.541458-1-kaiwenx.deng@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|MW3PR11MB4635:EE_ x-ms-office365-filtering-correlation-id: 919a22da-69bb-4da2-70ca-08dbe0529566 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SyswtR5p9bkn5gOc8c+gwiKOMSu+fEUBhe69MkkheufDbrAqZiG/w6qBEdgCShCXFKM8bgpXISt4154p5ZDd4ILFAglrSAJAPJVisO/foIkXh43MT571vLxmtmugXXDgv/cdoKU9w93ZPXLv3C5/Wu/mgDzU3dZnQggeYi01/zBZJp7Th2l+5gea+GUwJWhMoqY1f1PbNI6o8tF52WS/B2E7mioRjLv1iEWyNXEeYrzYR+MiZEHCpk9I9E++37UnYoPiFGzEZ7OYtjBa1f4Jb9ttrzrB2cxCiguHo0fI2nX3RgQjJwqKslDN5Yt6+W8UB2Cscv5ddq1VlSLiYGl7vS0Sgq/MImipm4XTZ9kShYqW0kO+2wO7EFYzUbYPMq5Kqayf7pkNH2ylr4K6h55knuidpZEMMEwzlNE1L1BiVUHFYBTC8LfTsIWB+vb8/Wet9aKMtRdEdlyWwqlkepO2l89RPT/4gbAboMm/2lmPd4U4dmw0ZZPk/Y4r/WK2cUqZoscaqrJIlHQlVXfcF3HAMZzKAWLxWC/hpgx8WjXX6BQqt/ZZFHIy03tsp9R583uDiI6Xh0p0Z/7YWMoLfZULXcWdwWAyjoDPJjIMDyTvv9k8hFD5kqvCgQhIFEC2zCwm x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(396003)(366004)(136003)(346002)(230922051799003)(1800799009)(186009)(451199024)(64100799003)(110136005)(76116006)(316002)(64756008)(66476007)(66946007)(66556008)(54906003)(66446008)(33656002)(26005)(107886003)(7696005)(6506007)(53546011)(71200400001)(2940100002)(9686003)(38070700009)(478600001)(83380400001)(5660300002)(38100700002)(122000001)(41300700001)(82960400001)(2906002)(55016003)(86362001)(52536014)(450100002)(8936002)(8676002)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vdmh3YXQ2PlJEbK76wvvFp0SuAOsR8pTV1Nk2fw0iMGqM7v2WFiX/+Fo1Wrh?= =?us-ascii?Q?yXB7RKxetfE5zkLZPyH8kQSIrGvIXOjtIrGBxlcHbgP54/+NXk7ASuFYvvMu?= =?us-ascii?Q?k+MifbrnfUKduyy8geHzh3J4orbiJEl7wli6427akgf1/4w5l/TKwPmr2GWK?= =?us-ascii?Q?7y8/M1FXYAbXAqC0n67NmIgRAuvjyw4QbAMlC5hFJ4VrUAn2VLeY4rpIUPla?= =?us-ascii?Q?R/LPgz+KC0BDNa9n2STDLLJU4k+kBdP8M34x6mp3zuZTBPuO7IJO9reLW40J?= =?us-ascii?Q?HuX5HY4+EzTBitGBJPkeQMg88s2+XPyBiHvDwSPaYGzsxkMFTfAbVs6tUKVx?= =?us-ascii?Q?XjbqjBcfMvb6bEQaqBBtMPtwLIJNGbuYetgpQPRdSnmJRg3wiKW/N8l+xFwm?= =?us-ascii?Q?/hELTJ01+BD/uKW/Rq9gyk5P6glwhv4kV0wTzkwlfE67Y0OVZATVIercvDCm?= =?us-ascii?Q?8r1lPqcaVBZ7Vyka8Sfq0QarrjTLUQ4eQ48vnQDFPnIHbUNbTfYZn1qHi0XN?= =?us-ascii?Q?ehO7IV9MasXhjOOvLXuvBMHfi2xpzr39x1bb6oC0MKJUd1xknKusnfExQvPI?= =?us-ascii?Q?X7I2mj0RA3zks2RGcPvBhLdzK1ue1x42ytmf+ogZb4qVysH43KzVdsOgpR2X?= =?us-ascii?Q?buaza0w7FuXAzM0skOFv63v+Ra5azQr5AKHdOPsXOXw5PbM9rf5Dlmwz+OAX?= =?us-ascii?Q?Q8UmPn4Umq6qs8qZD0FU0rFVcGqrbH2sTeQzVoMeXBynsz8n44LL4MZJud1P?= =?us-ascii?Q?a/Ic4tF/k+mAWBQZym7EiIsJUbr6NgyGEpjVvjCvle4RTn2o2Xk18lsEcL2/?= =?us-ascii?Q?WLZSXjjrEqd5N7vc1MLUZELCmVyQ6e15pQ1AjaiB2we21iNwMP4pEB5wfkc8?= =?us-ascii?Q?M6nbZqZ3fMvQpOUUoatbH6dSONRtvL1dr5fqr6C8tbXYgcKHFc7dunM85/wH?= =?us-ascii?Q?glH1ZRgLChrD4SvkYIuBuqe1GVSq47Znokg+J5x0aMb5c7T7QNqYWnVgEi1Q?= =?us-ascii?Q?mf6OImsPILz916zNIPCdQ3hDTk4bAaxMSdD6ffcll6cvJs1jaFFPeGS9q4o0?= =?us-ascii?Q?8bMJkBUtgPsA2//Pc1wdeo+bGN5gm0uqAWYa0bTktdzb1xH1lJgLfFjgjddt?= =?us-ascii?Q?tkCdw/2bW5Y7Jm/T0CJ6HGv23xQSJwOF7gP44W7tr0hhJe8ZDjJnScWvI7c0?= =?us-ascii?Q?0bzXIPSOgNd/aRyeMAB+MYTS8+S+cm0l/gjjdixMJ5rl+sP/vXsyp1cjYXgx?= =?us-ascii?Q?E12q+lNIp/L2PuybC+3wBg5/WbHAvXmVOaODVQsZJJXDTeowYItxgvTtNVhI?= =?us-ascii?Q?o5DXa6WuvEuBfFUF8CoQ+BSCCdTx1gygb7VQqLI7j/Gd+lOLptbbNjkmnJY6?= =?us-ascii?Q?4AMiRbWO+r04p8uiCzJomZcsR+p97IYRBqWha1aksHX5cMym5XzWzhYeLdKf?= =?us-ascii?Q?o7qXcMnTPio8vqR9Zvf7Rwz2pjA0skOk0SgBWfzC12SnqTEvtmJ4TKlUKtI+?= =?us-ascii?Q?pPUlJ3VbDSBvFgi1uuAn/z8uC+nWyeOjpT7ddi9AIA0j/gLl+M5e8VDobx6o?= =?us-ascii?Q?bAdebqyjDLQwQWWVyQMmtr7zAUqTohC5y+ET8fpZ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 919a22da-69bb-4da2-70ca-08dbe0529566 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2023 12:02:30.0908 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fX7YvdLq/81CS4f6H4NP33F9b/1AwdG68/4CXZ4UeFb/Y5xVdnnFQdAhm+dpTHFhkRsBRjE3sSrJQIU0gDCuJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4635 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, November 8, 2023 5:33 PM > To: Deng, KaiwenX ; dev@dpdk.org > Cc: stable@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Wu, > Jingjing ; Xing, Beilei ; Z= eng, > ZhichaoX > Subject: RE: [PATCH v3] net/iavf: fix mbuf release API selection >=20 >=20 >=20 > > -----Original Message----- > > From: Kaiwen Deng > > Sent: Thursday, November 2, 2023 12:43 PM > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Yang, Qiming ; Zhou, > > YidingX ; Deng, KaiwenX > > ; Wu, Jingjing ; Xing, > > Beilei ; Zeng, ZhichaoX > > > > Subject: [PATCH v3] net/iavf: fix mbuf release API selection > > > > When AVX2 is forcibly selected and outer checksum offload is > > configured, the basic Tx path will be selected. Also, the txq mbuf > > release API is incorrectly set to iavf_tx_queue_release_mbufs_sse. This > causes coredump. > > > > This commit selects release_txq_mbufs to releasing txq mbufs when > > selecting the basic Tx path. > > > > Fixes: 22f1e7608ebc ("net/iavf: fix AVX2 Tx selection") > > Cc: stable@dpdk.org > > > > Signed-off-by: Kaiwen Deng > > --- > > drivers/net/iavf/iavf_rxtx.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/iavf/iavf_rxtx.c > > b/drivers/net/iavf/iavf_rxtx.c index 610912f635..a16e03d88c 100644 > > --- a/drivers/net/iavf/iavf_rxtx.c > > +++ b/drivers/net/iavf/iavf_rxtx.c > > @@ -4022,6 +4022,7 @@ iavf_set_tx_function(struct rte_eth_dev *dev) > > PMD_DRV_LOG(DEBUG, > > "AVX2 does not support outer > > checksum offload, using Basic Tx (port %d).", > > dev->data->port_id); > > + return; >=20 > This make the execution routing not consistent between avx2 and avx512. > I think it will be a better solution if we reset the use_avx2 flag here, = and use > this flag to decide if need to overwrite the release function later. Or you can just "goto normal" and removing function call assignment. >=20 > > } else { > > dev->tx_pkt_burst =3D > > iavf_xmit_pkts_vec_avx2_offload; > > dev->tx_pkt_prepare =3D iavf_prep_pkts; > > -- > > 2.34.1