From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56768A0542; Fri, 18 Nov 2022 10:57:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7C184067B; Fri, 18 Nov 2022 10:57:43 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id AD8794021F for ; Fri, 18 Nov 2022 10:57:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668765461; x=1700301461; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xplcG+wjwO82mqkXlQZEO6D5ytlV291NhEGgfkOcG/w=; b=iGwhzEeW6dgZvFnGhhAxvkTJhjs63kbqFVfz7uqcbAdToS2lH0VbkYW5 CE0cKvkE3xMNJ11s/nBxRMxySXCcVxs9XLNvaplNYX10HSJts8UiWcMWk g7o46aZ9ty/wDg1/M6AohTtyuHhAYxM8CQwaBwfSo0YCFDUw4QSQz5K2i 2/NdKsAza5Outi5fX0C9ehY3CR45HyU0njocqhhpBMCAEAf+G464W0Y/t c2AX/a4h+ffk9mVLFRGgo405nrbYD62CPTjDw0ihcZTNZSD0zK+i/aUbM BCsrW4IFR5RWJXZW+qSTqHmNAR4rzp4lKDXXxaqz1eJWraJ4tIbmoKp9a w==; X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="339940255" X-IronPort-AV: E=Sophos;i="5.96,173,1665471600"; d="scan'208";a="339940255" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2022 01:57:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="590956188" X-IronPort-AV: E=Sophos;i="5.96,173,1665471600"; d="scan'208";a="590956188" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 18 Nov 2022 01:57:40 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 18 Nov 2022 01:57:40 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 18 Nov 2022 01:57:40 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 18 Nov 2022 01:57:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RdETYYZWXZZAUERWYKc8QLCZGyk/+Keu9N442WylBUcMrFiC+MfsT2gPj4kwAv2HO0dcqesLTCUca4P33WdAMsT+z7QcvjR4rmK4q81iqxUiiSfUi1XUqI045Km7Nb70zeFBb/AEreOYlrVxUYkbRrX2LWeudh7zifY7AFF3YV8PHgOQGQnWJSyi+xDjl+x18lenn7Bp6OEuc60Yl6TSKX853/b15KLT1b7g+lUxkv4BvoNKMGY2AUeWzWSfCo5l600oEn1HleK93FmpsgtDmo7qY82GVydDSM1cLrE5/sfsqq0GUWBTuHd6/1+jiSad4WPlH15+8UH2Kt4qSrhEAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xplcG+wjwO82mqkXlQZEO6D5ytlV291NhEGgfkOcG/w=; b=Jrdjh2U4LvHrIFBQrw7zQ/aqNAGFWYGczRtZ4mLG9huNnVfkEUdQ/d5idZrrsBkagWgKz3UVLH3tjlnEbiZXKYwwDXFwF9WpUQo5MF8+S9zU0zTA+ZPxTkR5AHvmJft6NBVfAKQd2bxt6ypFP9t7hk5jv9oLl5xmznBfo6KPgYUP1AfNtJi0A4Am0PwxBLQHxcWdH54Jz+WyQzWefNlRJMbsZFef/rDPDI/ReDDOreE0LgqhwYHufxJw9UBZtzyfnAgurorRD3vtJeAldbHOdfSZmlLaNS8KTcTaoIGmq/FnBSZ4ZubhCBzWk6CK+cZ4H1vge1JWowIWs2U7Rn63Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DM6PR11MB4626.namprd11.prod.outlook.com (2603:10b6:5:2a9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 09:57:32 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e2ac:cde3:4d74:3fa7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e2ac:cde3:4d74:3fa7%3]) with mapi id 15.20.5813.019; Fri, 18 Nov 2022 09:57:32 +0000 From: "Zhang, Qi Z" To: "Xing, Beilei" , "Wu, Jingjing" CC: "dev@dpdk.org" , "Peng, Yuan" , "Xing, Beilei" Subject: RE: [PATCH v3] net/idpf: fix crash when launching l3fwd Thread-Topic: [PATCH v3] net/idpf: fix crash when launching l3fwd Thread-Index: AQHY+xvTXDwnEEUZDUeP2M6e/cTgha5Ecbfw Date: Fri, 18 Nov 2022 09:57:32 +0000 Message-ID: References: <20221117101509.14472-1-beilei.xing@intel.com> <20221118070246.114513-1-beilei.xing@intel.com> In-Reply-To: <20221118070246.114513-1-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|DM6PR11MB4626:EE_ x-ms-office365-filtering-correlation-id: 1d19286f-2127-459f-9d15-08dac94b500a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K14sGMEsJO7+a3ema907czwj5moGAmkpu/n+4fsxHLfHauru2Raqr/DuB379ypWT7yOUExzAUXAp/KEyO7BQlFBi3wf4ycTioTOGkpOVeWsOqfugCJncBN3aAF9Dm2Ob0YOAGMtpbhtNYvRd8IJaEIIpBOuZJiTWLfS4hjVAsml8/v/0VSEqTBAwNABeiBZkAIKbJ6Hbj9c8WTh0rt3q1jiY+rgkQRHTvR2Jk9n60yBV8t6CJsoUddmeugh9GWHGIZLJfPcx8kEE/TpQMY4XanPACH0i73sX3+XU4+5jeODID3E/dGVXcXrnXPf5KWg+h41v+ByHbfcppXhd3+x0OH7INPufUNwrqAjJIBp3poh1sTglxcjOAPA1XMtwVuFAgzBXEPRKZncXpp54A7A3H8mzpIxmPTnrjYuUVSvib6i7NFa4w0jefbPvkRlFFfzw/vWjkcih11dvJsukSTh6UuMtlD/RIiJ3rh2YTW3tS34HIWpDmpQ5Ifzh/RUmZZezk5tbPjpmu9g/zNBNgi5yXpHD4fNJNDW91O938cSFj86BOnEPWQiBfO6OSyPS/UK02QjlPY9gSZEfs6FHVOTUVYtKm5Cpj8ELPQWdKZHImq4MMzKNX4kPc/gTxT7HZAml3VzOdZAsGOJLoUrc0B1Yu/yucf/g3GRAkWjt06guM7v80uZ5tcsj0Gh1zx4WxY12pFrNp/ehNdJZBMa4Kg7LmtgNKSd3pS6t1BuJqQjtIk4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(376002)(39860400002)(366004)(396003)(346002)(451199015)(316002)(71200400001)(26005)(9686003)(6506007)(76116006)(64756008)(4326008)(8676002)(66556008)(66476007)(66446008)(66946007)(478600001)(54906003)(110136005)(6636002)(7696005)(53546011)(107886003)(66899015)(5660300002)(4744005)(8936002)(33656002)(83380400001)(186003)(41300700001)(52536014)(2906002)(86362001)(82960400001)(38100700002)(38070700005)(122000001)(55016003)(32563001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3Sfi1KCGWeO0MtoIsgN0mLW5TqQOczNWpZhRokvRJ6P6JJUXGkaq7c54jmR7?= =?us-ascii?Q?ykbk8a9vvC6wMqdqWDeaZWnAZLRUVIkfC93Ee67awuj3Aep5LCg9kTbkuE8i?= =?us-ascii?Q?tPnUvoupXFtykZ7/zmJxAxQDUDXPJDcUHzOBLaR2vpEmZwAFC4fssRFcjUtS?= =?us-ascii?Q?El10LeScPa+Ny4fXku46a8HBPdYn1eDOkC47F0/RG0KZtOT14OQLnzBsn+gJ?= =?us-ascii?Q?odvtW9TAzngbivGVBtV53XRfFXIFSwm2CHouby1mMmUyNdZiXwiqI6cRMzuH?= =?us-ascii?Q?MD6iMO88Ja0iAwCxeQSPApKgrmmTOflEWZJjbBOoqXwahUQ2AFNXHxHsU0Pk?= =?us-ascii?Q?3iyTMWErHNDCOeTMBLiHAs/q4xFUgKoC9OG4ZLxLXGmfrIwm6jdn753VkT/z?= =?us-ascii?Q?l399dUZAwaiYnABwukyG7kLbwdwIqYdDvrsah9nmYHrAcDDEHAaVwSCKqeED?= =?us-ascii?Q?b7w6VfSe9nFBRa5Nr+XDHEN8cLa2Ud/A+h1ks/yMDxCSodtkeSEtHfce1cII?= =?us-ascii?Q?9/J6PzNRl26kxZlt8lpZ8ikmNeLft0zNrMCw+nCXm9JuUmL5ajZm/75nnVqR?= =?us-ascii?Q?V0Y99Luzc7Ts+2Rq/Cl4ks4IIQeDOU9sReoXF7BXyDhXFsA1XaQAC3IJB9yI?= =?us-ascii?Q?Xu5YknWVMFmQpMfHXaqqg/+KSuFYLQfOjsG9TFge9cXE75desxAhrgm//7uj?= =?us-ascii?Q?CMhB8n1S5GCKzM5kCOP32Mo2Gd9h2DWN19Hws1P0h5aORXF2sw4nCvy00jnI?= =?us-ascii?Q?tDQeFlkr7L4ay8qfffNJS+G3fciO5+Tdt++Y8YZUrimU2JwuXvvMeeWFoRtB?= =?us-ascii?Q?X8qGkUQHOo/SX05Jid/Se4UBXXrzim2j+a4Q8XsHP9TcqLCc4qaa5WP7wqS8?= =?us-ascii?Q?rSowBPLxzUrYEtRDIeCLoCKOmX3EqpcPdLWW5zuslFFt4B40M01zl+M6OB3w?= =?us-ascii?Q?riLgV+Tdr9ZxGSd260/Z6njkVWB/bHH3IQ+EVCQsM/LKr01TQlZf6W+b7z+s?= =?us-ascii?Q?XQSq0mSjhIz0GiOgOhDHkfTZNoaLTCBzXXvmJ2xCqJUYDKPfRq9+FLc2Rr1H?= =?us-ascii?Q?6fColoydKKY4VKqdrNc0q68fjiFiuWfHVPD3ntI1gCI5FVO0e//RYjRc4v4V?= =?us-ascii?Q?dWjVq0dhrXUDXgDPhKNxsnfUiFN337XETiWcZniVCv+YM6nEbj9FpV1h5CD4?= =?us-ascii?Q?3FZZQAY19GYgnUi5RuCrXWI2ypq1MIhybjKdqL+U7/qaGgBTt7ntsjYmdYd0?= =?us-ascii?Q?PXXWFlUYZaCc/B8j6czzt6w0G3h/Hq9tDwRFayIn6yTMHy4yJZwVwBKv+kJD?= =?us-ascii?Q?Jdlw33yx7W2SRQT1UNduriDY1/XxHDlgHGLDK02G154b9E3S5z6BQ7xcwJXn?= =?us-ascii?Q?yl4I/Z0Lrz8qZpWwKmbMebnQClA+QGMzY7mJcyH/sdpX6Il1xfjef6aucCtF?= =?us-ascii?Q?KbDh889Lx5LqdR+HvOIHXuXNoo6CHpJN37S66rDRXMpiIJiTxsX5UEfCyV63?= =?us-ascii?Q?R6abghDX7B/SjoovxuXq9Vf5hrSbAhUQ8sWQWswRS/isJM2k+8V5ZatL/yo4?= =?us-ascii?Q?BmMT9NaxheYKqqdzbW8Xlhpb8wqWGcm8BW/8tYV3?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d19286f-2127-459f-9d15-08dac94b500a X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2022 09:57:32.8324 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iRGUVbWpUh3k3MYUUqKbdnJLYijCj/gGUFV/P71AnNZi//oiQ0Ow/eYn+MJPs0p2TEgWtC0jZl+jSHnxFvQK+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4626 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: beilei.xing@intel.com > Sent: Friday, November 18, 2022 3:03 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Peng, Yuan ; Xing, Beilei > > Subject: [PATCH v3] net/idpf: fix crash when launching l3fwd >=20 > From: Beilei Xing >=20 > There's core dump when launching l3fwd with 1 queue 1 core. It's because > NULL pointer is used if fail to configure device. > This patch removes incorrect check during device configuration, and check= s > NULL pointer when executing VIRTCHNL2_OP_DEALLOC_VECTORS. >=20 > Fixes: 549343c25db8 ("net/idpf: support device initialization") > Fixes: 70675bcc3a57 ("net/idpf: support RSS") > Fixes: 37291a68fd78 ("net/idpf: support write back based on ITR expire") >=20 > Signed-off-by: Beilei Xing Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi