From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1421429FF; Wed, 26 Apr 2023 08:53:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D0FA410DC; Wed, 26 Apr 2023 08:53:15 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id D4E6C40DDA for ; Wed, 26 Apr 2023 08:53:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682491994; x=1714027994; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FXsU24GZ93JLS3BU/vt1e7Ox8ansoyV3RmHp1ZgEAnw=; b=XhJmwDJMrGbFO9rIt8Mzuj75HUbCJiRjtJSrKRpDuP46ofW7n2szIzqg vGl0hZPwInNrPoI35ynES8FwQIwovP8E7TK18zfSe0Xx3716HUT5hXDSi JejN74HV9RHMK1PbZQ1z5Qnfbk3oOduojRM7AAKqBZjtEKH5rVAXQrnpk qaU0ISIJCMdsdtBTn6mlmm+XD5+arSweCwivU5TgoBWXkBrBjYZSiVD+L 0McZWjvSelpeVlOjH9gmKdUBp7QKxVNZBtqt1+f0JXawp2JJJknyuxeLN OHB2XnI7qssIJAtyT8gcQK687QRlY+kYJmoskKHSc1F9KXl0GTykY61rK g==; X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="327336994" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="327336994" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 23:53:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="763186277" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="763186277" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 25 Apr 2023 23:53:12 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 25 Apr 2023 23:53:12 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 25 Apr 2023 23:53:12 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 25 Apr 2023 23:53:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WSltjFq1vOXFM4Hk9qdaNSdJH96zGMlS8gjZBeNYzFCDHduMpKm3HgYvaw7/0QV7fJYikLd63+p9l6hvcApgtgNAT7Bl3hi/6AQqAgJPWQcIxjTQ8IEuGBLnbGoTUgcouKDFwCsT5m0nZOLlRiy/h1JPNUK8gw0gA2LcT3MAOL6Q5lNzYy7pJBZ/ZAlJCRo2UNUImqW6PaKIoFI3wHEHy8WUJmX8OwE9E5Ye5WavrbwgNaUna9sqxy5e/MdC3lJyYGYc4xCseGKEu4ZEhaYon45Ez2eAKGxf5uKTPbxdXcwtSa8JL9BrclzEzADgoZgjPpLM5Np7r4sGACOY0zFI5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WZoVPiECycJUNV3Mjpy8Kee95G3dVlDtYB0UpJEhXCA=; b=BSokESzC/emTZ5dE6l4RWPNh948QTiVrRA7KilLsgxdZha7ALmd+iwqqiVKZBFEizUk4SK5PuqdcZjZp28T/MMrAI/7wuOa6cVpjQ9E+TKdcdjkOCb5Mh2V259RxddSq8QsyKeNBoVlE3v3UJeCHemY6dedqAeae3rozQ2oCF4nf0Ybuq4Ku0NAvbf5RDwjPXJU0X6slF60R0Fn9ORcQdpqxqpUStCEq9IyjBdbVNF5vuAgZ+b8sBv+0sByH9+HmdeaglK8DqvBfexhuJhR8RhRxb/BSviYlu8icr1SYRUtRFD/hs92c+wF3Dpw8+bfoXbX8Dgr4svVfrr1zcPg2Ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by CH3PR11MB7763.namprd11.prod.outlook.com (2603:10b6:610:145::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Wed, 26 Apr 2023 06:53:08 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6319.034; Wed, 26 Apr 2023 06:53:08 +0000 From: "Zhang, Qi Z" To: "Xing, Beilei" CC: "dev@dpdk.org" Subject: RE: [PATCH] common/idpf: remove unnecessary field in vport Thread-Topic: [PATCH] common/idpf: remove unnecessary field in vport Thread-Index: AQHZc15domHymu5phkiCqEPrOsGf1q89LquAgAABwdA= Date: Wed, 26 Apr 2023 06:53:08 +0000 Message-ID: References: <20230420162038.637079-1-qi.z.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|CH3PR11MB7763:EE_ x-ms-office365-filtering-correlation-id: 2eb50f12-aef3-47a5-cea6-08db4622e4bb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zFVoQ33SvJjRNBVtjcL60DtOTrDndBJIo1J8KEHfBpR3jw5pHShMCUFir/Sm+vnsBSDZCU2RfeeBBFF4Y0RD8x78iuvHSv5MmxC2cIhhA8gTHM629x3Ck8t/ZcF8W+LfZRc/IqbO8cxtindll8AMCgvXpLBZn/NOwAraeAiLKnm3JCPZDF51jo1pISrizyhtJ8sBlQXcES4D8RMPhs1ztaTKkarn9UKb49AcTd7ipFy+3CLbImFe5qPuFeW1poUakDYIVofMSB2sQhT8n4phUFBKYr2VVwPX3QHSzutw3+vcSVl9dTYIZy936LJLh6ysM9T2FHs1RImoNSVZ9+gO9Z44WSd9cu0Nrk37uf87BskqAu2NwI7yGyTDWKiiWPLJryx9xXYCz7qCcmerJE3ryhLP+HCpsg56Y/zoH7UXJLDAMG56JPUltqVZ/v+itOkOIJXALPGuT++fQ8ui8pnr1PKlAgI0IBWjNixKU/0ZHUCkfhXG1CEP1rvMG+QDOdOs4F8bn8GOxIts57erggtkYBmXuaIbotN5EamlCk0zczo6ug2iVweLjFhwbW2wl3u0b1lKAP02FhBGyxz8nhYXi17NCmydcBZ+o9lhc01LJfIqIPr7DW086OTUhyfsj81l x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(39860400002)(366004)(396003)(376002)(346002)(451199021)(4326008)(66556008)(76116006)(6636002)(66946007)(66476007)(52536014)(66446008)(5660300002)(316002)(41300700001)(64756008)(8936002)(6862004)(2906002)(8676002)(478600001)(83380400001)(7696005)(71200400001)(26005)(53546011)(186003)(9686003)(6506007)(33656002)(55016003)(82960400001)(38100700002)(86362001)(38070700005)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dRQPdgM0jc71qpyqG8mB+qMN/4uVvh6SkPAB1pam5RCT0dRM+UoX3fSCwg8+?= =?us-ascii?Q?nUZZEbWc5NlR6PNFZcMwMC6tta/aFy3WNJkZlFjB9nvETwLRomxoR/qE1Pgx?= =?us-ascii?Q?lKQjPxXCbaPyJf7PT+T5YXsR46ESmvpM4fpKoKpyKs4jKpqTIYHXwvId2F53?= =?us-ascii?Q?/TplXiQ3RVv9KWGx1JsOquwhjIvewl+DuWQTZi8LKZQGg7SxeD09jQ9zgA1m?= =?us-ascii?Q?7k2uVV5vbl0/b8vD9R8wqTXlxiT0+MG0mi4lrn1GgzKZfrq4hvVoC/RHL21H?= =?us-ascii?Q?hO4ylgNfU0Gsxfw3N7OAP2edwm2b/YvpLQCK4o7rEBE3eAcm8h0yfNyMaytN?= =?us-ascii?Q?s8K6wqKeRVvBYn0y1HS3VV6RSYfxlTAnFwMMqCOuw0MZT2TAonPcgRTfAcsb?= =?us-ascii?Q?bwgKeWdYPCrtsUlQR1KQgmiV9guEcXIOtwdsYRT7vYbkw1lVwjaE5kW6MHSH?= =?us-ascii?Q?FRv5NAYivDyG7oNlgKqoOVJSX/9ZfPij7ef4aPhjo1DQHFio++YJ2qOTEaJr?= =?us-ascii?Q?D/wG0RpaYNIB2jcU37AVUU2tn2q4krDqt4tGjIrmTzjY7JPqnLEOrj2IoUqg?= =?us-ascii?Q?Ktuy2e4llyMTY5rO/ja8cJIP2NRrhOGYILHyM86/e/1DpwgmqzVhdGwIuA6p?= =?us-ascii?Q?dkOIf7NNrdnYa5HQm5mkyOlB6Km4X8rq0GWRcwCNYoUKuqGa2cMewYWxdHJn?= =?us-ascii?Q?Oa53Vlpg9apETUBWW0l9Tf7Cq1xJs7708YYcfkehlROpkN32J0gPsaou0YG+?= =?us-ascii?Q?+nMLOcNsGlDbOcDTY0eSk4BqXNy7XtncDFcVhDvR2l+1IHdeXIPJYQWHqLLb?= =?us-ascii?Q?bgSXRRmnKveda4NHvWkPrrKRZkn/c+AVUsa9mfMrI7i+YqQdoMqvfWyujzwk?= =?us-ascii?Q?pxSlGY1LEUciMsyMrI+KuON7wIeSHYJYYB9PcgIXUi8WmUeOE9Wkd1wKA8gu?= =?us-ascii?Q?OuMnmmH1/29OPgECazn7yXgB2qEmulb/EVJu5eQ4UnJrXnD9qRxIa8op0gDi?= =?us-ascii?Q?SnqXjbF6tVx4YM8cPvWHIGMiS3azHtqcCUpKOFRwvJ39zuZ/d1QhKZMmZR2w?= =?us-ascii?Q?/zMpEWtg0gIKqDDSn5itOurU1DKU0qZZ+r52/BVvy0H8bYROo7wDJTAQUJ88?= =?us-ascii?Q?kxBfVX7kXe6bGOoD65XiP32wiDD5f/qSJTjuUvpEF/F6Pp5tMpTfPKDiMsCv?= =?us-ascii?Q?Zj6SFqfCb+ag93DXYLEEFESA12tyOIuQg3I5m0I4j3RmPboVm3Jsoiy8MELq?= =?us-ascii?Q?V+Zvr/603KjzrBd6W8mXCHEOEkEB3MZYnsca19PGKL8a7unC6ZNeU05GwERD?= =?us-ascii?Q?6H04v55QXzrMdtudecFqBfVXdCTrN+N94b5lDN7u4rgIUsFbHlDwuTT3najw?= =?us-ascii?Q?jHQ5fE41PigSMpfE+t6wEGwVZBuT67DGbONYKsC1BzhFpR22lz8o2dxrEpfc?= =?us-ascii?Q?yv5JxsBiPA6eQ/QWz5qaJuCbSB1nY5cyM85fJp7U+hnkk55k+6G+EXD+rXO0?= =?us-ascii?Q?Yi6fRdJKrv0K8PhZFoD8bMwE8rllySPIokCc79/+JBHjLU2CHQHDbeiiexnq?= =?us-ascii?Q?yJ16eamnAtxlm9q2jU4OGq9Xr0UMHmJ6NOniWoZb?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2eb50f12-aef3-47a5-cea6-08db4622e4bb X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2023 06:53:08.3296 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7CORovZQS9ulAp2gcOnOip6t++O7X6IcPTi4Hd4GetFQUlo+pDSr42t0Ca5iO2Iju36cP5I/3Kyif0qph9l8Ag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7763 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xing, Beilei > Sent: Wednesday, April 26, 2023 2:46 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH] common/idpf: remove unnecessary field in vport >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Friday, April 21, 2023 12:21 AM > > To: Xing, Beilei > > Cc: dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH] common/idpf: remove unnecessary field in vport > > > > Remove the pointer to rte_eth_dev instance, as 1. there is already a > > pointer to rte_eth_dev_data. > > 2. a pointer to rte_eth_dev will break multi-process usage. >=20 > Basically it's OK for me, do we need to add fix line? the multi-process support has not been enabled yet, so technically this is= not a fix but code refactor. >=20 > > > > Signed-off-by: Qi Zhang > > --- > > drivers/common/idpf/idpf_common_device.h | 1 - > > drivers/net/cpfl/cpfl_ethdev.c | 4 ++-- > > drivers/net/idpf/idpf_ethdev.c | 4 ++-- > > 3 files changed, 4 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/common/idpf/idpf_common_device.h > > b/drivers/common/idpf/idpf_common_device.h > > index 7a54f7c937..d29bcc71ab 100644 > > --- a/drivers/common/idpf/idpf_common_device.h > > +++ b/drivers/common/idpf/idpf_common_device.h > > @@ -117,7 +117,6 @@ struct idpf_vport { > > > > struct virtchnl2_vport_stats eth_stats_offset; > > > > - void *dev; > > /* Event from ipf */ > > bool link_up; > > uint32_t link_speed; > > diff --git a/drivers/net/cpfl/cpfl_ethdev.c > > b/drivers/net/cpfl/cpfl_ethdev.c index f1d4425ce2..680c2326ec 100644 > > --- a/drivers/net/cpfl/cpfl_ethdev.c > > +++ b/drivers/net/cpfl/cpfl_ethdev.c > > @@ -1061,7 +1061,8 @@ static void > > cpfl_handle_event_msg(struct idpf_vport *vport, uint8_t *msg, > > uint16_t > > msglen) { > > struct virtchnl2_event *vc_event =3D (struct virtchnl2_event *)msg; > > - struct rte_eth_dev *dev =3D (struct rte_eth_dev *)vport->dev; > > + struct rte_eth_dev_data *data =3D vport->dev_data; > > + struct rte_eth_dev *dev =3D &rte_eth_devices[data->port_id]; > > > > if (msglen < sizeof(struct virtchnl2_event)) { > > PMD_DRV_LOG(ERR, "Error event"); > > @@ -1245,7 +1246,6 @@ cpfl_dev_vport_init(struct rte_eth_dev *dev, > > void > > *init_params) > > vport->adapter =3D &adapter->base; > > vport->sw_idx =3D param->idx; > > vport->devarg_id =3D param->devarg_id; > > - vport->dev =3D dev; > > > > memset(&create_vport_info, 0, sizeof(create_vport_info)); > > ret =3D idpf_vport_info_init(vport, &create_vport_info); diff --git > > a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c > > index > > e01eb3a2ec..38ad4e7ac0 100644 > > --- a/drivers/net/idpf/idpf_ethdev.c > > +++ b/drivers/net/idpf/idpf_ethdev.c > > @@ -1024,7 +1024,8 @@ static void > > idpf_handle_event_msg(struct idpf_vport *vport, uint8_t *msg, > > uint16_t > > msglen) { > > struct virtchnl2_event *vc_event =3D (struct virtchnl2_event *)msg; > > - struct rte_eth_dev *dev =3D (struct rte_eth_dev *)vport->dev; > > + struct rte_eth_dev_data *data =3D vport->dev_data; > > + struct rte_eth_dev *dev =3D &rte_eth_devices[data->port_id]; > > > > if (msglen < sizeof(struct virtchnl2_event)) { > > PMD_DRV_LOG(ERR, "Error event"); > > @@ -1235,7 +1236,6 @@ idpf_dev_vport_init(struct rte_eth_dev *dev, > > void > > *init_params) > > vport->adapter =3D &adapter->base; > > vport->sw_idx =3D param->idx; > > vport->devarg_id =3D param->devarg_id; > > - vport->dev =3D dev; > > > > memset(&create_vport_info, 0, sizeof(create_vport_info)); > > ret =3D idpf_vport_info_init(vport, &create_vport_info); > > -- > > 2.31.1