From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F94D43863; Mon, 8 Jan 2024 10:53:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0900A40263; Mon, 8 Jan 2024 10:53:21 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 0ED5440261; Mon, 8 Jan 2024 10:53:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704707599; x=1736243599; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jWHBXa2CbppYlyRV7QQOxU4caOkbSRkz2DwUTr/FoWE=; b=ImmIubHCdVVGiodx98HI3k2NwbAgCusaV67E0lTLR/HYBTZN7NfIYJP/ S5svtfEhWdmleaJN7uA7AM6NOowq3rAPIRqqlfmK43I/qhVchIJ/qt4Qn eZHpeCzOczzY79Mi6qNIkNt09XvZ/jhuqwfNVKegih/HR/fP3Y94+bzsq k5dHNZHtJ/LBuP9DKIfOmhQu+OBTU/EyPGYrFgaAjtvutfnh0ag404ON/ VnWx5MlIZ6agah8Si+3mVjZZuu+Trqs2G8XX+lLOwyO6yMT857fdI9+lr vjUeNTq9xpcKgB+30LFsX+vablDB5Ccb3vaxbJACptJktPU4WkLh4dCaN w==; X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="395003462" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="395003462" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2024 01:53:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="1112691474" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="1112691474" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Jan 2024 01:53:13 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Jan 2024 01:53:12 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Jan 2024 01:53:12 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 8 Jan 2024 01:53:12 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 8 Jan 2024 01:53:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SlEcltG+8G6WQ9UUDlBVQCOKTsMMvp5UOY+ZuTw07Ku8otjNBHSRkig8b/6wKyH8/oQuQAWPauP2BkBZej273+Pqx1Hqh5cquSh8jtSe3/GYT8VAw74GwvMHpsl27XrjVngJGFJS0ftcGjGzJbkkMW6nzcEHeSiFjtEkG1vrFY3EnKuWex4rQEqjhXHWNgCJlSWfnH1QK6shI00Gph6y/DJJVILN3XYzEcfa8svmGWsS9XBodDPIbncKverIwgF3sYnBF7YXMHKFuA+eDgrM1quui3MGQ+5qxSeMDS9PJ0e1nBwrkU5x1QUF0AUnLFVKbH9UGeszgDhNcUy7SlFh9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uARf70hWJuDDlQegoeWi+q4HdZn+/WEsgPx7XVDPn7Y=; b=aSkXr9KZRA/EsH/Cf1yFZfS+yp7mt5dOe/1c2hcrvbOOzCTIMmxLuZNQ9OTSKK77SPVOh8/4rZuw+HafZstv0DETFo5NeaKGb0w9P5jDeCqqxXjuUprN1nUEBfBqYPWrW7LeZTXCF3NVbeJUYfhylOBHhFuRvxO9lIvBo4UL5Iu+e+9awbQ758AxQq3k2+3V+scBSs8erln+FRFHx6wjiow5xu6U6F5LM5tpkueLoSLjaxNZ7PZ5+ExIWbiFl6EnDzSA7NqTmALO21RYLRbN6TfeyWmvuab/xmPBW4y/bgxLcFJ+dNRl3r3JS2myERZyGWM+5aieNbrNhEZIVjyJRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SJ0PR11MB6720.namprd11.prod.outlook.com (2603:10b6:a03:479::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.20; Mon, 8 Jan 2024 09:53:09 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::fc91:526:bead:4f73]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::fc91:526:bead:4f73%4]) with mapi id 15.20.7159.020; Mon, 8 Jan 2024 09:53:08 +0000 From: "Zhang, Qi Z" To: "Wu, Wenjun1" , "Yang, Qiming" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] net/ice: fix memory leak Thread-Topic: [PATCH] net/ice: fix memory leak Thread-Index: AQHaQWQVH8NjPy2CG0OSOLpnq0+u9rDPhVeAgAAosuA= Date: Mon, 8 Jan 2024 09:53:08 +0000 Message-ID: References: <20240107204914.483140-1-qi.z.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|SJ0PR11MB6720:EE_ x-ms-office365-filtering-correlation-id: 7065f539-6b66-4486-2074-08dc102f9e4f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +7SFIM3RGIexsO6ltcTxLahZQziqJLQjPkOQW2e6ODksP1Yu1UKoD7eB2dwu3j3pJuWD6qG05GhHUcKkNubdFpIoxbunl/dXLn1HCQ+Xze9RQZBUgWcWBj5KRdxe8Xwz8ljOYy2RHP4TjyUSFHL/1bWM5BDCWQIY9x2tXgXqgBBqmB19Z1MQmBCFELzSbr1PP5dpjbSYZSAcDhtBLGgS1YWwUoD0smDYv+xN7afh99LQTikrxiE/uFPugHHFGnNYpQa6V7n2+WIk3IosGZib8osLvPAHkcF46MO/0PrlIv1W9Kq+yuZjQlmqRLNlpWAlXLaoRsXHqajyJdMqJ6zqYMnzylEs7I0ZyY4LJ6cimh+naUlLdXYDSXQhuYUmy+U/FEK96PRWws1AiqCt0RAB7RDYlzTsSIEudPw04MSioZia5FkdGcAyCnV6gZ+yCkNa/+1PNE0txY6WArDo2zWCrbZe5/9HdFzp8MqtIx1SjrSKij0+U/sDYt5Dp5nd5XfzzFWMaiOxNQL1/VT93CtCjyUgIRH+Ob9IlLMCSJ+BZep1GqRhqcugxjwywic4kSO1y+ZJvIS9PbwKuq0UkkbFXE/hldEp7fui8zYtm5hDzhpBnzQb29Y3BdFnFMDGv2fw x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(366004)(136003)(396003)(346002)(39860400002)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(66446008)(66556008)(66476007)(64756008)(450100002)(76116006)(8936002)(8676002)(4326008)(82960400001)(52536014)(316002)(66946007)(110136005)(6636002)(41300700001)(54906003)(38070700009)(2906002)(33656002)(86362001)(26005)(83380400001)(38100700002)(122000001)(478600001)(53546011)(9686003)(5660300002)(7696005)(6506007)(71200400001)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jEHbgVuJW4iZRjCO2ggCfLLpwm/CpPVrQHWP0UnMwOKj3knshneP25a7U8Pk?= =?us-ascii?Q?CcVOUnn/P9MEXOkyTv3WkIoP/xWIGMhLVSpAE1am033uHNqrBZvaoxHf9buo?= =?us-ascii?Q?oPmBEA8mdil5VKjRS35lTcnI6gK3MrnowZ8EK0nduhlrGlFgvwM41TftaJab?= =?us-ascii?Q?i7qoaWr/38oQ3S09oJwDVTs0hhBl4aV2nWV1p2u4ZcLA6M1Ts4rqWRcwQLyK?= =?us-ascii?Q?VzaAriQWJKmyzQPsJv1wDCIb53G4KYah1+jyGffo4qWrcJOzXQaKWKZXwHQY?= =?us-ascii?Q?4HOiH68TLG7Fod4K/JIZupiV0EN2Nox073G5WaINSH0xH9vRGm3xuXb42fTO?= =?us-ascii?Q?38iylkJCqNm3uWsNdrNUOGoEsG1uLBcgXD5y/WNL+4coOniJ8VFDc/2/7nyx?= =?us-ascii?Q?8FEiIsshksZ1v6QWjdE/mK9QHRHONjzmJIeeh516dM0g98oZyTZNXnSYOn8M?= =?us-ascii?Q?EtA3oFp1jxgVl/5j2Xw2NDp9C/aslrjiZdzDT5g2kVLoqkK67u7OQKtzlQ3Y?= =?us-ascii?Q?qP2DNCpdJKuYFwVhOVw0guKfQx8P+XB+f1vzHv5/B9qBT+AJhEQSISU+Zgil?= =?us-ascii?Q?1J70mr2oHb5oJjpf8UDnrgef0IYBBKweyDjYU/0O/grUolzUCz5SKIbR92X5?= =?us-ascii?Q?c/gUNKDstb71hOQC06llhx18gPO5E+Uv6FtlFqFXJsOLq+8Fpr21iEfxRPMl?= =?us-ascii?Q?sUvzLDd8ARMXP42/2Rx0aU+X0quzDA4oCbQZ0zZEUNzHgRGq38BpuKTSPhOq?= =?us-ascii?Q?KYdZFWUl8aAqneVBNBQXF9UVNlB2jqtWUhpHWH8OGSx8WxtOQF6orpv0Fm9o?= =?us-ascii?Q?bqie60D2bjP/unsTbkmGDg4yEjifOnjSfJETEN1xbXmqz03aQfsg+yi2vzGg?= =?us-ascii?Q?t93oi/cQgA+FZgHHXjGZ/6L9T+a4lYajuoQqNPy9xZsmEgDzC77t7LOO2oJj?= =?us-ascii?Q?rpKw1wiCnq0Bwl98HoGAdlZQJPtDi43XGivp7Oe82A9Y0oCAhI6avS9iJfTy?= =?us-ascii?Q?KN7GR1R6rkxFjwj3uML/cJajsW1wj7D1+4IWN9etrdzLBly4WcbjgcsdF4Wz?= =?us-ascii?Q?Dlzx4Hx8tmZ2w5sP0Dy5hZfKdm1a2aQha1y3kIVCfVLm5yVsNfhBwZfVeM2I?= =?us-ascii?Q?rKTRCaeYlbq5q/lamC0SQbeINlWg9jCH+r7k1qZYZucmFjrcK0Rqcd6SQfWw?= =?us-ascii?Q?qgl6Lcoo301NHakw2e/rGHZR20oD9PG0WNMVUarMc4D0+y2a/BnB46VuAwMi?= =?us-ascii?Q?FhvnhrLgLGw8omvzp4yl3xY0E4QizyMRkHQXt8TVlaIP2mGZ0N3DvIBjF3Pu?= =?us-ascii?Q?gpVbQCOQ9XaBvgGj0gf/3PB/7B/QJMMkf5E7j8+GnaVas11snlWKTmPogj6c?= =?us-ascii?Q?h+JFgGplxVi7/NuatN0hMz3pH0V0FUJuk8DWl/KvfWhEOBV1EpVWWF/2jxfv?= =?us-ascii?Q?CoITYWiv+SCTP7BqTWBkHp0aw8tKWW120qv6gIvEhD0z8JFUpV1Tsaf9Pr5m?= =?us-ascii?Q?CsM9L+3L6bX3XMLljtjZSp0lGo0yuqTcthGRMTL5PIhCdMRrsd5vCbOrvN5S?= =?us-ascii?Q?rfJVxaGAofMSaLZ+qmXHQRN6MkeawfCkW52VkM6g?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7065f539-6b66-4486-2074-08dc102f9e4f X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2024 09:53:08.5236 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FQiqGK2TLL9YyrmmJXDdulnDGZXC3GvJWww9PQfC2vBZGuT6aayTbYsDik8c8UgzT9H+A4l+3uG8dBKEDL2h7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6720 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wu, Wenjun1 > Sent: Monday, January 8, 2024 3:27 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] net/ice: fix memory leak >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Monday, January 8, 2024 4:49 AM > > To: Yang, Qiming ; Wu, Wenjun1 > > > > Cc: dev@dpdk.org; Zhang, Qi Z ; stable@dpdk.org > > Subject: [PATCH] net/ice: fix memory leak > > > > Free memory for AQ buffer at icd_move_recfg_lan_txq Free memory for > > profile list at ice_tm_conf_uninit > > > > Fixes: 8c481c3bb65b ("net/ice: support queue and queue group bandwidth > > limit") > > Cc: stable@dpdk.org > > > > Signed-off-by: Qi Zhang > > --- > > drivers/net/ice/ice_tm.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index > > b570798f07..c00ecb6a97 100644 > > --- a/drivers/net/ice/ice_tm.c > > +++ b/drivers/net/ice/ice_tm.c > > @@ -59,8 +59,15 @@ void > > ice_tm_conf_uninit(struct rte_eth_dev *dev) { > > struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data- > >dev_private); > > + struct ice_tm_shaper_profile *shaper_profile; > > struct ice_tm_node *tm_node; > > > > + /* clear profile */ > > + while ((shaper_profile =3D TAILQ_FIRST(&pf- > > >tm_conf.shaper_profile_list))) { > > + TAILQ_REMOVE(&pf->tm_conf.shaper_profile_list, > > shaper_profile, node); > > + rte_free(shaper_profile); > > + } > > + > > /* clear node configuration */ > > while ((tm_node =3D TAILQ_FIRST(&pf->tm_conf.queue_list))) { > > TAILQ_REMOVE(&pf->tm_conf.queue_list, tm_node, node); > @@ -636,6 > > +643,8 @@ static int ice_move_recfg_lan_txq(struct rte_eth_dev *dev, > > uint16_t buf_size =3D ice_struct_size(buf, txqs, 1); > > > > buf =3D (struct ice_aqc_move_txqs_data *)ice_malloc(hw, sizeof(*buf))= ; > > + if (buf =3D=3D NULL) > > + return -ENOMEM; > > > > queue_parent_node =3D queue_sched_node->parent; > > buf->src_teid =3D queue_parent_node->info.node_teid; > > @@ -647,6 +656,7 @@ static int ice_move_recfg_lan_txq(struct > > rte_eth_dev *dev, > > NULL, buf, buf_size, &txqs_moved, > NULL); > > if (ret || txqs_moved =3D=3D 0) { > > PMD_DRV_LOG(ERR, "move lan queue %u failed", queue_id); > > + rte_free(buf); > > return ICE_ERR_PARAM; > > } > > > > @@ -656,12 +666,14 @@ static int ice_move_recfg_lan_txq(struct > > rte_eth_dev *dev, > > } else { > > PMD_DRV_LOG(ERR, "invalid children number %d for > queue %u", > > queue_parent_node->num_children, queue_id); > > + rte_free(buf); > > return ICE_ERR_PARAM; > > } > > dst_node->children[dst_node->num_children++] =3D > queue_sched_node; > > queue_sched_node->parent =3D dst_node; > > ice_sched_query_elem(hw, queue_sched_node->info.node_teid, > > &queue_sched_node->info); > > > > + rte_free(buf); > > return ret; > > } > > > > -- > > 2.31.1 >=20 > Acked-by: Wenjun Wu Applied to dpdk-next-net-intel. Thanks Qi