From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41F65436E8; Thu, 14 Dec 2023 03:24:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4FA342F57; Thu, 14 Dec 2023 03:24:06 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id 726E240283 for ; Thu, 14 Dec 2023 03:24:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702520646; x=1734056646; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4wnAXBJGFzElszE2+ugfmxtv+nsNlYPp3PVwMCjdkT4=; b=FsDknlp800GDSVVFcVdTfBU0+ey8iWSZaR8f4gCfPm8knoaZd5LHKJWC RDu5BKSGg99adIx/HUvXG3P7V8PDJN8PhT3SXQx3/PPZgsnEIFmYVBcgY nft1DRD+Mo5iJFOPO2w04Zq8dXNl/8YrBY+cg/NvxnRsPgXL0hU/TlxC7 0fgK81T9zZJNdg0fCMPVqDsVfDLguyurT/zBxftjsr71JaPqxKM7ihgkn wqgt2R5A/PVrLEi+eL/27YQ3Rv6ZK+g5M1cRYFImGeCrENOCpAED4pmbf 4Tkh57c+gJumIy0bCNUUdf5mxhdhkRIWLL33ABnCQ09YtHQ4RNXYgqNDR Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="1909400" X-IronPort-AV: E=Sophos;i="6.04,274,1695711600"; d="scan'208";a="1909400" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 18:24:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="947396980" X-IronPort-AV: E=Sophos;i="6.04,274,1695711600"; d="scan'208";a="947396980" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Dec 2023 18:24:04 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 13 Dec 2023 18:24:03 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 13 Dec 2023 18:24:03 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 13 Dec 2023 18:24:03 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 13 Dec 2023 18:24:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CgOmqK3YREKDDE9M6CXvTft58aHSVHOI5IOHrMLOyIXb+dD023VnjrZvCu5rL28xBXIlEudioOfMlB4Md5vJD9j9ZZVqZUE5gXPMMN65Td8aX428mZ9QVTpB/Tq7KLmUgDTZcE6/2mXgcXCy9SqoM4O6HWZTK8n5e3I7Q7c6ARoA49FnZ82/potbPPWjav3J5Zv3yB71EnIHihmUv7s0aL2DMeZoJq7RYtnhx5EDxqC52uY/HTcUCyI6DISB6EWwkjj0lRRMoo1Yy39t7cTxxiNWJQWKOcUjXNdc9LVGa9+RHvRIKC5h3HrTU3OmatfaO1pn/5EQP6nEClteOV7ksA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dJXnPsVnmwQMaloPwL/L8YqQ/NzhIhrbJ67XwHgBA2o=; b=mgyZAt41vW/Hb+EL01SSNMl2qlY6spv+eyiu/WFyBtIhQ0T99dWlgtKr5lvjhUnHT5KZYwyzJkjZ51kDiPPW8EzerG44B/m8MyYu6oYcs6ycL23jPNPBWKICmi4pufR8Rb9fWRAM1REf2lB84+JUqKluQFxnfoOtpv9p+BClu80HzSdukgige8rX1GzvxuUsKsRsnl3Q7fc4Eol+T2UIHjjWnq2Am3kxOqalO4vK9Mvc3Ev+Hbs6OE/zDmSgi4kU0c7TeJs463zP4i25m+rK9HydQA7n4kBsMwUzCAOm/ZNQ0WS/gKzlbdEL5rNIl0jTuFBXQEuWu27YrJqKhN0SYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by MW4PR11MB6787.namprd11.prod.outlook.com (2603:10b6:303:209::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Thu, 14 Dec 2023 02:24:01 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136%7]) with mapi id 15.20.7068.038; Thu, 14 Dec 2023 02:24:01 +0000 From: "Zhang, Qi Z" To: Simon Ellmann , "Yang, Qiming" , "Wu, Wenjun1" CC: "dev@dpdk.org" Subject: RE: [PATCH] ixgbe: fix interrupt clear mask for eimc register Thread-Topic: [PATCH] ixgbe: fix interrupt clear mask for eimc register Thread-Index: AQHaKe4lJGY+8jZeIE2w1Lg0i3m0RrCoFKeQ Date: Thu, 14 Dec 2023 02:24:01 +0000 Message-ID: References: <20231208154410.14212-1-simon.ellmann@tum.de> In-Reply-To: <20231208154410.14212-1-simon.ellmann@tum.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|MW4PR11MB6787:EE_ x-ms-office365-filtering-correlation-id: 440509ba-fd08-4970-f908-08dbfc4bbc24 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EIi/cy/09M0cHYWgEsdgJpBptxrzoro9gFehrpLrHbdRIbCtvzTBeuYsPXjTMc1FNG+fQksR6PDDCx8GK8347LCLv5Isj3SM2MZcbV14gGxbouvK0ilbAlSp2FgoJd2g4uJkbfLA9f6Ba4pq6ing413MUTkibSP7a0X+b2I5fcLc9i7qAXVXHxRtKtxM6V3KjswC53PkPSc9+JLisBIzEfkEzseYzaHpTj25vsnVu13A71a6U/q9UsAakbm/H0yU78WvjvXAYY2zmbw+0XD1gZUiZ4Kvs9xmMD9pv1Faz9gwwr3U8Or9YowvXdyCW7IMNUydXCJ4FeSs6civwOkd9btc1GVXUxK81VmLp5FE0vL0xPPIAbf4v/V51eBoXBkLLaaiyyfIgzhVS3g/ChVX5kWh8Vc778KEFfNObF7ELZZmvfEuFu62j9toO02UsEh+84lSAWUfbByg7SOClqn6rQVCE1TaiV0UZWvUxtriZOGABIzYrJ9vQo888RbGbpW36FQ0ff8JQR9NtNRBzfNBq2GMIOnYuHvBhfYpHPMban7Qlw2M9UYHZlk4MeYeTEKsplz1UGF29/TQBAkkIoOfh5D4V0UUti9UPj7CLPUszXnvvQsi8NQSRYpq/nPcWg51 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(346002)(39860400002)(136003)(376002)(396003)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(2906002)(33656002)(86362001)(4326008)(8676002)(8936002)(52536014)(316002)(5660300002)(38070700009)(41300700001)(478600001)(9686003)(26005)(71200400001)(82960400001)(55016003)(7696005)(6506007)(83380400001)(53546011)(110136005)(6636002)(76116006)(38100700002)(122000001)(64756008)(66946007)(66556008)(66476007)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Bl+wxWNz7JetjWDtffkfaFm2h3vfqM4mG+0TJFnLxKrefus91k5JPzP9FFPT?= =?us-ascii?Q?U2TRChSF9ORwOGOv6lsh9TRQc0WjrrJ1kuv2I++4DxJX6UUAxPu+rzWOVP3z?= =?us-ascii?Q?+a/C9sIhy+1wWMXoZJa1mcI6t6tnW3XXWhZaEEEup1yg385ZtxfXTTiNEX6Q?= =?us-ascii?Q?+cUj+/wEgj3mPqmh3PGtw47ICNtJ9n80HQBmsQ1Ofm2au/wSS++sQj+n5VVm?= =?us-ascii?Q?xJh+nXV3/QU5fOX2q3qr6+QmxbQ6BSbp/25JenoFjGBvJWvc3pQG9YMUG1Kp?= =?us-ascii?Q?t0gJopl1auegTMufh29YAumPX/D1udAUMmVsw24vQW04VioFbNP37YZ4mI0A?= =?us-ascii?Q?uzx4gst3T27OZg3Vs+B5JuPs1s50ZbQ++QVQVvmnZ0CJLwpwbZWITOypIxVP?= =?us-ascii?Q?iXAWbjDdbhJL3ql00UbVsInxF4Pwdo3SHJ6LsgHPIlgj+91IJ9tc8Vfphhss?= =?us-ascii?Q?ta2CEDgCfkR5w6ntlQlB3pncHBdVYxh9a2mwXeCGy91MxZaUYRbYLWcZuTur?= =?us-ascii?Q?4bxfdNPIQa8IHyY/rgIujXtONY/uDzmEB6icD5Yz1gITW8HfhueOCwwrx1os?= =?us-ascii?Q?A2k0jNjwFjRD6LWb24QVTMJ6SKhgM3ArOfXUXNLYWp8ozlby47+YoE3am+CV?= =?us-ascii?Q?jbDkA4I79sfhsQWL6BQHnfOAnQTXdeKrvLCno7arAyyqL6+yAseHsiJWJDml?= =?us-ascii?Q?tR+eRNI2cOa/anKcq985xrE+7w3ljsFkgFVuu40HmIxA1y+WyvQQOWpWpppU?= =?us-ascii?Q?0iWVK/7uE6q23B9IRt5PeucMMCVNdkNT4ww1oXjdxWbp+F3JrCyrN/jyO1B3?= =?us-ascii?Q?HnIbcM1f6HWF29kVbOBVjiOM7Uv+tKRDJGT6my6h/gmWSaaOTbhRvD1jmVJw?= =?us-ascii?Q?LJnAO5tlf6sVv5a5BhJ35VozbQcajk10kIEKEyoFlHZ8AsVY2svl6fYm1u7z?= =?us-ascii?Q?RTmd+ZvNmZBEe1rXrrS1T/RNgCM931bqR+zxe54pblTGL1+flSsuhhQr52SR?= =?us-ascii?Q?56SixtX6IN+Pq2ofP86C61sEIyVOeCp2PZodbucb/KB2gFnR1FB1ea8Jcu5O?= =?us-ascii?Q?awtSntSVToaSBaDTy6qBpcpGzbQgiXQ7JmuP2rf1CuXNDmP7W1XFemAPLOqM?= =?us-ascii?Q?pXvGP66VZ3h0+p0s/0MUTjite1Es4ZmcnxLTEQaA+GSwIN3plqobBbQarOmN?= =?us-ascii?Q?W2m87HTDKpNASU+/kCX80QeDaFBXAVyY53vjrFVBb/CDPuD/SD1kwXdo845A?= =?us-ascii?Q?LDTQwqGB/ikBH6wIXtLAE5hNHkKJjXR8ZF8gDE5rH4dCtTUP7+6mNWSkDOvZ?= =?us-ascii?Q?/iR/cSCIzpwrVW3MUsAeVuTWXriKf2eMmkGPX8EejCRPxJYQo22w/WNiVB0e?= =?us-ascii?Q?1urn3Gy5ade56a0MOGpSYnJ5B5Tm4W+u3iGrsL9zguC4QHIDrUZ/Sw538gYp?= =?us-ascii?Q?SLyC05/DdKAjFkZ6WlZM96IvGSZ/wKXLzgWlG+eW+OeV3ymy5iDDheiUI13X?= =?us-ascii?Q?4hiLlWtGSxvY422EATSdzYr4EghHYXYWlcdsT05FYFYCdeR0LYP/JovvUxSL?= =?us-ascii?Q?pTs6aB0Hcakakn5yeCAxrrt0DxfPdHZB5pKNBDKM?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 440509ba-fd08-4970-f908-08dbfc4bbc24 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2023 02:24:01.2086 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UkjrrHZJ9T2MJLx7eEcach/9cWhF60VKEOw19Tjvr7JQ/bXKJviFNcSLQuNCa/68OCdDz1NlD6h3gny01bm/3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6787 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Simon Ellmann > Sent: Friday, December 8, 2023 11:44 PM > To: Yang, Qiming ; Wu, Wenjun1 > > Cc: dev@dpdk.org; Simon Ellmann > Subject: [PATCH] ixgbe: fix interrupt clear mask for eimc register >=20 > 32nd bit of the eimc register is reserved according to the datasheet >=20 > Signed-off-by: Simon Ellmann > --- > drivers/net/ixgbe/base/ixgbe_type.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ixgbe/base/ixgbe_type.h > b/drivers/net/ixgbe/base/ixgbe_type.h > index 1094df5891..03b299cd10 100644 > --- a/drivers/net/ixgbe/base/ixgbe_type.h > +++ b/drivers/net/ixgbe/base/ixgbe_type.h > @@ -2023,7 +2023,7 @@ enum { > #define IXGBE_FTQF_QUEUE_ENABLE 0x80000000 >=20 > /* Interrupt clear mask */ > -#define IXGBE_IRQ_CLEAR_MASK 0xFFFFFFFF > +#define IXGBE_IRQ_CLEAR_MASK 0x7FFFFFFF If it is not harmful, I will prefer to keep the base code aligned with kern= el driver's implementation which is 0xFFFFFFFF currently. >=20 > /* Interrupt Vector Allocation Registers */ > #define IXGBE_IVAR_REG_NUM 25 > -- > 2.43.0