From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E29CBA054F; Wed, 25 May 2022 10:29:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B11B400EF; Wed, 25 May 2022 10:29:41 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 37C5C400D6 for ; Wed, 25 May 2022 10:29:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653467380; x=1685003380; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=P1APu5IMNf6XE5NaZ9fnUBHvrnkTEoDDA6D2HDu4zCA=; b=RHKly/h9338SVYQyROTMMeudqrU09NqnG74DRoB1Y84TkkmkSJ7wBa2s EE6WE7h6QhQUyUVvkriqwOv3PrTf+U2FKM0OA0p2VeOGX21Tc3sowipjP mIJju2FMzY7oOvgz+Ia/YO5bpEgn8/Nq7mjU4kOlW9M+ZBzH2SyNDWC7x 42a16Ec5l3+Q6iLzaGl76Tm8Ri6L1VkJ1b34QcOjdKTfhVy8Jr1E99vOX SJHEYi8l7gmpeaA8PUxKkO8PDWuAo/GAlamqZO3A2ZA4vc/0gjk2s8N18 DUbfB6HNDZmmtiGEzN/EpS+slJVo3dV1CeWOlk6DqMQkHEk2ZZErh/gkm Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="360145570" X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="360145570" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2022 01:29:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="676775491" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 25 May 2022 01:29:32 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 25 May 2022 01:29:31 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 25 May 2022 01:29:31 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 25 May 2022 01:29:31 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 25 May 2022 01:29:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NtIqvN3ombsCJDGzjdlSiRyT0BMdzOltS/OgQDwTPUxhNcxGWuVBEvGbsraI9eZVz86XlP4HA+ixnMp8jsLnOO46boevKQMa9HjVriLstsOVXpu6c6bA3dh+Onfl30Sx5pKxQ4885Y0OCpQSoEhF7u8biWQKkIELzGQ1HlqCRyLLyo0obgrInzP6OpZCQyxvyAF/EXQWUfpNJzwek06MZM5uFR5+MKS2SBRjywqNrQRIaahgeEfR6ArjIKeau6/IV5psXmWc/gvCGFnIJo8a3HrFMrQX3eNyY4PG3GqtkXur1grJoyss4VGxkEuTBKojIo4IBzFLdymwSGBI9e4e0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ep0jbpew9Sw8cy25ZYwab8kYGm0W9K4073gpJ296NZk=; b=a6GnAKZ/T3jrQ0178bPhL2tvRLPLVSwFcTti92MhguBOP0BsI0JyLCqfVmw+NA6VP4CtrcZdXL+i9ADTpw+W2RhGNlhJFbHTCHFjJaME12khr1lbKQUwaV1DZfLxZG9ungBO1H99yfjhsaIzbUM+OJq77h2f/nx9TBOeg9rOejP0wjWuAXNp3Uya853Yu6RFW1z8vFLyICD0ONfqCu/seZ+4+tk4n+MC+bg3JrD8eNMOcvMaoNc8iGu/sDVLgAaUW4nV07vhvCgKt2g0l3sXEpDDx611YeVLDafzwyBYX6CmlWRn19+KOZ/u5Yc0lYKlMoJOeKk/9aYjL6PNFFyTKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by PH7PR11MB6497.namprd11.prod.outlook.com (2603:10b6:510:1f2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 08:29:28 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7%8]) with mapi id 15.20.5293.013; Wed, 25 May 2022 08:29:28 +0000 From: "Zhang, Qi Z" To: Thomas Monjalon CC: "Daly, Jeff" , "dev@dpdk.org" , "Wang, Haiyue" , "ferruh.yigit@amd.com" , "andrew.rybchenko@oktetlabs.ru" , "Richardson, Bruce" , "Mcnamara, John" Subject: RE: [PATCH v2] ixgbe/base: Manual AN-37 for troublesome link partners for X550 SFI Thread-Topic: [PATCH v2] ixgbe/base: Manual AN-37 for troublesome link partners for X550 SFI Thread-Index: AQHYOWgI/FvuTNVQ3E+3m88sjeNJdq0kIZXQgAohkwCAAAM7wIAAU/QAgAB9gTCAAI8NAIAAAuXw Date: Wed, 25 May 2022 08:29:28 +0000 Message-ID: References: <20220316181544.7251-1-jeffd@silicom-usa.com> <4594196.1oUyQt6lIG@thomas> <3526909.qqrk5fENW1@thomas> In-Reply-To: <3526909.qqrk5fENW1@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f2b90003-acd5-443b-0c15-08da3e28af5e x-ms-traffictypediagnostic: PH7PR11MB6497:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fmNY6v4S0OfKgytuQ5uOqm2ohMduH1xipn90cmwJsMd+WGHYrZKd/h2P1EXvXtjWpHJp5Dq/X4dOH32cQ8kZhuZ58xXwggFIhcmOL0sN/Gvx/h67BSr/yd1xUh1/OFNtLh9GrEXV76UpkLDeIzG2+jlT1R7n3zDvJYIqwlUhGYpLH9pctQTLPmmcJIO5JW4mNaP6ivyzbNQEuauPzVpdK22aIB0aWpvPMBLI6qlf2RbGfV0DY4JFpiYTHojrjkj7xGiDKYV1JTukOFqXXrr1n/8o7oXjYKslIn8Vn43HoLd//34FKTI2RyF7+gprgzcquYU8AiHP3edd/ERyxDtaLmDGuRVjvkOVTTc5JQpT0vpcMVPfi1VeWJr2H9id5QjJ8hyD1UfCDjqRRfhljAxn5gke1H58utSWLxAzxXuaog0sUrTYMT5GOiDnBlfuGFMe+WLfpTN79WndXOEos/vbEHjcEHfG+YMCbiEYdRFcYZW7q97q4FTTfbZ6zqvZ2bEXK02D54mtu15wSvnTHo1uYkvvftNIQ392UuIiH/kL0fphvnvifX1YP5cWYmnL+3v97yGtX/cE9d9kWFH8DXBHvLuJ2w9IYZ8f7RWo5DxAVMSmbhMX6WJNQRPSdvEt1ctZ64e36Ut9sTxQbF40m7u61jb6xGi7tuDdQIq9n9OSYUoqon1mU+C0lnLe+bvfCkPP34H0kxdN7pPR3TvJ+0XRsxOwKcAJJ3vXoOnz4YX/CPcuvgj0AEbNPrAGzWlt2hZIvspVvT00VzNyMNBLtQIqnHKb1rrM+A0B1KFzF3XAP3s= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(186003)(52536014)(6916009)(54906003)(107886003)(316002)(33656002)(9686003)(26005)(122000001)(7696005)(82960400001)(53546011)(6506007)(2906002)(55016003)(508600001)(64756008)(66476007)(66556008)(66946007)(8936002)(8676002)(4326008)(76116006)(66446008)(71200400001)(38100700002)(86362001)(38070700005)(966005)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HLdR5nMPma4/YGKPOTvVM2h1kBF9e6U1GrS9cxiEKBRYQxE3IPDqGBjuv3xA?= =?us-ascii?Q?QkeLcndmIe2Xgo8UdiWELtZI+KhW3sfOVUsLQKm/TZQtoyG+AimNJUNByQ+T?= =?us-ascii?Q?ztlHvw4/wTNB3XpEVWwGKt0NSBiozBSJUjENuW/kCpoNPXxa5SzgjHiYzjEr?= =?us-ascii?Q?uyc3pMAgffg1qSRU0pFRlbqQYFTHwHkAyZpB4fxmuLsngGFVOVK3ji3mqA1h?= =?us-ascii?Q?aegC8r1uvz+iqyqIRsnrGeW8yftDbL+ygnRK1mqhuV2hYXDdnDVXeBQzWNM1?= =?us-ascii?Q?5kvlbGSkBMeqAYarlMxWxPJfbg5078p5jK9OWM8ePJoAu+rZDsCwRYTJNYBH?= =?us-ascii?Q?y8tvf1EuuQLVzUOaafLNTE6Jz49XBojir18nt89M7eTUkoccU6iUB3jncCPa?= =?us-ascii?Q?M1WYoq6dpV/SAc77bG6ZwiV8wLj0lXTCO12e5FS3J8KpFinDcjI4+3KtHrYF?= =?us-ascii?Q?n3ttG6D5rUjuteT61ApS9bUVkzc/cR6W+/ZwUd41p4bd/tXocqCsplZjJa18?= =?us-ascii?Q?Bl+xs+PRceqmurnsA2bze16VWbIsZDapNMcJ+th+9bOmij/KyLxvwZ0LPrm6?= =?us-ascii?Q?kyk9fl75Esx1N654fzTCp/A/UGAdoxxlhvKnQtWXIuQu2N1L7A4s43GnVQ73?= =?us-ascii?Q?wgm9KlJrhEEWyXhq4cw9WVpH8f0PFZAdkMpzm+LO9InzMr4pO3r74wBQ0orf?= =?us-ascii?Q?5gGL9hyamRPOe4UHm2tpB7xSv2PYvTtIHdvFfZtAyv6b2P3zYB+iBw3RTk9W?= =?us-ascii?Q?rbJtyU04E2AlOtEDPOklHpDJTvf0yy8BioFi8PA19WDaWXRxsjAgokD9iXDY?= =?us-ascii?Q?Ewc6Y1YSUy757sdG4tp0kADlyhoLy5fb7rQx7hL8Te5a7xYgCV4R9oB8oiRC?= =?us-ascii?Q?bgguh930qAo08SxXf25FY6+9ajCvuLO3t4SoDv1saOZztWaEhkTvClJ8id1/?= =?us-ascii?Q?zDaDkN9dGJU8ndn09FUcJ2LYGRJr/YjyT5UvJtWieSf6pgE8gshRKOncgCyK?= =?us-ascii?Q?iMFmcSKc/rRv1T0D7EkM6ETc9Izz2yk36U0BhHCJTHaGKsq8gnLHYkAxFzNe?= =?us-ascii?Q?/c55W/wDk1VpduS58npiW6Cne/KguOyFOxy7ryrlssbGM8x/hnwWa4BsGtiY?= =?us-ascii?Q?gldQp3e537tvSjuNPZXRce4cy/DkPuQlbBxVxKIsIBV+ldOeCClZU4UMdpaT?= =?us-ascii?Q?dQI9tIQPTZ13fQsXFLoNiQK0oQWSWEOU1mzmVNr90OJNhrfM6v4Hp/kPD5vf?= =?us-ascii?Q?TH1scxp6iQXVjoHwqTe3PXndYCOVxSEf0t3EX5FUYB5q2Q06lCGGBcq2Ts4o?= =?us-ascii?Q?f/Al0jh2bW+/jvxiRhAIMtBnw6TKs9e194zM3a1UY7eW4KtgfoOiYNS/UQ6X?= =?us-ascii?Q?RDv095vtd6HPHhyypYFVtcL4EaKtk6y2Gh1g9R1LVD3LCrITvj+boUAKCq90?= =?us-ascii?Q?INr0HMPcqlBwsLO2irEw+nZONCio4hlghhaATHOJPxYPUhuf1PiiYI76NE0o?= =?us-ascii?Q?89g8XQsIv+ToVaZj4DL0iymBEfG3/+AsJgWWZ+rlz2M2SDMCVhrRgy4JDHyn?= =?us-ascii?Q?pE8KXUX2KLnDggaZpGdShP27trxsw6P7p6Ll4MgnSnMHgjXl23sGbUXLACim?= =?us-ascii?Q?EIkN+bVrvVLcz6wm3zYYoFW+D4TQ32oVJ7j8H73rosNRBU8Sk6pdh5sXw/Hl?= =?us-ascii?Q?Encrc1tLf0HMFCaRN8whdMCpuycP/3zT+VnuvbuhQJHjHPLoY6SwsPGUZrP0?= =?us-ascii?Q?HZdJvWneKA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2b90003-acd5-443b-0c15-08da3e28af5e X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 08:29:28.7824 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wvmqIhQTfMPn9gfTKgOjwl2NlX4Lj6Z78eQvBkEQcTTbLQV8X15R6XtN0izGfxadfFNH2IvVvKvSssGVQqhPgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6497 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, May 25, 2022 3:56 PM > To: Zhang, Qi Z > Cc: Daly, Jeff ; dev@dpdk.org; Wang, Haiyue > ; ferruh.yigit@amd.com; > andrew.rybchenko@oktetlabs.ru; Richardson, Bruce > ; Mcnamara, John > > Subject: Re: [PATCH v2] ixgbe/base: Manual AN-37 for troublesome link > partners for X550 SFI >=20 > 25/05/2022 02:11, Zhang, Qi Z: > > From: Thomas Monjalon > > > 24/05/2022 15:42, Zhang, Qi Z: > > > > From: Thomas Monjalon > > > > > 18/05/2022 02:03, Zhang, Qi Z: > > > > > > From: Jeff Daly > > > > > > > > > > > > > > Some SFP link partners exhibit a disinclination to > > > > > > > autonegotiate with X550 configured in SFI mode. This patch > > > > > > > enables a manual > > > > > > > AN-37 restart to work around the problem. > > > > > > > > > > > > This fix for some specific hardware in base code, > > > > > > unfortunately Intel DPDK team don't have the device and the > > > > > > knowledge to approve this, > > > > > > > > > > That's why the work is collaborative. > > > > > You should get and trust knowledge from partners. > > > > > The only concerns of a maintainer should be: > > > > > - good feature design > > > > > - good code quality > > > > > > > > These are the questions we can't answer, we don't understand the > > > > design, what is " change mode enforcement rules to hybrid " means, > > > > what is manual AN-37 here and what those numbers in the patch means= . > > > > > > So these are the basic questions you should ask to be made clear in t= he > patch. > > > That's the same for everybody: we must understand the reason and the > > > intent of any change. > > > > > > > Of cause we trust knowledge from our partners, but anyway this is > > > > an Intel product, > > > > > > The DPDK driver is not an Intel product. > > > This a community effort where anyone should be able to participate. > > > > I'm taking about the hardware not the driver. >=20 > The SFP is not an Intel product. I'm talking about supported ixgbe NICs , that's patch will impact. https://doc.dpdk.org/guides/nics/ixgbe.html >=20 > > > > only Intel have the right to authenticate this. > > > > > > What do you mean by "authenticate"? >=20 > You forgot this question. > What do you mean by "authenticate"? I mean a hardware vendor to judge if a configure is correct or not on its o= wn product. Btw, I may not express this clearly in previous, I would say "responsibilit= y" but not the "right" >=20 > > > > unfortunately none of the active ixgbe DPDK maintainers and I have > > > > the knowledge Meanwhile if this is an issue on DPDK, it could also > > > > be an issue on kernel driver that's why we suggest to submit to > > > > Linux community first where will be right people to answer above > questions. > > > > > > Why Linux community is more able to review than DPDK, or FreeBSD, or > > > Windows, or any other community? > > > > Of cause DPDK could be able to, if the people have the corresponding > > knowledge that works on it I would say on this very specific domain, > > DPDK community has the gap that depends on Intel, Nothing else, we just > try to provide workable suggestion based on current situation, meanwhile > we will escalate. >=20 > You can get the knowledge by asking the right questions. >=20 > > > > > - no regression in known cases > > > > > > > > > > the base code is delivered by our kernel software team, I will > > > > > > suggest you can send this to the kernel community to get the > > > > > > right expert to review. > > > > > > > > > > Which kind of expert do you imagine to review? > > > > > Intel team or Silicom people who are pushing these improvements? > > > > > > > > > There is another problem with asking Linux kernel change first: > > > > > the patch will land in GPL code, bringing difficulties to move > > > > > in BSD-licensed base code. > > > > > > > > Only if the author agree to share the copy right to Intel, so > > > > Intel is able to re-license it to BSD as same as other base code. > > > > > > Yes we should be able to grant such copyright in the commit message. > > > > > > > > I suggest we make this process more flexible: > > > > > 1/ a contributor sends a patch for DPDK base code > > > > > with an explicit grant for backporting in any license. > > > > > 2/ Intel checks that there is no DPDK regression > > > > > 3/ patch is merged in DPDK > > > > > 4/ Intel merges it in the internal base code > > > > > 5/ Linux kernel team can backport the fix to Linux > > > > > 6/ Any other OS can backport the fix in its driver > > > > > > > > Right now, our base code in kernel is GPL license only, code with > > > > BSD-3-clause can't be distrusted without change our license > > > > strategy, so it's the same effort if someone want to backport DPDK > > > > changes to kernel (shared the copy right to Intel) > > > > > > > > but I like your suggestion (if I understand correctly), have a > > > > dual licenses in kernel base code make things smoothly to backport > > > > from DPDK to kernel, I will feedback this. > > > > > > > > > Let's make the DPDK process open for everybody. > > > > > > > > For sure, we should. >=20 >=20