From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B405A0540; Thu, 7 Jul 2022 08:55:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F1F440A7B; Thu, 7 Jul 2022 08:55:56 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 7EC8E406B4 for ; Thu, 7 Jul 2022 08:55:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657176954; x=1688712954; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=hyngDxZzMfL3hk7016PJkrdEGpHtsL9WUR3tA6bZGzo=; b=DuF+7h0jox9RGUEpEeWBfsoGbfvZqJtNxelFAU7h0GOI4u2NwwPDLYAh aaNC2n3iHpaXfEB7yuXgjnYe8woWYW4Yyijo+o9bXspyR6uWgJsR/l4l0 MeT5HsqgueflLeb9nahc/n5c7jJsBfjMNqK6DlPPglNVAxdBKZ3MIFJNQ xMBUHLd2XYImKqbm4YUxzxeFqe7psWnuvTc20mxSdUjd8o3rkSduJrH6t RAgbq8rPAJMHk1C9ethU69nAGp7qOUHBHV8ag0a1caM8j/DUI2LTjuV7l EiKO9gWIrIpH+62dVrmWnv7Kja2oTL5wNtcSxxqUGvEWcrXyrzFFptAhS A==; X-IronPort-AV: E=McAfee;i="6400,9594,10400"; a="345636722" X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="345636722" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2022 23:55:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="839812029" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 06 Jul 2022 23:55:53 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 6 Jul 2022 23:55:52 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 6 Jul 2022 23:55:52 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 6 Jul 2022 23:55:52 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 6 Jul 2022 23:55:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kgr382UKRzKu5PriXC4JuKTCLBYOTehcXXY4na653J7Wt9d22jho9JWIbjz+f8/WCFRFuwN31jl1JiTWtWPsZwSyFwHM/ClpPDJ3QtnHSN3h8Yndsk8Mde+0epBAevEKRAvmz5BVUqKfuciaMWKhGchqRcnfvHohJ0r/p8XsqSjt037RL4wqHhvRgZI/4JasrH4Lyw/8hq3O1gBQHi6isy60U3xssmOHU80JuVcpxu9jBT43gKaVU+Y3aRPLHsoSOZCVPzg1joWY7TnCidrnE9Q6xCH3Bih8WgzwAQPUsXuBlRaW6miPK/qoZNL1FYYlhN3Lz/8XBOvpLLbxZLSkwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bHA6qBddng2wps3puXgwuSe3d+KT22MllCM2aa1irAs=; b=ex4N+CEKiZEx9LmNkL54KWzealnS7cwosDdquAoNASsYYE09ppbUfd3d7bmccxb4WarcTeR/I/rK4Fj2C3tnGsXQQZVJ9NcFBRerUutze1qDnd215sc4a5td7H7swL+1kzuQP7YLVzAaWBkcuba/IP2GKTrjIabAq2pOAlD3xXOOiU3ihe4LxrvJw25nDcRPFtt7wdxTx8yPjQt/QUmW/kZs9XVFz01OVKG2TOqY9He/7xh0UBc4AGzQ64lXP87htcw185juqy5LOKqTPLnzjGhpb1h7Y51KeGRMC3mybzqYaaPryeBrM6V2ClAgoQGWLrtcia+OugdzYmSGwTBxsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SA2PR11MB4844.namprd11.prod.outlook.com (2603:10b6:806:f9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Thu, 7 Jul 2022 06:55:45 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::644f:ecd2:47d0:aa6d]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::644f:ecd2:47d0:aa6d%3]) with mapi id 15.20.5373.018; Thu, 7 Jul 2022 06:55:45 +0000 From: "Zhang, Qi Z" To: "Zhang, Peng1X" , "Yang, Qiming" , "dev@dpdk.org" Subject: RE: [PATCH v6] net/ice: add retry mechanism for DCF after failure Thread-Topic: [PATCH v6] net/ice: add retry mechanism for DCF after failure Thread-Index: AQHYkQE7rfLqt4kEtUaAFThyL4nUPq1yemEA Date: Thu, 7 Jul 2022 06:55:45 +0000 Message-ID: References: <20220706141709.7681-1-peng1x.zhang@intel.com> In-Reply-To: <20220706141709.7681-1-peng1x.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ea57976d-e47e-4e5b-f430-08da5fe5b761 x-ms-traffictypediagnostic: SA2PR11MB4844:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mXwI1dNKB/rWmvoOzMyQ3a39l89ISWz+rH9QDDWlKDkipvFwf446JsiF7L6DMatGrRCcEi5h/dtfFpLCaNhEW4cPjYzZ+m+mjZMv682qBQZnID4WDA1yN3B1oewgmhgaZdFYnc8Ibgex4PnuEmHQsJkmY5c8whckIIj8OUBzCnJ9kxrMdSSbMTSAwYcvlZ8Kkb+FynJwn22793zdEpHojOLixEns1ZabQFQ/e8K1mRwzDklTQvC9/f1QOjJHqnQHG1DgKhQlZa9alYSFLs0QeO4bOOOkz6NofmDvFEH7+BDYcSfRO/i3XSCm/EhBa98/QG0tmRMMztQDavszYal+OahIOJnnGp7tN+7Dc/RYbxzHNqtgGVS7cKm7me5ankPSEwbKTlbh7b3lHGITDZMf62pAKZ9e1h8VPixEWTdxpFymw1VMd/yXBAvp2rGgyidJ5ULGZCLl5VXUjgR5B76sxYUPKj0sEsKGIM5E1ap15pyYN+IsuL5j6OH8ak+gF/16PYPR/KdLcfeQwNVCJW0zGgI5K3V6Rtn8JVWw4lgqq9c24q0jPZmF8EOVzQ6yAOCR7vPKg3ZtvVQKuUCO5xhGS88l360zLuIVvV6WwlLnPOIRiDJq4X4sXsPT5rMfplQZR7DGD+S9SO5kEOciDY4xr1D5SYE3XD5oPr2nYOutK/38riGZ3i1As5su+f9dCPoqhKgsZnVTzE+8rN75RjfiAHTZCIsqHenvdRn2wRxGPznG7NdCzEjPb9fzoOXUXfk8zX7RyaG3UPEdoU3MGhBEVW0vu4kbvzfx3NYFtU7MHHFnuKXrnAMbVYX+C8qi8BLm x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(376002)(39860400002)(366004)(346002)(396003)(52536014)(38070700005)(82960400001)(5660300002)(86362001)(316002)(8936002)(66946007)(55016003)(64756008)(122000001)(66556008)(8676002)(9686003)(83380400001)(26005)(66446008)(76116006)(38100700002)(478600001)(2906002)(71200400001)(7696005)(66476007)(41300700001)(110136005)(33656002)(6506007)(186003)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rE7xowdvoYVvkvf8nbUKJforU9+Ho1GKppo49v8MCDiGdRzsf2yywo3A/QjB?= =?us-ascii?Q?B5ATzb2GtJf5c+pDv8xIsKZELD5aO/qPXr//+7fy7zGfPuyI2oVPyg2H4khJ?= =?us-ascii?Q?+1R93YGJ4xDRVdweIE2TchxKm2QdmXNVoIjDfgscrDt2UP8aeBIcLa+hHeDp?= =?us-ascii?Q?9d2co1JNc8M3b5s/vr005wO+C48xaXh7I7d5rZFTMo3fj47JqhRQWmNhXCC0?= =?us-ascii?Q?flAZ0tSp4sGS2jDGxfJ7hVAx8E+x1VmlnMd9YnacpMY7HZU5XlTV2Xx5FXa2?= =?us-ascii?Q?iNunsD7LWT5Qmo2y8yqPB6eOeQeMBjWLrJTTtpgYS8JmJFat3UIdySjlhI3O?= =?us-ascii?Q?Ay9ZD3dHHkmzXUzH53fFs1+N/tfVKbp2ePUPMUqYcxh8aNs1Lwz8XfZvaF+v?= =?us-ascii?Q?4pkP2hqf4HzEPrsbPvVs+VlKk3ziClVQ01jsmAv6UjyxcUH78hVFneUUrEiU?= =?us-ascii?Q?NwaR5ZfOhF1urZ7RPHfEM1aSmcK4rD3qufnqug2KzJqB8jVL0qZaVL8MSC+b?= =?us-ascii?Q?GTnh/VSNui3U4pjpFjTQnmXbK8gmTAYZXCedPcqc5ULkMTPykCRV8Ip7r+mh?= =?us-ascii?Q?U/F4zngnoWjEQz7D1GUkdsYjoiZMk46USakc/tfh2usK7okbpUg+USyMAABW?= =?us-ascii?Q?oAUkabUM4H/HP5YroCCYxhilHAYb9w//XUwIklOpKXNCmW0aXaBJrP8ESSKu?= =?us-ascii?Q?/30FS8jZzSne0bvqu89t45pVFArQhiYItdz3hzMgiXK9xeXgbNOyeV2Xmlp0?= =?us-ascii?Q?Ttks2977bTepxGBKzcJKHqW6jTC1nKqa3fY039raDxujYXyM8xgbZ+ddHoMX?= =?us-ascii?Q?USdMdCqwDrlx4Yc4NZPJcngpv3EK1fnsYvYdr4XijO+YzMU4gd26zfF/o0ag?= =?us-ascii?Q?HwovP0RSmh9bOvVfxteYjaxq7YYXOed6pWk7zyiYGPzKNXyqzRo2DlbAclNM?= =?us-ascii?Q?isvLpKukqQCTGoKgOT9cpwFGLuqg3GzKml3dtfd7+wLp9wUGINlIRHCTEhAn?= =?us-ascii?Q?TRy+TMtgYIlihR9fWA5/8NG8JoETtRXtwQegS2DCP4niuwCrBDUxPPVHkmoG?= =?us-ascii?Q?rL4NyHljPowCWN++x4ycahe1s84Lpal6Gz9KtnyA6p3ucNps3SBSolhAblrP?= =?us-ascii?Q?I44UGsAcdF1gcGk016+W+mXkAi9+51V8ariRR1MFEL1plZmU5Psfh2s/FVjk?= =?us-ascii?Q?4amnKDSB4qMV7l96mcxs6n13cgDLG2nn2sq+LbxFQvkFYUgqJJX/ee7O2e4T?= =?us-ascii?Q?ZPcud/ce0SD3B8K1DuqeK7ugJFVqQi6Axw+u+hbYBMb9kj+SrEkRKYLr9YPI?= =?us-ascii?Q?KJte6FJhikzfNUOuiD3Rctsjk6IIPwHF8lCExUVuNiCsHI9gcjT/o74RnsHg?= =?us-ascii?Q?Hy2683ywp3DoaSEsUKNzdju3NEcEQOLRo5zCnwjfpDWAlqGmnteQw+6kZL03?= =?us-ascii?Q?0W0cTe111R/f2MO9IXSMk1F4ZZxafcF+sfvVS2jaKgyN04DoDLGkV9VcmiOH?= =?us-ascii?Q?9t9AFrkT5RkzoE+FYV2HBGcXAe2isEu6fkp/OHkmxO1yKWWIiRMu/+6bI3h6?= =?us-ascii?Q?osz5+IDFE6GWxrxTMGuPAK87h5YUuzrgsrM5ZRDf?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea57976d-e47e-4e5b-f430-08da5fe5b761 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 06:55:45.4989 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MqztUDHqHgL5Hq/SToKqw5DtqrJIOvU1jtLkU7vT+y7QLDA10I/ISkO/AyYU4gwuJg93zyNOirAHbx2uM7tsDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4844 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Peng1X > Sent: Wednesday, July 6, 2022 10:17 PM > To: Yang, Qiming ; Zhang, Qi Z > ; dev@dpdk.org > Subject: [PATCH v6] net/ice: add retry mechanism for DCF after failure >=20 > From: Peng Zhang >=20 > The origin design is if error happen during the step 3 of given situation= , it will > return error directly without retry. While in current patch, it will retr= y at every > interval time during certain time if receive designed error code > 'VIRTCHNL_STATUS_ERR_RETRY' > from kernel. If retry succeed, rule can be continuously created. >=20 > The given situation as following steps show: > step 1. Kernel PF and DPDK DCF are ready at the beginning. > step 2. A VF reset happen, kernel send an event to DCF and set STATE to p= ause. > step 3. Before DCF receive the event, it is possible a rule creation is o= ngoing > and virtual channel command from DCF to kernel PF is executing. > step 4. Then result of command is failure, it will lead to error code ret= urn to > DCF. Error code will be set as EINVAL, not EAGAIN. >=20 > Fixes: daa714d55c72 ("net/ice: handle AdminQ command by DCF") > Cc: stable@dpdk.org >=20 > Signed-off-by: Peng Zhang > --- > v6 changes: > - Add retry mechanism for DCF if receive designed error code from kernel= . > v5 changes: > - Add retry mechanism for DCF if the result of sending virtual channel > command is failure. > v4 changes: > - Add retry mechanism if the result of sending adminQ queue command is > failure. > v3 Changes: > - Add the situation description, expected error code and incorrect > error code in commit log. > v2 Changes: > - Modify DCF state checking mechanism. >=20 > drivers/common/iavf/virtchnl.h | 1 + > drivers/net/ice/ice_dcf.c | 32 ++++++++++++++++++++------------ > 2 files changed, 21 insertions(+), 12 deletions(-) >=20 > diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchn= l.h > index f123daec8e..e15e3a4439 100644 > --- a/drivers/common/iavf/virtchnl.h > +++ b/drivers/common/iavf/virtchnl.h > @@ -49,6 +49,7 @@ enum virtchnl_status_code { > VIRTCHNL_STATUS_ERR_CQP_COMPL_ERROR =3D -39, > VIRTCHNL_STATUS_ERR_INVALID_VF_ID =3D -40, > VIRTCHNL_STATUS_ERR_ADMIN_QUEUE_ERROR =3D -53, > + VIRTCHNL_STATUS_ERR_RETRY =3D -63, Where this error code be used?