From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5469B432D5; Wed, 8 Nov 2023 10:33:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40B9442DD8; Wed, 8 Nov 2023 10:33:10 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id ADC0F402DA; Wed, 8 Nov 2023 10:33:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699435989; x=1730971989; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=eEMYk3KWjNoqvs4BxdtxcOyn1evMh70GHmTU1vBiybU=; b=FZ/CoAzhu7IlYgSF15FfQmQ1UC6BgbjuJxxX/9lsrrOdqeultM5jxEc+ ZdQLJsGyY/2cOBcj3oMm3YhKpAlbo0velsveV9zzdQfae8nvSaW2l1k1z msagpRKcsagPIoZSLnSG4WZ6Dsu/B1mUr2igIXRUrQ1AGgEfyS4A8HVXE s4rB0LO9L263vz7zzh4lslez8AImb/pqvn9CsxMh0EduAosR3GMsfnaIB LuVugDKbXlfWqE5gxcZtysnZJYf2tjuhlMsZuAHcSpeQUbwL9rNRICVE8 a5YQzmfxw6/EnvZe9muhSq7kAe1trV0pOxgWpRepQGQ6cjmUIbeYLKzdH w==; X-IronPort-AV: E=McAfee;i="6600,9927,10887"; a="392594678" X-IronPort-AV: E=Sophos;i="6.03,285,1694761200"; d="scan'208";a="392594678" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2023 01:33:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10887"; a="833431580" X-IronPort-AV: E=Sophos;i="6.03,285,1694761200"; d="scan'208";a="833431580" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Nov 2023 01:33:07 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 8 Nov 2023 01:33:07 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 8 Nov 2023 01:33:07 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 8 Nov 2023 01:33:07 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 8 Nov 2023 01:33:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y7ULEEvwSajrA61njRw3KXR+oROpACjRwhgL8/bttVkfTTkZ9dhNCemhUxzDJjYnNRlSn1IAZe0U6pDnfdk4NJZ48F36mS81uX2NznO6SVHBgP8OJa+7bBFB3sGqEZ58X3GcStedDJNVWMgRTUkvPq4P/Xfu6hXq2w4dDEbvcChwVFTweSkFwEASwXW9k17DL3ouszdoPz1nyfQlTFJ6tCb1D6QxmjpVfsqv6mkcm9sV4Ht9tvRm6fSciCBvk47UKQmWigLaiT9wB+nY6nqH9V2AvLW6nISfcHOrfLRgE0KGViWtRJXSsYGzN/I6c+SKhMYxzvrNsgGxIPvzAMbuVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UbQOaOzsGJrjkRwMKS1Qb7s92OJfsBtCfnfai38NWuc=; b=HFN/uZpnlRlQT6dy4Uo8apcGspN6RQS+u3I4EqGPxvKI3zE4RGNw2x/fSwXpT5HkilrdqeGhKiopTsKVqkvzTaIURTJJRPBNQ7p5lgiGCAGBnbBfvKtfKVDEQBsLBRVf2vKW9ReZ6IsMA2YryVxtkdDsvj1G+yBouloJPsU3QL8v4yDuVpqmb/qtBARV13sZxgINt3Dr7gWyDCJjjhB4E1KxI3VpnmB2sWbppi86bEZnG66/UOlU4PnUTownCK2cM+ZwXZgjOnvSp3aygmi1rT3oaPvKXevJpXfc2KIKIaqLlCV6Yq+e15BNCmfAUn7l3aUtTPMxkVclEAsUcFodCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DS7PR11MB7835.namprd11.prod.outlook.com (2603:10b6:8:db::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.29; Wed, 8 Nov 2023 09:33:03 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136%6]) with mapi id 15.20.6954.024; Wed, 8 Nov 2023 09:33:03 +0000 From: "Zhang, Qi Z" To: "Deng, KaiwenX" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" , "Zhou, YidingX" , "Deng, KaiwenX" , "Wu, Jingjing" , "Xing, Beilei" , "Zeng, ZhichaoX" Subject: RE: [PATCH v3] net/iavf: fix mbuf release API selection Thread-Topic: [PATCH v3] net/iavf: fix mbuf release API selection Thread-Index: AQHaDUyvc+aNMNRdCUibDRJ8yPWh8LBwMRfg Date: Wed, 8 Nov 2023 09:33:02 +0000 Message-ID: References: <20231101013433.534399-1-kaiwenx.deng@intel.com> <20231102044316.541458-1-kaiwenx.deng@intel.com> In-Reply-To: <20231102044316.541458-1-kaiwenx.deng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|DS7PR11MB7835:EE_ x-ms-office365-filtering-correlation-id: 4d697f71-6f0a-4845-9f07-08dbe03db490 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rZHUZpefdiFjlGyFcaW2wwVCRpWqg80sNWrnP2gTHqAl7olLcikDwodOQ1JTnx1+OWHrF/1N1LCI2CDUuwWppdkDMKUwMMCEvowIOqEhrBDXYdDfG+VlIOXGHQA5hQt/rmeIEURNtx7Tfbhm2nBYajLrhFxgOG3pqRiZiRXZdqzvcvMWRQdiKS22AQRG8LxND5xlN093m3S0pCsN0RFibzaO6UQygHn7YmwiUzXuO2vMUdHxJq/L8LScQquu3259PfcTFVvSTaiuuwwm4J0W6bDQBzCFkE9WTvx5G41x16QBK+N7Rw1NTuAEHQH/nBoqKLiELRhB0SIVf/OQteiAYDpacvop/cNnAkwxhD91PMX4+k6DK+r8cdhuRq/mQQPV5gpUpQOrfN6acaswqzCsABdJIIshGHbz74w1lsMksjdIctHoOejn5pRPeqt3VllOF9qMUrhrtulwuX72SemYz+eJgjpH0JCaO9oH8A3yzFh3eOaPbVkEeBYrRRbdBeWsO3QhEqvOfsAkHmS/dmm+3l14KLt9OmjYW1l6uCBZYydgdTSzDIhGDxasTCmLv2Xy59JphuoWTLN8cc6nYLYy7tctuGJ+Dh2ODywLozkXmOudWahfn9o/PhFs52cF2Yw9 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(39860400002)(136003)(346002)(366004)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(5660300002)(7696005)(6506007)(86362001)(53546011)(8936002)(38100700002)(450100002)(52536014)(8676002)(71200400001)(55016003)(478600001)(4326008)(107886003)(9686003)(316002)(64756008)(54906003)(66476007)(33656002)(76116006)(66946007)(66556008)(110136005)(66446008)(2906002)(26005)(83380400001)(41300700001)(38070700009)(122000001)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oJl17mtVpe8WzNsMiup119dOj9d57tCnFPTITFxl6QhoItCcspEef+GoQpZj?= =?us-ascii?Q?rJV/pH2Wd/Uikn9a+7xzTc5xcHowShAVkL2f7UQ9F6hWyBYH7kqQqbbXGUrR?= =?us-ascii?Q?2hj1z6Zdk0lokZKXkYij8a8cXJ7d8Jtd4swNjkorpfjEmJ42+V/l9aKC721D?= =?us-ascii?Q?pUsLTT66eOwi7dmXPpCu98yEWVBOGgHFAkPDnaSXzJszFRmuwl/gVfTfR446?= =?us-ascii?Q?8C/bCWz66ZF4aCmtfAQq4CqhQv8lmLWnG9DfNq9JAdihMn0w17glJcgueQyw?= =?us-ascii?Q?aODn/tudG7ejxToG5RkO/L6aNekHOe6yS27siFLoQkwp4e8jsXVmcSFf/6Tx?= =?us-ascii?Q?lRsmInDuqj2Xuj+i4iwusk7OBUAFy4ZF+2S4u6+e7GXZ7vT6JDJHBGsyYGSl?= =?us-ascii?Q?NeFvGpkjp4nnmFo5NOwOMfmoxyDF13lgPk7knG/SvLaLmCLFI0Kcht4tGYTc?= =?us-ascii?Q?I+ydMaw0dNby/EcKMMsHq7VihNCOV0mqmtfz5MDVxLH/S5vn/lKdYy9MCXaf?= =?us-ascii?Q?/q+3datOAmWyeEQfSKsVB4yeQ1WK6tI17w8mExqwZdLbVx86i4BVkS/0Y15w?= =?us-ascii?Q?H3fcmJVGUil5s54An9r+5px8HBiImURPpiqfMW6gzyn1PoirX+GNRMQt5wgE?= =?us-ascii?Q?M/AyyRNIYY13l+v+gRF2y+WJcFCYDRPd+22SycoQtpk74s8D3HDlhoTGUt2S?= =?us-ascii?Q?daO5BpnPm0caRXrt8cgZugKtos5w/fsd5giMrnhsNk8716y3LOagBj01lp6b?= =?us-ascii?Q?1epnwQ5jFTff17eSuTygvV62T2D1ndvmOHM35mgqeWP0erFSQF2eyks9XTdS?= =?us-ascii?Q?YrIhxyRqBHiRdd768HYhvdq5PvGUI5QadGnnz1qrw6iYMV8SrqLBcfT3WYm6?= =?us-ascii?Q?45Ve98JOoNL0/o3Qer2b0yyYkr98PaNgwMdlv2iAssDuacIuSSgSBLvoXdET?= =?us-ascii?Q?WzUT6bkXXElkFvLF7evPRVIkoANVkJYtfDYeJZGfOK0WyC6hqGUaS9TvJ3rQ?= =?us-ascii?Q?vtpmurSHMoFn7lipdXGFFRStHFLg/e6PHNRQBHmjy8MH/0fTtq1psYSc2Dob?= =?us-ascii?Q?/t+jpIZlvVQqdveUL2E9Pw4P79WGlixKRACkl+tG0hV68MsADNddisb78b2E?= =?us-ascii?Q?62OjQaeNOnAWjnN3GKYhNR7MNh+HQ8uIRfxC3IlhcMPannSNqGFY+8+ehcFE?= =?us-ascii?Q?Pxgl+Dg61pa8Lh5AyoIIHQVXyfeuy7++RIma2aJMh/IfP2nV2r4BkSpB0med?= =?us-ascii?Q?m5d56g7mqWROr0+kUo7rqHeKL2ChlwOM3vhU8xXhX5NjW01M8xsMc+5ac7Xr?= =?us-ascii?Q?PAx0+wiidDPM5pLf5b65hHIPH3AZn0NWQM/iwg6KHPtD3J8MJF0Bw4MQztJi?= =?us-ascii?Q?2QQvwlfF/ROMbol4JLS4BK0pN9MlTj8F/WLXgzko2J2ZH6mNyHzRk3JDR9DK?= =?us-ascii?Q?eW0a0c5YT44RQSSoVD1j2T4tqmq7yPFwwq7eXiGAzZTkh0I2E/CiaKYfHvbt?= =?us-ascii?Q?jqrHK10XAVb6aT3/LhvR26CdvCcn9a5ya+/Cx01sp7a+2nKijC3Y0G7s1uyQ?= =?us-ascii?Q?jKxDspjEi29C61+v/dgleThTWh903xYt/EI2PWQ4?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d697f71-6f0a-4845-9f07-08dbe03db490 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2023 09:33:02.9555 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2pQ/O8f3lYEzWQ3VrhrVMiI9OpaTqePQo6+brz3D1yN6rIoVPBAJ+oSYxj8V9y5XEjY4Zfko/LRqBdW8k3ZYMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7835 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kaiwen Deng > Sent: Thursday, November 2, 2023 12:43 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Wu, > Jingjing ; Xing, Beilei ; Z= eng, > ZhichaoX > Subject: [PATCH v3] net/iavf: fix mbuf release API selection >=20 > When AVX2 is forcibly selected and outer checksum offload is configured, = the > basic Tx path will be selected. Also, the txq mbuf release API is incorre= ctly set > to iavf_tx_queue_release_mbufs_sse. This causes coredump. >=20 > This commit selects release_txq_mbufs to releasing txq mbufs when selecti= ng > the basic Tx path. >=20 > Fixes: 22f1e7608ebc ("net/iavf: fix AVX2 Tx selection") > Cc: stable@dpdk.org >=20 > Signed-off-by: Kaiwen Deng > --- > drivers/net/iavf/iavf_rxtx.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c = index > 610912f635..a16e03d88c 100644 > --- a/drivers/net/iavf/iavf_rxtx.c > +++ b/drivers/net/iavf/iavf_rxtx.c > @@ -4022,6 +4022,7 @@ iavf_set_tx_function(struct rte_eth_dev *dev) > PMD_DRV_LOG(DEBUG, > "AVX2 does not support outer > checksum offload, using Basic Tx (port %d).", > dev->data->port_id); > + return; This make the execution routing not consistent between avx2 and avx512. I think it will be a better solution if we reset the use_avx2 flag here, an= d use this flag to decide if need to overwrite the release function later. > } else { > dev->tx_pkt_burst =3D > iavf_xmit_pkts_vec_avx2_offload; > dev->tx_pkt_prepare =3D iavf_prep_pkts; > -- > 2.34.1