From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 870E042643; Tue, 26 Sep 2023 14:15:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15454402AA; Tue, 26 Sep 2023 14:15:40 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 30AEE4028C for ; Tue, 26 Sep 2023 14:15:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695730538; x=1727266538; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=paMCXa4+P95vxqYoW3NZBaLR4WndMyuX6wMZ90Vwqtg=; b=a3d65WaeUQaq7O3ulHFWoEmqI9hXrIDRH528zClaCzpdRbQgYKNw8cDi 4noBYjLg2+0I61dROjBwcjLGf2otQYOErmm/MUyaeQIx5LhZ1z//LsGgI LWttzAhHzdmWWf+WTZWthZxey7eL/IEpI17xw6WzkbtzPR+5TMr37jCV2 lj8q9O5YitKUWJi8xRI2Mf9CKyktLti/o2U1N5byA8OGgkta7a1QN9gha GqznwxoPW7dEZHkQTgpCboteyKjM/C9FXvD8oyc5HZqMLzZtubLMa+XTL 2gqqxBFGCUHkhm4qFZDzpNHfeR3t4P2mGiPHweXhflIoAJBEH44bkYBta Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="384331995" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="384331995" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 05:15:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="748796093" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="748796093" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Sep 2023 05:15:34 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 26 Sep 2023 05:15:33 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 26 Sep 2023 05:15:33 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 26 Sep 2023 05:15:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KExaXt3dzoS7ZcB0JoAoL6vEpQtsaZ3pJKcCmmVUP+NgwE0V+ihL8fH4hMak1SYdijwW3qOjN41es87Co3U1F7iZlBkWMZVh6TzHDA+ET78JX+puzN1Fie52ic3Dik1pFhC9PIdLcE9BF390+bH96/cvw3H4bflpHJ2rF5A1W23lePLR8Sh9oB2cIpn1e5WcNR7icOp5iCY816dtTxXkXUeQxDLNocuCn5v7358N58xd7X8kvKOUaLNu4U/5qUvtEmrjHH5GXJoB0JVh8IeUz5DwqHmqoqdlZe9xjebwxDQcNjOCT5RNV//KiXjG9wGGAWV18YpEN3uk6DV/s1/cug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nxBPsPBGBYAvlE3dJkvtkucUkBkIDN2M3e5RygaLBqc=; b=nVv3u4zNzsK+MkN9PJZ8MLIuB6H0eYh0zPeNh9jdHY58IC7/GJ+2u3dzCTP/vHVjiPIc9h96vDEeFTsO6uFYAUUCWJKQ9tmo8aZ7qGysr5QlCCmLpogOuHbDrmAD4yZaS0PJWuSi1CY0YamGKV/N4ASu3JSDF9Up+UwHzKdA/W4o2o0EaNGMsvEZ1jLUoMNo4lIfmSMcQZagfTo0JCESs2qWUyfAVfhdo6XxzvXAzHpHmyyK5RpB3pxG2la5364BO2Z3p01RR1Q3w32dO38siVkgsFYYdGN1DoWDMbe3ZXH5be/B4BcLUMcrw8UVZBEyLuNYaD8oNVc+uX0wjsDPXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DS7PR11MB7929.namprd11.prod.outlook.com (2603:10b6:8:e5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Tue, 26 Sep 2023 12:15:28 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::27ea:67e:2966:23e3]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::27ea:67e:2966:23e3%3]) with mapi id 15.20.6813.017; Tue, 26 Sep 2023 12:15:28 +0000 From: "Zhang, Qi Z" To: "Richardson, Bruce" , "He, ShiyangX" CC: "dev@dpdk.org" , "Zhou, YidingX" , "Wang, Liang-min" , "Su, Simei" , "Wu, Wenjun1" , "Zhang, Yuying" , "Xing, Beilei" , "Yang, Qiming" , "Wu, Jingjing" Subject: RE: [PATCH v3] net/iavf: add devargs to enable vf auto-reset Thread-Topic: [PATCH v3] net/iavf: add devargs to enable vf auto-reset Thread-Index: AQHZ55bW+vavW+whQEubL3ayfSCbYLAszIgAgABAdpA= Date: Tue, 26 Sep 2023 12:15:28 +0000 Message-ID: References: <20230811094043.200995-1-shiyangx.he@intel.com> <20230915130249.425790-1-shiyangx.he@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|DS7PR11MB7929:EE_ x-ms-office365-filtering-correlation-id: aadeb66a-c03e-4ef1-b362-08dbbe8a459e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: D2oDFPVAs7gS9Rr1wNMPtc3ZsMXdK+BX5DVUsh2AjBhVa2lHumG74GpwR8IvId/5ofCkRWEobn6Pp4S3hmagX/v9jHFBNLvctqJ+5zilt4IT42rqS6d+JsMl/j69W2zw3B69zpXqN7RUpQdJJ5SpFbHGjyEcZR1j0B4o7xFQMwnTdzH+J+ujZkw+JARYRScbq8l0sOq9t1Nfsxrlej4Gz3Au6dUqKKeLqBAbacwp8JHZ7sgywF1rArAAnFdMwBybcnB1+N4OcihcrqwZTov7uD+ONCBPVbveBFm3ZQphHu+22Fq8/ijB2fA6qFZyyC33CSb1TyZvgW4e3wjlZNANTP0A44gMQ+6a5ae9m8Uo9yEjeTQe7lWUlUEVOVQ5nPYLa1guq6bCnLjFsprgy9Hvuay4fOpWsiCwgYMhCsnq7KhIZIemaaACXe5yB7RFBKhF+Vvah6BMi5nE5G6961AujVqaQO5O/Rm7M5WqAetMIrfBXh9syjPD+ZZNiAzFmoKrqiPCpJBR3KUN8w1Xw72Snu2krAslXS/kpKYfgJsn9nOdW8ReWx38QxIPgseD6emhB4AV7c3Pmg1e9mKrH0brbuvE+yNMl/q4rrDkizYCjU4EnRHsLpSZZlABzZb2SSYV x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(366004)(396003)(39860400002)(136003)(230922051799003)(451199024)(1800799009)(186009)(38070700005)(478600001)(83380400001)(38100700002)(107886003)(2906002)(6636002)(110136005)(316002)(64756008)(54906003)(26005)(66446008)(66476007)(66556008)(66946007)(76116006)(55016003)(66899024)(41300700001)(52536014)(9686003)(4326008)(71200400001)(53546011)(6506007)(5660300002)(122000001)(7696005)(82960400001)(33656002)(86362001)(8676002)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Dq+X13Mh5hj2spxhvfZbAC/Wj4GeY82OpvGlOFkVb2tSW8ofCft2fyTjtKcT?= =?us-ascii?Q?gcrWdf5s9jklf+0+30fYM1AMQv9/edgbn0w6Nh6Rl0KijR9IUj23uKPN7Q3H?= =?us-ascii?Q?UvBDo9jfDSxrZIzUY6wmKMyO/I+ogTk/SUU70XmhjJbioZlRIQ81Im8TWT++?= =?us-ascii?Q?lHR233U4zH86fNl/d0bI0D/7ZlW7WPLtoD2QUnV5rMd2iO36mGJ1FKp14Vvc?= =?us-ascii?Q?FMGfjIo0JM1lljRlG9IRG8x7RHbduMvninq6bNXaKC0saDR+z58cnNQYwA5E?= =?us-ascii?Q?PX/0jHubl7oHZJxmlbqL+tc5NBpBoeubsIn0dP8x5w1NtCubY7v/+ev8/GQP?= =?us-ascii?Q?uDfBr/87gS++hceyzPhhsNVYXVXFg+RZnFCS0Z3zH5ZxieWw8DyPGHMe5dPI?= =?us-ascii?Q?CEQ4gi+tUWi3hKIfmlt1+VaB8Anm/ke7G25BaaaoCNBcr7xuYJsaEafu8kla?= =?us-ascii?Q?XhKYCChcTWp9kJNMF85nnDRef+fowCpWqssgnFsqC+79k3cn72lktlTG/KEe?= =?us-ascii?Q?SbNUtXf7LlxSEEIfnyVVOgkQzlD2rztT9aJXR9bolaeo8oQjJIZpD3sRIbOg?= =?us-ascii?Q?W1HjZIdjk2tlDE5SMIfcU/shWaaVwcO2A+fEPppO32tlfz7HcQ89UfPtnPnN?= =?us-ascii?Q?lTgjaEhX2xyoArYHMXhdUEQFxvBXwv0sxRrHRkWuD0TSxVimg2YHjEeiTg/D?= =?us-ascii?Q?vdI8JfY1WYTgYJkPh6iDL7BSk7qpluQT7DNvl3YMaxDBUv633uqgBYppWmiM?= =?us-ascii?Q?BQDN51FBvq6Pqmbtt2tKeE6qlTba+WSNP5MYoRkx8T+hOYV6wlLbDvLdJdWs?= =?us-ascii?Q?axKqVqrmsXTVYHDHWTfZ6VTPyQErMo6R4BJkjdJ7D23gGa4Z2jP9ramZNcON?= =?us-ascii?Q?DvqH4tU1ey+kH8jctNTUZDGABEe8M8pJtAP3GZT8Me/nkfbCTNrPW0IPex+X?= =?us-ascii?Q?jEqNGOP0ibZHD5dUkO1LJ2jR+p3QpHm6oAeOQmi0N2CUO905Ik4XGhkzmhIR?= =?us-ascii?Q?D6IjNaqLS6aJF92Rff14Tmoww8azV2HZhRC5Od8H1oCOQF7ZDX8nlbU3uGFH?= =?us-ascii?Q?ORNjWHhHrUXMkPOnh2MWBGO7Pk6LTFc0LFCFTSl/p5z6CPsTS/36U1fAdBwD?= =?us-ascii?Q?LRAixrmKsy7GAUDs8ocZJCRgz72sfChlrmfE2X2PEyuuFbcUzp6AstXkWQPa?= =?us-ascii?Q?jCWc5rH0y04oqG634mtJkJkOZEHwpH5T20bWeFMpFxyETPbHHpadD/H0Iyiz?= =?us-ascii?Q?XKNzk4Gqd9LbL7vxdRswHh2JtwuNn0hTlzC0PgEbU/wy1cfQOaYO9SA4IkEC?= =?us-ascii?Q?KU722J9oEGt/JeF0jlPgiMZkgcbhyjvo202b3ikx8gQCvbLMaDGID2BC3VKu?= =?us-ascii?Q?Kbl76dKselDD/X4WxCPiQXf+9UQInrb3dRKbdT3qwFXKfuzty8HiBFhUGP+J?= =?us-ascii?Q?KXwowGWTgdh/gFhjlw6eHpdZAsDJfk+HI4ECentrZxvyUQAkHYKwCib0meic?= =?us-ascii?Q?IX+lHGjgR1Ula6sr9ELmD94taGsAFqyR1v4PuZ25Bk1dlExWjoPqvX4OIYeX?= =?us-ascii?Q?m2UqIYacidayzAcrCNwUTmsvNuperHQfWHG7h9BX?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aadeb66a-c03e-4ef1-b362-08dbbe8a459e X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2023 12:15:28.5712 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HbZ6t7D3Jmf5f9bJJ2FAaKIB31Gbq5wZnTiuHYOElZHvO3tWSCgPwiLVRzd3yx2QuTYRUysBbySLrvuRwuERdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7929 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Bruce Richardson > Sent: Tuesday, September 26, 2023 3:49 PM > To: He, ShiyangX > Cc: dev@dpdk.org; Zhou, YidingX ; Wang, Liang- > min ; Su, Simei ; Wu, > Wenjun1 ; Zhang, Yuying > ; Xing, Beilei ; Yang, > Qiming ; Wu, Jingjing > Subject: Re: [PATCH v3] net/iavf: add devargs to enable vf auto-reset >=20 > On Fri, Sep 15, 2023 at 01:02:49PM +0000, Shiyang He wrote: > > Originally, the iavf PMD does not perform special actions when it > > receives a PF-to-VF reset event, resulting in vf being offline and > > unavailable. > > > > This patch enables vf auto-reset by setting 'watchdog_period' devargs > > to true. The iavf PMD will perform an automatic reset to bring the vf > > back online when it receives a PF-to-VF event. > > > > v2: handling reset by event handler > > v3: change reset process > > > > Signed-off-by: Shiyang He > > Signed-off-by: Liang-Min Larry Wang > > --- > > doc/guides/nics/intel_vf.rst | 3 + > > doc/guides/rel_notes/release_23_11.rst | 3 + > > drivers/net/iavf/iavf.h | 7 +++ > > drivers/net/iavf/iavf_ethdev.c | 86 +++++++++++++++++++++++--- > > drivers/net/iavf/iavf_rxtx.c | 52 ++++++++++------ > > drivers/net/iavf/iavf_vchnl.c | 11 +++- > > 6 files changed, 135 insertions(+), 27 deletions(-) > > > > diff --git a/doc/guides/nics/intel_vf.rst > > b/doc/guides/nics/intel_vf.rst index d365dbc185..c0acd2a7f5 100644 > > --- a/doc/guides/nics/intel_vf.rst > > +++ b/doc/guides/nics/intel_vf.rst > > @@ -101,6 +101,9 @@ For more detail on SR-IOV, please refer to the > following documents: > > Set ``devargs`` parameter ``watchdog_period`` to adjust the watchd= og > period in microseconds, or set it to 0 to disable the watchdog, > > for example, ``-a 18:01.0,watchdog_period=3D5000`` or ``-a > 18:01.0,watchdog_period=3D0``. > > > > + Enable vf auto-reset by setting the ``devargs`` parameter like ``-= a > 18:01.0,enable_auto_reset=3D1`` when IAVF is backed > > + by an Intel(r) E810 device or an Intel(r) 700 Series Ethernet devi= ce. > > + >=20 > Why do we need a devargs for this? If the VF is unavailable - as you ment= ion > in the commit log above - should this behaviour not always be the case > without the user having to ask? Ideally it does not need, but with below considerations: 1. Not break existing scenario, which still assume some application will ca= ll dev_reset /dev_configure/ queue_setup / ... after receive RTE_ETH_EVENT= _INTR_RESET event to recover the VF manually, the devargs make sure applica= tion be aware of this new feature and will not call rte_eth_dev_reset which= will fail now. 2. intent to ensure a smoother transition, in case some corner case issues = evaded our validation, keeping this devargs provides us with the flexibilit= y to remove it once we determine that the implementation is stable enough. = =20 >=20 > /Bruce