From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Markus Theil <markus.theil@tu-ilmenau.de>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
David MacDougal <david.macdougal@gmail.com>
Subject: RE: [PATCH] net/ice: fix module EEPROM read
Date: Tue, 18 Oct 2022 04:09:56 +0000 [thread overview]
Message-ID: <DM4PR11MB59946BC82452694158DBF9ABD7289@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221014053614.9543-1-markus.theil@tu-ilmenau.de>
> -----Original Message-----
> From: Markus Theil <markus.theil@tu-ilmenau.de>
> Sent: Friday, October 14, 2022 1:36 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; David MacDougal <david.macdougal@gmail.com>
> Subject: [PATCH] net/ice: fix module EEPROM read
>
> From: David MacDougal <david.macdougal@gmail.com>
>
> Fix issue with final word being dropped when retrieving module EEPROM
> data for the ice driver.
>
> Take for simplicity the case when `info->offset` is zero and `info->len` is
> equal to `SFF_READ_BLOCK_SIZE`. In this case, memcpy would not be called
> despite there presumably being room in the buffer (as we have requested 8
> bytes of data and the memcpy would write precisely 8 bytes). The same edge
> case will be hit on the final iteration of the for loop whenever a multiple of 8
> bytes is requested, as the final word will not be written to the data buffer.
>
Added:
Fixes: 52569256583a ("net/ice: support module EEPROM")
Cc: stable@dpdk.org
> Signed-off-by: David MacDougal <david.macdougal@gmail.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2022-10-18 4:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 5:36 Markus Theil
2022-10-18 4:09 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB59946BC82452694158DBF9ABD7289@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=david.macdougal@gmail.com \
--cc=dev@dpdk.org \
--cc=markus.theil@tu-ilmenau.de \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).