From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 563DFA0560; Tue, 18 Oct 2022 06:10:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4568C4021D; Tue, 18 Oct 2022 06:10:08 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id A01DA40143 for ; Tue, 18 Oct 2022 06:10:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666066206; x=1697602206; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=l+FjBoY47gr/4wd1SlLjJxy4uhi6QFtva77hwsxYBcc=; b=jLszQbmnXy5oQ3qLPpJiazzjNYvwvso81iIdEtMz4s55ZQX3q7ByOaFl DpKUOINjr/4LyTqrNuvbVEGtoT7fWQHUFZ9MHwY2KPGeiwxVEf6Ij2+MK VOWqcsMeKmFK8eQw0FTVnOdMvQazMWMy80MUupmttyQftddam+LRmQQaM AEyYnzR9DVBtNyUVlWPTDpoNfFXtq1evOcF5Ly/Uitu+icFZu3UCsrdmM K2thhhE455MMyEMj8SxWGWFb58tQFs5NMGa1hf3BdanOO8aftOtgZZtNL nDitccm+6n1V75ymSlbvm4IFlnzHKoNG3rkxAUvT8ApnRduFOwZiyQSbS g==; X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="307075901" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="307075901" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 21:10:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="753877399" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="753877399" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 17 Oct 2022 21:10:05 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 21:10:05 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 21:10:04 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 17 Oct 2022 21:10:04 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 17 Oct 2022 21:10:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OCBxx5qTDDULPcXJc+ipM+zQzcq9Iqe/oJ/RapzDa2LXwY8JBc1qVKte762zOk5k363foYAu9XeHWD/RKfNF2maRQfFBECKk11ZlUjPCX9o6zDz83m69DuwqCDb4xH5Vd6okeYLVHokczAOiFakalP9KZi1GWeV2XiqShRdugKlLZlf9rbXk/Uhsb3PAS2lgUCEf0aySTZ/ySAmAbW99MkiPBFXNC5xAGy5BHTmUpts3yfkauuc0h8yTE9ZOonLZkuwjXmy33BVBU3OUcmk3VXk545eETQ0qSGS/eejKdDLTsGKDo0UMx8igtWkES2nyme9cohrheAlzED3PKe/chA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l+FjBoY47gr/4wd1SlLjJxy4uhi6QFtva77hwsxYBcc=; b=Zr1nUvjGTVC4oM+RH1E4na7cCnBMZ/EZGXvVHGn2dmPawgJeQOakDNvqsl7Yf8ULxpMw1kt2xb7shKC6h7ppb9jqF/atB448vmuYaG4WK+bVosbDjre4vTAcu4pHrp1NI+vhtMMo2pDxqjzIpJLNYM8lkoYf1WlCTeFrC6fiulxMIB8eyarRFa6Fbj0qt6ksf2zUOyqk8wNxrkxtsWzgBe16CRBU6FHj/wQ1/RlPh65wEmtN3kGn7TVIMRRyaIicIzSZ3Ibhpy0OYI7dEr4AKymTmhT2UCkaBu97WUMAZ+nYjDqzX7M/InRlseizcHSqaTyU+L2nXTcWsfRnixlRVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by IA1PR11MB6267.namprd11.prod.outlook.com (2603:10b6:208:3e5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Tue, 18 Oct 2022 04:09:56 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::6fc4:1ff0:a5db:6546]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::6fc4:1ff0:a5db:6546%3]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022 04:09:56 +0000 From: "Zhang, Qi Z" To: Markus Theil , "dev@dpdk.org" CC: "Yang, Qiming" , David MacDougal Subject: RE: [PATCH] net/ice: fix module EEPROM read Thread-Topic: [PATCH] net/ice: fix module EEPROM read Thread-Index: AQHY348Kl459wxzjHky/h9Xl6dX92a4Tjv/g Date: Tue, 18 Oct 2022 04:09:56 +0000 Message-ID: References: <20221014053614.9543-1-markus.theil@tu-ilmenau.de> In-Reply-To: <20221014053614.9543-1-markus.theil@tu-ilmenau.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|IA1PR11MB6267:EE_ x-ms-office365-filtering-correlation-id: c6c37e1f-e92b-4b01-55a0-08dab0be9dad x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lla6ginUnfz5yLEJjRQr/yFnCUMIFiddIO/iY9Eox/NVLGPtFzgkSSk7ePYiT+4eDSbBiNGLmqBPmyHkvkbcyQ6ughmf32xPObuWn+BmPpNyQN7J202IoRAmLy17GmeHwEAWecD+hbdohcrUJRFb1v04DnjGA6rm7sv885k8R19W16Sh9zmFMiRxi939FJfcsjQuCbwn6VHqGB0RL8MQD5Jna8O1treCW6WX5x20A+LdeDz4LTBDKPLeWIKmv6phIZYzzbHuz4VAgzIaxZZcuHOez4bLePcQh3wQwTVjnjU+QM/8BmxZM4ysZNzntf4oN1BmBkFEpYj51GsVDgKQtkPltoR3ubWTkzJvvSbthx+kOTacSzR3HnkNdwyxCMDbYcVG7SLHt8IJLm6d1gVB7RxOlIpnV4RXYLcjgkHWVvRZLIxXkBKJi3LLQb8lu9cg3Kaj/cA6SVdahzFlT/iqVegOwIYXPZOG5Hf+zYOkZA/fxJeXsvBceOjuemeLZCTJC4Xrd1hyx9dg1vYPgXAZsmjuSZYpoGULTpKXiTkMeIt58nMDqdUN7YlWNB9dELbKtivUrzypuzQmDrZfTtYG10SbiXp5ujshLe1UjWCpoj2d3cVZ0Cq8c0K1Y0hy90JXkGcQrb3VZiS0HTb1tfai/UhU0uPgM/w/Akp0V8ooZyfbE3bkDjQohfK0ORGhFSQU5Gfs5GRXqrRGQ+aVYPWQYpKEZQr1TkzrzoBgc+xQ6+b6KhuDFh32XY1dqJTfmFMLEhI98Il/lX0alWBHNY68Cw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(376002)(396003)(346002)(136003)(39860400002)(451199015)(71200400001)(186003)(38070700005)(83380400001)(38100700002)(86362001)(82960400001)(122000001)(5660300002)(2906002)(4744005)(41300700001)(4326008)(8936002)(55016003)(52536014)(8676002)(64756008)(478600001)(9686003)(7696005)(26005)(6506007)(53546011)(316002)(76116006)(66446008)(66476007)(110136005)(66946007)(66556008)(54906003)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xDXsJE8lyjyb4mwtdHRI2FzdwZYMLcXk7XSKRt1a+lqyvZ2gRl/2aeG2LuCL?= =?us-ascii?Q?Gdw2K3P3lbd2CZF8xwaTWeEPpDclRVbFwaImzoBmPY57nkEqbJdp7/i1hEqb?= =?us-ascii?Q?6VjyA8r9qtsR8L6Xn/nIvqbNsUzgtCCBpzndUcPUz+JNgt07WROyrFkxxXAb?= =?us-ascii?Q?v8Qu/oF63c1zGR/FxFBLbu77kaSLMyxXo+Y9USyDhvLGe83Tcp4MY3fLQySY?= =?us-ascii?Q?H5ONoJJxlwmMcs3psm7+I8OlVnKknYZ2Zdln4EZPC8MxAml0XE10bi5Q901I?= =?us-ascii?Q?9IKUWUxZH9r3JNBpnMwIr57rktUjj8lKgcMqLUuFw/uImkbNRfDIcnByIw9e?= =?us-ascii?Q?WjVhDZCYAA8rh7UExB1YJu0rK26UuasZ4Xa5SIhhB3Pbzf3qOFdmZ14wTdAs?= =?us-ascii?Q?vcovrTXi/8KYhgiYWMRvR8+1f/OGDZ8h2JM/NDQO8+ZQJp8LiKbu3bZtdbWB?= =?us-ascii?Q?wTjSg2bPlaCID4PwcTj0gR2etTpJdmBE0f8gPzdVrJXX2GC99TSqMiirUxXk?= =?us-ascii?Q?QtAB/jfHhgrOMBiuBxPe9L/RhsBoe1eFKyEBJOB0ogZYjNdLUVB4kCGcDwgC?= =?us-ascii?Q?hwpzeVUWNSvZ8PrqoO64FV4tPY4fpbqug/RxSPnW6onplw/IAKDJZFg288NJ?= =?us-ascii?Q?AHIO23xrFEFOjKVDeWHGwWmLr7/WnILK2BDv1+O1DHTfIqtG+bw1vX/+kW+q?= =?us-ascii?Q?fuFtYKZGx873HZul3hUxZR7xC81fCHolQhDvZ0+02tFYZUptp9syIDJtOFc+?= =?us-ascii?Q?e5GjCtf3JkD0SQjxiJ7J6OZTW5ACx4W7cogpzzSom2mgcCmLxHDeBatgrcZk?= =?us-ascii?Q?eoryS0vb5rNl4mqEqRcB7VTRK6MeRWDTHeFXh1bLuD/5eE67mcgeDDskUazX?= =?us-ascii?Q?6RarBy1FYww6SXrDQYisoZWEAiFTVciiPw/aTQ2RhUPnywtNVnj53hDVP7xo?= =?us-ascii?Q?HXxCql8dHdlpmiatTgKHYY5ueCcCIGCdCDa5npNi9sPjArZIiSR/I32q95gm?= =?us-ascii?Q?IBFS/BtKqrg3EHcysEJKTAJDe55MxZxdIYpsRjRIdKY96xylK3aGe0r+0vuj?= =?us-ascii?Q?4v/58x153cZNWfjMRu5SkM+ouA5RiNx685V/62nDQdBaDud4T4U+Z+zQFNF6?= =?us-ascii?Q?H4mV5bAiYIdRbL+V/nK+SYrKrUEFm16nI/pRb25irDhypeyF7i/SmP83dJzn?= =?us-ascii?Q?Jjz3OhrrY5CNweJxUa1bS6Xr756qClAIOiDu5UZ9uItV9JfkGAblyyZDNb77?= =?us-ascii?Q?8E/lifiVEKCGXI+/cfkaKJ5kIoLTBdtlmnHA41OU5zWBM75zbLKHrTQNxyBm?= =?us-ascii?Q?JedHQ55j0n0r1Xsyoc4t8BvUMpQgWjbaYKKr3++vBniDby1q8C656rPVvFVA?= =?us-ascii?Q?KLCvsHk9Df+Y+yfatc0y+405gP1ZUSDCMJ6TZ+4ryjK3aVBNuBGmpvlLKf2K?= =?us-ascii?Q?KtLGJZqaEmSj02YLzz6GaGBNrh8QFfUTsqemRc4vaTcU4jwBJj1uayJtqqpc?= =?us-ascii?Q?Z/1QCKK/BgkFTWTh8bvVf36b4pHRpCcANKw8RTR8/f28YnutoKrJ2evQXYqX?= =?us-ascii?Q?CHZ/msRuk3kkJRj/l9GMqh8He+ZRJYnpBdHmB45s?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6c37e1f-e92b-4b01-55a0-08dab0be9dad X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2022 04:09:56.1691 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SsLQYlCxlrxE5F6hLNNnAEq4qBqGQBtzafJ8b43Ek+iJGC9dBxIjgV1pm9VWhn+dtLVKqclU0ZIEnDq9BSPR8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6267 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Markus Theil > Sent: Friday, October 14, 2022 1:36 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; David MacDougal > Subject: [PATCH] net/ice: fix module EEPROM read >=20 > From: David MacDougal >=20 > Fix issue with final word being dropped when retrieving module EEPROM > data for the ice driver. >=20 > Take for simplicity the case when `info->offset` is zero and `info->len` = is > equal to `SFF_READ_BLOCK_SIZE`. In this case, memcpy would not be called > despite there presumably being room in the buffer (as we have requested 8 > bytes of data and the memcpy would write precisely 8 bytes). The same edg= e > case will be hit on the final iteration of the for loop whenever a multip= le of 8 > bytes is requested, as the final word will not be written to the data buf= fer. >=20 Added: Fixes: 52569256583a ("net/ice: support module EEPROM") Cc: stable@dpdk.org > Signed-off-by: David MacDougal Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi