From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BC6EA034C; Tue, 30 Aug 2022 13:17:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 62F9740F18; Tue, 30 Aug 2022 13:17:25 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 00B9040F17 for ; Tue, 30 Aug 2022 13:17:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661858244; x=1693394244; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=njNVgHXTOMfCOB1Sa2xf0EjJGdlq7Klx6UJKgch0pSI=; b=lodXE5CXgP5LR9OonU6eKxt0+F8riXCxsiX+3lvqiXeeffB5W69ZtIT0 qMjFoijSqQqgt6EDDI4gB8YVE//fN4sSbgQnJR/Q96UeOugIB2oQNjeSb 8FtqbYs5VrQdAQEdJEZDsLYjg0BfA4YbqZNF66pyHS5QKnUp8zakXrQtr lU0Y7RlXddB1Xr+OpqNk0qQ7gYzXZKOJ4vpKGLcf1XgStBNu7L8msuui9 rsgauqRgLrv5NHleuFoDGHMYStcQskDTi9R8nZ68BUY9sEdBnkV6c433T eqvlL+2NVH4z0utxhmvBsWvDYBi5q+4Cf7P4Wp6UPm6mV0hj6qoIkZbqH A==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="295929107" X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="295929107" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 04:17:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="753992551" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 30 Aug 2022 04:17:22 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 30 Aug 2022 04:17:22 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 30 Aug 2022 04:17:22 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 30 Aug 2022 04:17:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PY+m+WNiD7MMJVISCqN9yBED3cey6xQKlMYLfGISKySWoXKd+4kbMB5/1uGhG8TjkNvvTV7FgAnvvNmMM9lUGKkEigGUsy+pNDAbJxGT6qqTRa3btVSExCaMYKd7OUeKZuG5WUcFEg6jKWU9WKQin6ejk3q8gvZlm5pO6I6fkZaYXBXEUNE3xW/xrXknYbdfwG6sai9jpR5O5xhXIUr331Y8i7dxulb1jVeyo73B1VtN6M8G/8dvwTK8pyU+jPOn0f8/e0xTVC4TZoX86h+cnDp8BO5uRXx1xmRmvrWm7IgjvbT+ujVtZGW+ccdEEKA0E3vooB5wGdrHksC6f141IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O5clqNw6g/uZmBIGxliqwvyIneHAy3DJmcgJ9c5beEY=; b=RWtPFatmq2TxZLagVE+H5ktGui/6O12SHZvipn1UK2mViPHBhRTvLHN99x0eRRkgb2S8IMxgX5Rd3N+f38vZWrn2ivekPN1Ys9U1fMJpBnwSghbI6EXR7M0q8fwNOigGYGc5B+Ly2mhdaGJU4n81EKyCR5MkVcz7L9SM7ag2dIRTpe9KnQzmH5KKmqF6S/qv2ewcQL4PAgZ5pkGTbgGSaojgymRPLyOcYSfOZa8Xf6pD2fDkfefYeKIkn9da4Ze6C7ZGdQubmw8FaFemBwoNBdXdmum8D/drZJjkNk0EE+2vk3KBGdbh95Tes41vucnkvMgkkUCXpaVrjaVZQ0cR/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DM4PR11MB5972.namprd11.prod.outlook.com (2603:10b6:8:5f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Tue, 30 Aug 2022 11:17:20 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::d94c:1798:9e3b:804e]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::d94c:1798:9e3b:804e%7]) with mapi id 15.20.5566.021; Tue, 30 Aug 2022 11:17:20 +0000 From: "Zhang, Qi Z" To: IOTG DPDK Ref App , "dev@dpdk.org" Subject: RE: [PATCH] IGC: Remove I225_I_PHY_ID checking Thread-Topic: [PATCH] IGC: Remove I225_I_PHY_ID checking Thread-Index: AQHYu42OWaokG1UUC0ae20RnBouWbq3HS9VQ Date: Tue, 30 Aug 2022 11:17:20 +0000 Message-ID: References: <20220829081436.29945-1-iotg.dpdk.ref.app@intel.com> In-Reply-To: <20220829081436.29945-1-iotg.dpdk.ref.app@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b9f5776a-9427-4dca-38a9-08da8a7934da x-ms-traffictypediagnostic: DM4PR11MB5972:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fK5FgsgGZA9NClAV0/n8B+6fyIDS0ooqAB15sh3md03AwiGRaEH1xW6ifxglUopGyKzw+FWVdM0MF9BxvRrSQmlD9ZtMqprgtAR3Hm7LEjhcpNVVlzUxK2CEgyZc142LAr4iLLJMtvLqMpO6rwuSKP3n3XK3wzXr+nzS67MMmBmFszVUaOXJwMrismr09ojD7rjOR9oSkIr+QK7d1ED3Zky9l8k3rOLnw8LtQdZAyxNLd0ncwxxykN7ghbdU/BdNkzaWpDCqF/323wD5eF3hqOfhTJIChwP0WYJD7K9pXvJejOjlGjwYpQGQ4Ql427LA3iEP/8obNRuftJnLyy4V2XyPq2brxn3Htjdu5gep6uDgEeOnccKUaN62fGf6eoTvw2jJReyCK7B5ZZoPMBt9s+yHU1mozH5etkulDJ7DJmQoyvfa+bMzffnpnNKzP+IISLpAf6FiUJ+JrBZeR2tt6zzn0eGHqA4n1SY6E1XS4Yp/5fFGumSCVktTsV0VwED0djv3vlkSecs347pt0hg6JBAspqgJOiFkF0vdmMoapBzDUpXctSJ3AaIS3ENIi4TmKR8SVERYYyRQ0H5e308LGUNJ9zYuh+r86Exvkmzhd3mpJwkTrvvQzy6VvMkxmt4Mryy+fjAuujpznGhJ2gBwPM3Et9r8kFh5cdWhRxh/Sgp8NWrgSYfx3zOcLiNMf/e26+lOZFRg9WxaGe5ZQV5NdYdkUN610KL2eFygBQXFdXdVgj2KMjvDO0PYXOMSDYzcU8467CKl+TOokKVThxZYuw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(366004)(39860400002)(376002)(346002)(396003)(110136005)(64756008)(8676002)(86362001)(76116006)(66556008)(66476007)(66946007)(71200400001)(316002)(66446008)(478600001)(5660300002)(82960400001)(52536014)(8936002)(38070700005)(41300700001)(53546011)(7696005)(6506007)(122000001)(26005)(38100700002)(2906002)(83380400001)(55016003)(186003)(9686003)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lqyJRi4DeeKnWQgymAT9Nw61TAdfTNXYIJOmVCYZUDKhl+WFFCfTqpS4XE18?= =?us-ascii?Q?lRIf8ngrZMyiZm3jDYk7rJrM2rNyQdvDC75nHdov3PrnsNa5Kc2hI231vkkZ?= =?us-ascii?Q?abIBN+fhOjDTm+eZ/LKZcgPzgy2ebbGKKYBWeOy+zrGcLRnNmYT5GJU7UhU1?= =?us-ascii?Q?wLJbMcJNi67SqXuKv47NFYEh1uCzVuWo0Qntsu0RKmKiqDwcsMKvcnz808Dg?= =?us-ascii?Q?UKfq73k34BndhknFFYCMcH0Xs9YxnIxpNxwNOsfq8VDQWkk7WvdsMvvcBVQ7?= =?us-ascii?Q?WDJDbB1CBvFTqA8A8AdSFiAljezvHFWGj2MLVy51aNGD40DBymAyADFlnq1U?= =?us-ascii?Q?ceHZ5ENqre0lmgjWTXpaN3WCNgnfyG9rxlW8dDlRY/BbOvn/ZGA43bQdcTe4?= =?us-ascii?Q?xiwqYw/BiNVdH4ou7SYXT+x4n+7/nCg3Vuf1jbAulP9dfhZXoVw1OLFXIqjc?= =?us-ascii?Q?Xu9atOlQQG0ue+ronrLEvfQZcTUsf89q6k/QUZftAACH1xQ31wRw1CCEDctF?= =?us-ascii?Q?Mts4+zACAWxm00YRh1oLTe5qSEMmcqoA4pQXmuFaZuHqihmxbaYGVVoH6olH?= =?us-ascii?Q?sI5aZnjUcUpc1FISrxsdJhnpOGOImAbJfRs2IQXuMaLRYudBt8qr6cdbf7N7?= =?us-ascii?Q?3xnMFn49MSFrNlZ0eGAp/3yfIzHxOC6vHNIeb7zJvauRSdKNdCJuiyBW97Bw?= =?us-ascii?Q?NKvra7HhHzbIzZbYY3EpNITbYR6Q+EjbMeDRFvEJ5wDcfS3lTQcSfyOfSJKZ?= =?us-ascii?Q?DD0Uy1d5MpR2FlJyb29EUCom94OLJpiafWLZvIV7u8MASxIoBdDByIPRAPCD?= =?us-ascii?Q?RitW7ihM/nRkykQEIz9jrqzCnnCZzacPugaeDJQIgwuE2Gpv36vWzuy0RQfw?= =?us-ascii?Q?j2dKEhlJLJhK9000X7WnQKM8sfgy1l63x7TKjAkgLdYnwwVwIp1hwvDtRNlz?= =?us-ascii?Q?3SIhxEM56NjIqV6F/ZxValJUzbcew8VDakCHd+QQm+cXdValj6Vf4bmEcm6l?= =?us-ascii?Q?EWgSxN+6mLCVxqHT1/e9+LTvhNonLTX+ha5Q+XM6jkQT/AR/DpIP9s4ctqyf?= =?us-ascii?Q?PgCdTK0ABGcCstrj96BUveK774dJoKDdaZCb7oF43AEPOd4zaDPpPO3kk5zP?= =?us-ascii?Q?U1obhJzEHI0hqLQ7H/dpBpg4U3lX6ijb6EAYAXGxnUDTjyxA6h8lH2mpvMH7?= =?us-ascii?Q?PQ/qI/uZn+NOYJIr5JOZh+iL18uYdnhMclJsq5bCIDObbGyagq11q5RAzuMX?= =?us-ascii?Q?IazzmF6WDRRX+709LjYUFuU52lVqHXbGDEfQovzIWz4EbucSZSMXQxjPVuw7?= =?us-ascii?Q?5mES74t/Fl8nC4D+0wW5eYR77h74at8+ot4u37shaCejHOiGrXpi3V2PqAg8?= =?us-ascii?Q?FWiEYjlfjhy34KbzjH2yQAgHbhTNrOEW+pcnocc8Zui8H/GfVv/TH8Xw5YM9?= =?us-ascii?Q?2vN/fN7BlrRn5REDiMpnOnoIYrbVpzzzjRJemmVCMh1GsKgVCXBefVjKiWEn?= =?us-ascii?Q?GTVC4v3m8zyfneYj0IeS4bNTLTjJWEZ5hLeq+XFN1ySzFC8Wn8onE+kGgiaD?= =?us-ascii?Q?H9UIkiHIGjV+79dNiNerxks5drVJX6G4yfF7FMFg?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9f5776a-9427-4dca-38a9-08da8a7934da X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2022 11:17:20.8103 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zC02ve0Y1KlZpoF47dhEb/DuImaAWL+jqWtTT3GsWAorysQvTIOm39AQHk9awyxi/DfjzjsNp6yPZT+oJvYKXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5972 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: iotg.dpdk.ref.app@intel.com > Sent: Monday, August 29, 2022 4:15 PM > To: dev@dpdk.org > Subject: [PATCH] IGC: Remove I225_I_PHY_ID checking >=20 > From: NSWE SWS DPDK Dev >=20 > i225 devices have only one PHY vendor. There is unnecessary to check > _I_PHY_ID during the link establishment and auto-negotiation process, the > checking also caused devices like i225-IT failed. This patch is to remove= the > mentioned unnecessary checking. >=20 > Cc: stable@dpdk.org > Signed-off-by: NSWE SWS DPDK Dev Is this the expected author name? > --- > drivers/net/igc/base/igc_api.c | 1 + > drivers/net/igc/base/igc_hw.h | 1 + > drivers/net/igc/base/igc_i225.c | 15 ++------------- > drivers/net/igc/base/igc_phy.c | 6 ++---- > drivers/net/igc/igc_ethdev.c | 1 + > 5 files changed, 7 insertions(+), 17 deletions(-) >=20 > diff --git a/drivers/net/igc/base/igc_api.c b/drivers/net/igc/base/igc_ap= i.c > index 9b791dc082..c9fc9ed4b0 100644 > --- a/drivers/net/igc/base/igc_api.c > +++ b/drivers/net/igc/base/igc_api.c > @@ -886,6 +886,7 @@ s32 igc_set_mac_type(struct igc_hw *hw) > case IGC_DEV_ID_I225_V: > case IGC_DEV_ID_I225_K: > case IGC_DEV_ID_I225_I: > + case IGC_DEV_ID_I225_IT: > case IGC_DEV_ID_I220_V: > case IGC_DEV_ID_I225_BLANK_NVM: > case IGC_DEV_ID_I226_K: > diff --git a/drivers/net/igc/base/igc_hw.h b/drivers/net/igc/base/igc_hw.= h > index 707a1883b4..e919a11c02 100644 > --- a/drivers/net/igc/base/igc_hw.h > +++ b/drivers/net/igc/base/igc_hw.h > @@ -164,6 +164,7 @@ struct igc_hw; > #define IGC_DEV_ID_I225_V 0x15F3 > #define IGC_DEV_ID_I225_K 0x3100 > #define IGC_DEV_ID_I225_I 0x15F8 > +#define IGC_DEV_ID_I225_IT 0x0D9F The patch's commit log claims to remove something,=20 but in code it also add some new device ID, could you clarify why we need t= his or it should be in a separate patch?