From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6D8AA0540; Thu, 7 Jul 2022 09:13:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9026640A7B; Thu, 7 Jul 2022 09:13:15 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 8E5D1406B4 for ; Thu, 7 Jul 2022 09:13:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657177993; x=1688713993; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PieA7anGYR05RU7TkX4EQO7sW7KfvfMRGgVBv7/zoU4=; b=jvnqtrcyxmOJXepfgCeuwaBeSYIbCW3nQIF1877T7u12s4+p0ZdQMcko 5RR/PGJsJk+UbKvu0IbawPhk4fPJ+IsEb7P1Npv+gEKsI4goSpxrT7hEM YdEcb43X2dhd3rIicBXfW1umxMjMFk6GRQo5NzdcciZJ0EKvXBj+wZSCK FfgRGaAMxKw8V0mUQ8O/uMbOxqn0n8dIk31w22JnfScZppPw8SBLNfexJ W6QoGCPuBCeDeVQ5W3SFD4TkSsjLqVAmoyLE7ma1u2uRpg0LveNOeGIYS 9vKld0rGmrEE53ogA4/uhP1pIaCk2CjJkVR80EObGnLdA52xRB0ZwTdXv w==; X-IronPort-AV: E=McAfee;i="6400,9594,10400"; a="272744742" X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="272744742" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 00:13:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="770329240" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 07 Jul 2022 00:13:12 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 7 Jul 2022 00:13:12 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 7 Jul 2022 00:13:11 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 7 Jul 2022 00:13:11 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 7 Jul 2022 00:13:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hpZXuZgSin2I9ev4c+x/STcJnezJ7R0xfRNoEIlasCao5UrWKXeDZQeE7RybirJg7s1IKWIQzlO2JiNxESzCYHXoQwdDolARsa3cOcP9Nj/jZCZo1gzsZO3HTJTA8ItKKjp88XgqCaOEVZVO4ftbIgqk61/GJqwPCn9G2xdnaue7qjN5hPa3k2aHtNM5ZqAJJB2GpqHvbo8XF3NbHJuXZTnDi/TkhS3Js4nTUNc7rKqLeSE5Jb9bmqCd4A/bUSGRvpRpm3Lyctlsojv0fnPgm+2YlleBcSvGpNP9rq6tPtJxve3lk+e8EmpXO67lgMe2Z8duvOeYO8Ob754WHKQyPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bnk5BK9vcGhfGAwBJ5j9AqqZeGG17XOKoSsFRai0wRs=; b=A68AVdskedPiSuy1Izwbi6nwMCKt6hcakoh2SgW4ulVwnO1Hm2sPP4RBUe/eUH8N8cszb3iRvVY21K1VYJKBJ7ZhNUXN/LMzoZhQjE59f1UPTNdhvih7EgzdRvYei3hWbowzvsimYxKrR7DZyRRIuAlOCXg2IN8Y4YGDqkjlM+hwgDN3X4ImuDbIXhc8UOzPmSkvR+JawkepOMiYEMB6MSHguuujDsc6gc4qE+8swQJpT0rID97zQZlJgEAvB35e38Ywt5WaCQMPjCu5HR71/vxqdr67cfjjT3MEBJvbNvj9anCznSxfNfBOXNq+D7KPL3S/TtNcuwMFogxxf1VSmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DM6PR11MB2811.namprd11.prod.outlook.com (2603:10b6:5:c8::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Thu, 7 Jul 2022 07:13:09 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::644f:ecd2:47d0:aa6d]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::644f:ecd2:47d0:aa6d%3]) with mapi id 15.20.5373.018; Thu, 7 Jul 2022 07:13:09 +0000 From: "Zhang, Qi Z" To: "Yang, Qiming" , "Wu, WenxuanX" , "qiz.zhang@intel.com" , "Xing, Beilei" , "dev@dpdk.org" CC: "Zhou, YidingX" , "Su, Simei" , "stable@dpdk.com" Subject: RE: [PATCH v2] net/iavf: fix gtpu extension flow error Thread-Topic: [PATCH v2] net/iavf: fix gtpu extension flow error Thread-Index: AQHYkOSCQ0ZARR445Uaz+dBu8+hk9K1ye/cAgAAEI0A= Date: Thu, 7 Jul 2022 07:13:09 +0000 Message-ID: References: <20220705100949.1060962-1-wenxuanx.wu@intel.com> <20220706025626.1070737-1-wenxuanx.wu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 94bed099-fbaa-4549-e7b9-08da5fe825c9 x-ms-traffictypediagnostic: DM6PR11MB2811:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oyXLUDUsB/Jgd9wIwMyajkeGxecVvavCxpqbVGpD/FXLjvdJ6pL268nyRm3ngAUg2n7/MTsawl0zGack9eFQt4dgZ2puMhExxQsVyGcdnXqp223IZsYixVhf3MocL/H18kSz2LsAuMirILqMxfZrWBH/V2t9hS5aDXi0b7LbpKFfDwzlt99cH6jMKC/Wya0FObs7KQLRrhlRSamp0wXnLrnqE64CQHVQHxV3Vq/zraX7XIOp2a4y+bgsQJXWt/YH3ee1Tfw7AH0ki2CYIho1DBWtlijUl2QwJRUAD0A+xkifAtIlivsO4Kv2Z7sH7uq5VWL0BzUFe8wb+BOVvNc15iZPKCZJAQQQANdmmbxWFY5ge/pVa/M78SrBcXzGXcYmMMzDsxse2en6x8BpLg0EjkLGY5ABltgVySbc6NE05WzcE8P1L3g17RK6PAMIuddv3exz5B3HNf8cXKHem13whlnK73McQY0kQ3uN0MGWa2aold+GI8aTWAWp+MXXcb9At+P4pqLjD32APCAqd/TycAl8fYI2CYsV+77i92nhk/6CpOhgEfh0Nd0bAWYWduhC8NsjOvTQYkwapIKWbjzgvR/0M9EUOgclrFlghgMPh90qB/Yg1q2japvNiQgzMWzm6YQzValjgym7K+XTMYchliShD1Ewcfp5BH98zHVf536VjS6knolNExFJzfyPJRZ3fQYTqcFMq7vIerNBONXDoqvhxi7BbmbGFoYFHXPak/lG4ZAGgvYR4YinDG4zOdrNSMepBDTjK7aruBGFa3GnovE5IKsy3f8CfPVq2oO6S8NGy8DBh4o369iCl6RGR3UF x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(376002)(346002)(396003)(366004)(39860400002)(54906003)(110136005)(316002)(6506007)(186003)(9686003)(26005)(7696005)(71200400001)(478600001)(2906002)(86362001)(38100700002)(8936002)(66476007)(52536014)(8676002)(66556008)(66946007)(33656002)(76116006)(4326008)(122000001)(66446008)(82960400001)(83380400001)(41300700001)(5660300002)(55016003)(38070700005)(64756008)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/bZ7yUOIkyomjVpiwwObmAwjPihrfGglOKOtUZOlKNo8s+j4nYc1ssnQEKEO?= =?us-ascii?Q?Ax/233TTva0B+368Qq0ydkm6ZhhzJq7G0OFchZOkqgnDQnzCX5MNafyuM8Kq?= =?us-ascii?Q?0G2g5SyOh+O5MMX+g7Jwx7B3SeeAARkmCV7XVVqtWs5UNui+rwVfPzMJ/E1N?= =?us-ascii?Q?AKczoW1ox2z7ESCffpA17PBQqULAhssp6iynSAEgJR9cyF7DmcnZo6RGsVBB?= =?us-ascii?Q?PLv5iBKpG/olDxYborwz9BGfd242uH3wQja9EwHgXcA/yfihX7KuzwSF1LS0?= =?us-ascii?Q?aoBLvdP1fe8zC8w5A0DNHQgCUXQ3FpoQpylMHBKPrmrg0N5xFkGKI2Jo3Pg8?= =?us-ascii?Q?hPzWVQ29b6IxBfh494jN3CfZiyjbMlXl6cyHoY2LiGTf2Ta5nwCcj+5I6h7h?= =?us-ascii?Q?ik+zImiupmG4YywQDBQZQ0AgVl/pSsEz0HUc7EHJ5WKaYePgx1TCIkHP+xQK?= =?us-ascii?Q?ch3FmsTtc9yf5atj5JtqTT0ovkbItjJyuj5BlXCo4IURyBdX/vmmtq48Pf9Y?= =?us-ascii?Q?/eiU6ruUgOkH5+JPVa/JW+/Vw87NBBNZy4XeCX2rAL8pEyE47kE9IqDUWb32?= =?us-ascii?Q?yBMG8N+SP5Db8Ng9OTiIsmb+OdSChOMpWm/fmfghd4XUf1ZyISV/NpciUZ0a?= =?us-ascii?Q?qi/xVOB/AbO50ncqgW/ABu9zTQkFy0utuqOddXFfp2i68XCPRy0Lx8fCmn5k?= =?us-ascii?Q?OVU0Mt6Vy/eCH6V6dC9BO3tkrE358S9tDhTAijXRSJiuvdEBIYsDedeygzsj?= =?us-ascii?Q?jb66qAPeLgV8VjHmzVpbuxFVfcceTIcfX5a7whgH5zAx/4BpCAlx5a+eRcqD?= =?us-ascii?Q?h8lG2IOgr/GtMWAdV7m18OkMecO7aN+Abyjju8UyQW9HgdzK+tsVnfnFA+x0?= =?us-ascii?Q?UTU9FRiW1VJIc9BSZgoYVwdU86EIveYrua+w8slReKlWMeFp0Q7sPJXMaePy?= =?us-ascii?Q?Z0kPXoKGRdobqvdA8GGMZPuCT7MUxhxEnC2jxdpJEhXj1YDoV1shvFcBEu/V?= =?us-ascii?Q?dR7SJ5NSWDM9AFwOZCprxUhVOkfWxCWFlg6ZC2aXfFV3rqSIRCFhIf5eY6F7?= =?us-ascii?Q?pW2n5J+xFyWi+iMZbF+hMew3dGodG2utf0wb1a9zX9S5S19TuWUp4lvzgTBj?= =?us-ascii?Q?ih/F6M/hzOypF6NHdW4ZwDDWe+eNdydyTcDFSc+xIDMMqjlVADP85561EW2W?= =?us-ascii?Q?ufeDb5RsX/Ipgk9Zy/BsRRDp+yTV+kFrKdnJ6WP8M1ckQAPSD3+JECuHzXer?= =?us-ascii?Q?eIk1ofhmk4qwGPXqEIh/hOA5nQkE7DgSDO/pFZ7wQzUs6cADiLC5lwWtg6np?= =?us-ascii?Q?R660+9jTbALTo8MtXjkGIq3qQbHfgjbJ13JBXdtz0z9eOFfGNyw6IGdGn2EE?= =?us-ascii?Q?v17yj8CsrFsxO4YM2P2ZW1VZC+C0L3x2baf6o9B2NDXExGy6xhB/LFD0SY4i?= =?us-ascii?Q?npHyLr+Podt7x/qWrDYbZx6tV40prKsS9rll2jKVGxtoVzJ6tGbloZO38Yn4?= =?us-ascii?Q?5a7qdUiyUCcp4+pstjpH0mtodZQ3Wno1mk9x4810JonOODwZiQMsGeCO+bh0?= =?us-ascii?Q?uXL2qMH0ucrf1DuswmdM0Z5ibEJM5Iiq60BL0Kj9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94bed099-fbaa-4549-e7b9-08da5fe825c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 07:13:09.7230 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F3S5bE/LW6DAm939xAArle82gYGD52ALcpxEkTe00Q9cgeVUpJEyf6aT4L43SGeU7oot74BdgUiBoBHc2Lpl8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2811 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Yang, Qiming > Sent: Thursday, July 7, 2022 2:58 PM > To: Wu, WenxuanX ; qiz.zhang@intel.com; Xing, > Beilei ; dev@dpdk.org > Cc: Zhou, YidingX ; Su, Simei ; > stable@dpdk.com > Subject: RE: [PATCH v2] net/iavf: fix gtpu extension flow error >=20 > Hi, >=20 > > -----Original Message----- > > From: Wu, WenxuanX > > Sent: Wednesday, July 6, 2022 10:56 > > To: qiz.zhang@intel.com; Xing, Beilei ; > > dev@dpdk.org > > Cc: Yang, Qiming ; Zhou, YidingX > > ; Wu, WenxuanX ; Su, > > Simei ; stable@dpdk.com > > Subject: [PATCH v2] net/iavf: fix gtpu extension flow error > > > > From: Wenxuan Wu > > > > Due to the change of struct rte_gtp_psc_generic_hdr, kernel driver can > > not handle gtp_psc properly, we introduce a new structure to fix this > > gap between kernel driver and struct rte_gtp_psc_generic_hdr. > > > > Fixes: d5eb3e600d9e ("net/iavf: support flow director basic rule") > > Cc: simei.su@intel.com >=20 > This line should be delete before patch sent. >=20 > > Cc: stable@dpdk.com > > > > Signed-off-by: Wenxuan Wu > > > > --- > > v2: refine commit log and doc. > > --- > > drivers/net/iavf/iavf_fdir.c | 18 ++++++++++++++++-- > > 1 file changed, 16 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/iavf/iavf_fdir.c > > b/drivers/net/iavf/iavf_fdir.c index > > f236260502..4789d46ab2 100644 > > --- a/drivers/net/iavf/iavf_fdir.c > > +++ b/drivers/net/iavf/iavf_fdir.c > > @@ -1300,8 +1300,22 @@ iavf_fdir_parse_pattern(__rte_unused struct > > iavf_adapter *ad, > > > > GTPU_DWN, QFI); > > } > > > > - rte_memcpy(hdr->buffer, gtp_psc_spec, > > - sizeof(*gtp_psc_spec)); > > + /* > > + * New structure to fix gap between kernel > > driver and > > + * rte_gtp_psc_generic_hdr. > > + */ > > + struct iavf_gtp_psc_spec_hdr { > > + uint8_t len; > > + uint8_t qfi:6; > > + uint8_t type:4; > > + uint8_t next; > > + } psc; > > + psc.len =3D gtp_psc_spec->hdr.ext_hdr_len; > > + psc.qfi =3D gtp_psc_spec->hdr.qfi; > > + psc.type =3D gtp_psc_spec->hdr.type; > > + psc.next =3D 0; > > + rte_memcpy(hdr->buffer, &psc, > > + sizeof(struct iavf_gtp_psc_spec_hdr)); > > } > > > > hdrs->count =3D ++layer; > > -- > > 2.25.1 >=20 > Acked-by: Qiming Yang Applied to dpdk-next-net-intel. Thanks Qi