From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD21D41DB5; Thu, 2 Mar 2023 15:35:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6170F4114B; Thu, 2 Mar 2023 15:35:23 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 00CC1400D6; Thu, 2 Mar 2023 15:35:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677767721; x=1709303721; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+heaz8TyxZFZ+roGqQexSZF7DRkt8nskKpdgdpic3cc=; b=K8P4oM0dMY1NrURwqcRfHs+Vy9Mo6zkLNre1miKKWSlDYf1LlfBSFyZm ofvZ40Q4FrCjprzenPlEmtlPG468b3V+XyZeOaCmQBwNirw3z80fYe3Dd 3KQ1eyiub2hLLsrHvg2arVZYN3T0i1emhCRkvTg8FhuWx+yXuGl/8TBKq zc4UKCXHqceTZxbqtplLEJNnlxKTCEi9WZWw2qIG75JQCRqo2R5yK9PtJ fLPwKEHpuxkI0fQWtQcuBcaXauoLYg/2VJ9MiOkWWn+oCeh0YBMrkRgYY i2GOE2o5pWA9UwQWWzXFXDjGbGXDVVa3npN8gSb34aUALkS6mSH7NBAJc g==; X-IronPort-AV: E=McAfee;i="6500,9779,10637"; a="399529929" X-IronPort-AV: E=Sophos;i="5.98,227,1673942400"; d="scan'208";a="399529929" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2023 06:16:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10637"; a="674973369" X-IronPort-AV: E=Sophos;i="5.98,227,1673942400"; d="scan'208";a="674973369" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 02 Mar 2023 06:16:07 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 2 Mar 2023 06:16:07 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 2 Mar 2023 06:16:07 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 2 Mar 2023 06:16:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j4tnQS3Dy4KaF3qBy2b9u/+vjWcYpCHK6h64MaP3IXjkjtZg8ZLMuWxO1Uly+BbyPgoQLIu30t9KSMBiXAm3OcXDXdbzEWDYnxXuubKvH7/KTz8r4pLvxS6DWYVQnTfRGr46pE80zV8/Mrq7yc11iOw3sFeMaLbP+3j8EjOE/3wDxdIP2Q1FR6sLSiVIZq07SEH3ENCAxf0F7dtcsyGDywMflyZL0nqexdGAROQ3frIqlTx0REBStC0OrrQF11lOs8PmngkEevVbGBTzFcMKNZwFgDA2CgmYal4RVa99rdU+471t6P4BChTFBPZsCKcybHmWYDjpJC3RczSPw7byNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gx6z8yS20/tm+2vx0oXj5LtGaUh1LnVbcC9QKeQenZU=; b=T563OrWW58yDja6r6uOuImPlm7NtqZnyX33QnuhPgdcmuDbbRf9EwnGd+z+tzlYfD0zCs06K3l3Byo+77WBSIlNw4qfQLbltYTWNUmUSG5V+35GdUq7EBpWQw+/8BluRKzkh2bPE5ao9SDwK9PVo0Kvcx8Pe3kb8pq+166jycxADxPAHF9tDZ1t5Uwd+IqlR4OU+UEW6oyESE4B2i/MFkyxN/ifRcelXiWRQoho/oS3aJI1EBLE3DalrrJeMluuk6/HeiXhVcPKAf+ZX6MzZ2Zk3Hj0txi0yumeTrm1kdLn/Hnt/WWQAlR5ZLIohtcnKEuHR+tbFYHj+9GmBc508qA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SA2PR11MB5148.namprd11.prod.outlook.com (2603:10b6:806:11e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.19; Thu, 2 Mar 2023 14:16:04 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::2c5d:49cd:a9b4:f764]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::2c5d:49cd:a9b4:f764%8]) with mapi id 15.20.6134.030; Thu, 2 Mar 2023 14:16:04 +0000 From: "Zhang, Qi Z" To: Thomas Monjalon CC: "dev@dpdk.org" , David Marchand , "Richardson, Bruce" , "stable@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" , "McDaniel, Timothy" , Ajit Khaparde , Somnath Kotur , "Daley, John" , "Hyong Youb Kim" , Dongdong Liu , "Yisen Zhuang" , "Zhang, Yuying" , Maxime Coquelin , "Xia, Chenbo" , Shijith Thotton , "Matz, Olivier" Subject: RE: [PATCH] drivers: skip build of sub-libs not supporting IOVA mode Thread-Topic: [PATCH] drivers: skip build of sub-libs not supporting IOVA mode Thread-Index: AQHZRFkrt467MfPRY0eyt/O0vb/Qjq7nkr6QgAACgwCAAACT4A== Date: Thu, 2 Mar 2023 14:16:04 +0000 Message-ID: References: <20230219115529.3260580-1-thomas@monjalon.net> <2030660.o4kTbAZ4gJ@thomas> In-Reply-To: <2030660.o4kTbAZ4gJ@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|SA2PR11MB5148:EE_ x-ms-office365-filtering-correlation-id: 4ba84b82-8e57-4631-11e6-08db1b28a87c x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zbTfaPB/uZM9kA7yYrwK/svIopHLNVri5MUD+qQbR/s9EwyLc5gAGaQMFWZsoK/yPm8oBATKgDsZ8EPXYCtSSG/DUPbdiC6lH/WDH2tdIOs1wqC/BqalFpt0coGmPC9ZevJ4gA97n2jghq8jMrHUqZtkpta4T9E/B8grEejkRBKMpwUv6bSaYMscQB0370soJaM3xoIkDw13vD45VxyyC7ZBhiZmq/aRZvHohliW+EVlxHq1JUULLWnN/5j1NkLwjr6fqfjQlv3DRT21sCNu5eZen5Q7mzDIsRNK3bcaxXXDbbfgpdm9b+UXUWB8nBMOw/tQQFJRGUHhzyVK1TAVG8WMnqxXu7JESUN9/ZIov64Qxy3Q/98e8Tg3OR4di7YkdlQ0InTlJ0q23LnWm0dLZuQrhfZGjkrfZAT/W2lyyIiGiTJFXtulOupCRILLN8aG3bdqlQM00DMI6GrJDUKbraUPUkEW+QskWcTTKBg6RreBLdO2cSoE3tHjuLaMYaGa686QTpe26rDL81mhJ3aRC3opTkV/p2DOJF2vOQYYbEzFgcwmJ+4LZPEmbxcX2ZIj3Zy9TkK6pT6DB/8fZvfPPGyu4163DkJfhTFiaKu3xaMEecnTCcF+1RvNF/R2rWgPObZ/i92xEJV/GMODy4PvCWoBfyvpkiM0mu7M8Xc7XT6g5O31ZWxZiJTMhfzmHuLx4oEbbBjYCCcqqN9/B2rnbQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(346002)(136003)(366004)(376002)(396003)(451199018)(71200400001)(53546011)(6506007)(26005)(9686003)(186003)(6916009)(41300700001)(54906003)(316002)(4326008)(66556008)(66476007)(52536014)(8676002)(76116006)(7696005)(64756008)(2906002)(66446008)(5660300002)(478600001)(7416002)(82960400001)(38100700002)(122000001)(8936002)(86362001)(33656002)(55016003)(38070700005)(66946007)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wZiwanL9XI7b68jIxAANVmO6OKgBJngp6Lz008QK4QJbrvTLWISKc/ipMZZY?= =?us-ascii?Q?FoFUciBaWbDKDIssQmEmGX0sQH7Z9VAVFfmLUtQpj11+5nRvSvqwTgHDFFo4?= =?us-ascii?Q?78cykj8arWKQtKBhGoAxbDHonqA8Dc1QDH5lUMCrh/H6TMhfU8Hl59QLo1GF?= =?us-ascii?Q?k+yl9eCwD5IvAfIQeOQGKmsjgEkhSaWmonoBRgNmeWaTlu0y3E8uGv3Qv4ib?= =?us-ascii?Q?PiwBJMgXUKcY6ftmh0lO1dxxDYESAEu+UrP5q6Vsewu+PctXkBMK5aZT0XFf?= =?us-ascii?Q?SDRI+eJ/8kaIIW2Sm0nMj3gOSNmo0nF1CTt0enEZFDJ6/QHVmy4NhrH5OAkR?= =?us-ascii?Q?VFBKQwQQvT2W7JF6QpQ1emp9uPKwXuDwsLmAswW5L5rL/zDA35LKQf7LkvtU?= =?us-ascii?Q?zHGbcimdh1Z5b/hBAHG0zhrlWuD8KZUXG1GniPpIsqc9yax0wQZuy+P5SYfW?= =?us-ascii?Q?vC2YOeGjceefjVObSlvp3Ja5QWtYf65vhMAAOfdE6gXSRFHza8/Vq04kwkvp?= =?us-ascii?Q?pVad+3SBE/lpTSoIa3CgBihqQTrr0OChJXEs9MZmLUWD1qg0WxvlQ5Leomlc?= =?us-ascii?Q?/u89KxkTrFCHQx/G/7QbxCddohPP0VEV024eGuRFhnIsyobfM2piAK3JFLL6?= =?us-ascii?Q?Au706GhCUWtONjiPwzKD/ElgihwFK37y+9ZhonqNDB+qt+f+m62DxDW+UuaH?= =?us-ascii?Q?zeLoA2LWq6l6iDwpE0M23BpVWs4ld8JOOWRHphqrd1K5aGV7Dli+h9V1dm/s?= =?us-ascii?Q?IFwDVzAdgZ3KXKb2865d9uQ5FZmRzZICh1uR+ulllcOVxDsp5v7LGcpo37Ew?= =?us-ascii?Q?TFWQ5RXRcmNN3mr2SeJtIG5sP3JnLMEcFXCEdsUSH3ZB+NLEeJtJdthFn4Y0?= =?us-ascii?Q?PbtwLOXnHouv7mCVnxELlzZEoZAuOSpyPxW6HOI25CBOoysGMS1vG2DBlB0a?= =?us-ascii?Q?Vsbcw8Qp60sXsqJccgSCuzdHXBe8zxEcGS8TjKpzAxDqO9ImycEuomdvFW7I?= =?us-ascii?Q?AFD603JcaQsS0kQap2H8VM/5abpLmmwbAKwb8QZC8FCN9Q9/6wkhbekXQTV1?= =?us-ascii?Q?oT90S6uykOVnpPOxq8mopu73uUf/ypTfW8i77YD9eQ8bWQiXgXpwNpQDTLtH?= =?us-ascii?Q?rrJIdfBx1Xu1bZs5EDjxbG1VRgw3sZewDeHZQXvmmCleROGP5QP8nBmM96be?= =?us-ascii?Q?Nr+PYMluJNhNF7DJ2059lR6FbZjbWrr0n2AO064rT0JEszHvl5zkf/zuLdlB?= =?us-ascii?Q?WnoN4laH9MnoZ2Nlf5vKk28PGmtlpm2ePUb89s2M8UnDTZPekcdC5/Nglay0?= =?us-ascii?Q?CzLjwOniKZpBBjiObH9IfGe2j9v1r9Ng1uQwqpwHUYoDTb5P8VKqoc/pPQEO?= =?us-ascii?Q?I0I6h9SvPUKEQiThPzUdK71z9b0BZswqgHprHEzIOGjaO4Xrvkf3Pbxlkn9D?= =?us-ascii?Q?EO2ey2w8zLb8KAF5xbviOENYK2qedtHucLVN7K+fsOCBaxxHhLTNAKYDsopE?= =?us-ascii?Q?IyyJItF9c86HL5WgHkiKVLQNdCl8PsHrD1+jInExURZr/OHq/ngB1lJfpqEV?= =?us-ascii?Q?LEbQ3b9SgcGhMhuELUjlUbPdAkGprupgsHVCiOpX?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ba84b82-8e57-4631-11e6-08db1b28a87c X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2023 14:16:04.1769 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kOqQHfCmqP0twil/NFE0CdQUF/HiSElLGDLqFE6Ybw4p0PGv7lfvh3IghQAM1UmIEYDV6LTUT2LGj8WX+n4nBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5148 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, March 2, 2023 9:58 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; David Marchand ; > Richardson, Bruce ; stable@dpdk.org; Wu, > Jingjing ; Xing, Beilei ; > McDaniel, Timothy ; Ajit Khaparde > ; Somnath Kotur > ; Daley, John ; > Hyong Youb Kim ; Dongdong Liu > ; Yisen Zhuang ; > Zhang, Yuying ; Maxime Coquelin > ; Xia, Chenbo ; > Shijith Thotton ; Matz, Olivier > > Subject: Re: [PATCH] drivers: skip build of sub-libs not supporting IOVA = mode >=20 > 02/03/2023 14:52, Zhang, Qi Z: > > From: Thomas Monjalon > > > If IOVA as PA is disabled and the driver does not support IOVA as > > > VA, the build of the driver was disabled. > > > Unfortunately some drivers were building some sub-libraries (with > > > specific options for vector paths) which were not disabled. > > > > > > The build parsing of those drivers need to be skipped earlier to > > > avoid defining the sub-libraries. > > > > > > Fixes: a986c2b7973d ("build: add option to configure IOVA mode as > > > PA") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Thomas Monjalon > [...] > > > --- a/drivers/meson.build > > > +++ b/drivers/meson.build > > > @@ -127,9 +127,9 @@ foreach subpath:subdirs > > > # pull in driver directory which should update all the l= ocal > variables > > > subdir(drv_path) > > > > > > - if dpdk_conf.get('RTE_IOVA_AS_PA') =3D=3D 0 and not > > > pmd_supports_disable_iova_as_pa and not > > > always_enable.contains(drv_path) > > > + if not get_option('enable_iova_as_pa') and not > > > + pmd_supports_disable_iova_as_pa and not > > > + always_enable.contains(drv_path) > > > build =3D false > > > - reason =3D 'driver does not support disabling IOVA a= s PA mode' > > > + reason =3D 'IOVA as VA not supported' > > > endif > > > > If we check enable_iova_as_pa for each unsupported driver , do we still > need "pmd_supports_disable_iova_as_pa"? >=20 > They are a bit redundant. That's why I prefer my previous solution for i40e and iavf, because, someday we may claim pmd_supports_disable_iova_as_pa =3D true but = still leave avx part not be fixed. > The idea is to use pmd_supports_disable_iova_as_pa (could be renamed) as > it is simpler to use. > But in the case of drivers having sub-libs (always enabled), we need an e= xtra > check of enable_iova_as_pa inside the driver file. =20 >=20