From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FA8442C9B; Tue, 13 Jun 2023 02:38:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCA4A40ED6; Tue, 13 Jun 2023 02:38:29 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 448EE40C35; Tue, 13 Jun 2023 02:38:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686616708; x=1718152708; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=A7VUvtZ5PhB8/v2JKZVbK3hoBAiOZg4/cFdW4Xkmo2o=; b=HTem2ooM2P9xa+3BhFQMU1GBa+DxZE7Ypv2JbXS/2NjIimX8D+G364Rh RX9rFJDcwTRh87r7BVitnM2zdmhBGhUlq47yKact2HoCdlUJpIzF4+LjU 8SPoshF848ekiukaqxKlJnEFi/4T44YybGbd6JIMfFhNc4vgMToIXDYta WOPgpl4iC1nAtqejxxikU0hVCHoQmYjtG/C7PgkuNWsx4TXnL9ah1tu0u YBlmBoCdqwzlS5KNa4YXkL646tz25NjK8FHJYcoB7ombWhXpEyXs/IuQz Gt9+ErUHgzh/C6ljuPSkKio9j25DIkIS+MOgFyeYGpDrIwVN1Ei8VsRBr g==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="342882682" X-IronPort-AV: E=Sophos;i="6.00,238,1681196400"; d="scan'208";a="342882682" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 17:38:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="744501738" X-IronPort-AV: E=Sophos;i="6.00,238,1681196400"; d="scan'208";a="744501738" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 12 Jun 2023 17:38:17 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 12 Jun 2023 17:38:16 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 12 Jun 2023 17:38:16 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 12 Jun 2023 17:38:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nO+sVUdZHTot7tCZi8zJG68MpUcJ3NQlKuX+T+ACsrcZqYjvEp45ItW5JPcjFVSFRYzRzbxm1R5OC0XnXAHoNC0Esjm2LhTnYOvZY7P3GQy5ZL0fJvrHd+/Qeu75kPViAH4t0EyNoGCWGFp0DUHGTjtm+NfrS7BIPIab/EfgXO8BHgqNxGXxR0eiVgw2C+BcLauelX/AKHRZmnYBgkWIo/bELgYzR57f+YOwNs8WO42Lw7iUujoCEVvzgV4XBXp/h++iDyjduZwxZMlHeWZ3l8JT2tRqTbXZh/EaVccbjDxu3tLjR9I4SawzrPCpFZ4tFmvc5rFQ5m/XZfFdLIlOXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A7VUvtZ5PhB8/v2JKZVbK3hoBAiOZg4/cFdW4Xkmo2o=; b=PO5pCN2VnPV3K6a3xIlXWNT/NDdGfkIOQX7yfDo4NISFz7ZbFZgvohBI5ob8e4u1ZB7HDyd9xRzy7byUXdlgYPLKgWgS8V65AWf+xlhCVV9jmiOE+NSPwv6IgxXOPMF/j8c5FiJ506UYGKNFlBsy93bOZZ7epEShY7DOkLZMPMLFqyBJKQzIN1y6Qdjr8zVfD3Wgj2WARAhNsW6yM4dZBcIxCcx3VDDe6hL362rJ8M1c+th7gotZG0eWENOrbVO1CvhiCeShnnRKneyB3bMFTNEaj672WWKv93pibf3pxJRP7Z3yz2GOya57fZEX5NGYbPl5b5Hy/JrM0bE4XcvF+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SJ0PR11MB5120.namprd11.prod.outlook.com (2603:10b6:a03:2d1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.36; Tue, 13 Jun 2023 00:38:14 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6455.030; Tue, 13 Jun 2023 00:38:14 +0000 From: "Zhang, Qi Z" To: Thomas Monjalon CC: "Lu, Wenzhuo" , mschmidt , "dev@dpdk.org" , "Richardson, Bruce" , Konstantin Ananyev , "Wu, Jingjing" , "Xing, Beilei" , "Rong, Leyi" , "stable@dpdk.org" , "Zhang, Helin" , "david.marchand@redhat.com" Subject: RE: [PATCH] net/iavf: fix VLAN offload with AVX512 Thread-Topic: [PATCH] net/iavf: fix VLAN offload with AVX512 Thread-Index: AQHZYJQgWcZBnlocsUuoK5858o0Ts68Q9AOAgAgoE+CAbtK8AIAAblBQ Date: Tue, 13 Jun 2023 00:38:13 +0000 Message-ID: References: <20230327100750.448859-1-mschmidt@redhat.com> <4584961.CvnuH1ECHv@thomas> In-Reply-To: <4584961.CvnuH1ECHv@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|SJ0PR11MB5120:EE_ x-ms-office365-filtering-correlation-id: 98fb6842-d897-4c3e-5eee-08db6ba67894 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GcW5cQO8GJwDefgCDPTyiyalSOWWgm3X+HG0coBtpfyOBntAOrafgecHVo+ETMbOsUMolSAyjivxxvSWefqFmCyJUbB3wNHAPPhwepcmVTt52NWUFNR3ElHDltquGrG9QAMpPj8VuNvKoOOAZJIkkITbhPqYOjdeMXGPIpv1tx5EziACgmI9AVsyzFQJwttkeVS1vNLGRyi1mR3tz6KM8w7v0YdmJnD/RUgMtNxjUUl+4VmEkWhr7vOZqaK4NgENMWp5Mcn+6DvPYCfP1+0QveMxiVpsP2Knrrdo6ms82uuWqQ8GdYUlqz7Kz3mq1erYXh+wqanua/3WNBzTrxAlwnd3s0aaDa39YYJbMjQEW2O+qf0zqUujf2ITuoW2GzNPUH2eh6UOKwr5aJrqCzis3EW6BAYIZWOrMqbjR6XMWeG4SmwujTBa0e2Zna3UfyfL3Z+Y7tSMwjTHUZ6o5npOHP1miFWni58JeoaVLcWA9uLd+b3/3uDqvMercfpXHhU+QPhkj2CW/8nj3kDZBkqDvqZdhoAuRwVp6tlTCWQXoxW/MhJfLBsBGIu4ddU8xMbzL4UHg75HmUTmXu0wl65W3RD7x5iNXrsTS5y9B8nKO4U= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(39860400002)(376002)(366004)(346002)(451199021)(7696005)(38070700005)(53546011)(33656002)(55016003)(26005)(186003)(9686003)(52536014)(5660300002)(41300700001)(6506007)(478600001)(8676002)(54906003)(66556008)(66446008)(83380400001)(76116006)(66946007)(64756008)(66476007)(71200400001)(4326008)(8936002)(2906002)(6916009)(82960400001)(38100700002)(316002)(86362001)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gFf2Nvpwjayl5GA5BkR6TbpvqpfOxl0ul/MGLaVzag1QEVBzhtITnbkhqisG?= =?us-ascii?Q?d8CBMy4ckRLryJA9Xp1RbxaCCvNJ5CROwgmly+Flk9e5jpEDIZEHrcUx/KV0?= =?us-ascii?Q?kC0BVGIeloy9n833ECkNvps8ZsBK7tlyC5e8X7avOQhN7YxwOjHxk6ybjTEO?= =?us-ascii?Q?clN4q9H/iSjBeJuR2cwXo+EUYHohgruACYrAxzyQkmf9AbuR7shMsh0JT4c+?= =?us-ascii?Q?ntY8gFAwOmJekXg/tFLZtRSGBsFcdTLKAlEmtXoU1Q0XLHdmbxrK0nr1CHDL?= =?us-ascii?Q?rb0M2k3tnp70KqJ49KvjDJxFgmzCXeqgM9F+mu+XGZocVR14CFS8uW2REHsp?= =?us-ascii?Q?X+6fsKAsdNCrED3dOm2SZlwh+MrVIKEXIh2/zFjfrMBcbOwFQfa4p5fGgjLy?= =?us-ascii?Q?Bx7INKsBI+UpeprqDJ7kJbGxTnupPEpTmJ9apoO8yfnclqGaw/yq0TBLaUOx?= =?us-ascii?Q?gVywD3rJZtnx59CXNQ+baQaI6IxkTQL8lrcpumeWkxUawiKiVd/73ynbdG8k?= =?us-ascii?Q?eiSdlyo+WOd+YWXJrPZTf80YPMy2Dt0lCbVr9fIlqtMimvDOKsYsDPAUaowL?= =?us-ascii?Q?2XnLDZynvXh8nh0XMRUmMD5WcC+8x0jTwheseeo4XqBk2VfxgEZoWtMbxrrI?= =?us-ascii?Q?uu62KfOgRj4c5zUCfsbGBhGbIgYb+Gp0uGuaUrRFZ8sOMf+5mot8HGW2KQVh?= =?us-ascii?Q?5krVFDBetp94g2GdnL66nBobDQmxXEG4exXyZP+eNZ0FfQDy/2XehSesewvr?= =?us-ascii?Q?fmWFj3gxV+9U9oXIHV6HwA90ur8CKRmvoVEEs/zgfqu9Msv7ARrwvyQDCczZ?= =?us-ascii?Q?uePZSBBiyevujd3D9kx+0o/s1+lx3MmOqfOAK1ZBvlhRbYtaAFQE2aDO4w0L?= =?us-ascii?Q?OzEkIYIOMkz1DHoOdckUB5z7SoxqBHdN4WTdOwezCoyTzRj0xdd5aluRgXKA?= =?us-ascii?Q?ZlHZkQCQ/GcqfhPO6aI0KE0oMUU0jCraeipLw9crxFeOOLMJSnTRUZDZlScm?= =?us-ascii?Q?xp2rtkOcao6z5eATRfVpapvz5+qP0Lp60hvQPRDMI+eBj/Nt3ythShNIDSsK?= =?us-ascii?Q?ogJqgJCmEFv1/FMvfb5TLOYEE60R0kJOrUEUaoTYTU8hAUBPyShs4+/kwKim?= =?us-ascii?Q?nQciuN7IU3ryldkqjsQAV44YAyx7QOtASKjNntsujAJS7GkRLQ+zaoLfAdjc?= =?us-ascii?Q?NgiYRlUUdn74iVfMGi1v2xZh/JPchIGDqki3i3iFqU0LAAWI5KT868ToEQJN?= =?us-ascii?Q?STWabCOUegdysrpgg9bzGZd1vAY6mrp5/EgTYbEvlrT/eUiFxgABidh9bfxO?= =?us-ascii?Q?ALzWPzkasNgfKTRQgbmbHn6UoTGrRY4uLaXBEsIb8XjdEv7kB+ppHGXRKQpD?= =?us-ascii?Q?62UVWGElFGrXPY//jP8+P/nKsy/Div//RltTzpQIC1Cq7DDDNe3FSEC06grZ?= =?us-ascii?Q?pZOPUtGOf4M4sDk36ORl5wErHWYpNo0efsJWQ8sUnLakn8zpIqUulSJ9U8Dz?= =?us-ascii?Q?JEzQP9+xchWrF1asvFYo2BGDdtfYIvcqUWNQWqOUcO7ld5VTNWAJgeK5PKT9?= =?us-ascii?Q?taMTUTUUlWuyrHQnySeiWG3/tq0/dxmok/KnlyMO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98fb6842-d897-4c3e-5eee-08db6ba67894 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2023 00:38:13.4424 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nCp0umo8v9haY4okmbiWHY68TJG8i6m5jtwH7WZC1FBhEcRvCyzbLv4u/R9wM0JhvVVKFnqKHoK6pvgwTGdeaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5120 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, June 13, 2023 2:02 AM > To: Zhang, Qi Z > Cc: Lu, Wenzhuo ; mschmidt > ; dev@dpdk.org; Richardson, Bruce > ; Konstantin Ananyev > ; Wu, Jingjing ; > Xing, Beilei ; Rong, Leyi ; > stable@dpdk.org; Zhang, Helin ; > david.marchand@redhat.com > Subject: Re: [PATCH] net/iavf: fix VLAN offload with AVX512 >=20 > 03/04/2023 07:39, Zhang, Qi Z: > > > > It has been observed that mbufs of some received VLAN packets had > > > > the VLAN tag correctly set in vlan_tci, but ol_flags were missing > > > > the VLAN-indicating flags. > > > > > > > > _mm256_shuffle_epi8 operates as two independent 128-bit > > > > operations, not as a single 256-bit operation. To have the > > > > RTE_MBUF_F_RX_VLAN* flags reflected in the resulting vlan_flags > > > > for all 8 rx descriptors, the input l2tag2_flags_shuf must contain > > > > the required pattern in both 128- > > > bit halves. > > > > > > > > This fix is for the AVX512 Rx path. The same bug in AVX2 was fixed > > > > by commit > > > > eb24917428a1 ("net/iavf: fix VLAN offload with AVX2"). > > > > > > > > Fixes: 4b64ccb328c9 ("net/iavf: fix VLAN extraction in AVX512 > > > > path") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Michal Schmidt > > > Acked-by: Wenzhuo Lu > > > > Applied to dpdk-next-net-intel. >=20 > I don't find this patch in your tree. > Is it lost somewhere? Sorry, it is merged now. >=20 >=20