From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45171432B3; Mon, 6 Nov 2023 02:41:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0576402BC; Mon, 6 Nov 2023 02:40:59 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 39E904025D; Mon, 6 Nov 2023 02:40:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699234858; x=1730770858; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=hipBVAaAPDkZcMeptxWXEUytBMiw9Ix5G5vmnYqe+HQ=; b=LgAj2h08C8FpwJ2HC8EC7658qThJBWOiHOQ8KJhl/XTJ6N+IsFR3faWH LA6/yboDlOtnZLpXVvCpUOMB6dvjcJhKhlcKV+sAI6QVCci9xE0P4Ikf5 LKREHuAkJkLv9z4wKx6UZ9zbKC35c4EGMOwJQrm3NvzBHgWa4ukJg2uKB v3xTRHiRSO2Fo+GGuMNEp0tdnjsdAwaOBiTRVj7pDpBoFIwWrxKI1ujkq hVAz/RAVzN0mtHcfw1sFtmu6gamNKDHIlG9Pf+qpNKjcQgocxHnB/NAHq 4H0OGsS3UeWqXupnKGFgyWICRp6GHURR4RxMcwH1xHEBEFdEa67/U9Qkr g==; X-IronPort-AV: E=McAfee;i="6600,9927,10885"; a="392057050" X-IronPort-AV: E=Sophos;i="6.03,279,1694761200"; d="scan'208";a="392057050" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2023 17:40:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10885"; a="765805291" X-IronPort-AV: E=Sophos;i="6.03,279,1694761200"; d="scan'208";a="765805291" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Nov 2023 17:40:42 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Sun, 5 Nov 2023 17:40:42 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Sun, 5 Nov 2023 17:40:42 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Sun, 5 Nov 2023 17:40:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q56dLrIW5ronDRkLPJ0Isvyh5MTgVaN0J3fwn/iBKZ3/v28OnxU0INU3e5RWYJw13/dC1N/JNCm7kSFaFe/3pTb3PS+sLw3kx1dfYWMl7//Mej2T2LPegJUbw1vLh/psGlttOf/WqW/me2kV+p2cIicVLI8GxuxH9SWLDlHARBvhvQAkRhH7YfEvhu/BOaq1myywxAZEtTm9kWgXd/naZzgH9Y4L0uFFmh1XXhUMH4g2upkZWYmixVNLvd8Qo9TxNfIXGTwtVUtQPCTDO4sHuKFa2Gm6vXtNb6aCSpH2yynLM+TGYLcC/3zAPc3JabJqZ5ectTkurUbWMudqQj/RLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sb9/9KvNZCE/lS+oJCJ3tloQUIijcSGBawbW454stkE=; b=aX1dfvqavlBAw1dVYe85Y1fdIr+Xvo5uMCqmQrpM07nxJyUgnGQCakDZAq4NjQ3olCm1twuBbhUS5gMbIuZdNwJUmdWroTfZHIZRD3/N0V0saud1QM+zA48dURHPA1wjwLYcr5VFAxieO58SaAT1b9bQRvvjGMEex6PHV/dCXNAZnkh9VJTrIcmbuO9F+EXyRumVnXvJt/oYuhm+QwUEBhaQzCT450NjtopcuMXuhxkLTHAraWs52+4NmxZkJkBBrbJT7yAjgBq7bK1o6f+m/uQTY34n2d3jPxZbqGmZAdzBTF5GX27b/sXyafJDZ8oCIfsrJH6SFStViKUdDSs/jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DS7PR11MB6128.namprd11.prod.outlook.com (2603:10b6:8:9c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.25; Mon, 6 Nov 2023 01:40:39 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136%6]) with mapi id 15.20.6954.024; Mon, 6 Nov 2023 01:40:39 +0000 From: "Zhang, Qi Z" To: "Yang, Qiming" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] net/iavf: fix Tx preparation Thread-Topic: [PATCH] net/iavf: fix Tx preparation Thread-Index: AQHaDT7r2d0ubY8yG0u5+/tuihj0/rBmlbGAgAX0NYA= Date: Mon, 6 Nov 2023 01:40:39 +0000 Message-ID: References: <20231102120504.1468111-1-qi.z.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|DS7PR11MB6128:EE_ x-ms-office365-filtering-correlation-id: c8bf2573-a60f-4830-c45c-08dbde6961a3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: F0t6SUVnMUofApQErUv2JvMnLgLYDvNJvBMWg8Jtp0sGRuoJXKb0iurQvSDVjT0uYgKgKQ8v+6Ku2mWMHo6As2/ZK7oJUGMdrAR+tdDq5x7fvH02ZpYhCttM9050CabExd3AW6Ob/7V1Deb4hph2ZWhqV6BV2qrp3cm2/fuFbUFV5qzH5I9QoMCC+p+u96Iq3cGQHLbfpcGcJj+/D7wtbqHBm/0jfShbtib3LMVifdrVQPTIQv4KdaY4wQqWBEj8VxJRNseMYhzUhuhLP36lf7qVCAuL/wnS+IT/Hw1ISqCuq3MAPinItxQleDPiYEUwVv7QDksXdosK4ku91SYJMHoTfpkHAR9bF8PT4VUdH9P3BLMYxlJEm4cOIvnwLM817kE452NEnkoEZDCIvrkr//JvqjentSV8i/oB3AnnNdTAjDrD2xZGhc5ridBR8hXtknTckX6bYS2Ofl5IcHAZo9GiDG6DJ+P9z3xALKKjz2HdGH55ZObJWdDdCZw1IKc5R3Qr438rS5Y+uYmbVn81FjNdrH2vF7tU7SAXkqmGXCDx6Z0mPEZGKUpe9uJWDWHq+GHFJF+P+zf7jQJkb9PpSYAhNrZ6Ur0HdBQ9E+Ygevk9dpX2vM5VBBkhdl2M6mSA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(346002)(366004)(39860400002)(376002)(136003)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(86362001)(2906002)(41300700001)(66946007)(76116006)(122000001)(110136005)(54906003)(66556008)(82960400001)(64756008)(66446008)(53546011)(38100700002)(7696005)(9686003)(6506007)(71200400001)(478600001)(83380400001)(26005)(52536014)(316002)(5660300002)(8936002)(6636002)(33656002)(4326008)(38070700009)(8676002)(450100002)(66476007)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LWon4vY5gzFYrmoZzbbvbpBeIgZcoEfowi7Yl71doDRxx93obz1kIE4OOD3j?= =?us-ascii?Q?NTiDCqkR8cEgg7ys1iTl6FwXY04UXu10+N7EiA/3WlgrZEWxED5eJ5xxtMy5?= =?us-ascii?Q?Suvx50ebXRKEB+/kUXhh64zymhomKtIfQ7jTZEdGsBCOZdNSSbwQuwBjl6dc?= =?us-ascii?Q?dWAoez/fy0DUhgcJEU8Qfdl5jjOnWcL1sS+pKpK38mocGF4+LY6ute1TlXef?= =?us-ascii?Q?YNcayNEjYaiWIed9NkIBHfBuE8kPGJCUN49aP7LSZfK+Ik5YQAzRIUjb+5e+?= =?us-ascii?Q?nbbhm6pw5JTLuuwB5sJ0/ThGlyolxXXvJATQOm/yYlcNpQyXgY/ZeAOS58pD?= =?us-ascii?Q?K+l/8RTW5lXHjYq9FOSmSff2LZLlRrVv+1Vytf1b50bI+/Z47mwM1ywm5jA6?= =?us-ascii?Q?6Hwa1OQaP3MnXmCSSMCzVsSDOxcytvZFOwL33pk/0/fS0Z6cpMIL1h5WITGZ?= =?us-ascii?Q?u4/MysMeKnvT7eX04ggndLAOPFGDDNe+SlH9nQKf7/XydgLoTG8DH/j+YSKM?= =?us-ascii?Q?fxJ1+9jFgBnAd/jctuLW019JktgSQQYHI3ASFJOcBfskAlLQVNbZQNJpsbgF?= =?us-ascii?Q?wLkEgG2Z4eBHU2Mzzo+sLSt4T119NsPDYvqMZPW6CGpxReiUcUt9UIqUVRSb?= =?us-ascii?Q?kcTOh6EuN8uifz+QXdFp+Mg54y04Ei1c1+TKGQ8o6/Pk1sANo97UsRmsp3qT?= =?us-ascii?Q?grTpElqK0DIOY81tBaxDe/JKyS/kRerGrxeitksVdiNLiyX7LNIVjOQY+lG8?= =?us-ascii?Q?G4KOUfDtYpqfBwNHWEsSI+aqUnA2mkWTvKsRjaUThOi3giUX8q/t5ItVctuO?= =?us-ascii?Q?v5DhdOdZu86yl0bvXcxzg/6mANAtP/fUlN0o+DjLQq3Aod/u+kOWteF1+YyK?= =?us-ascii?Q?yjt3PJByg3qIlmuLJR0JwY0pIFtEdQ5tx1qjqTxXWYMHadb+SMKYQCHOnuH9?= =?us-ascii?Q?66kUb/ksC9WMaiiT4/ue4MD0YI/68WU5IfMnKKAKN7zol6pdfMnZaINFoiRF?= =?us-ascii?Q?3ZrIvCPfvbGWSV6mwyO+OZggYmE3r1UtbA2EEksIyuBBzy5Napopn+inAgOL?= =?us-ascii?Q?z6LetojW1Zzv6fYN5tKLJVTXqL2c8Dj5Fr3+Wt0e7QOHXSKIrwLRNGHjL5Y5?= =?us-ascii?Q?ZYECm5E/XUJ72deAf7VMRcYhwRS7Sbo/gy+fAm7ejCwxGc3h565ngnSG2yXJ?= =?us-ascii?Q?DMCc0wJ+7C1w5+hPsfn3YpguB3vo0dYFPWUQTPqRlHAmx4Ggz7ib5ZbQrIk/?= =?us-ascii?Q?L2hokiGvW9sj5Ufx18hmhOuUTIW7PpJewpcXrOhaPc3hP4dtbksjS2TCpa9r?= =?us-ascii?Q?o4ZuAkYPdaoSaKCC9b7UGAXyx4qEG1lr/nWfEDCAuXfzV3RxJSbU7s5Iuin7?= =?us-ascii?Q?MKMl6isNcbYSwOFEYxjkYsqKN/2qMtghn35aMkSQ94Hfr6/R0O13ReDtV/C9?= =?us-ascii?Q?FMalnvsCVrV5LpgqthByb4Pw1YPfaxVrcF/qwwOMsBxAB9p1ep3Y75elI+ho?= =?us-ascii?Q?nW5vGBsevS1jGJrJXqMtYXUIglZGn6e2JjOM4czoC/pY8XrmPBYbmX0Sf4Il?= =?us-ascii?Q?M9Nx9CLIEwxPhxx/eueGRp+N+VUGedzsF2B1DzsH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8bf2573-a60f-4830-c45c-08dbde6961a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2023 01:40:39.3824 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J9nM5Za57D2tNfQgAhodhXmkvafEb/Yi36dBjl3YM3yVv83d+1qw7K8YYpsuaeUwAKHL6M0H/u8qiAw/zzCf0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6128 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Yang, Qiming > Sent: Thursday, November 2, 2023 2:45 PM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; stable@dpdk.org > Subject: RE: [PATCH] net/iavf: fix Tx preparation >=20 > Hi, >=20 > > -----Original Message----- > > From: Qi Zhang > > Sent: Thursday, November 2, 2023 8:05 PM > > To: Xing, Beilei > > Cc: dev@dpdk.org; Zhang, Qi Z ; stable@dpdk.org > > Subject: [PATCH] net/iavf: fix Tx preparation > > > > 1. check nb_segs > Tx ring size for TSO case. > > 2. report nb_mtu_seg_max and nb_seg_max in dev_info. > > > > Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx") > > Cc: stable@dpdk.org > > > > Signed-off-by: Qi Zhang > > --- > > drivers/net/iavf/iavf_ethdev.c | 2 ++ > > drivers/net/iavf/iavf_rxtx.c | 3 ++- > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/iavf/iavf_ethdev.c > > b/drivers/net/iavf/iavf_ethdev.c index 98cc5c8ea8..0c6ab4ac5a 100644 > > --- a/drivers/net/iavf/iavf_ethdev.c > > +++ b/drivers/net/iavf/iavf_ethdev.c > > @@ -1207,6 +1207,8 @@ iavf_dev_info_get(struct rte_eth_dev *dev, > > struct rte_eth_dev_info *dev_info) > > .nb_max =3D IAVF_MAX_RING_DESC, > > .nb_min =3D IAVF_MIN_RING_DESC, > > .nb_align =3D IAVF_ALIGN_RING_DESC, > > + .nb_mtu_seg_max =3D IAVF_TX_MAX_MTU_SEG, > > + .nb_seg_max =3D IAVF_MAX_RING_DESC, > > }; > > > > dev_info->err_handle_mode =3D > > RTE_ETH_ERROR_HANDLE_MODE_PASSIVE; > > diff --git a/drivers/net/iavf/iavf_rxtx.c > > b/drivers/net/iavf/iavf_rxtx.c index > > 610912f635..45f638c1d2 100644 > > --- a/drivers/net/iavf/iavf_rxtx.c > > +++ b/drivers/net/iavf/iavf_rxtx.c > > @@ -3656,7 +3656,8 @@ iavf_prep_pkts(__rte_unused void *tx_queue, > > struct rte_mbuf **tx_pkts, > > return i; > > } > > } else if ((m->tso_segsz < IAVF_MIN_TSO_MSS) || > > - (m->tso_segsz > IAVF_MAX_TSO_MSS)) { > > + (m->tso_segsz > IAVF_MAX_TSO_MSS) || > > + (m->nb_segs > txq->nb_tx_desc)) { > > /* MSS outside the range are considered malicious */ > > rte_errno =3D EINVAL; > > return i; > > -- > > 2.31.1 >=20 > Acked-by: Qiming Yang Applied to dpdk-next-net-intel. Thanks Qi