From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A39941CDA; Sun, 19 Feb 2023 09:31:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4CE940C35; Sun, 19 Feb 2023 09:31:00 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id AFB2340698; Sun, 19 Feb 2023 09:30:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676795459; x=1708331459; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=38MjQrYVfnzl+ZeCUHxAO2a2knTEHuYPfEZzNfMIVJ4=; b=UNNM29QgbcUArhN6o8vIAXkBQn/i3dXOfZyfWhfNEgY8xwxG5Gn1do1z UnZmdcsSnIGeDYeeIH4AKMPnno6zDBhDQREm20bY77Cnv4FOTQuCLPNWS 0TUVCFDgFJMoTPsiEXxutfBx6Xqg1hjB7o5WT0E37LYE6R7O4qQm2mHCa JRKb4m5vY8fEYO9wEMTU1uche/ng9JhlQ0/R+HuWtO5jBa+s9u1IB9qHp LqZLXCCoKt9F5k7ZArrQM4mrEoVXkRTPg3SHSANl7iDH8Vkpx1VMpkBHg 7ateKVABrT5G3q87sD+Jv0GvoTcf8hTHylZzrMUQsDP9r2W4TLbIbPnxQ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10625"; a="329947795" X-IronPort-AV: E=Sophos;i="5.97,309,1669104000"; d="scan'208";a="329947795" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2023 00:30:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10625"; a="780286107" X-IronPort-AV: E=Sophos;i="5.97,309,1669104000"; d="scan'208";a="780286107" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP; 19 Feb 2023 00:30:51 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 19 Feb 2023 00:30:50 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 19 Feb 2023 00:30:50 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 19 Feb 2023 00:30:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QhnD82Q6UqYhGhRu01Mx+KqNbY0LJy9Vzuvf1ya8R3R1wy97LqTXWQcP6oldKaWCKPklNio8nS5QZf8C8Jxn1HgywLNtSxCFlGirOH8q29oRJBk90VGcR5d0pYXtPniUE1G3gHX0ZizRdK0vQnPk31tZyvsd3CSkUomuqPU2uwZfgkFqWjHTnvdEBzewVvKf2ZLXQLBS7VOCzUMNJ5JbxSCBWoaFPR7d/ndZxU181ONRXuHut07yp9nd+a9EIXx4O10g70vFeCQO4BRtHQz8a2U0sjwGFLI8CMiu5zdELQYnjvjKiXMNtqJq/gPMDJLHz3YGvazRh60oNI9R8FuFxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EvuJLN8hQHLLec0ERB6cqvDTUr8+FuCCpelY1iM6550=; b=XJQgMKM5EWgOs332G/RdWI0N7TdqnbJ4sVx0nnwp4AzLKKlAzv2SonfA/fgLmzwepeIGsIEttGFAOKmXIprP8QYjIKbbuSWQgKwTHdGPC6UqfCs/89KRMCdHGOAO06IyMPMnID/VkUtHtQn+g+HLWU5/Efan/N5pEWCmuCgHVspMHbqNrON++uWorb6jqcAvjyqBAjUXHX5EpmkaT5RA7RA1NAzwRl5ifVhPuz7/7OTSlcjRvvNze6mKMjYhb2BQ9IBCtrczKrWNrgZJWypJWv0FObnyj3658QPKczoZMU855cnDdcuaSjbBlf3OOb6JNcNIZFA9LSBQqRWCuOIiWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SN7PR11MB6850.namprd11.prod.outlook.com (2603:10b6:806:2a2::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18; Sun, 19 Feb 2023 08:30:47 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::2c5d:49cd:a9b4:f764]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::2c5d:49cd:a9b4:f764%7]) with mapi id 15.20.6111.018; Sun, 19 Feb 2023 08:30:46 +0000 From: "Zhang, Qi Z" To: "Ye, MingjinX" , "dev@dpdk.org" CC: "Yang, Qiming" , "stable@dpdk.org" , "Zhou, YidingX" , "Ye, MingjinX" , "Wu, Jingjing" , "Xing, Beilei" Subject: RE: [PATCH v3] net/iavf: add debug checks for mbuf Thread-Topic: [PATCH v3] net/iavf: add debug checks for mbuf Thread-Index: AQHZP4Y1T9VuiOqQsECmjV/fzbxaD67V96OA Date: Sun, 19 Feb 2023 08:30:46 +0000 Message-ID: References: <20230202100350.668809-1-mingjinx.ye@intel.com> <20230213083150.295194-1-mingjinx.ye@intel.com> In-Reply-To: <20230213083150.295194-1-mingjinx.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|SN7PR11MB6850:EE_ x-ms-office365-filtering-correlation-id: 2b446741-da0e-4fe9-f8ec-08db1253993e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SDQglOhgiPcgmtOdb9GgRRD5Uuqy1adOQLgg8Bw/ZU+RHc5TNRzuhZJhktEQBcrwKAJHkXeB1hoy/+xyO7SNp4FQAS8Y0kpqQTjugawK7K5dNycObTAdASz5adKGpBh/xOvm0ARIVYEyK0f3kW+BEE3z6Euy7FDDtkVWAyT1XyMoTpMNu8TORGIt3nHl49TjrG4KHQ3s4PZDmiwrBzqCKxsi8ZHgrmW46tpbfJGEuR8280211/cq7ZwL7CTEwFZh/yuxaHm119C4xF1UY+D47mSSxepY1Y0pHrd37LdVny1MVfY/qZnUre8emj40feVERQf7Q6Z+D7Frzyie8a3mdcPOkV4Sj1bD1Kd4zw4zRAn6/rfzvzdElo5J4CoC+G7NutGQtQUzYPhmgRQN70Kgt6ZGMl6NgX/be6uGYvFYiDpPBkCKoRBYjh5dc5gDsfDu8+ZITrVhQMIVRb7/35XnC3DziZvJpFsXv4pYRruDgXibqzWIL9n5/QBcPOs8eNrl69EAFD1xU2Ivm61fQEUFz8jFzhlIf6H2DZb68VJMElAs7bwwFagv5OM5r0raa8yoW+p1TY+TeGJDKMHI3GUtFNSvzE4plIOLOt4w6uiEKcRBBwC3aznh7ow7zym2InhIUIu0zANnHOJq5HQhzVHT5p9WCQPxVYrHMaUhvxltqS1NULm1aNgi65wf5oUcnySx x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(39860400002)(346002)(376002)(366004)(136003)(451199018)(5660300002)(8676002)(41300700001)(450100002)(110136005)(76116006)(478600001)(66946007)(66556008)(66476007)(4326008)(52536014)(54906003)(316002)(66446008)(8936002)(64756008)(86362001)(82960400001)(55016003)(38070700005)(33656002)(7696005)(71200400001)(122000001)(6506007)(186003)(26005)(9686003)(53546011)(107886003)(2906002)(83380400001)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?j6P8IMMx6e2wst+H9jFedKadmEsKebsCZF6N2b1HRQLKD25oVijNFznl6Io4?= =?us-ascii?Q?vQr+UR6IpBJ7xHKexNeeB9+a2lP+GWQVZS+4hoAhPC2bIjVt45MdsBjX4VEI?= =?us-ascii?Q?6sB/moJJJxsBua0LibBMP3GK74gS9V7TvO2x106uI4NIAxA/FAPZG799Fy06?= =?us-ascii?Q?pQLwsMG8thW3IoMXLH9Mhznh80JQRdlEyF7tPDlZbcqhjA0Gj6T13Q0FrFVU?= =?us-ascii?Q?9tCUrBCp+U3ezS/N0036IJIWHOhWbQE29Cjg0tpy5aHX489NZ7LcldtBX1rV?= =?us-ascii?Q?1ONlr2oU2kSYJcufPjwbzn8N6JXvHuvHxcvqxgDqqUYNS9cC6poZCCodcNl1?= =?us-ascii?Q?dHNhYq/6qIM13tohtWBut8AtCIhLyDnsNtNCYQMWO3yrPFtsEGi+a3GtjjyK?= =?us-ascii?Q?PGi98wn8oVebXJavaUtjt/gNoMF9K0XH/H+23vDm5mPpPqvk1XihgMxA1dqI?= =?us-ascii?Q?zW7FPytviY/0tiuaZ0MOJEwPIdLkRWgctpXlKSenzVDeEjkbz4meR9C7WNvd?= =?us-ascii?Q?LAo5S/ZRSiuPPzldyUkjtzvO5qg//a2cJmwZbcg28MccHmWZ7IQzRYTXwTKn?= =?us-ascii?Q?O3/l1HydOQyxrxS/vsqIHf9uB8kBQu1p3UzJA1/sG/DgtYMYl7FiPAuio2BW?= =?us-ascii?Q?xEDlDzb2HfjlTaVUylo1i3jng9jN2ZIfb/DonVFKnmXI9phvKN+NXkEIysoc?= =?us-ascii?Q?Yjw2RF6ZzphkvpVV45JgiyM6i0GB2kv8qhN7bCtiKYBYhREMLHX1fRLcoEIj?= =?us-ascii?Q?+ujngvKNkcs0zkFuqr1jz3PyP9GuGOLLWCQtybK4MEiMpaogKoXamd0fmmve?= =?us-ascii?Q?y6B8CIRxx/8FDHftD65R/4aF5QnTTG9WTd5a9UuFT7e0FtrNVXru0Wq/LlzQ?= =?us-ascii?Q?x5OwLIuT8qwCAD1u7FVtHAotsRF5HNqBr+SDrkM9Y9/vFk3DgMFagFtbB1Jn?= =?us-ascii?Q?2/bxN8CRvNZYJoY9wf7iau5ud3JGvDK/VUgsNV3npPZrWWybg8GqmR8dVB/E?= =?us-ascii?Q?YXa34QQ3FpgGDZWmfS5rd6rIxzFyuMe29MbZhIEAT5vPwJZyNJai9aFDFOzy?= =?us-ascii?Q?KlkScDIVPtd9yFEdsfNodDYns7JObtm+dULkdDoQ2VpF+Cpkfoyf0m4NReEE?= =?us-ascii?Q?iG0JSk3BUlvpokXQPm9MCKG4YHrlIs72wbAjZ1xl5HR9vufU8FkXN3Oe44EB?= =?us-ascii?Q?8XWz90e4MbQtihSZzKg24TPw8Xj7dsv74+c+jYlYtody0sIfJcIcNIqTnB0S?= =?us-ascii?Q?3YsASmax2kiSCaWTrMLaDVec7tzUGU8hz8OAO8MjC2cisKp4LE2CUhjh8amb?= =?us-ascii?Q?CgmWNL7vz353vlXh00ygCa8j3ihasytcuDBUksJ3b4O3s99y8Z1C8kQ6k4YA?= =?us-ascii?Q?4liAUGXmRePXujd67qK0KgXp3TuaNgUVrjVpcFrSmkaq6JE//5jpWOmjKoel?= =?us-ascii?Q?5HS21ddCem78pshtjfoQEldGwvl0AFaakOmzUIaaQr7ykDEdo77rU5g7N3Tj?= =?us-ascii?Q?UkZtKtLu8UMG3hs0PNRK2s34ew1UV6bdCse+XBJZHOPUi9KXY8u2UHZVkIKj?= =?us-ascii?Q?UwirehuE4VmxB7G74XzWef5T7M/2bjpW+2+CW3LA?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b446741-da0e-4fe9-f8ec-08db1253993e X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2023 08:30:46.5058 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +XHJdAJbyDDbX2DksEpPC1E3yxx1qhO3WjFZwMZQ6SxXHZmyOJnJNQtccK9vR/CVcM1M9LnRMhHz6//vCa3z6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6850 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Mingjin Ye > Sent: Monday, February 13, 2023 4:32 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; stable@dpdk.org; Zhou, YidingX > ; Ye, MingjinX ; Wu, > Jingjing ; Xing, Beilei > Subject: [PATCH v3] net/iavf: add debug checks for mbuf >=20 > The scalar Tx path would send wrong mbuf that causes the kernel driver to > fire the MDD event. >=20 > This patch adds mbuf detection in tx_prepare and enables it by defining > `RTE_ETHDEV_DEBUG_TX` macro to fix this issue. If validation fails, rte_e= rrno This is a debug utility but not a fix, enable this check will significantly= downgrade the performance Removed "to fix this issue" > will be set to EINVAL and returned. >=20 > Fixes: 3fd32df381f8 ("net/iavf: check Tx packet with correct UP and queue= ") > Fixes: 12b435bf8f2f ("net/iavf: support flex desc metadata extraction") > Fixes: f28fbd1e6b50 ("net/iavf: check max SIMD bitwidth") Removed all the fix lines > Cc: stable@dpdk.org >=20 > Signed-off-by: Mingjin Ye Acked-by: Qi Zhang Applied to dpdk-next-net-intel after apply above change. Thanks Qi