From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B73C1431E9; Tue, 24 Oct 2023 07:42:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70A56402E3; Tue, 24 Oct 2023 07:42:38 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id D0C344021D for ; Tue, 24 Oct 2023 07:42:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698126156; x=1729662156; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zFsvVn+Sz8IgfxvKOhS5RShCdvkzy+vzRwuoNHrKLgY=; b=BYnTDS+4JnHx31qlHRFc5Q67H611JOhK7KAAqmMU0f2hBWdioAx2d9d7 Rj+DPST8t+5VZeWtGlW2RqInp1pCAi4MuzwcxWjonW1U1wB8hSD7Epiyn X3teC4Ff+7nxHWeVV/uVn6kiS8uJYJtX3kkjlbego/xTDaqCr8YX3Ml3u VE/nYzoL7MduoeiyLDrkLxV0iJrhiH/+ofWcYCq4Zry8V7hr2O8Z8m4pj rzA6qk9Wf/jUemaivWuho80qC7F+8zp4r867zm20lsQke7Pg3xoxzUEzJ ub6oEg1dhYdliEOL1fdj7eVcHsxJUwRcy8gc5L1cTEhV6fg9WWXWplvFa Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="390866556" X-IronPort-AV: E=Sophos;i="6.03,246,1694761200"; d="scan'208";a="390866556" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 22:42:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,246,1694761200"; d="scan'208";a="6052168" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Oct 2023 22:41:18 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 23 Oct 2023 22:42:34 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 23 Oct 2023 22:42:34 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 23 Oct 2023 22:42:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VNFlI1bxE0r2dHHi427Jsy55hwV1r8dVyATFIV3HiT6c/Cc76Vcw9tJPy3hkLXk/h4vMgGIsE/P8iBjnD+O3XdUcw+dIr1GZowjYulhBS2Tzlyzcjf/3HZjzhKz+xs6qRgO2eJp8cvGukxiKkw3zgKrHg5GnSzKP7o5ztzmoJpZdbW/V1DOBhdxBqvDiJSVJJKKH9bqRWfpRLntP1D0NtpvuWWv/oqGTqZ2ieKABTVAn0Pc9iLI3hEv2Ns27aY0VLYjoIW8c99NEM8uXrvNrOBF0E6+ehpl/moqReDz6WJJ2YH7AMJuFZCe8vbcZj8PRZ9QAwG/Sbj70U5Wa8/0Taw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GiJlfT3056f3mw7yQB556vukMq0NWAGEJS7vQgooc2E=; b=Zp1fkO/m2XoR/6dgvzq8u2EvhKA1yOUVUl8PIIKmbRt7bjTpkpHkSDtEIoJolU7m1LgR1X1CjJDbXaqmqoNvyNv4YRhkNOvOOhLgTZRmIpqh3EVfxk8cVGCqVY3sHqwm64xxHKSZyUcSdpHbBpVIgVLy93u8QLE0ysW+y4oyQS2bTOqs8VIMloh4/ccQRL02ulpP+PeCLw3aBlA82rOqR5k17i8M4rhFPlZj+tik+kJzw/yjHz5a23zYFeEgZ3D6Pm+3DvA8VJC90uItiD+M6I7idCxGZ9XohKPFnxKvftj6+tnGzznIKBnpNw4Df10jhAy7Bn98Ktj5cQyHJzKgaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DS7PR11MB7931.namprd11.prod.outlook.com (2603:10b6:8:e5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Tue, 24 Oct 2023 05:42:29 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::2df0:68d8:88ce:74cc]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::2df0:68d8:88ce:74cc%6]) with mapi id 15.20.6907.032; Tue, 24 Oct 2023 05:42:28 +0000 From: "Zhang, Qi Z" To: "Nicolau, Radu" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "Nicolau, Radu" , "stable@dpdk.org" , "Marchand, David" Subject: RE: [PATCH] net/iavf: fix Tx offloading flags check Thread-Topic: [PATCH] net/iavf: fix Tx offloading flags check Thread-Index: AQHaBc9hUOJdFcnXZkiQFHyI/ZIcFbBYbNQA Date: Tue, 24 Oct 2023 05:42:27 +0000 Message-ID: References: <20231023163803.98455-1-radu.nicolau@intel.com> In-Reply-To: <20231023163803.98455-1-radu.nicolau@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|DS7PR11MB7931:EE_ x-ms-office365-filtering-correlation-id: bfbf2685-7673-4f89-360f-08dbd4540211 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O/k589z545WlhOraqwKv9UA1FwPGAu5SC8z+sBwBVBwtWikGEiXTGADMfEEufldNFO0gVO8lDa5tU/oD/pecKks5Yih8/LD4qg2NSxTewQFnFQZKJvfBkvfxMOCdD36iIN020WoCEp0ZCjMGCLkPZIOYCmkrfhxyneXj/N4/iHggB31A/8nyhcj6VCvsmGW2WyRdM/ee3dpyCNrjA4GrbGIzgaKXq4TnCt9K0WfxXh5wp3wlaPV6TfoBkIqwtCb3wGGI/nG3HH+hq9dbrFszlOdeEkBn5jMa4fJ5zx0CBc5iVh4Qchu8Jk12oZV03SYx1GcBys6WMWAAIlWhpTF7MT+nlu7TxDdR7CW2GYt1xeNy86PbxpMCsD6MpI9NS/w1Z1N52hcDHpt6UXHHe6FjWFjXAvW1H6u5i7n2LR4U7yRuDTijMnT6YZPqb4CeZLRE8fHy3La6ItblKuonFwSBqN5Gr+PH6vcsB3T3xhGydgrHK4lvH45xl5LT3WsnfH/w+vOCriNiFLORdgmgwxvy7/mcyT/p5YpSfFl+tWrBbUD7ccAKu5q0fDlkHN/j5i+1UUJvCR/mUiOgvQAk3j4h4iK1ZFonFn4YGJkUXqQ8lmHHV59jzKZz2THf92nCIzoe x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(39860400002)(346002)(136003)(396003)(376002)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(55016003)(38070700009)(86362001)(2906002)(38100700002)(83380400001)(6506007)(7696005)(52536014)(5660300002)(4326008)(53546011)(41300700001)(122000001)(9686003)(26005)(82960400001)(478600001)(71200400001)(110136005)(8676002)(33656002)(8936002)(54906003)(66556008)(66946007)(316002)(64756008)(66476007)(66446008)(76116006)(6636002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?b629JrjYfItcOsyNyoVuR565d/Q/rVnpxF7oQ635T66GR1k/ZtDHjIVlzwFm?= =?us-ascii?Q?uiQaZdkr2kk4PmuueGLZMilItJTVqTi6FcHlhJibLB13xQj093wtRxY2eYaH?= =?us-ascii?Q?XoqeedmXjuWQ1kzqFaTeZ/8mhHzP/fLtT3C8V6INXUAjIiPGxzAVlpA49f6T?= =?us-ascii?Q?/LCXtTVCj5+I0L66BzkEaNrQ0TGhOMMIw6YSXAGFN6EY3IYqNSFWd7EGcYHt?= =?us-ascii?Q?VzFy8AAFaom+mpUWA/hKvQsITzMrHwUrd1S8nucOzAn8VuXYT1PrSRHRBGoc?= =?us-ascii?Q?hEAOoIpSAgV/+k4IzTG2ZMtgsZwwICh1TO7DDrNW97Q0nY6KAuECfO3tvhLP?= =?us-ascii?Q?+fP388psOaIaThV2DejaBQ38GaOL98sF4gzS3a2Y+vhxRtSKWukmTsN+Ipbm?= =?us-ascii?Q?ecVHrEY54UzNFfCoZF79QmG8sIZtVTd6hlF3AiVaMs0OuwjsXG6Q1bIxDy2q?= =?us-ascii?Q?NY4SCzpdhlPF42ZofDVJFRIz08nWFMlm8geoCC15g8QNAHa+EJKTjFB+xFn3?= =?us-ascii?Q?K8GzumiIy9RtROHq9a/b1XD2jT7QxkQ5ijauK2XraX8O2Yx/qfXdizJmnrkE?= =?us-ascii?Q?IQ0lrOas78rWg9Jsg8GldO617EBxAXytTEKR+hPvJ2BfO3QA9Dbqta/LSQQG?= =?us-ascii?Q?kQ85Rc2Eyil/b9mqopwxVitimkDUntAKA355yS3xd4Xg6Y4yTu6Mqaco8ZkH?= =?us-ascii?Q?yi8XR+DrmblYDjqPBx8DCRb+8m8Bv3KjsPEktBXuaP5ZCdvNxXwvZuxk589b?= =?us-ascii?Q?Oryj7Fx6r3ZEZMdgx03hYvb+7REpkzAgbrGYmookOODjzgvwbvm3ufXU5eBa?= =?us-ascii?Q?tsu/3bxEYK9ABrLyquSEKy3Z1Rq05Vsr5+2BG8htExaVsvnDZeABkPBXUVqo?= =?us-ascii?Q?WfLiOhK8uTbyIEMdliZfTk4ia3Lb69smF0YpQoKJ9fWp6/Z762/xDZDsPZaa?= =?us-ascii?Q?8kYLW0dEVTMZjKMDk5mYMlRPABkEEyIJ2nAEf6d6htpD0rIp1Kfo9Dyi9UvG?= =?us-ascii?Q?ghGbvuU8w0bgYGbXqX561TutJeUt8AajAe/FH0EAA/MsHHV2vHHtwRd4Xn02?= =?us-ascii?Q?e0BmWyVIPHi6nZ7asXdingkCPijLnA6dib5E130JTehGbUeHxG+BJrll1tpr?= =?us-ascii?Q?wJdfY+OWJR9wgbC2tzfSRgpjFpmna1cEZB7WJwB+3PkEBVDYK38++JXgTCTq?= =?us-ascii?Q?PnzmKMjHqNLj070IIyofiCgQ+1MQvWp6cUnfKe0oeVvLyKqzBJqUYXglh2MD?= =?us-ascii?Q?dPAIadB+VleC6oh7w5MTN73sMZJZMA2dmTkj/H7mg6GymkGFoDZsMU/4fcny?= =?us-ascii?Q?aNCL2uXxmiHB/gu9kw1yzMF+FH/Squs1H4r/uSsXiZ+Y563QGBiq/pqMVW28?= =?us-ascii?Q?OqUd0OffwC9M/1YVIYqa8ee41MXAhvIKg1dZFc0EjepUehyDRaICprR0szov?= =?us-ascii?Q?O0rVN3jT1Rl31HveZsGmSbBvxuHMHl9Juk+ITwz8/ucOKkw0ssXeuJqg69Fn?= =?us-ascii?Q?9Mc7RGlIAGMqg7FKx3FuRcsnU3fsG8pREOWYVFqIGVpfOdyccUP3LWhihWBz?= =?us-ascii?Q?3lQr8pe16wvdKe/xlEd9C900v0pjHXqvd4On/lIQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfbf2685-7673-4f89-360f-08dbd4540211 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2023 05:42:27.9625 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HJYe6TJnmjMZHHIVUNVzeToWjyqG71V2BZivblHd9hGOBezR5VMZZGWiuq4dTXefPap75T5CH/SFxJHNuwg58A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7931 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Radu Nicolau > Sent: Tuesday, October 24, 2023 12:38 AM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Nicolau, Radu ; > stable@dpdk.org; Marchand, David > Subject: [PATCH] net/iavf: fix Tx offloading flags check >=20 > Use IAVF_TX_OFFLOAD_MASK flags instead of > IAVF_TX_CKSUM_OFFLOAD_MASK. >=20 > Fixes: 3c715591ece0 ("net/iavf: fix checksum offloading") > Cc: stable@dpdk.org > Cc: david.marchand@redhat.com >=20 > Signed-off-by: Radu Nicolau > --- > drivers/net/iavf/iavf_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c = index > c6ef6af1d8..85f8c141ce 100644 > --- a/drivers/net/iavf/iavf_rxtx.c > +++ b/drivers/net/iavf/iavf_rxtx.c > @@ -2664,7 +2664,7 @@ iavf_build_data_desc_cmd_offset_fields(volatile > uint64_t *qw1, > l2tag1 |=3D m->vlan_tci; > } >=20 > - if ((m->ol_flags & IAVF_TX_CKSUM_OFFLOAD_MASK) =3D=3D 0) > + if ((m->ol_flags & IAVF_TX_OFFLOAD_MASK) =3D=3D 0) Not sure if this will break previous fix. Could you please provide some clarification regarding the specific offload = flags that not in IAVF_TX_CKSUM_OFFLOAD_MASK, but you still don't want to s= kip? > goto skip_cksum; >=20 > /* Set MACLEN */ > -- > 2.25.1