From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 412BFA04FD; Mon, 23 May 2022 07:36:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 282AA4014F; Mon, 23 May 2022 07:36:47 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 0560B40041 for ; Mon, 23 May 2022 07:36:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653284206; x=1684820206; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=NfgmhLU+L51cpeZqoy3ingGo7i1dp3r9xIbL2BAbx4c=; b=m0btZ9mUYGW11QSrz5GMa+VXO3YWyUivxTkH+FfspjczrWOzBK0YKG/i LbIqWfQEjUR3qDEzpjtUgjw0Iwnjsrhjk/Wm2A945OnylRfzC35dItoT3 h0J4t8UbnujAV2WJTFkXEXLMXaasaGmEB1h0tjwE4FCCgH+TDLTDJnWa5 A+hrqji7Lqoe7IBqkE0vrvgNTmwBCgvi3gWY8BOfYEtvjZ3ejO6qDRw+w gpPVK8g1+dyF4theFkxdHSRNa9Al64CHQqqAjbwvMj/J4Yc9IFzzLi2cD nyLJWoiDZ/S0ejQ9hbwIcwEZrcbkyruLibfjfNg/k+3Ku6fK3xbn3/X7/ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10355"; a="270680268" X-IronPort-AV: E=Sophos;i="5.91,245,1647327600"; d="scan'208";a="270680268" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2022 22:36:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,245,1647327600"; d="scan'208";a="608027971" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga001.jf.intel.com with ESMTP; 22 May 2022 22:36:44 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 22 May 2022 22:36:44 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 22 May 2022 22:36:44 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 22 May 2022 22:36:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mgRCo3ejGAO7D/mGHXmAD9CzEEHGbjg0XnfiXileYnt0WGRqo1cjC3xaiBVsSLFxjKHu3L+DUx6kDgp0HW9L1pRnAhu+IjcOWXDP/54HtmfMZqaciYk8Fba1ceQnUC01u0rj6fSSgC86t/t5P9xllqI53CvbFYTuRW43W22j+8Q4o/ws97ndMl4cfKDRAhydot/Jmv0UZW8CdLZaVPqkr/ICRzqlE5iYE/ciIGEAixAzM3LhXGWXIkIvKrTNlBPam931aT4BcMc6aKKejIsMjESR38OSCxBJN7iUdx2a5MlWLUc0SpNC6/OqpMYW0O6WwY4Os7gUZqjV4cCjLChJ4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rZbi74oQfwr5xr2Gp1n2iAYQiTqQ0wXCo8bx0XawTB4=; b=fKECJejNnGmuEnOsZ02KrVCRHKjRNfZ+7AMscMdxZE2wtNhdaDUKCZVWgmGXWRXDLBbaXf9AZG3ymaW0hgYfuFkfD7YxwhgS1zVkSqgYGNIV9+JExR12uCGGCfbv/bTmFt/3zTaB2cn3WzcnzV8STQeyCJIh5BK+ThR9cjnxClxktfqBuX9NT6GGCYqyMXEi0dJuSbwzuKi/8dj/E0Rt+IQiFKWeu1/ZlRI5a7phSErYlDdJdlajN28RJufaKY0Wn18l26d6y5pR8v+m6ybfSlHxVvXIiUEPDIUnsR/Pb8laOuc16LQpjPklOmKD1hBgjpngGw+bArKnpIchB9E+Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by CY4PR11MB2006.namprd11.prod.outlook.com (2603:10b6:903:2f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Mon, 23 May 2022 05:36:42 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7%7]) with mapi id 15.20.5273.022; Mon, 23 May 2022 05:36:42 +0000 From: "Zhang, Qi Z" To: "Daly, Jeff" , Thomas Monjalon , "dev@dpdk.org" CC: Stephen Douthit , "Yang, Qiming" , "Wu, Wenjun1" Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Topic: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Index: AQHYMnOyeQTUxssyHEy+SSEKCDh1Cqzuk+wAgDi80mCAATIIgIAD4m+Q Date: Mon, 23 May 2022 05:36:41 +0000 Message-ID: References: <20220307223442.28012-1-jeffd@silicom-usa.com> <1681763.yIU609i1g2@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b53ca16-dfae-484f-16d3-08da3c7e376e x-ms-traffictypediagnostic: CY4PR11MB2006:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v4so53ydrDvqWZh1MlNYyf+SHUpuHOxpNUPVH0gEvX2HGIavJmmFKHXx0QHlWsUakHCkE0+IrqPFP58j9rCapfa0Q+kPSs/WmfLTZPReRUd0h9QeleTNBJTrvMsNMV7sRyH/Z5oQ0h24NCcKRM17vP03z41q+CzOKsI5xg69+OMfPhz9fGZcx658XPVoy6loVROXbO9HTQ1A3C7HVd6ZuNJUqAPlINqusF4l6DGE4spfee4jjgU5eO4F1hSn+dNndy/foqJSHoupVjYu2/jFZEEK9WDatDAb72zmtVNPvzBEzNvW+KhSAKp65EXJH2m7blBvTburZZP8K/ZvLXRsI+tqQbDf9rIxVTBZSAKsdZ2NABFGg9oCu2BE+EzlIP8DSMSsqGb5BkmEcSf7fxC2sM2rJcLq73qG/Z+DqtIFwFC4ey6lUhI+PaK9R4IGDLN4EwyVkod2IAwAFsDwz91OmioOHbI7PnOcDuk94RJaw99chsTYAcFsdp9KddkHd+RuEu7Zhs2E/t0TAK1hRLvJt1flg02eJbIKCzzWVGCBFwPsc/uKoJQ1GS7XnBWjwdQ3rK3iJZAxdCjUSr3j2Pg+FlMR2HV+Lvi/GkkEesD7WJVZUsREjhqUj/667O3ybxsBUvle5LBRlu8q1R+COy6HFqWnRjGE9ljb4BFTswvyglVUIcver5pLoNJb/JGbQwXM/cKLi4yKwlMD8UFfAhy/4fBMH423L6RQtcReh+xTsApkmAj+I+gaemlehGaMDrdpHe2p0RC1OLIhke5qg0FFHuiIbcvHxdmBenE7ybkNQJU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(55016003)(38100700002)(316002)(8936002)(66946007)(2906002)(52536014)(38070700005)(76116006)(110136005)(54906003)(966005)(86362001)(4326008)(8676002)(66556008)(66476007)(66446008)(64756008)(82960400001)(5660300002)(9686003)(107886003)(122000001)(53546011)(6506007)(508600001)(26005)(71200400001)(33656002)(7696005)(83380400001)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fIzJzQb9idy8yBV0ueqdQkvP9JrYXvE9YXl2RGoIZmGBHZg8MG3XgAWjVR7n?= =?us-ascii?Q?ZXQRvMSINGcLmmnJ/C/12i320j6Szzh9fEYQaZ0KuVYwVAgDjQUETB6OuCeR?= =?us-ascii?Q?rubeQxM9uFoLlWCnL0/qIjur8rE/CpiCq4GlJ0WrBpYblhG7lmTiCLjxdcCV?= =?us-ascii?Q?niVsdY9pCh5kAFbDyOyjIpBNk/WMKQwq3iQ6tqHchYS4JVdmUlGql2vWKgBJ?= =?us-ascii?Q?L87nvv5ivESvTsEuP70O2XJokCSbY79MocGK9OMRvrtuXbQzxhgN+i9eJvUR?= =?us-ascii?Q?SAZAhXaTQduUC4u6unBwJ4ef6EPavdlm03/cdNCAtEPICQbfMbg+mDWf230u?= =?us-ascii?Q?F6Tw/pSj43mGDWD4hFEb2Mx481u7iQaLRS8ubc2V3MlI0rIzBwka/aH205o1?= =?us-ascii?Q?AjUQ5/MhB4A8pwSEUQy9OkxnZGwg86FgNhKr8H3Ctlz8zyj7fiQ9/eEPRVGU?= =?us-ascii?Q?xsFDUT/vVcEAtz1NB9gtfRHoAWI7wOrmtAPb8et0X+4mYoUlooK4NA79I0RC?= =?us-ascii?Q?2/NUwzhFOP48xwXz/rXqM1w1uqyK8969A4GQcU4euzYaHhq+KZc9bg6oPP+e?= =?us-ascii?Q?0omZr9GpboxOHBfMO4uJedRDSyfuveCeUdwfIQCy8kmotFqKe3SzEQ65/CsW?= =?us-ascii?Q?lYKax4D4tLok5mvjv2CrEKGjCeMgM13JRLFkaQ9yMlSQinqBng2YY9rRBQqZ?= =?us-ascii?Q?jrwZNg5/x+jq1BTPYPs6mEq3yYlfKk2+RD5U5HEMw2tsMpt4cktubrbC9GYM?= =?us-ascii?Q?k8q/Bi4ZdhdvR9NOof8jZ1EWfMrHLaJRUvaTJ/I0kuFm9T2wfyFvgpJmlxp3?= =?us-ascii?Q?jZym3CJn/YKYf40TNZ46gX44JzCos0XUFrDwIW077jXGiTF6KexNYRmRcchS?= =?us-ascii?Q?HrlDDyC+tysecdAi2g9qduZP8oLKLazfcDca36Lc9Iy6azfmw5QLz+cjaRdt?= =?us-ascii?Q?DblJLBmI0GgaGk1e04dhl8LvHiBWEPngEYu2tID8h23k02nckZzgt/aVwZtk?= =?us-ascii?Q?nIXuv/6la7jDUWCJPH7l47axzBbRrQZeGOAjnnWgyu2ZQzk7KMMh8jaus88M?= =?us-ascii?Q?F0wBmV8YaNcgYibg3oYE9ipcCeWGc4e0r99b77JBjhjIfHbxaqw/ulrBGZ9Z?= =?us-ascii?Q?HncFFUl23+JWfFLsK7pgrJMEzLvlRlwjjVpN0dgXzWDMoOEvKstLRQBpEQiL?= =?us-ascii?Q?PFhuk9WEofkRLTHX7U4SfMJ1qPgDtoXI0kvyjllmuMXqnO84kBi3dByKvvly?= =?us-ascii?Q?cu68OmesWaEjuqZ07i0wjHYO9f/Nqq1BIXIT584SdNFt+2ifzVqRg7tLIca9?= =?us-ascii?Q?JAaF5+AT9ElHyCVUAeZdq4+A+PCpDqEtwfAZnFywfzP2HKVxRKvzY5HCEZl7?= =?us-ascii?Q?AJos9EphuXmG2lGqiTUBICQNbvqPD5LdGzWiqSU1RH60l5PCSXbUVdFbaYRR?= =?us-ascii?Q?iA3EVWJeBNVJID9hNg6/qiUCG8V+AY1Uo/CSLhMDdLvTbqkHW9VkUSurvCI0?= =?us-ascii?Q?+RMgsDyuYYxm+THzg/PymP/EEpIbj3wZabC9KD58BWMVdM135asUt1zZiwbz?= =?us-ascii?Q?/FMfdC5CEkNnD+eMUWVI6ywYiV2zCe+jj5Vb4XSj/p/1DhbdJaq9UDV6nMzD?= =?us-ascii?Q?Y32YOzhXN7JNrSifXfPxSna4feGYy7AN4SzEv3SJ55Y1Vyu2UZS9ZIeSKl82?= =?us-ascii?Q?SINSMP64RjFgboMYoqlGGM6MhYnOSCAIkjATsivU0DMs6vpZNjFEHGMa/fhX?= =?us-ascii?Q?nUdU8MnH5Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b53ca16-dfae-484f-16d3-08da3c7e376e X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2022 05:36:41.9541 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yY+k02zsNAg06sGeNmYlBopc4QA4A/pzgzmPzlt6ZUFSo/45w6YtFGcLprKoGhkh2Gi0tkEt6BTmM7biTwFOTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB2006 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Jeff Daly > Sent: Saturday, May 21, 2022 2:03 AM > To: Zhang, Qi Z ; Thomas Monjalon > ; dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 dev= ices >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Thursday, May 19, 2022 8:15 PM > > To: Thomas Monjalon ; dev@dpdk.org > > Cc: Stephen Douthit ; Jeff Daly > > ; Yang, Qiming ; Wu, > > Wenjun1 > > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > > devices > > > > Caution: This is an external email. Please take care when clicking > > links or opening attachments. > > > > > > > -----Original Message----- > > > From: Thomas Monjalon > > > Sent: Wednesday, April 13, 2022 10:21 PM > > > To: dev@dpdk.org > > > Cc: Stephen Douthit ; Jeff Daly > > > ; Wang, Haiyue ; > > > Yang, Qiming ; Wu, Wenjun1 > > > > > > Subject: Re: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the > > > X550 devices > > > > > > Please, could we have a review of this patch? > > > +Cc new ixgbe maintainers > > > > > > > > > 07/03/2022 23:34, jeffd@silicom-usa.com: > > > > From: Stephen Douthit > > > > > > > > 1G Cu SFPs are not officially supported on the X552/X553 family of > > > > devices but treat them as 1G SX modules since they usually work. > > > > Print a warning though since support isn't validated, similar to > > > > what already happens for other unofficially supported SFPs enabled > > > > via the allow_unsupported_sfps parameter inherited from the > > > > mainline > > Linux driver. > > > > > > > > Signed-off-by: Stephen Douthit > > > > Signed-off-by: Jeff Daly > > > > I think we need a devargs for this feature with well documentation So, > > it should not break existing behavior by default, but allow people to > > take risk if they know what they are doing. > > >=20 > there was already a patch submitted to IWL mailing list for this feature = in the > base driver, which was rejected. > https://patchwork.ozlabs.org/project/intel-wired- > lan/patch/20220414201329.27714-1-jeffd@silicom-usa.com/ OK, thanks for sharing this,=20 But base on the concern of the previous comment=20 " As for 1G Cu SFP treating it as 1G SX, some 1G-Base-T SFP modules require= the use of RX_ILOS and some Intel Ethernet products don't support that." We may have a risk to accept the code as default behavior But devargs is allowed in DPDK for device-specific features. >=20 > > Thanks > > Qi > > > > > > > > --- > > > > drivers/net/ixgbe/base/ixgbe_x550.c | 14 +++++++++++++- > > > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c > > > > b/drivers/net/ixgbe/base/ixgbe_x550.c > > > > index 8810d1658e..8d1bc6c80d 100644 > > > > --- a/drivers/net/ixgbe/base/ixgbe_x550.c > > > > +++ b/drivers/net/ixgbe/base/ixgbe_x550.c > > > > @@ -1538,9 +1538,21 @@ STATIC s32 > > > ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool > > > *linear) > > > > case ixgbe_sfp_type_1g_lha_core1: > > > > *linear =3D false; > > > > break; > > > > - case ixgbe_sfp_type_unknown: > > > > + /* Copper SFPs are not officially supported for x550em > > > > + devices, but > > can > > > > + * often be made to work at fixed 1G speeds. Pretend they're 1= g_sx > > > > + * modules here to allow g.Fast DSL SFPs to work. > > > > + */ > > > > case ixgbe_sfp_type_1g_cu_core0: > > > > + EWARN(hw, "Pretending that unsupported 1g_cu SFP is > > > 1g_sx\n"); > > > > + *linear =3D false; > > > > + hw->phy.sfp_type =3D ixgbe_sfp_type_1g_sx_core0; > > > > + break; > > > > case ixgbe_sfp_type_1g_cu_core1: > > > > + EWARN(hw, "Pretending that unsupported 1g_cu SFP is > > > 1g_sx\n"); > > > > + *linear =3D false; > > > > + hw->phy.sfp_type =3D ixgbe_sfp_type_1g_sx_core1; > > > > + break; > > > > + case ixgbe_sfp_type_unknown: > > > > default: > > > > return IXGBE_ERR_SFP_NOT_SUPPORTED; > > > > } > > > > > > > > > > > > > > >