RE: [PATCH v2 3/3] net/ixgbe: move bypass init in a testpmd command

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@xilinx.com>
> Sent: Tuesday, June 21, 2022 3:04 AM
> To: Yang, Qiming <qiming.yang@intel.com>; Wu, Wenjun1
> <wenjun1.wu@intel.com>; Jiang, YuX <yux.jiang@intel.com>
> Cc: Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman Deep
> <aman.deep.singh@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>;
> dev@dpdk.org; David Marchand <david.marchand@redhat.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: Re: [PATCH v2 3/3] net/ixgbe: move bypass init in a testpmd command
> 
> On 6/17/2022 6:07 AM, David Marchand wrote:
> > Introduce a new command and remove the last part of specific port init
> > from testpmd.
> >
> > Signed-off-by: David Marchand<david.marchand@redhat.com>
> > ---
> >   app/test-pmd/meson.build          |  1 -
> >   app/test-pmd/testpmd.c            |  4 --
> >   doc/guides/nics/ixgbe.rst         |  7 +++
> >   drivers/net/ixgbe/ixgbe_testpmd.c | 82
> +++++++++++++++++++++++++++++++
> >   4 files changed, 89 insertions(+), 5 deletions(-)
> >
> > diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build index
> > 69c7595a45..d13e98125e 100644
> > --- a/app/test-pmd/meson.build
> > +++ b/app/test-pmd/meson.build
> > @@ -68,7 +68,6 @@ if dpdk_conf.has('RTE_NET_I40E')
> >       deps += 'net_i40e'
> >   endif
> >   if dpdk_conf.has('RTE_NET_IXGBE')
> > -    cflags += ['-DRTE_LIBRTE_IXGBE_BYPASS']
> >       deps += 'net_ixgbe'
> >   endif
> >   if dpdk_conf.has('RTE_NET_DPAA')
> > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> > 4e8523f961..e11e2e2cb8 100644
> > --- a/app/test-pmd/testpmd.c
> > +++ b/app/test-pmd/testpmd.c
> > @@ -3949,10 +3949,6 @@ init_port_config(void)
> >   		if (ret != 0)
> >   			return;
> >
> > -#if defined RTE_NET_IXGBE && defined RTE_LIBRTE_IXGBE_BYPASS
> > -		rte_pmd_ixgbe_bypass_init(pid);
> > -#endif
> > -
> >   		if (lsc_interrupt && (*port->dev_info.dev_flags &
> RTE_ETH_DEV_INTR_LSC))
> >   			port->dev_conf.intr_conf.lsc = 1;
> >   		if (rmv_interrupt && (*port->dev_info.dev_flags &
> > RTE_ETH_DEV_INTR_RMV)) diff --git a/doc/guides/nics/ixgbe.rst
> > b/doc/guides/nics/ixgbe.rst index ea4684c2dc..d450fc1ca0 100644
> > --- a/doc/guides/nics/ixgbe.rst
> > +++ b/doc/guides/nics/ixgbe.rst
> > @@ -418,6 +418,13 @@ Set all TCs' TX min relative bandwidth (%) globally
> for all PF and VFs::
> >
> >      testpmd> set tc tx min-bandwidth (port_id) (bw1, bw2, ...)
> >
> > +port config bypass
> > +~~~~~~~~~~~~~~~~~~
> > +
> > +Enable/disable bypass feature::
> > +
> > +   port config bypass (port_id) (on|off)
> > +
> 
> Hi Qiming, Wenjun, Yu,
> 
> For me changes looks good but this set changes ixgbe bypass configuration in
> testpmd, instead of it being enabled by default, now an explicit command needs
> to be issued. This also can affect bypass testing.
> 
> Can you please test/comment on the set for the ixgbe bypass? For both
> functional and dts testing perspective?

Thanks for capture this, after internal discussion, though we think its low risk but we prefer to hold on this patch merge before get the result of a ixgbe regression test.

If we missed RC2, we should be able to capture it in RC3.

Thanks
Qi

> 
> Thanks,
> ferruh