From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D63442A01; Wed, 26 Apr 2023 10:15:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BFF9410FA; Wed, 26 Apr 2023 10:15:56 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 5737D40DDA for ; Wed, 26 Apr 2023 10:15:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682496954; x=1714032954; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=UeNF5v+9r80ivz1gnl9X7n57F8Ny1ammCLvXBUPOsvo=; b=IlhXTEwWzqV7zZ4EG3Klk9iUPVUipGTbnpyW7KDfKMAMzXKqAysbEffF 8VQ97YYOm/jM0ea0dtRgxUlKJzhvhoKdi1FuYwFpUc3BOAL02yuXw2x6H MoFrdOe5DC/RkU9D/qXPraGWXVDyDkL0JAoIxqtEnSGcAwVTi09q183Lk XQoYVqL5D70zRLx0zpKAj8NzCES72Fhqb4mPvtiv3IpxbBCUvHmh+8jEX 8WQUBD+kRXxBvGQCtsDuLSMfvg0YZHkWg6HjkXKg1Tp+IjZC3xtIm9d0M xK/4nTJ/8FEn39PKHCttOEbu13uyS7Q39QsD1JZY4zccVD0hZf61/MaOA g==; X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="331263953" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="331263953" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2023 01:15:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="868203331" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="868203331" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 26 Apr 2023 01:15:53 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 26 Apr 2023 01:15:53 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 26 Apr 2023 01:15:52 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 26 Apr 2023 01:15:52 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 26 Apr 2023 01:15:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CBFjynjV80PCFjbKQjEUFlH+60y9PRUg2RcfCKf4W7KCE9oS25ERfSEK771CdBk5Jz6SPVbHkEM5bWhnNdehZ2dJ8KahEMyPcbNC2StHeI84f3xvtA714jaqSLvDZi+RVO6oDYpb5augeg+9DFs8WUfuozYccptg9aMMzdvipJRuo21ZLqTtnLsHlLB6s7AIBf2VBUMbCOsG3zaQWSGGRxLOgLbr86buqPHUxZGwDMQgKmXdGsJfEJubhAekG76CT0bdGxLUP7l8TYfdq30eZWD52QRm76IRiHkUE2c68/eSHh/u8jHWWJb0RBzEYFYS/VIUb4TaEOiy5puuV9ydSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y+3xByUceDGIiJtj/uSh+nyDHwqxnV5Vna3SiPDZ/qo=; b=bRGpGHssKIAaoTycbXf6kUNC0ReKD91eyjribslMFfcOWoEmSYs4jwSIFoORCIhDSHTCySvTXKtJB3uWOgGX+Csjuc8sc0fexWxtHbamqCt5nlPElU3tMfNX0QeobGYF5WGnUPAJh2fwZZDqASNtM3Ihmbi+awJgLbxTdUwrjl+DxQd4+EaVegldvxyvmr49Be9OusaeT0w/m0dmS8rpk4iw0Xrpzy/i3yKQUasDbUUZuyaiW+emsdLi8n/SaR/7Qwzxar94vfj+h5Ar/rtJZwY2IZfwi/Z6tAF15nthxv3/PswLnSCs8IfgYo3429gXls4Sd76kijB0OTS+aYzLlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Wed, 26 Apr 2023 08:15:50 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6319.034; Wed, 26 Apr 2023 08:15:50 +0000 From: "Zhang, Qi Z" To: "Yan, Zhirun" , "dev@dpdk.org" , "Yang, Qiming" CC: "Wang, Xiao W" Subject: RE: [PATCH v1 2/3] net/ice: fix outer src mac as FDIR input field Thread-Topic: [PATCH v1 2/3] net/ice: fix outer src mac as FDIR input field Thread-Index: AQHYheS7Xs+jUOwAFUavk4oPCsukZ68/Imkw Date: Wed, 26 Apr 2023 08:15:50 +0000 Message-ID: References: <20220622030032.474770-1-zhirun.yan@intel.com> <20220622030032.474770-3-zhirun.yan@intel.com> In-Reply-To: <20220622030032.474770-3-zhirun.yan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|DM4PR11MB7303:EE_ x-ms-office365-filtering-correlation-id: 74e84109-8e10-4d2d-c63d-08db462e7281 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CqJObt1nIE33dy7ZjoFMXnppYAubbXIL1aQIZo1PQ02p9oi/F3ZEDV/PlBPNpvBaeSoAKe6eYS1yX6A4VAlOdF1R+N6szO6tVJwM8y9JfpJ+aU0om0B/bjjWInvyaa9sdSZNhdADu5OZnH6ElUL5roUHUlHiEOKZo6AP37yHYLUGo2R7jRdzStL4Q+tISa0YB7Rp3mwlIu0PmCQpTc2/Z1Q6nebHLt85YdFDphBNHA8vCZGp0YYGbKAp/Sc7NEtwmhjwMswxoMUqXDJy0OINtJYYKLpASgPV7Dq2C3yF9+BVqZa978tGI0mZX4tQ7JJobnj44qVeino8iWbh4NX/AG92uouemojqkcJAooXcjsMYwDLvsGYW+TPFBbOJIP4pUaB9HPZ+mv9LfoV9J7oZxS9v2DjnQciBUsPle3PwgJfwZzdOZnHskG3L2X+57PaFZjZd7NYp88S0AvDdRNchIBvvCXl7Dd8a4CElcPagKLgPijbbcpBF3Rr/rJNNhxNUv+Q3qu6qOM1f7N+bb20nLqujzSfwuyFf1PItYdDyZJLXHSlsJPberZ+wDizIgcGcXO84AlT8Tsn0gIbGW5/JaCCTdUsy9h1EdW54hd95Ni0zUGVfn9kuinc1DwlfaEPe x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(396003)(346002)(366004)(39860400002)(376002)(451199021)(107886003)(6506007)(9686003)(26005)(110136005)(478600001)(38070700005)(38100700002)(71200400001)(122000001)(41300700001)(5660300002)(33656002)(8676002)(316002)(86362001)(55016003)(8936002)(52536014)(4326008)(66446008)(64756008)(66946007)(66476007)(6636002)(66556008)(76116006)(7696005)(2906002)(82960400001)(83380400001)(53546011)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5QHeqGf36dazUHCr31NX3gRkbe3G2yxuA5/l6fbp19Nq28VUeBgOSfSpmBXK?= =?us-ascii?Q?weADunJDIxHTAoFK/SFQNowjfMfFmaJffFKH2MDbAgNTUqu6ez6eupOiyS7h?= =?us-ascii?Q?Qvi4iPGUx+rgXvf7rbsOPiVHn8OGzqiptuMivTdVXEKfxn+k31NxZiOy4RoM?= =?us-ascii?Q?FrWS2jMz7ckWV6Otd2IzvvahybLg8dsRnKMyzb6lyecIIhBgA+XHIvdD71zs?= =?us-ascii?Q?zAsT8tjaUKJ1TXRQkDvZdY8d+INyDP3trI51vFLB9euppY4RagrTuJOG4Maw?= =?us-ascii?Q?o1c/7+3qVbysTWeMlpKhcXME+hy29XoC60ZWCPU8ydVxooLo82CxNpqbEvQh?= =?us-ascii?Q?+a0APMZsyg4WbIRTc5bGRwqUKoG4nQpt6DeO63VaJR0cMFepUvLxqgDmeqZt?= =?us-ascii?Q?oBi4VT6CC7sOTkX7TOjMbbLwIQ97vC/YBbYwNM2OkRN8hfwLWIlu4tImCi9v?= =?us-ascii?Q?vMTkNWK8KCPRtQAj/e0mqOLAoWJSEDlM1kIAVj6wIz5rDaapVzRc7f19Z9Zq?= =?us-ascii?Q?UDDlEUDs/QVRtNXyIU2vr7kvCAvX6rDGuFlQdfSlrB0QO9bsmU2E2KTgMTjO?= =?us-ascii?Q?kDFTpmXHrXYSlsQ5ybnIHr0kURCBZAuYVk8THqMhdQnranj2++gD4cIYre37?= =?us-ascii?Q?OkMmWCuuubPv8p6yLCcvm13gKf2AD1q4gpEaWw0Kq9mjiv7IzTyTro7gWfjq?= =?us-ascii?Q?Gsp09h7ZBxLb7y6D2jzA0Vx4j7YL7k08Z7hZF3E8AFyEA8LwWN8jvhDipmF5?= =?us-ascii?Q?fZGogGkAZqVh8E2YPZhUiE0yZGHfk70TWaqcclmQZ24tYLuA2Ua8QnpOiWDu?= =?us-ascii?Q?k9RtYm8sscdTiZF4eCRO9hsyR9tAhNnsukuw9//ePJovLIgha89AD/CwvR6H?= =?us-ascii?Q?30+qaGsxRWl9TgW4OCsd0ErseRofh/WRpZzxYDqGaUysyXrqFjARi68RVxxo?= =?us-ascii?Q?WN8QfFD8jAZ1DdPvNxSsgUwmsKi++2epzhxIQASp6sgF0iWF6rkyPnDN085a?= =?us-ascii?Q?NyFfDAZCbyMZa+CtjfPsumUrzYlpKuNjJFpTTnXaTUPn772PeBHbf4UOhdLC?= =?us-ascii?Q?0w7bGJLq6p87wdF4pyokGNwR5M19ssHGfSB9YCBXSdzr4OmvlodN9WaQaWlS?= =?us-ascii?Q?t4Z2KDNtj1oBsnzPwvKEXv7Gl85Vds/+IlqnIN8rWMh9fHnTLWk9rFmUKWkN?= =?us-ascii?Q?1TRL1ck9xvIHKjg0IlXx5Doonk6ZqR3ag9TotWb3W4pBenY2NfOi6yQSb8Uu?= =?us-ascii?Q?AhikVxKKx/vhHiVeMg2lQmyK2Uf6mZeX6TKFjedLDIfsVuN0YspmWhApVySI?= =?us-ascii?Q?ruVdBquAJuMaK9VezzMioOk/kQAWFO3F+IOTDHv5Ygg7oiJOFOUBrVQnk+un?= =?us-ascii?Q?PP0PEqZgofiJXOsuHHDgAtcwm7e94FRBiYS/PKIXnVK5jIq9vq+FE4Fc9WiN?= =?us-ascii?Q?Y7DGcD28YU5fOlVopOXdlhGjFzrPIRmUQlyzBMAm8D3iIc8CL0AcDh7ZRsU/?= =?us-ascii?Q?4jZ35tGLkvcOnpP2C24C0+MptV0KFXPcZCiGDNPZAXi9IrdYHiAgXJY42+xg?= =?us-ascii?Q?GBdYvTzogcgglstPaGIytua+TFxTiu+BUA2EjGKQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74e84109-8e10-4d2d-c63d-08db462e7281 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2023 08:15:50.5988 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aR+gm3taWH+iGy2Sa0iGJ8iIdi8/d9c3jxpJmxXfqnq0hKRdcLX6/bQwTHEh/t/5hiTcKK0z581WsN6eMeESiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7303 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Yan, Zhirun > Sent: Wednesday, June 22, 2022 11:01 AM > To: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > > Cc: Wang, Xiao W ; Yan, Zhirun > > Subject: [PATCH v1 2/3] net/ice: fix outer src mac as FDIR input field >=20 > Add src mac in input set map. If not add this, the src mac can not be par= sed > and this field will be ignored. > Add outer mac as extracted key input to avoid rule conflict for VXLAN rul= e > when outer src mac change only. Looks like you add some new feature to support outer mac match, so it is no= t necessary be a fix right? >=20 > Signed-off-by: Zhirun Yan > --- > drivers/net/ice/ice_ethdev.h | 3 +++ > drivers/net/ice/ice_fdir_filter.c | 3 +++ > 2 files changed, 6 insertions(+) >=20 > diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h = index > ec23dae665..791e8566ea 100644 > --- a/drivers/net/ice/ice_ethdev.h > +++ b/drivers/net/ice/ice_ethdev.h > @@ -366,6 +366,9 @@ struct ice_fdir_fltr_pattern { > struct ice_fdir_extra ext_data; > struct ice_fdir_extra ext_mask; >=20 > + struct ice_fdir_extra ext_data_outer; > + struct ice_fdir_extra ext_mask_outer; > + > enum ice_fdir_tunnel_type tunnel_type; }; >=20 > diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir= _filter.c > index 7914ba9407..4b0b6b5b23 100644 > --- a/drivers/net/ice/ice_fdir_filter.c > +++ b/drivers/net/ice/ice_fdir_filter.c > @@ -919,6 +919,7 @@ ice_fdir_input_set_parse(uint64_t inset, enum > ice_flow_field *field) > enum ice_flow_field fld; > }; > static const struct ice_inset_map ice_inset_map[] =3D { > + {ICE_INSET_SMAC, ICE_FLOW_FIELD_IDX_ETH_SA}, > {ICE_INSET_DMAC, ICE_FLOW_FIELD_IDX_ETH_DA}, > {ICE_INSET_ETHERTYPE, ICE_FLOW_FIELD_IDX_ETH_TYPE}, > {ICE_INSET_IPV4_SRC, ICE_FLOW_FIELD_IDX_IPV4_SA}, @@ > -1247,6 +1248,8 @@ ice_fdir_extract_fltr_key(struct ice_fdir_fltr_pattern > *key, > rte_memcpy(&key->ext_data, &input->ext_data, sizeof(key- > >ext_data)); > rte_memcpy(&key->ext_mask, &input->ext_mask, sizeof(key- > >ext_mask)); >=20 > + rte_memcpy(&key->ext_data_outer, &input->ext_data_outer, > sizeof(key->ext_data_outer)); > + rte_memcpy(&key->ext_mask_outer, &input->ext_mask_outer, > +sizeof(key->ext_mask_outer)); > rte_memcpy(&key->gtpu_data, &input->gtpu_data, sizeof(key- > >gtpu_data)); > rte_memcpy(&key->gtpu_mask, &input->gtpu_mask, sizeof(key- > >gtpu_mask)); >=20 > -- > 2.25.1