DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"echaudro@redhat.com" <echaudro@redhat.com>,
	"mkp@redhat.com" <mkp@redhat.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Doherty, Declan" <declan.doherty@intel.com>,
	"Sinha, Abhijit" <abhijit.sinha@intel.com>,
	"Nicolau, Radu" <radu.nicolau@intel.com>
Subject: RE: [PATCH] net/iavf: fix checksum offloading
Date: Tue, 22 Aug 2023 01:52:01 +0000	[thread overview]
Message-ID: <DM4PR11MB5994A5BB21057B538F6FD3BFD71FA@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8xJqmKAWLKViNNFHOW7W4qqHQ2UKjR0=r5BZBoA5ep4uQ@mail.gmail.com>



> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, August 22, 2023 1:29 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; echaudro@redhat.com; mkp@redhat.com;
> stable@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Doherty, Declan <declan.doherty@intel.com>; Sinha,
> Abhijit <abhijit.sinha@intel.com>; Nicolau, Radu <radu.nicolau@intel.com>
> Subject: Re: [PATCH] net/iavf: fix checksum offloading
> 
> On Mon, Aug 21, 2023 at 1:54 PM Zhang, Qi Z <qi.z.zhang@intel.com> wrote:
> > > Subject: [PATCH] net/iavf: fix checksum offloading
> > >
> > > The only presence of RTE_MBUF_F_TX_IPV4 can't be used as an
> > > indicator that a checksum offload has been requested by an application.
> >
> > According to current implementation, actually the only presence of
> RTE_MBUF_F_TX_IPV4 will cause IIPT = 10b, this scenario corresponds to an
> 'IPv4 packet with no IP checksum offload,' according to datasheet.
> > So, I assume in this situation, the PMD  continues to operate under the
> assumption that the application has not requested checksum offloading.
> >
> > Could you share more insight what is the failure,  maybe we can perform a
> more comprehensive investigation?
> 
> I think the missing piece is that OVS passes a l2_len == l3_len == 0.
> In our tests, we could see that tx_errors get incremented for each failed packet
> to transmit.

OK, do you think to ignore RTE_MBUF_F_TX_IPV4 when l3_len = 0 is a better fix?

> 
> 
> --
> David Marchand


  reply	other threads:[~2023-08-22  1:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18  9:03 David Marchand
2023-08-21  8:03 ` Eelco Chaudron
2023-08-21  8:22   ` David Marchand
2023-08-21 11:54 ` Zhang, Qi Z
2023-08-21 17:29   ` David Marchand
2023-08-22  1:52     ` Zhang, Qi Z [this message]
2023-08-22  6:11       ` David Marchand
2023-08-22  7:33         ` Zhang, Qi Z
2023-08-22  7:39           ` David Marchand
2023-08-22  7:59             ` Zhang, Qi Z
2023-08-22 10:10               ` Zhang, Qi Z
2023-08-23  6:29 ` [PATCH v2] " David Marchand
2023-08-23  8:33   ` Zhang, Qi Z
2023-08-24 15:24     ` Patrick Robb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR11MB5994A5BB21057B538F6FD3BFD71FA@DM4PR11MB5994.namprd11.prod.outlook.com \
    --to=qi.z.zhang@intel.com \
    --cc=abhijit.sinha@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=echaudro@redhat.com \
    --cc=jingjing.wu@intel.com \
    --cc=mkp@redhat.com \
    --cc=radu.nicolau@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).