DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/igc: add I226 support
@ 2022-05-19  6:04 Qiming Yang
  2022-05-25  5:57 ` [PATCH v2] " Qiming Yang
  0 siblings, 1 reply; 11+ messages in thread
From: Qiming Yang @ 2022-05-19  6:04 UTC (permalink / raw)
  To: dev, qi.z.zhang; +Cc: Qiming Yang, Kevin Liu

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 5933 bytes --]

Added I226 Series device ID in igc driver and updated igc guide
doc for new devices.

Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
---
 doc/guides/nics/igc.rst                | 14 +++++++-------
 doc/guides/rel_notes/release_22_03.rst |  5 +++++
 drivers/net/igc/base/igc_api.c         |  6 ++++++
 drivers/net/igc/base/igc_defines.h     |  1 +
 drivers/net/igc/base/igc_hw.h          |  6 ++++++
 drivers/net/igc/base/igc_i225.c        |  1 +
 drivers/net/igc/igc_ethdev.c           |  6 ++++++
 7 files changed, 32 insertions(+), 7 deletions(-)

diff --git a/doc/guides/nics/igc.rst b/doc/guides/nics/igc.rst
index da77e0845e..da904c2130 100644
--- a/doc/guides/nics/igc.rst
+++ b/doc/guides/nics/igc.rst
@@ -5,11 +5,12 @@ IGC Poll Mode Driver
 ======================
 
 The IGC PMD (**librte_net_igc**) provides poll mode driver support for Foxville
-I225 Series Network Adapters.
+I225 and I226 Series Network Adapters.
 
 - For information about I225, please refer to: `Intel® Ethernet Controller I225 Series
   <https://ark.intel.com/content/www/us/en/ark/products/series/184686/intel-ethernet-controller-i225-series.html>`_.
-
+- For information about I225, please refer to: `Intel® Ethernet Controller I226 Series
+  <https://ark.intel.com/content/www/us/en/ark/products/series/210588/intel-ethernet-controller-i226-series.html>`_.
 
 Driver compilation and testing
 ------------------------------
@@ -21,11 +22,10 @@ for details.
 Supported Chipsets and NICs
 ---------------------------
 
-Foxville LM (I225 LM): Client 2.5G LAN vPro Corporate
-Foxville V (I225 V): Client 2.5G LAN Consumer
-Foxville I (I225 I): Client 2.5G Industrial Temp
-Foxville V (I225 K): Client 2.5G LAN Consumer
-
+Foxville LM (I225 LM, I226 LM): Client 2.5G LAN vPro Corporate
+Foxville V (I225 V, I226 V): Client 2.5G LAN Consumer
+Foxville I (I225 I, I226 IM): Client 2.5G Industrial Temp
+Foxville V (I225 K, I226 K): Client 2.5G LAN Consumer
 
 Sample Application Notes
 ------------------------
diff --git a/doc/guides/rel_notes/release_22_03.rst b/doc/guides/rel_notes/release_22_03.rst
index f03183ee86..d752bd27da 100644
--- a/doc/guides/rel_notes/release_22_03.rst
+++ b/doc/guides/rel_notes/release_22_03.rst
@@ -88,6 +88,11 @@ New Features
   * Added AES-XCBC support in lookaside protocol (IPsec) for CN9K & CN10K.
   * Added AES-CMAC support in CN9K & CN10K.
 
+* **Added support for Intel Foxville I226 devices.**
+
+  Added Intel Foxville I225 devices in ``igc`` driver. See the
+  :doc:`../nics/igc` NIC guide for more details.
+
 * **Added an API to retrieve event port id of ethdev Rx adapter.**
 
   The new API ``rte_event_eth_rx_adapter_event_port_get()`` was added.
diff --git a/drivers/net/igc/base/igc_api.c b/drivers/net/igc/base/igc_api.c
index 2f8c0753cb..9b791dc082 100644
--- a/drivers/net/igc/base/igc_api.c
+++ b/drivers/net/igc/base/igc_api.c
@@ -888,6 +888,12 @@ s32 igc_set_mac_type(struct igc_hw *hw)
 	case IGC_DEV_ID_I225_I:
 	case IGC_DEV_ID_I220_V:
 	case IGC_DEV_ID_I225_BLANK_NVM:
+	case IGC_DEV_ID_I226_K:
+	case IGC_DEV_ID_I226_LMVP:
+	case IGC_DEV_ID_I226_LM:
+	case IGC_DEV_ID_I226_V:
+	case IGC_DEV_ID_I226_IT:
+	case IGC_DEV_ID_I226_BLANK_NVM:
 		mac->type = igc_i225;
 		break;
 	case IGC_DEV_ID_I350_VF:
diff --git a/drivers/net/igc/base/igc_defines.h b/drivers/net/igc/base/igc_defines.h
index 30a41300f5..61964bcdd2 100644
--- a/drivers/net/igc/base/igc_defines.h
+++ b/drivers/net/igc/base/igc_defines.h
@@ -1351,6 +1351,7 @@
 #define IGP04IGC_E_PHY_ID	0x02A80391
 #define M88_VENDOR		0x0141
 #define I225_I_PHY_ID		0x67C9DC00
+#define I226_LM_PHY_ID          0x67C9DC10
 
 /* M88E1000 Specific Registers */
 #define M88IGC_PHY_SPEC_CTRL		0x10  /* PHY Specific Control Reg */
diff --git a/drivers/net/igc/base/igc_hw.h b/drivers/net/igc/base/igc_hw.h
index be38fafa5f..707a1883b4 100644
--- a/drivers/net/igc/base/igc_hw.h
+++ b/drivers/net/igc/base/igc_hw.h
@@ -166,6 +166,12 @@ struct igc_hw;
 #define IGC_DEV_ID_I225_I			0x15F8
 #define IGC_DEV_ID_I220_V			0x15F7
 #define IGC_DEV_ID_I225_BLANK_NVM		0x15FD
+#define IGC_DEV_ID_I226_K           0x3102
+#define IGC_DEV_ID_I226_LMVP        0x5503
+#define IGC_DEV_ID_I226_LM          0x125B
+#define IGC_DEV_ID_I226_V           0x125C
+#define IGC_DEV_ID_I226_IT          0x125D
+#define IGC_DEV_ID_I226_BLANK_NVM   0x125F
 #define IGC_DEV_ID_I354_BACKPLANE_1GBPS	0x1F40
 #define IGC_DEV_ID_I354_SGMII			0x1F41
 #define IGC_DEV_ID_I354_BACKPLANE_2_5GBPS	0x1F45
diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c
index 060b2f8f93..5f3d535490 100644
--- a/drivers/net/igc/base/igc_i225.c
+++ b/drivers/net/igc/base/igc_i225.c
@@ -176,6 +176,7 @@ static s32 igc_init_phy_params_i225(struct igc_hw *hw)
 	/* Verify phy id and set remaining function pointers */
 	switch (phy->id) {
 	case I225_I_PHY_ID:
+	case I226_LM_PHY_ID:
 		phy->type		= igc_phy_i225;
 		phy->ops.set_d0_lplu_state = igc_set_d0_lplu_state_i225;
 		phy->ops.set_d3_lplu_state = igc_set_d3_lplu_state_i225;
diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c
index a1f1a9772b..b9933b395d 100644
--- a/drivers/net/igc/igc_ethdev.c
+++ b/drivers/net/igc/igc_ethdev.c
@@ -97,6 +97,12 @@ static const struct rte_pci_id pci_id_igc_map[] = {
 	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I225_V)  },
 	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I225_I)  },
 	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I225_K)  },
+	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I226_K)  },
+	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I226_LMVP)  },
+	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I226_LM)  },
+	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I226_V)  },
+	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I226_IT)  },
+	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I226_BLANK_NVM)  },
 	{ .vendor_id = 0, /* sentinel */ },
 };
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH v2] net/igc: add I226 support
  2022-05-19  6:04 [PATCH] net/igc: add I226 support Qiming Yang
@ 2022-05-25  5:57 ` Qiming Yang
  2022-05-25  8:55   ` Zhang, Qi Z
  2022-06-05 16:42   ` Thomas Monjalon
  0 siblings, 2 replies; 11+ messages in thread
From: Qiming Yang @ 2022-05-25  5:57 UTC (permalink / raw)
  To: qi.z.zhang, dev; +Cc: Qiming Yang, Kevin Liu

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 5903 bytes --]

Added I226 Series device ID in igc driver and updated igc guide
document for new devices.

Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
---
v2:
* rebased
---
 doc/guides/nics/igc.rst                | 14 +++++++-------
 doc/guides/rel_notes/release_22_03.rst |  5 +++++
 drivers/net/igc/base/igc_api.c         |  6 ++++++
 drivers/net/igc/base/igc_defines.h     |  1 +
 drivers/net/igc/base/igc_hw.h          |  6 ++++++
 drivers/net/igc/base/igc_i225.c        |  1 +
 drivers/net/igc/igc_ethdev.c           |  6 ++++++
 7 files changed, 32 insertions(+), 7 deletions(-)

diff --git a/doc/guides/nics/igc.rst b/doc/guides/nics/igc.rst
index da77e0845e..399d2d650c 100644
--- a/doc/guides/nics/igc.rst
+++ b/doc/guides/nics/igc.rst
@@ -5,11 +5,12 @@ IGC Poll Mode Driver
 ======================
 
 The IGC PMD (**librte_net_igc**) provides poll mode driver support for Foxville
-I225 Series Network Adapters.
+I225 and I226 Series Network Adapters.
 
 - For information about I225, please refer to: `Intel® Ethernet Controller I225 Series
   <https://ark.intel.com/content/www/us/en/ark/products/series/184686/intel-ethernet-controller-i225-series.html>`_.
-
+- For information about I226, please refer to: `Intel® Ethernet Controller I226 Series
+  <https://ark.intel.com/content/www/us/en/ark/products/series/210588/intel-ethernet-controller-i226-series.html>`_.
 
 Driver compilation and testing
 ------------------------------
@@ -21,11 +22,10 @@ for details.
 Supported Chipsets and NICs
 ---------------------------
 
-Foxville LM (I225 LM): Client 2.5G LAN vPro Corporate
-Foxville V (I225 V): Client 2.5G LAN Consumer
-Foxville I (I225 I): Client 2.5G Industrial Temp
-Foxville V (I225 K): Client 2.5G LAN Consumer
-
+Foxville LM (I225 LM, I226 LM): Client 2.5G LAN vPro Corporate
+Foxville V (I225 V, I226 V): Client 2.5G LAN Consumer
+Foxville I (I225 I, I226 IM): Client 2.5G Industrial Temp
+Foxville V (I225 K, I226 K): Client 2.5G LAN Consumer
 
 Sample Application Notes
 ------------------------
diff --git a/doc/guides/rel_notes/release_22_03.rst b/doc/guides/rel_notes/release_22_03.rst
index 0923707cb8..226afe786e 100644
--- a/doc/guides/rel_notes/release_22_03.rst
+++ b/doc/guides/rel_notes/release_22_03.rst
@@ -113,6 +113,11 @@ New Features
   * Added PPPoL2TPv2oUDP FDIR distribute packets based on inner IP
     src/dst address and UDP/TCP src/dst port.
 
+* **Updated Intel igc driver.**
+
+  Added Intel Foxville I226 devices in ``igc`` driver. See the
+  doc:`../nics/igc` NIC guide for more details.
+
 * **Updated Marvell cnxk ethdev PMD.**
 
   * Added queue based priority flow control support for CN9K and CN10K.
diff --git a/drivers/net/igc/base/igc_api.c b/drivers/net/igc/base/igc_api.c
index 2f8c0753cb..9b791dc082 100644
--- a/drivers/net/igc/base/igc_api.c
+++ b/drivers/net/igc/base/igc_api.c
@@ -888,6 +888,12 @@ s32 igc_set_mac_type(struct igc_hw *hw)
 	case IGC_DEV_ID_I225_I:
 	case IGC_DEV_ID_I220_V:
 	case IGC_DEV_ID_I225_BLANK_NVM:
+	case IGC_DEV_ID_I226_K:
+	case IGC_DEV_ID_I226_LMVP:
+	case IGC_DEV_ID_I226_LM:
+	case IGC_DEV_ID_I226_V:
+	case IGC_DEV_ID_I226_IT:
+	case IGC_DEV_ID_I226_BLANK_NVM:
 		mac->type = igc_i225;
 		break;
 	case IGC_DEV_ID_I350_VF:
diff --git a/drivers/net/igc/base/igc_defines.h b/drivers/net/igc/base/igc_defines.h
index 30a41300f5..61964bcdd2 100644
--- a/drivers/net/igc/base/igc_defines.h
+++ b/drivers/net/igc/base/igc_defines.h
@@ -1351,6 +1351,7 @@
 #define IGP04IGC_E_PHY_ID	0x02A80391
 #define M88_VENDOR		0x0141
 #define I225_I_PHY_ID		0x67C9DC00
+#define I226_LM_PHY_ID          0x67C9DC10
 
 /* M88E1000 Specific Registers */
 #define M88IGC_PHY_SPEC_CTRL		0x10  /* PHY Specific Control Reg */
diff --git a/drivers/net/igc/base/igc_hw.h b/drivers/net/igc/base/igc_hw.h
index be38fafa5f..707a1883b4 100644
--- a/drivers/net/igc/base/igc_hw.h
+++ b/drivers/net/igc/base/igc_hw.h
@@ -166,6 +166,12 @@ struct igc_hw;
 #define IGC_DEV_ID_I225_I			0x15F8
 #define IGC_DEV_ID_I220_V			0x15F7
 #define IGC_DEV_ID_I225_BLANK_NVM		0x15FD
+#define IGC_DEV_ID_I226_K           0x3102
+#define IGC_DEV_ID_I226_LMVP        0x5503
+#define IGC_DEV_ID_I226_LM          0x125B
+#define IGC_DEV_ID_I226_V           0x125C
+#define IGC_DEV_ID_I226_IT          0x125D
+#define IGC_DEV_ID_I226_BLANK_NVM   0x125F
 #define IGC_DEV_ID_I354_BACKPLANE_1GBPS	0x1F40
 #define IGC_DEV_ID_I354_SGMII			0x1F41
 #define IGC_DEV_ID_I354_BACKPLANE_2_5GBPS	0x1F45
diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c
index 060b2f8f93..5f3d535490 100644
--- a/drivers/net/igc/base/igc_i225.c
+++ b/drivers/net/igc/base/igc_i225.c
@@ -176,6 +176,7 @@ static s32 igc_init_phy_params_i225(struct igc_hw *hw)
 	/* Verify phy id and set remaining function pointers */
 	switch (phy->id) {
 	case I225_I_PHY_ID:
+	case I226_LM_PHY_ID:
 		phy->type		= igc_phy_i225;
 		phy->ops.set_d0_lplu_state = igc_set_d0_lplu_state_i225;
 		phy->ops.set_d3_lplu_state = igc_set_d3_lplu_state_i225;
diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c
index a1f1a9772b..b9933b395d 100644
--- a/drivers/net/igc/igc_ethdev.c
+++ b/drivers/net/igc/igc_ethdev.c
@@ -97,6 +97,12 @@ static const struct rte_pci_id pci_id_igc_map[] = {
 	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I225_V)  },
 	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I225_I)  },
 	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I225_K)  },
+	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I226_K)  },
+	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I226_LMVP)  },
+	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I226_LM)  },
+	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I226_V)  },
+	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I226_IT)  },
+	{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I226_BLANK_NVM)  },
 	{ .vendor_id = 0, /* sentinel */ },
 };
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [PATCH v2] net/igc: add I226 support
  2022-05-25  5:57 ` [PATCH v2] " Qiming Yang
@ 2022-05-25  8:55   ` Zhang, Qi Z
  2022-06-05 16:42   ` Thomas Monjalon
  1 sibling, 0 replies; 11+ messages in thread
From: Zhang, Qi Z @ 2022-05-25  8:55 UTC (permalink / raw)
  To: Yang, Qiming, dev; +Cc: Liu, KevinX

> -----Original Message-----
> From: Yang, Qiming <qiming.yang@intel.com>
> Sent: Wednesday, May 25, 2022 1:58 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Liu, KevinX
> <kevinx.liu@intel.com>
> Subject: [PATCH v2] net/igc: add I226 support
> 
> Added I226 Series device ID in igc driver and updated igc guide document for
> new devices.
> 
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> Signed-off-by: Kevin Liu <kevinx.liu@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2] net/igc: add I226 support
  2022-05-25  5:57 ` [PATCH v2] " Qiming Yang
  2022-05-25  8:55   ` Zhang, Qi Z
@ 2022-06-05 16:42   ` Thomas Monjalon
  2022-06-05 23:12     ` Zhang, Qi Z
  1 sibling, 1 reply; 11+ messages in thread
From: Thomas Monjalon @ 2022-06-05 16:42 UTC (permalink / raw)
  To: qi.z.zhang, Qiming Yang; +Cc: dev, Kevin Liu

25/05/2022 07:57, Qiming Yang:
> Added I226 Series device ID in igc driver and updated igc guide
> document for new devices.
> 
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
> ---
> v2:
> * rebased
> ---
>  doc/guides/nics/igc.rst                | 14 +++++++-------
>  doc/guides/rel_notes/release_22_03.rst |  5 +++++

You are sending a patch after 22.03 is closed,
so it should be listed in 22.07!

I will fix while pulling the tree prepared by Qi.
Please be more careful with the basic checks.



^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [PATCH v2] net/igc: add I226 support
  2022-06-05 16:42   ` Thomas Monjalon
@ 2022-06-05 23:12     ` Zhang, Qi Z
  2022-06-06 10:49       ` Thomas Monjalon
  0 siblings, 1 reply; 11+ messages in thread
From: Zhang, Qi Z @ 2022-06-05 23:12 UTC (permalink / raw)
  To: Thomas Monjalon, Yang, Qiming; +Cc: dev, Liu, KevinX



> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, June 6, 2022 12:42 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> Subject: Re: [PATCH v2] net/igc: add I226 support
> 
> 25/05/2022 07:57, Qiming Yang:
> > Added I226 Series device ID in igc driver and updated igc guide
> > document for new devices.
> >
> > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
> > ---
> > v2:
> > * rebased
> > ---
> >  doc/guides/nics/igc.rst                | 14 +++++++-------
> >  doc/guides/rel_notes/release_22_03.rst |  5 +++++
> 
> You are sending a patch after 22.03 is closed, so it should be listed in 22.07!
> 
> I will fix while pulling the tree prepared by Qi.
> Please be more careful with the basic checks.

Thanks for capture this, have dropped this patch in dpdk-next-net-intel.
A new version is required.



> 


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2] net/igc: add I226 support
  2022-06-05 23:12     ` Zhang, Qi Z
@ 2022-06-06 10:49       ` Thomas Monjalon
  2022-06-06 10:54         ` Zhang, Qi Z
  0 siblings, 1 reply; 11+ messages in thread
From: Thomas Monjalon @ 2022-06-06 10:49 UTC (permalink / raw)
  To: Yang, Qiming, Zhang, Qi Z; +Cc: dev, Liu, KevinX

06/06/2022 01:12, Zhang, Qi Z:
> 
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Monday, June 6, 2022 12:42 AM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> > <qiming.yang@intel.com>
> > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> > Subject: Re: [PATCH v2] net/igc: add I226 support
> > 
> > 25/05/2022 07:57, Qiming Yang:
> > > Added I226 Series device ID in igc driver and updated igc guide
> > > document for new devices.
> > >
> > > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > > Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
> > > ---
> > > v2:
> > > * rebased
> > > ---
> > >  doc/guides/nics/igc.rst                | 14 +++++++-------
> > >  doc/guides/rel_notes/release_22_03.rst |  5 +++++
> > 
> > You are sending a patch after 22.03 is closed, so it should be listed in 22.07!
> > 
> > I will fix while pulling the tree prepared by Qi.
> > Please be more careful with the basic checks.
> 
> Thanks for capture this, have dropped this patch in dpdk-next-net-intel.
> A new version is required.

Too late, it is in the main tree with release notes fixed.
Do you need more fix?



^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [PATCH v2] net/igc: add I226 support
  2022-06-06 10:49       ` Thomas Monjalon
@ 2022-06-06 10:54         ` Zhang, Qi Z
  2022-06-06 11:45           ` Thomas Monjalon
  0 siblings, 1 reply; 11+ messages in thread
From: Zhang, Qi Z @ 2022-06-06 10:54 UTC (permalink / raw)
  To: Thomas Monjalon, Yang, Qiming; +Cc: dev, Liu, KevinX



> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, June 6, 2022 6:49 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> Subject: Re: [PATCH v2] net/igc: add I226 support
> 
> 06/06/2022 01:12, Zhang, Qi Z:
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > Sent: Monday, June 6, 2022 12:42 AM
> > > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> > > <qiming.yang@intel.com>
> > > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> > > Subject: Re: [PATCH v2] net/igc: add I226 support
> > >
> > > 25/05/2022 07:57, Qiming Yang:
> > > > Added I226 Series device ID in igc driver and updated igc guide
> > > > document for new devices.
> > > >
> > > > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > > > Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
> > > > ---
> > > > v2:
> > > > * rebased
> > > > ---
> > > >  doc/guides/nics/igc.rst                | 14 +++++++-------
> > > >  doc/guides/rel_notes/release_22_03.rst |  5 +++++
> > >
> > > You are sending a patch after 22.03 is closed, so it should be listed in
> 22.07!
> > >
> > > I will fix while pulling the tree prepared by Qi.
> > > Please be more careful with the basic checks.
> >
> > Thanks for capture this, have dropped this patch in dpdk-next-net-intel.
> > A new version is required.
> 
> Too late, it is in the main tree with release notes fixed.
> Do you need more fix?

OK, I guess we need to revert it with a new fix.
Sorry for the chaos...

> 


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2] net/igc: add I226 support
  2022-06-06 10:54         ` Zhang, Qi Z
@ 2022-06-06 11:45           ` Thomas Monjalon
  2022-06-06 12:06             ` Zhang, Qi Z
  0 siblings, 1 reply; 11+ messages in thread
From: Thomas Monjalon @ 2022-06-06 11:45 UTC (permalink / raw)
  To: Yang, Qiming, Zhang, Qi Z; +Cc: dev, Liu, KevinX, john.mcnamara

06/06/2022 12:54, Zhang, Qi Z:
> 
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Monday, June 6, 2022 6:49 PM
> > To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> > Subject: Re: [PATCH v2] net/igc: add I226 support
> > 
> > 06/06/2022 01:12, Zhang, Qi Z:
> > >
> > > > -----Original Message-----
> > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > Sent: Monday, June 6, 2022 12:42 AM
> > > > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> > > > <qiming.yang@intel.com>
> > > > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> > > > Subject: Re: [PATCH v2] net/igc: add I226 support
> > > >
> > > > 25/05/2022 07:57, Qiming Yang:
> > > > > Added I226 Series device ID in igc driver and updated igc guide
> > > > > document for new devices.
> > > > >
> > > > > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > > > > Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
> > > > > ---
> > > > > v2:
> > > > > * rebased
> > > > > ---
> > > > >  doc/guides/nics/igc.rst                | 14 +++++++-------
> > > > >  doc/guides/rel_notes/release_22_03.rst |  5 +++++
> > > >
> > > > You are sending a patch after 22.03 is closed, so it should be listed in
> > 22.07!
> > > >
> > > > I will fix while pulling the tree prepared by Qi.
> > > > Please be more careful with the basic checks.
> > >
> > > Thanks for capture this, have dropped this patch in dpdk-next-net-intel.
> > > A new version is required.
> > 
> > Too late, it is in the main tree with release notes fixed.
> > Do you need more fix?
> 
> OK, I guess we need to revert it with a new fix.
> Sorry for the chaos...

Why revert? If there is a bug, just fix it.




^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [PATCH v2] net/igc: add I226 support
  2022-06-06 11:45           ` Thomas Monjalon
@ 2022-06-06 12:06             ` Zhang, Qi Z
  2022-06-06 14:20               ` Thomas Monjalon
  0 siblings, 1 reply; 11+ messages in thread
From: Zhang, Qi Z @ 2022-06-06 12:06 UTC (permalink / raw)
  To: Thomas Monjalon, Yang, Qiming; +Cc: dev, Liu, KevinX, Mcnamara, John



> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, June 6, 2022 7:46 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Subject: Re: [PATCH v2] net/igc: add I226 support
> 
> 06/06/2022 12:54, Zhang, Qi Z:
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > Sent: Monday, June 6, 2022 6:49 PM
> > > To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> > > <qi.z.zhang@intel.com>
> > > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> > > Subject: Re: [PATCH v2] net/igc: add I226 support
> > >
> > > 06/06/2022 01:12, Zhang, Qi Z:
> > > >
> > > > > -----Original Message-----
> > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > Sent: Monday, June 6, 2022 12:42 AM
> > > > > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> > > > > <qiming.yang@intel.com>
> > > > > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> > > > > Subject: Re: [PATCH v2] net/igc: add I226 support
> > > > >
> > > > > 25/05/2022 07:57, Qiming Yang:
> > > > > > Added I226 Series device ID in igc driver and updated igc
> > > > > > guide document for new devices.
> > > > > >
> > > > > > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > > > > > Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
> > > > > > ---
> > > > > > v2:
> > > > > > * rebased
> > > > > > ---
> > > > > >  doc/guides/nics/igc.rst                | 14 +++++++-------
> > > > > >  doc/guides/rel_notes/release_22_03.rst |  5 +++++
> > > > >
> > > > > You are sending a patch after 22.03 is closed, so it should be
> > > > > listed in
> > > 22.07!
> > > > >
> > > > > I will fix while pulling the tree prepared by Qi.
> > > > > Please be more careful with the basic checks.
> > > >
> > > > Thanks for capture this, have dropped this patch in dpdk-next-net-intel.
> > > > A new version is required.
> > >
> > > Too late, it is in the main tree with release notes fixed.
> > > Do you need more fix?
> >
> > OK, I guess we need to revert it with a new fix.
> > Sorry for the chaos...
> 
> Why revert? If there is a bug, just fix it.

No a revert patch, I mean a fix patch with revert change on release_22_03.rst

> 
> 


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2] net/igc: add I226 support
  2022-06-06 12:06             ` Zhang, Qi Z
@ 2022-06-06 14:20               ` Thomas Monjalon
  2022-06-06 22:53                 ` Zhang, Qi Z
  0 siblings, 1 reply; 11+ messages in thread
From: Thomas Monjalon @ 2022-06-06 14:20 UTC (permalink / raw)
  To: Yang, Qiming, Zhang, Qi Z; +Cc: dev, Liu, KevinX, Mcnamara, John

06/06/2022 14:06, Zhang, Qi Z:
> 
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Monday, June 6, 2022 7:46 PM
> > To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>; Mcnamara, John
> > <john.mcnamara@intel.com>
> > Subject: Re: [PATCH v2] net/igc: add I226 support
> > 
> > 06/06/2022 12:54, Zhang, Qi Z:
> > >
> > > > -----Original Message-----
> > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > Sent: Monday, June 6, 2022 6:49 PM
> > > > To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> > > > <qi.z.zhang@intel.com>
> > > > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> > > > Subject: Re: [PATCH v2] net/igc: add I226 support
> > > >
> > > > 06/06/2022 01:12, Zhang, Qi Z:
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > Sent: Monday, June 6, 2022 12:42 AM
> > > > > > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> > > > > > <qiming.yang@intel.com>
> > > > > > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> > > > > > Subject: Re: [PATCH v2] net/igc: add I226 support
> > > > > >
> > > > > > 25/05/2022 07:57, Qiming Yang:
> > > > > > > Added I226 Series device ID in igc driver and updated igc
> > > > > > > guide document for new devices.
> > > > > > >
> > > > > > > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > > > > > > Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
> > > > > > > ---
> > > > > > > v2:
> > > > > > > * rebased
> > > > > > > ---
> > > > > > >  doc/guides/nics/igc.rst                | 14 +++++++-------
> > > > > > >  doc/guides/rel_notes/release_22_03.rst |  5 +++++
> > > > > >
> > > > > > You are sending a patch after 22.03 is closed, so it should be
> > > > > > listed in
> > > > 22.07!
> > > > > >
> > > > > > I will fix while pulling the tree prepared by Qi.
> > > > > > Please be more careful with the basic checks.
> > > > >
> > > > > Thanks for capture this, have dropped this patch in dpdk-next-net-intel.
> > > > > A new version is required.
> > > >
> > > > Too late, it is in the main tree with release notes fixed.
> > > > Do you need more fix?
> > >
> > > OK, I guess we need to revert it with a new fix.
> > > Sorry for the chaos...
> > 
> > Why revert? If there is a bug, just fix it.
> 
> No a revert patch, I mean a fix patch with revert change on release_22_03.rst

There is a misunderstanding, please read again above,
I've said that I've fixed the release notes while pulling the tree.
So I assume we are fine.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: [PATCH v2] net/igc: add I226 support
  2022-06-06 14:20               ` Thomas Monjalon
@ 2022-06-06 22:53                 ` Zhang, Qi Z
  0 siblings, 0 replies; 11+ messages in thread
From: Zhang, Qi Z @ 2022-06-06 22:53 UTC (permalink / raw)
  To: Thomas Monjalon, Yang, Qiming; +Cc: dev, Liu, KevinX, Mcnamara, John



> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, June 6, 2022 10:20 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Subject: Re: [PATCH v2] net/igc: add I226 support
> 
> 06/06/2022 14:06, Zhang, Qi Z:
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > Sent: Monday, June 6, 2022 7:46 PM
> > > To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> > > <qi.z.zhang@intel.com>
> > > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>; Mcnamara, John
> > > <john.mcnamara@intel.com>
> > > Subject: Re: [PATCH v2] net/igc: add I226 support
> > >
> > > 06/06/2022 12:54, Zhang, Qi Z:
> > > >
> > > > > -----Original Message-----
> > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > Sent: Monday, June 6, 2022 6:49 PM
> > > > > To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> > > > > <qi.z.zhang@intel.com>
> > > > > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> > > > > Subject: Re: [PATCH v2] net/igc: add I226 support
> > > > >
> > > > > 06/06/2022 01:12, Zhang, Qi Z:
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > Sent: Monday, June 6, 2022 12:42 AM
> > > > > > > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> > > > > > > <qiming.yang@intel.com>
> > > > > > > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> > > > > > > Subject: Re: [PATCH v2] net/igc: add I226 support
> > > > > > >
> > > > > > > 25/05/2022 07:57, Qiming Yang:
> > > > > > > > Added I226 Series device ID in igc driver and updated igc
> > > > > > > > guide document for new devices.
> > > > > > > >
> > > > > > > > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > > > > > > > Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
> > > > > > > > ---
> > > > > > > > v2:
> > > > > > > > * rebased
> > > > > > > > ---
> > > > > > > >  doc/guides/nics/igc.rst                | 14 +++++++-------
> > > > > > > >  doc/guides/rel_notes/release_22_03.rst |  5 +++++
> > > > > > >
> > > > > > > You are sending a patch after 22.03 is closed, so it should
> > > > > > > be listed in
> > > > > 22.07!
> > > > > > >
> > > > > > > I will fix while pulling the tree prepared by Qi.
> > > > > > > Please be more careful with the basic checks.
> > > > > >
> > > > > > Thanks for capture this, have dropped this patch in dpdk-next-net-
> intel.
> > > > > > A new version is required.
> > > > >
> > > > > Too late, it is in the main tree with release notes fixed.
> > > > > Do you need more fix?
> > > >
> > > > OK, I guess we need to revert it with a new fix.
> > > > Sorry for the chaos...
> > >
> > > Why revert? If there is a bug, just fix it.
> >
> > No a revert patch, I mean a fix patch with revert change on
> > release_22_03.rst
> 
> There is a misunderstanding, please read again above, I've said that I've fixed
> the release notes while pulling the tree.
> So I assume we are fine.

Oh, perfect, thanks!

> 
> 
> 


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-06-06 22:53 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-19  6:04 [PATCH] net/igc: add I226 support Qiming Yang
2022-05-25  5:57 ` [PATCH v2] " Qiming Yang
2022-05-25  8:55   ` Zhang, Qi Z
2022-06-05 16:42   ` Thomas Monjalon
2022-06-05 23:12     ` Zhang, Qi Z
2022-06-06 10:49       ` Thomas Monjalon
2022-06-06 10:54         ` Zhang, Qi Z
2022-06-06 11:45           ` Thomas Monjalon
2022-06-06 12:06             ` Zhang, Qi Z
2022-06-06 14:20               ` Thomas Monjalon
2022-06-06 22:53                 ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).