From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51E1BA0553; Fri, 10 Jun 2022 03:01:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF6D44069C; Fri, 10 Jun 2022 03:01:56 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 77A9840689 for ; Fri, 10 Jun 2022 03:01:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654822915; x=1686358915; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4kZNPghw+kjWJcWRUoFWOrNmTqXN3AcCx/lJ3kTgGQo=; b=C3xyQtlUKaAWDg2gH3gnSfYNAeRu8ArxFolT3qkELNObCZz03tEEpa3e 5TvvtJsAHWYR6XdRjtFGvKa8Y9H1VDE+4/+KU1/GQ2bo+yh+iXGDYDXpv 8Clg8Qoxecto1EH+sRheRhpOM8AnOe0/kczMlyepjJqtJ9BgIHXHdmqji 0Ik3m3oOQ2+aiocUgSNfK3YTIKsB1rCJTcrxbp4I6jupiwnYQa9TTOy6c M95uXRe504SjkFxYgUQ+VpED144KQ54MKMI/rHAi43T2vbP5aXJyCeS4f pgT/M3wPAFd6QfxfLDr7V/049MyrmjWmSO0xhWBSinmD5kcBocXp481vJ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="276242568" X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="276242568" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 18:01:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="724702951" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 09 Jun 2022 18:01:53 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 9 Jun 2022 18:01:53 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 9 Jun 2022 18:01:53 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 9 Jun 2022 18:01:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XX2zlWSwRxhExMbOm8AZnRJTfzwmLxuhc0DE4mRt9sJwNbsXaqBTgpjhCrSZfpzV6gTA5pcCK7iTBPK513ahHh1pCe3Et7opfPPrMFqrfZaB3xWSpdsqEYH9TQqBXvmRE9t/bCWUUi9fEez9CtCcRY/QJDFvTvbasOy3g6rqNmG3wAETqNsIgEM9Zw1eL6fUI21HDRvlM6tlTgSjDwHUmFOdex3L+fd6J602AxjK/MDDzL6DRTN6QS7r+i4c/PPEuTzkarSJ00dexX1zQhGoO4GzQeQ0S3qYnb0qlEE/A9XeKF8ZSS2AydSn0Hv6dFTtu9me5rDJH5Gw+LaGYbyHOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CN1gaJZyqaxRrFWRZ1kjUC2TDZr8ByKzLoC1QOhw2bE=; b=iJR7E3hcpNDS92O667RN4JgUs8c/itt0zxKlBEctYe+JciL75H2HQOySjp4NIM6SF5tYb1fliXvE42ahaE11x+211hCHItdursnJm/tdB90wuM83alF5JbsXmEIYJKMMmCRJ4mYPUpLi86bJtxIyyhBJSVBcuttQYgmGYTFpBte5RMsI8yEg0bVKaK6IOenlXyC7REuYr7cFNeZOhsy6D92KQcAXXcSxBfjfpbzBr/Z9tXHIYv2DV8lMXWbdGCmYzwdFiKKo3CNnZGpmgcDRDy1QE46shl2wKKKUiPIfIic+XoKyv/eElkYjfjSSc2HZpmYP6jHTMW9IaJ1zhWkqzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by PH0PR11MB5596.namprd11.prod.outlook.com (2603:10b6:510:eb::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Fri, 10 Jun 2022 01:01:51 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7%6]) with mapi id 15.20.5293.019; Fri, 10 Jun 2022 01:01:51 +0000 From: "Zhang, Qi Z" To: "Liu, KevinX" , "dev@dpdk.org" CC: "Zhang, Yuying" , "Xing, Beilei" , "Yang, SteveX" , "Zhang, RobinX" , "Liu, KevinX" Subject: RE: [PATCH v4] net/i40e: add outer VLAN processing Thread-Topic: [PATCH v4] net/i40e: add outer VLAN processing Thread-Index: AQHYe8xeLtDf/tpcgEmKkjQnRbS6Oq1H0O8g Date: Fri, 10 Jun 2022 01:01:50 +0000 Message-ID: References: <20220609112614.193699-1-kevinx.liu@intel.com> <20220609144321.274775-1-kevinx.liu@intel.com> In-Reply-To: <20220609144321.274775-1-kevinx.liu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ebd8b396-8ae5-4d8d-ba5b-08da4a7ccd5d x-ms-traffictypediagnostic: PH0PR11MB5596:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xzGO9gK9f7k1NeD6zZ9Af9JPJ5pfkamgkWuTf9CRaOeG6Fkj+plM/cMEh4Myf2N1yw4puGImtC8vHcoTQ2cMYGRyla94shFAkzPjU+itAdfxt4lZaYC8x4UrLMCcMjOgJfHuCocFYzJAbbFCwT3rtTNx7g7IgnKmmf4y0VeF1dnyTFsNxw+x77S/IJsAStqKi5Pj8CrjBBcumsp8yUs4+QWjWcfR+RV1DSLmcASkGSiMlAwGI1xrndc0dIkk5/vuX7zCnUWUZvdrZ1TH3KF1WqRqHR8hL274fEUcpCqxdnuX71OEPpg3Q+3wpDR8DQ8/GBCEgYpTGjLwEVOj7dmJ8fW3Thn8gjr+QhHcd9yHXue/Gbh8WBuM87stq8SekPpVvywZy5W8GxPz4ttxy6gjDL/kTQk62kp+TSYIjZMQnRBlTZ/QduBGVX8KrS6vL+TCSAW3r6ViUoD0vnVeeVl9N8rnMTtVpNZKt9xCpQqb1NVj3Ys31GCClgSqmvmgLdt3FY+utXUpTGZxqE9hhd6vE4amNXIpJaCZO9LTx2g9uobkKgSObdzzZ3xECbzU7NVAmeKgmyS+4KaFCqz45mkjdQtGPPbuzffdZ2K1ZzFb6hO6FyizcyDWan/PUBGojG9aUO1Rkr1/CaTfHCfSG5XVhFiMamPluu7a1/eYraMcXAF32JFE/L7vgJz+FlUYBQ7VzuRxLokJx4bawlVnyv6pVA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(7696005)(82960400001)(4326008)(52536014)(8676002)(122000001)(38070700005)(71200400001)(5660300002)(2906002)(110136005)(66946007)(66556008)(66476007)(8936002)(76116006)(26005)(66446008)(9686003)(107886003)(186003)(316002)(508600001)(33656002)(64756008)(53546011)(55016003)(86362001)(38100700002)(54906003)(83380400001)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZpVHGqs51cx6/DD/Yjqn7FkkLqMATE6YuLH1/MFbG0u2v3XfIJMPkpfqIHPH?= =?us-ascii?Q?cR81bU+v0dKs8P8Ha2IFGpbgY/xbZq/CrNIqlDvxPnucpV44kpTPaY3oSEPR?= =?us-ascii?Q?8tRORSDW3foH50iOMODuww5mB5UbYQYZTY/2vblllKJ80IDeO952o+lynjSt?= =?us-ascii?Q?66GrJh8TIzQJeLZyL3p5UP9w92dMy5wYD42mH0RDvnDStuhRvA9u8Jzj+sBV?= =?us-ascii?Q?oEHbH0kfncJG6xcLZ4sJVWO6U6FRJjHEceiyYCQftU9SPRI1DkGI5dog01Sf?= =?us-ascii?Q?HZa+nx8zOD/UGJf3hUnJqPrDmw19F8blJHN/Huh/TDqTJPYA+PexpSraB+30?= =?us-ascii?Q?zTQmG5bR2FLOlFps8KQ5HfgFBX/hUy+KGzbU7/TwncvsQQG7mk5UQGLOsPcb?= =?us-ascii?Q?BPGMf2ypqFeeVo7CovXvYjq5gqjrBZD799f4FTl94/QOKSO1poOPlN9YDOru?= =?us-ascii?Q?b0wqayIxuWiN5IHiF75FSN+bGMB+xSRj3sl+3lRsx7NgzbrUp4Oygt6uc16x?= =?us-ascii?Q?klm01qTWdtCE8QUVh30HzTLuVnRiTg/foMX7pJZpvag/mW7UbP/gKHOWfO8m?= =?us-ascii?Q?1G69OCZnXlFkBPF7Iyj4ae0g6qoMLP303QcBTqDYVTJYDP6GtHgzyT/p0FPx?= =?us-ascii?Q?zdZtHWWpw6kM+RC51J0X+lRFa2ckiidkOhMhl+BKEBRycsqqav0BDDiAl7j6?= =?us-ascii?Q?trNTYKOwBvUp+uih2abbNjE7v5dQQgs2CWgFMlNUkw/VqR2khcYuqGMDyX7b?= =?us-ascii?Q?sfSn6ZJI0UWnxMBbk7lyIxabmifuIlFVI8OWBdWf/zUu6YHTzk4JLPc8vMgB?= =?us-ascii?Q?KI/Hv8RKWk3nr14/wLNnGaehWHkj3S8fjOAsRNVC1aRHdf5vVgaUbp2XsRzC?= =?us-ascii?Q?OF5jVwyu3I+zK4SbChItmHCwMPVPvjypo22Yg/EUZKmpylO1+tNOcJBnCmWK?= =?us-ascii?Q?KZ4G9P6SVhEg7HCXdUbxJQK7DRj9nbEAyjFGhJ5PPS0VGET9DQEHDSXsY2rf?= =?us-ascii?Q?3MZ8i1jkeVYXRevOd9VMFZm5qVeUeF6xeIHZQfAnZ9h1if1e8kwlE8hGMZyb?= =?us-ascii?Q?tWSQFOJqmwAxikN+PWYkYHPa2SXzuIm/DpbUh1cUdXLoVzwJIQkayQslED7+?= =?us-ascii?Q?wdrovMR/olUMsXGBhsU5YejpzpwEiiaeZyes0/LRco/fKHWIywjeJSzYWaKb?= =?us-ascii?Q?/iZjKEN+yx+NgzfxSAFw+lwATuv186aAhM8mlaks5xzAyr4JtHn5XEe4oajI?= =?us-ascii?Q?4qhKZFUre8nPtKp8rJOskhW85En/MkvyehL4h7LjTd5rjPt25tnJHQXtwMzx?= =?us-ascii?Q?Uy0Pkd0syX+nO/RE9CaS1UDXm+m3FeyHC9buchooW59rpObKbpZ4ql2N9nuE?= =?us-ascii?Q?tlySpXTuaNi3iCXRLpt/8NT9dLkhd73HiOaG957bya+PZld6oy1ShKCe0hIX?= =?us-ascii?Q?TxeAU8yhzR1jqQG+HERW44LFDfhHgN/2vpAejZGh1L6ZdWzrJ6Mq+GYXTjFB?= =?us-ascii?Q?E8nKwt4eLpWLri/CMboKvsKqMJGoMhNjg77wTpylUXUMeyIDtpnF+wCyIvf6?= =?us-ascii?Q?QW9QH2qXNO6Qd1Is/7pYYdyx26gU4Qnu1QELBZ7T9qVa5rAhRaXxe0HS406E?= =?us-ascii?Q?lXd3hG/HQpkYL61bJvbl7Bv1O/uinC4zZd4ul09vMUyL31DdgrGkcaILnCXj?= =?us-ascii?Q?wGvILvVCniBUmRgeR5QwRyNgKPO54eXJS3G7xMeflRXP8ySVzc9R0QtQDSTv?= =?us-ascii?Q?QLG/PKpGyA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebd8b396-8ae5-4d8d-ba5b-08da4a7ccd5d X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2022 01:01:50.7906 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: a9XY7frqXbaRH252w7GamKPHcCC9gY2jT2AKU+vvC/v2Tha46qC61SD07aLmIg7xCwDGYUX2n6pMX9bGUtbEcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5596 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kevin Liu > Sent: Thursday, June 9, 2022 10:43 PM > To: dev@dpdk.org > Cc: Zhang, Yuying ; Xing, Beilei > ; Yang, SteveX ; Zhang, > RobinX ; Liu, KevinX > Subject: [PATCH v4] net/i40e: add outer VLAN processing >=20 > From: Robin Zhang >=20 > Outer VLAN processing is supported after firmware v8.4, kernel driver als= o > change the default behavior to support this feature. To align with kernel= driver, > add support for outer VLAN processing in DPDK. >=20 > But it is forbidden for firmware to change the Inner/Outer VLAN configura= tion > while there are MAC/VLAN filters in the switch table. > Therefore, we need to clear the MAC table before setting config, and then > restore the MAC table after setting. >=20 > This will not impact on an old firmware. >=20 > Signed-off-by: Robin Zhang > Signed-off-by: Kevin Liu > --- > drivers/net/i40e/i40e_ethdev.c | 83 ++++++++++++++++++++++++++++++++-- > drivers/net/i40e/i40e_ethdev.h | 3 ++ > 2 files changed, 81 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 755786dc10..736afb268b 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -3909,6 +3909,7 @@ i40e_vlan_tpid_set(struct rte_eth_dev *dev, > struct i40e_pf *pf =3D I40E_DEV_PRIVATE_TO_PF(dev->data- > >dev_private); > int qinq =3D dev->data->dev_conf.rxmode.offloads & > RTE_ETH_RX_OFFLOAD_VLAN_EXTEND; > + u16 sw_flags =3D 0, valid_flags =3D 0; > int ret =3D 0; >=20 > if ((vlan_type !=3D RTE_ETH_VLAN_TYPE_INNER && @@ -3927,15 > +3928,34 @@ i40e_vlan_tpid_set(struct rte_eth_dev *dev, > /* 802.1ad frames ability is added in NVM API 1.7*/ > if (hw->flags & I40E_HW_FLAG_802_1AD_CAPABLE) { > if (qinq) { > + if (pf->is_outer_vlan_processing) { > + sw_flags =3D > I40E_AQ_SET_SWITCH_CFG_OUTER_VLAN; > + valid_flags =3D > I40E_AQ_SET_SWITCH_CFG_OUTER_VLAN; > + } > if (vlan_type =3D=3D RTE_ETH_VLAN_TYPE_OUTER) > hw->first_tag =3D rte_cpu_to_le_16(tpid); > else if (vlan_type =3D=3D RTE_ETH_VLAN_TYPE_INNER) > hw->second_tag =3D rte_cpu_to_le_16(tpid); > } else { > - if (vlan_type =3D=3D RTE_ETH_VLAN_TYPE_OUTER) > - hw->second_tag =3D rte_cpu_to_le_16(tpid); > + /*When FW > 8.3, the tpid must be set to QinQ to > close extend*/ The comment is confusing, there is no firmware version related check in bel= ow code And what is "set to QinQ to close extend" means?