RE: [PATCH v3] app/testpmd: enable cli for programmable action

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Sent: Friday, October 6, 2023 8:36 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Singh, Aman Deep
> <aman.deep.singh@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>
> Cc: dev@dpdk.org; orika@nvidia.com; ferruh.yigit@amd.com
> Subject: RE: [PATCH v3] app/testpmd: enable cli for programmable action
> 
> 
> Hi Qi,
> 
> <snip>
> 
> >
> > +#define ACTION_PROG_NAME_SIZE_MAX 32
> > +#define ACTION_PROG_ARG_NUM_MAX 16
> > +#define ACTION_PROG_ARG_VALUE_SIZE_MAX 32
> 
> Let's be a bit more generous with some of these sizes, please.
> 
> The action name might be hierarchical, i.e. include the control block and table
> path separated by dots, e.g.
> "dev5.ingress.forwarding.routing_table.set_next_hop", so:
> #define ACTION_PROG_NAME_SIZE_MAX 256
> 
> Some parameters could be 128-bit IPv6 addresses, which may be specified in
> hex with additional characters such as '0x' or ':', so:
> #define ACTION_PROG_ARG_VALUE_SIZE_MAX 64
> 
> <snip>

Yes, definitely we may need to support a larger name and value from p4, I will fix that, thanks.

> 
> Regards,
> Cristian