From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 592E642D7C; Wed, 28 Jun 2023 08:57:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB53440A7F; Wed, 28 Jun 2023 08:57:33 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id EDECA40151 for ; Wed, 28 Jun 2023 08:57:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687935452; x=1719471452; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=rf+MneRy59cN/nfscsbwKyUgjPp3gP0k7yqPyDeDMHQ=; b=ipyPRZhOwSic9a2QQWj2uKH7qCJZuRX4vJ6H81Dbv6HmO4yT/7dJkWNU XkqSeaw51yWoPcjyZRwMxZBF71RkYb54v5njn5m+ikzP3KfndHaYOdKMD fxw5O3syrRm8wiqeAiQs6X+Hg1BEQL9dltO0ud9w0mebebDX0RhOeCM3q Es36Z244dLfDJJgY8r08k18QVZ9EuFjCX+/ioIApewKvQ1qEEgaS/Rrml G4rigPnHG62cwS2LJnTTpkBW9Sni2oJOomYqEBy7I5/baY3b7EWuPuuR/ Gq9eY+YXs2r4mc1MzSEBPg92oT9t1iVWF7oqC5Z8/jR2LCqoaQvcUkugb A==; X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="425440173" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="425440173" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 23:57:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="746541237" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="746541237" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 27 Jun 2023 23:57:29 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 27 Jun 2023 23:57:29 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 27 Jun 2023 23:57:29 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 27 Jun 2023 23:57:29 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 27 Jun 2023 23:57:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FiO6y0s4JEct2xJYZUnIOhvo1NsFZORW6YFDnrGKNLwlG+bPBFFjA+kOvDqDHv2vMQAzFjyG55MaIOViTKrpcE//ivXdmyJ650bIzeDgsj6Ib0t9U1fltLFICThpFyAweSglBKvJbohsxxsoCUVwg4qwXA902p6MAgcPVZBiHWBUdW1K3HThCC3QzrpXyT7KbKq05qQnfTILDDF/FSsCYXJR+Z6ZbHEY9uOXopfmrc7+313qYflaqDYXG0TdVx6Ut6oQRYBsX9N5f4FoIRis1TPi+jNeApoD9fcI8fBtgceBFem/0zJsCQxpnjjTv8LJIZrPuYiPuSbqhGZMhHPl0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3PQOU4UXm4onmRdQhF1GxhcwFNMMslUR2yQ7J1C5tBg=; b=InHsjb/iXUmbjcjezP4QQYPCX+BDyxYFdwhiPpkyLRqqjHGqp7vwDEPQ3GpPnX0WXEhaoxvUgSyF6ajLrpdI57vLDrJwXHbK+ICPMuLRJ+Zct+U/V/dpEuWC/sCuWlwwAWm08p9YXl3AbDzKrv2jvoemPsazuSkHfIW5uQP4YhddzW5PffZlnLwSGpFItJVyuonUXYonkVydbCP/nKknIkUS/Ios8xdnPo+I3hSgY6PO7L9aOAqBOTvTA9ILq4MjFQVP0izlNh84C5UPiyY0/K4e5LZKUJkUpNHtQOskxPLS6jJ1i9J1C5L/2bLE63G68NTsEFG4bnplYrp2zdn1WA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by BL3PR11MB5683.namprd11.prod.outlook.com (2603:10b6:208:33e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Wed, 28 Jun 2023 06:57:19 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6521.024; Wed, 28 Jun 2023 06:57:19 +0000 From: "Zhang, Qi Z" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "stable@dpdk.org" Subject: RE: [PATCH] net/iavf: fix VLAN insertion in vector path Thread-Topic: [PATCH] net/iavf: fix VLAN insertion in vector path Thread-Index: AQHZo+QMcsJNze3yREyWuxY9XmvJoa+f00Bg Date: Wed, 28 Jun 2023 06:57:19 +0000 Message-ID: References: <1687310355-130696-1-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: <1687310355-130696-1-git-send-email-wenzhuo.lu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|BL3PR11MB5683:EE_ x-ms-office365-filtering-correlation-id: 16f80ac8-bd41-4f26-b33c-08db77a4ea77 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DPdnoJEGyX7f+XC9mN8HyxhGsLST/t72O95m0unO9KLVoAIjpx9lCHam9s0WhMeUrCX1pnfVZUomoT2fOOcO1crviLYoZiZHM3jEC6p8ejsiRH66f0TrTwZkylklXHUTLwtfngLo5nu2WRNab6pVzU0oxDZwSgWqCwV0cIRBRMNdFNMN/LycEdrJ+6Q62HEUKdvkyZEA02jwau5uKLFIdeWMtyvqYGv5RfHzb5ytWvd9g5BrQ837PYNnSXTG2zwUcEG47x6T8FGdzSpunZRrtkb/4XV9fqtKwoZ2J3vZblTDOYrknHT++4BHtVcjQR/9O3AdKHV81ATS490wJZ1wBtfhWSb0qAG0XRTgUz7xkVcqaCV7PG6bNxnQBQRwqbKFrDp188rZegNY9NUQkb12CxV+PM+4w3X12p6cG2fkFfUbRygvz0jnPxoTiB4yijzOcawhMPjG/yNO+ceUVhPcJ8Tz4A3WQdqeMjU9sn02x2GKlxug1vu97FGhXr27LY+MpXjvhzYP/z+C1wo5sNsFSG2gCGwS7GHwJKANKM/KO513EN2qBFZhPn8jXJT8iVxcmW8kzdpLJnIaA+6//mvG2JmyFqHDzlCVR/mJhRIaYaE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(376002)(136003)(396003)(39860400002)(366004)(451199021)(2906002)(83380400001)(110136005)(7696005)(478600001)(71200400001)(54906003)(9686003)(6506007)(186003)(76116006)(26005)(5660300002)(316002)(52536014)(86362001)(33656002)(41300700001)(66476007)(82960400001)(8936002)(38100700002)(55016003)(4326008)(38070700005)(450100002)(66946007)(66446008)(64756008)(66556008)(122000001)(8676002)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YvynZIBFqyyYA3Sich/bknWcaIaB/u4rNP6AAVs0u1CVyV1M4TX+MLSfrGoK?= =?us-ascii?Q?5dfeG5zbkji9ZZNMIOrX1aGC2t/h3pg0yUzFyoUUeCjDVZl4uyyMrBfSEeSU?= =?us-ascii?Q?1JtBFJLsU/ViyW+UxTKlcnZnWhue1tupYvhfFFlQJaeIxgH0T4rbga/xNajk?= =?us-ascii?Q?wdWBDgixjon8SFr0fCrbAkce1r24124B/wpsFZtWAGxlP6+9224oxe1Imqs7?= =?us-ascii?Q?5w/ZYGQxLmNQlYL+BayEy7MFwv1f9/C3FsAJwG1ZRD+GTB0JQQsj2dEL/HdA?= =?us-ascii?Q?FXjSBSw8ly1HZsCGYRxxkS1BkmO7l+zvjDt9pVx74BaVJKHogB7KK4pFLdAV?= =?us-ascii?Q?e04kiR2O4mINlIVoeqKCdkzEEoC+LosQrxwl0mmRwpL8JC2lG2MJRTbzte8T?= =?us-ascii?Q?DMLSNVcQGLMFTL3DxZCFd20vJjP8tiIkbxHxFxMA6p4wY2Nt0W3Tq/oP8DbR?= =?us-ascii?Q?QLE/WRLZb1mkmeRkDptAAeFmSwYeKPqwksKEFq6KYWLSCrCpy7cZ6beUexjj?= =?us-ascii?Q?uvl/yYIGA5mfA0uSH2kR4ggjP1uf6jNzqWXy9Tbo1JaAJN5Bbrpez0fLCS9D?= =?us-ascii?Q?N2v8gQE89Ayh8twOR7PapXdXOMbegltBTn1BOOxd6+AWYbAp1X5iGrUoOmUc?= =?us-ascii?Q?xM2RL/NttNf9JHkfFO+C2qdMfo8lismoGiU42v68I40ZinaSWjtrTBXnRqtj?= =?us-ascii?Q?mfWrqF+I6h5ZQm0JWY8AHcfjKHCNhukuAHaXRsOaSlDlOZiUVqbNBBTNYLf7?= =?us-ascii?Q?rwnuptQOhAU0rnV2C9kN5KyveFvdmQ4C0kmEcWVFJPtZ/rGs3IBb+R7kSZ00?= =?us-ascii?Q?g0Qniy7pioGUWpKNzjJzfKLjGD2AKR3lQMUTs/TW29oRQ4YOVYippKRYdbLm?= =?us-ascii?Q?skzUkssSi53hioOaxo8fx+4P7fY122Pa7j2aTeewf4vh4bgdnOd5AmV9Z+lu?= =?us-ascii?Q?4LaLPqgJnqBgKBdS6XAt7N2FTRzytzmUgRVv197Aj8iWfolQnLGTJsh/hP2e?= =?us-ascii?Q?/eouxup3B229up+eOFUxRRfxIj28Llb4boRKtMHQdqL1S1lo8aOdagLHAcpB?= =?us-ascii?Q?TZVNiUleE4M11irQ3v5hK7a/TPuLhwBVIiTKEASB0nNvAju2nbzELiuLH5pw?= =?us-ascii?Q?rlGEvyi40wlsUjXHca8//vj49wnHIkOQNxVkHUMAEEfrU8Y5ZdtlEbmyV1K7?= =?us-ascii?Q?y8B85A2AEGJ0Kan4nUHJBDfHSVWpHYDjxzf3LCFn22kN0SpgfhohnGvMVzvr?= =?us-ascii?Q?hfpvKdnEcrNJPKfHT+KyxN7SCezWhZZOlqc2JksmzR1rmmWyo07uAjZJ7CIO?= =?us-ascii?Q?jCjGN78/MnMwm3zRez/ylBSi3tNT/LCMIxiTxvoPCoG4/t9H9g0r0Q7nSTH2?= =?us-ascii?Q?/RiQJ8AE7sylW8q6VMtZZTdpZyGvl3DcBT1r4L7lpDhZKYi4S0dhkSHhuqr3?= =?us-ascii?Q?jhSyRlgvQRW0yGsS0F3hBh8e5Hfc+X+j/TsZhCfB4CIluSezXe45XMkHBoBP?= =?us-ascii?Q?McBqLSzwJkSdTcYKDlg2D5fSG0aDUpsIxyvDZ52Bk3qaqxbBR5F+1AcCovEb?= =?us-ascii?Q?s/au5787Up1XmDBKwwkZwMKQJ0Oi/LC019zwMxS+?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16f80ac8-bd41-4f26-b33c-08db77a4ea77 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2023 06:57:19.4971 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mzG98//SnabHIVD8zDM+tPeotVBQWHDHLdat2HeXwux4bfxdkB8+3hrrOqDfqiPDlUPthIDxQ2Jva/B0Z66PQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB5683 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wenzhuo Lu > Sent: Wednesday, June 21, 2023 9:19 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; stable@dpdk.org > Subject: [PATCH] net/iavf: fix VLAN insertion in vector path >=20 > As the VLAN insertion is partially supported in vector path, the behavior= is > different in scalar and vector path. > For a VLAN packet, if using scalar path, the new VLAN tag will be inserte= d after > the original VLAN tag. If using vector path, the new VLAN tag is inserted= before > the original VLAN tag. > To avoid any misleading, disable VLAN insertion in vector path. >=20 > Fixes: 059f18ae2aec ("net/iavf: add offload path for Tx AVX512") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wenzhuo Lu > --- > drivers/net/iavf/iavf_rxtx.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h = index > 547b68f..2459c15 100644 > --- a/drivers/net/iavf/iavf_rxtx.h > +++ b/drivers/net/iavf/iavf_rxtx.h > @@ -27,13 +27,13 @@ > #define IAVF_VPMD_TX_MAX_FREE_BUF 64 >=20 > #define IAVF_TX_NO_VECTOR_FLAGS ( \ > + RTE_ETH_TX_OFFLOAD_VLAN_INSERT | \ > + RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \ > RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \ > RTE_ETH_TX_OFFLOAD_TCP_TSO | \ > RTE_ETH_TX_OFFLOAD_SECURITY) >=20 > #define IAVF_TX_VECTOR_OFFLOAD ( \ > - RTE_ETH_TX_OFFLOAD_VLAN_INSERT | \ > - RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \ > RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | \ > RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | \ > RTE_ETH_TX_OFFLOAD_UDP_CKSUM | \ > -- > 1.8.3.1 We may need to update the iavf.ini to claim VLAN offload is partially suppo= rted to align with this implementation. VLAN offload =3D P