From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01970A0093; Sat, 21 May 2022 03:34:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9918540222; Sat, 21 May 2022 03:34:43 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 7B29540156 for ; Sat, 21 May 2022 03:34:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653096882; x=1684632882; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=wzW8XQpLUyJaEekTK1Dhfaike8++JoF1NNUh8WQ0sPc=; b=jbYHjyVmhnv+A2PGG1zATK1arM7NDNQgXoShFHf1ijfjgnRi+K2HMihk bi7Poc1Wa16KYSRO41fdj6OyYa45bEncWkq6roRsmlc7xP/GVOu5Tw6F3 1fa/Dzi81hAe5PjkuMhDlxT4cn/cCbVYnBz2H2EPCzGPdBAHeRNc4xQNW Yjev50l2GezZJ7gXEnPIDsP++o+jyx8yYlFw5r1WlOHsf4YfQJV76X+LB eONxymbhrz2g2EktT7cJN+6IpmbFYfC8pth60h51JrDIkVllsQP3GpXK1 AoavcyPqvX3IFxghGMMMrL5cEfJhCvaTTRXczcUbDJzBXZ2rzA5KanLGy w==; X-IronPort-AV: E=McAfee;i="6400,9594,10353"; a="272495632" X-IronPort-AV: E=Sophos;i="5.91,240,1647327600"; d="scan'208";a="272495632" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 18:34:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,240,1647327600"; d="scan'208";a="818820166" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga006.fm.intel.com with ESMTP; 20 May 2022 18:34:41 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 20 May 2022 18:34:40 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 20 May 2022 18:34:40 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 20 May 2022 18:34:40 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 20 May 2022 18:34:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DzI5CozeqpzLqumPlkbUY5xJ9UIuipUq8F3N/gsNk/qmjaozDCVBC9YT0QH/Ibslajc8YqjvKm+NIYgMEjoSRiOg8Hk9NF/9h8BipQxa0HaM/QTimo7XmS3AB8RsGOMLvkGYpLvxbnSczSlMkoYOECFpoJkYDgE17JsgHrrsBfpcahTF2xtHZpPWIGUSFusjxWNQHGUi60P1ZPVZyqD6+3ksfXvQKAA1uQTiTTADQJiOq03Ud+4FVhFmE9ZbJbhnTnXAlPVDGfXEwJaQrf3OO9MTj8TM3qIzgut6N70j8X3q+fXCooUFcQ8IWrCw17q9onj2dPdKlhKDHNJmT1yCxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nQSYqz9yjIFa5M/NWu3pP71DWUXn3hkPWhI0jq07s60=; b=YriGxfIANO3JTTIaqxIY7x0dHN77RrRAiH9A85dD8qSSWrV09aC1U5iZMEE6XMjLKQGnZe9k+KgtMM/RKOFtHJTAlLziA4+W620gW+JV/hAM2lrN6VQ0YGP6Ure5qV+cvceEkj/BfjZiyZOkblyJ2NDR+MKwd/CUanAS2ZlGnzFVJloCJPHksBsKw5SHMN1KCACZ23RNHBiuti78DYkPA1FSsEePzNop+6dFhvurQe+nfafIUE+OPjpkUOdV6DUFNcefcK82vMBxQPMjlLzsf/mUKIoB1fT/l7prctv4o3KkwF+tWaeCoAUtz6XIR5apGujNP8MVdELwup3/I33XZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SJ0PR11MB4960.namprd11.prod.outlook.com (2603:10b6:a03:2ac::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Sat, 21 May 2022 01:34:38 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7%7]) with mapi id 15.20.5273.014; Sat, 21 May 2022 01:34:38 +0000 From: "Zhang, Qi Z" To: "Guo, Junfeng" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "Xu, Ting" Subject: RE: [PATCH v4 1/4] common/iavf: support raw packet in protocol header Thread-Topic: [PATCH v4 1/4] common/iavf: support raw packet in protocol header Thread-Index: AQHYVS/kg6//ZIqzmkGDwxNLUu2FXq0oukfg Date: Sat, 21 May 2022 01:34:37 +0000 Message-ID: References: <20220408091218.240922-4-junfeng.guo@intel.com> <20220421032851.1355350-1-junfeng.guo@intel.com> <20220421032851.1355350-2-junfeng.guo@intel.com> In-Reply-To: <20220421032851.1355350-2-junfeng.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e5b55a82-5abf-4933-7952-08da3aca11a0 x-ms-traffictypediagnostic: SJ0PR11MB4960:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mAtyPPpKgAIs/fWlTnwa2VVPCrSxqRDygCSJix2T5fzSfxp0znNyuNVS2B0xIKaZ2kM8Nbq2oCllvfjLLwddlEBSJ+FOuZviXyIEy7LT0QyvGABTyCCWFZW+AeRgmxnB171zLOnWZX0u6zGAVMDa1PRaKsoNYyvfDm8jcx1Ny4DO4ZkfqM3OGlqgMSYUPNf2mPXR3fyQ7eoFV3sWvrMb26rn34KcvWe571JmIZIQcYHlnOFBtLFUhIbwE63I82568Wq+t0bMTtogWhGCK5W4G1gx11Pi8MSCXhSJ96r53rNzZY2aKE8892fMT5EWkx3/DkG21jnydFvoJUMcRPYUKM9dPQ29uxfim4SFVWSi7K/IX6TjBW4mnJJhs+25ZOBV1sBqQ7H6R3GSDfh1HtXz3txiw1ezDxas1ik0KyRxc9vaLbv1hFZn/m9ZLeq/fsPje/53T/VunceYQdqRNtSMEOn0SqZ2M/xBbnkj5UOMkBai3kM37P1kjJdDNgbuFdDwSLdgErA3MyEFc2DKaRFU0xA67Ptc1phdb3mqYZdLi8l6zvrFV2SGXP+xP2dzpCOA+92EgHohDeJ8It+BfhvC7fZRIUB0TUDc6S3kE2+/9jwp2vvDvoS8icCuj/JzgpmUKCaMk88UX+jfHTqqzmSvgi1Ajr8cpwNaAbnNjX6/bEPZ9IlsOgMaT4Pmap6ULBgcPyYRhs6Weg6klRZUqwWiCQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(82960400001)(9686003)(52536014)(122000001)(8936002)(64756008)(66556008)(8676002)(5660300002)(38100700002)(38070700005)(86362001)(2906002)(110136005)(66476007)(4326008)(66446008)(107886003)(54906003)(6636002)(316002)(7696005)(508600001)(26005)(6506007)(71200400001)(66946007)(83380400001)(33656002)(76116006)(53546011)(186003)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gwm9L30TzCVKUfKJh0pNK/bjXGijNN22pIi6Q0nZA4H39K+dhEAKb1ueVFBZ?= =?us-ascii?Q?DYAbGy6DVfAVXDn2cmaHeafKxTNbLyIcXfZHasjydUMfnONNY7+3To9IJzZc?= =?us-ascii?Q?4+9YtAE2OjJdTS5tYy9pvKlMcx4ZFfRagr2q2xmopndgmY7wscTgrrbI1HxC?= =?us-ascii?Q?SjaL+GHZpd8P15AbDLUMCCWOwuHCPayTqsY/3JHt2aNP87lwar6NfukzweGh?= =?us-ascii?Q?BwC8EFLHEDfG36Hl27eDaHdi8CUykc5eI03fxzRDjlb6ccqzJNHQ0XvBJSi7?= =?us-ascii?Q?rvSnmF8LhMfta6eA9Lj+eJ/1qYZeHhnIMU6Z44aK8n//lXgsO9waZprPvGY+?= =?us-ascii?Q?JN0ly1EjIu5fWFgQh2Yvm5kYBIkJxyNKU7QtTtJWE3JPDqappiroAkxV3rI7?= =?us-ascii?Q?HWcRvZktYDQbxihNxNxW7pEd4CLdRZObg9AUJkvngBy22JkHmCf+21xJ+OxP?= =?us-ascii?Q?MwOIF/aQIr9l1fAhdIhy4IUfwZ2qBRK/Ye+KYQTAezTAX7KayZlDBmh8QV88?= =?us-ascii?Q?2xJne35NHcmwCu+52aT2+0VigO0OjLwZcZY9PQvmNe/LRYLOIDsJE/l9VlFz?= =?us-ascii?Q?8SDQNQkOGyfZv5KD7Q5b0vOe1jowkGdxC2hK5B14gvSLpoyF3iFcC4rTz0Br?= =?us-ascii?Q?5y8Ys8ho9G6V3f6kBFLDa3ROlcceeroFnCMtsyktl5fPMs4/9T86lK1SdkoR?= =?us-ascii?Q?wwzxspd5fYwKfI/8EslKOUUX67586NS2Gp0Q8a/sRpogr0CJU+nLBPiQ5Ypn?= =?us-ascii?Q?vkWNhWlboe35G54PvZoyKz6QoCkMj99D7tml/htRuVL6P2DCnqnpj56QYZk+?= =?us-ascii?Q?czxeMkoNhlC8RYh24Gp20jNbDW1cUlvVEtmwUfd5Z7PzywJX+YXOAbVGzund?= =?us-ascii?Q?LtCDjNwQvpMHKGpycR1ey9OhFl05Z71FotQgBMwZrJWT+aYXIX8wJ4trWEjO?= =?us-ascii?Q?ikMzxKnnyN1xZfTbyipDCLgaIqGvJJ2ZYZb0bgqPAUCMWrEjbyfHhrfD2D+O?= =?us-ascii?Q?I9SdRvEtrFSz7swD2VQ5UYT+UrTyL9BbshxJJmpxvBOV9wgBz16IWgkAl8Nk?= =?us-ascii?Q?kRe/xzX+xPQJg+oyT2wRbM7L1j/4+VOUwomtthb3+01jV9LMaiTZb9pM+SBk?= =?us-ascii?Q?vTN7BpnyF4jKxcWfDY8mvHWcaSGpGoAECtk6XoqWFbSqYZwDasFLxgY5+8bW?= =?us-ascii?Q?J0t0j59dIe1AiR0G4lZVwJQ2IJmd33nTOEPcldG0ldR6+ICsHYQN0e5Ab/pF?= =?us-ascii?Q?Xm06Ca7bnDQfeRiwNRSbiQ3wtSs8gucLTwq49sVf4jabrveJqrPC4MTNgvYK?= =?us-ascii?Q?y6ZMP/Ywk/iObahzWfUrgWcQ27B05d4/FMJx4WIreE0NDOD9tycEJ+5EVviV?= =?us-ascii?Q?zq+jgsJgbouypXMDsvDugTwv09TM2tpUNC74PzyEgDofgwc1vYBfPG5sYj9D?= =?us-ascii?Q?RNqdcla69Hkoh1bcGyRYD/VTRe66CUApss4HepZWNwTkR7wlL+63nXA+xDlE?= =?us-ascii?Q?J29i9kFQe02yBuP1mnD4DrEyf5BCrejk7JjQLBCD8+Z3l54TgCcaWXmMqRk+?= =?us-ascii?Q?sTUFPcK7X8UjNRxvtavYorMntiJAb4KO1jBvncpW6C4nwQXFowCWL+jjiR4v?= =?us-ascii?Q?By1058DszwTJ2DAFadWkSgBa5PZbGqmgwMU42t6KEOICPBLH08yjwBR/EscV?= =?us-ascii?Q?DUJSH6ZEEsrfOB+u2JkWsyRZ9eYsQPhzPlA+VZcLDSH5s+ZZzJoLo7ZCkERz?= =?us-ascii?Q?6pL++c7AKg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5b55a82-5abf-4933-7952-08da3aca11a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2022 01:34:37.9255 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hJyr4606c1t+1UX/z4mbIA+WNyPqoGeet8sEFOoC7ZOUmjwfgx1vE7v5bW8LU7Cgok4njqkZ52tyjm+0jwnOrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4960 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Guo, Junfeng > Sent: Thursday, April 21, 2022 11:29 AM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Xu, Ting ; Guo, Junfeng > > Subject: [PATCH v4 1/4] common/iavf: support raw packet in protocol heade= r >=20 > The patch extends existing virtchnl_proto_hdrs structure to allow VF to p= ass a > pair of buffers as packet data and mask that describe a match pattern of = a > filter rule. Then the kernel PF driver is requested to parse the pair of = buffer and > figure out low level hardware metadata (ptype, profile, field vector.. ) = to > program the expected FDIR or RSS rules. >=20 > Signed-off-by: Qi Zhang > Signed-off-by: Junfeng Guo This patch broken compilation, please make sure per patch compliable.=20 > --- > drivers/common/iavf/virtchnl.h | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchn= l.h > index 249ae6ed23..c9f6cab55b 100644 > --- a/drivers/common/iavf/virtchnl.h > +++ b/drivers/common/iavf/virtchnl.h > @@ -1484,6 +1484,7 @@ enum virtchnl_vfr_states { }; >=20 > #define VIRTCHNL_MAX_NUM_PROTO_HDRS 32 > +#define VIRTCHNL_MAX_SIZE_RAW_PACKET 1024 > #define PROTO_HDR_SHIFT 5 > #define PROTO_HDR_FIELD_START(proto_hdr_type) \ > (proto_hdr_type << > PROTO_HDR_SHIFT) @@ -1678,14 +1679,25 @@ > VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_proto_hdr); struct > virtchnl_proto_hdrs { > u8 tunnel_level; > /** > - * specify where protocol header start from. > + * specify where protocol header start from. must be 0 when sending a > raw packet request. > * 0 - from the outer layer > * 1 - from the first inner layer > * 2 - from the second inner layer > * .... > - **/ > - int count; /* the proto layers must < > VIRTCHNL_MAX_NUM_PROTO_HDRS */ > - struct virtchnl_proto_hdr > proto_hdr[VIRTCHNL_MAX_NUM_PROTO_HDRS]; > + */ > + int count; > + /** > + * number of proto layers, must < > VIRTCHNL_MAX_NUM_PROTO_HDRS > + * must be 0 for a raw packet request. > + */ > + union { > + struct virtchnl_proto_hdr > proto_hdr[VIRTCHNL_MAX_NUM_PROTO_HDRS]; > + struct { > + u16 pkt_len; > + u8 spec[VIRTCHNL_MAX_SIZE_RAW_PACKET]; > + u8 mask[VIRTCHNL_MAX_SIZE_RAW_PACKET]; > + } raw; > + }; > }; >=20 > VIRTCHNL_CHECK_STRUCT_LEN(2312, virtchnl_proto_hdrs); > -- > 2.25.1