From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7D8F430C1; Mon, 21 Aug 2023 13:54:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 576C042B8B; Mon, 21 Aug 2023 13:54:38 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id A529C427E9; Mon, 21 Aug 2023 13:54:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692618877; x=1724154877; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=GqBXI5nhVdU9vKx+zrqesuijyzWT7keVe97qtzgCQRk=; b=VGblJ/LsRXLc7TrcZlSVWlwOf7Yg6DJnzvL94Y06Z0TQ36t8fZXGkm2B AFXtVO6BpIBbWSTWHQyaw82hLNypD9Ww4dkZg38OqTYKtyUS52z7Ff519 94v4Uhss/I2sP5umoOwUI6eFulkbjotIAW/u2HT2FOzJTK+JurOq7KfTd 58/l4eTk6gIPa03mY3AT7xABx8qMv6nL3mzUSVT8PzfdtFiUP1rGepUry CbNvSAZHpvkiToEQUUeY8j7TmVz9bPgcJkzNMAtlJLVtqM4YtxeIQXcun JhRtk+9lXFDwjORSLdbM0q+lrFb/KTZXKygQnJalbGT74sq36Gvo3nCqy w==; X-IronPort-AV: E=McAfee;i="6600,9927,10808"; a="437491180" X-IronPort-AV: E=Sophos;i="6.01,190,1684825200"; d="scan'208";a="437491180" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 04:54:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10808"; a="712756174" X-IronPort-AV: E=Sophos;i="6.01,190,1684825200"; d="scan'208";a="712756174" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 21 Aug 2023 04:54:35 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 21 Aug 2023 04:54:34 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 21 Aug 2023 04:54:34 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 21 Aug 2023 04:54:34 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 21 Aug 2023 04:54:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D6wGe/IR1S19Zzz4wnTX2YVpH8MbGnb0mGE3KavGLfMln7XVibyCzOuBsf/gXxfyMMWXCiPFIyotZ90cWdi3+00ZMeIfF+qVsoN8zB9F456hQFZK9uffRldVC+TQcmIstDeshMLalwwSBNnCOhtwlgVYNBs4G4h5zxoN3oNcfWmfLUAcZ6t5tGTp7PmLD3CTLDBwUodtbV94r7a94bGPqWXpRrTjK7HyjkYx7UysJ/0BRRbcTmFaQ2yGXAoq5hg88wee6UjF3cdP05PB8wn4RpXlmdLsuosY9ROiMWBw7uW6C14MG9qKCnSU6gHgzFdd7KfkkEqHo7SyO5xgDVvZ+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=78xzUPZqAtsAexnqv2Fw5PmSV75ctCFd4zj5Y0+rfvQ=; b=S5R1Qx/xyjlmsJEZtPTSszjL6SaN3En/eHIHJ/pvimeyDZ5pyJKjJSIHGmQQ9nseSC3mpE19lAvCpNrTRJAXZN4sHJ+w5rROll2JAZ427diLUmBRQKfWYBWVccwlnL7bJiBJjA7EXmn5anBJV47JzcgmkgRtMefL0U9Ni+svKkMWLNWlI0e9INCqakl/CUS3KOmG8suznNZJRB4wdmUMXFRpLMLXNj7MG3aIjfaX5O6Cjtc14HG7jYAoUQkYFwrlkiXbpZMUxVKZDKQzIYIe/VDbEZ+46Wpp2Z9B/2LmaYJwJUPeOdjZILiIvwAQUEZm5WKOr1WbMVDsPnXeoUjDpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by BL1PR11MB5543.namprd11.prod.outlook.com (2603:10b6:208:317::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Mon, 21 Aug 2023 11:54:28 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::8a49:15a2:ab69:91c3]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::8a49:15a2:ab69:91c3%4]) with mapi id 15.20.6699.020; Mon, 21 Aug 2023 11:54:28 +0000 From: "Zhang, Qi Z" To: David Marchand , "dev@dpdk.org" CC: "echaudro@redhat.com" , "mkp@redhat.com" , "stable@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" , "Doherty, Declan" , "Sinha, Abhijit" , "Nicolau, Radu" Subject: RE: [PATCH] net/iavf: fix checksum offloading Thread-Topic: [PATCH] net/iavf: fix checksum offloading Thread-Index: AQHZ0bMLT+ioD+MlO06ehOsJOZAv5K/0pOCA Date: Mon, 21 Aug 2023 11:54:28 +0000 Message-ID: References: <20230818090351.2402519-1-david.marchand@redhat.com> In-Reply-To: <20230818090351.2402519-1-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|BL1PR11MB5543:EE_ x-ms-office365-filtering-correlation-id: 23ae6fe4-ba93-43f1-01a8-08dba23d5faa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aWhqMdLEfGtKsVmssU/f2f61XToMmaZB6lDcYfV5qN0QEtzHcWy0lgAVnFxaoeaxxnpkSdJiWXufcppJvCn806yennjMrUGKJ/DbyDKVG1JrXP6A8Jgqgy0ov8Ls4srpvp1UwnzuRzCEOeryT1lZs9pdwtbS7PmrWpLeGSGQEV6HHjVRlVcpBGmy8gbE/1s72pGKi0aTZFR8WCtZk/ZVltLDjOtvngcSnotC7yPwNIC0tBR3pRrhYf7nHH9mqakVtHtXR+wG7EslAM4G25qjXw/noLYNqKkrL5GImRRENnhQ1dQrn6Mfo1dx/SiAYhlCpHz0pp8Lv0q3xKZBa+Vf2GwancVu5iNWVjo0dYFipKULCAxNh44VcD3qFk6BSIEHx21v3VBUMYY4iDpi41h6kwAWMvH+GJc/ZWiuZ1eaqonq+EGuQMN5aR7Mm4u0DFOBRKfuIuQy9vW+d9ry1dvpwlrCXXn5k/KnsmmngjVBvtPaT+OqjsK9pSQGseR/gsuY2fDjr9ptX/3dXQzGCM6MmDLF8i6b9ng36oT4YJsoCZLADQVeCZjnVBFA5KE6++veMlaZ5ddBks29mnUnEMUg1MuKmwbPcN6ltbMtUgLYk6aqu+FANwFI1WPic7Tuh7Yg x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(366004)(346002)(136003)(39860400002)(396003)(451199024)(186009)(1800799009)(2906002)(53546011)(38100700002)(38070700005)(6506007)(83380400001)(5660300002)(52536014)(33656002)(26005)(7696005)(86362001)(8676002)(8936002)(107886003)(4326008)(316002)(9686003)(66946007)(64756008)(54906003)(66446008)(66556008)(76116006)(66476007)(110136005)(82960400001)(478600001)(122000001)(55016003)(71200400001)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZPlpnIqaEYyFM8EzqwKI+OOTyXmvtY4VXy49F71kDzojQ3Xr+UFUEJfDH46t?= =?us-ascii?Q?Ysuq8rtWEXf7lr2Gt4CBkUKw7RbnlT+bx+mM6mql2zbjfPn7YRJgYsg47Rd4?= =?us-ascii?Q?Qmexzt4jCOO9Z4Jmu3LyLFeB4SR9492Rs1JxODNC5H7MNrXqIL418UjqDWjI?= =?us-ascii?Q?aiyk4B5rphiiZFKqhfDL3BKWb9hJRPxrWEf5GPyedxFWAwonIbvUw5nNopz4?= =?us-ascii?Q?NCqCAPypCwRnwpRf1iHCEZzOSkKjxmmbeeIrMGU1VFV4cDs47ahyjBA9I1zG?= =?us-ascii?Q?LIUomrU6qB/c2yutyEodnm3rob2xFgyZde9W85o/kN2qUc7AVe0Y72s9O/hu?= =?us-ascii?Q?/4gFzLWphUPTnM/syzaz59fEu/b/GI4NeqrHkrFmTKIggKoCAVy0kgjL77Py?= =?us-ascii?Q?l4fIY5NDmuPFLjjPk/gg3uw7geJ8dOcPr21xS0/gvnc5y/Js0G3nXG6JRRGo?= =?us-ascii?Q?EfI3XRoGDQihE9E40xEFJ2UGrC7Mw1u18zFXDgc/w2TS1pvbSaJic5hqRHki?= =?us-ascii?Q?iwOf6tVgZ+PAOs4Cr8WrfJczvhuk/UfpoXdBHNXXPhhA06pFQqDWIrXsvTKV?= =?us-ascii?Q?zShGjt74uLefWJs9rBzAAraGm6JXVQ+lsQNvokYpfB5JvQ25cm3Z0kehNGMM?= =?us-ascii?Q?EE5YSY2h1bSiN3F5dSd5bVRoT0kSeCLUiY5P9cfUlrT2KKh9ok9fQEYocm+2?= =?us-ascii?Q?MQHR02haz0UAnCIj5irWJzW1WCC0x6lcHbAj7b+0YNGKRTLZjfpZaGDwcpps?= =?us-ascii?Q?aIObDubwsYMIKbIO1LvpGAuWNmvU4ce+mfzkweuZ3kwA5G4QZH0UD9PrwWg9?= =?us-ascii?Q?Cyq7BbBe9vi2bGSnEPIAWwvjqfa7h+lq87IXMCI71pZu0JXUJflZtTJNxI78?= =?us-ascii?Q?te4vENBAXGD7KKoHKyxzaczo7e8RoeMybipQTXXUCPbUYJHGy9n2zyOJ58sp?= =?us-ascii?Q?aqtxbIrtDc/aFjDqLUoe/VqiHR4RBIbbNwzcWmil8YCwPArovTLusResrMUP?= =?us-ascii?Q?d36Qw3oOFAWJoQIq2bzLKD4Nt0ByaqCDUzZmS8QYGsuTbzB7EvgDZ5pRFLEi?= =?us-ascii?Q?Fg7e1IVBrT4sTFjEnpl+w+C1H/jbWnCFgyoKD6BDHkgH9GzZXRMpfYJ/VLZO?= =?us-ascii?Q?EG1HEABAv1ryo2lzLyIk/dGKAxJZa6e86Uv/DezYz/IWi0Pk3lX8Tr3K3ERL?= =?us-ascii?Q?PUmKvXEinbDGEwtab9F1O6YNkjUv2EfbLY3iJ0IBPR+cGpe0mmT5DmT7g2T9?= =?us-ascii?Q?dv4th1OE8mqBb8upyvVdQ6Ve2BCQ8KuuQkLXU502mkWShqJVB7iVl5q4l0y/?= =?us-ascii?Q?wE7G8Ukl/AxLM868YoWeB0pBg8KxgcV029vHNlIWIDXY+/tgBWdW4Ef1zdfh?= =?us-ascii?Q?AT8++va/JXJttf3mX3WpoZGyZYa4eZaTOBD4kdptDH9GU6RDXR872DN5BcWE?= =?us-ascii?Q?8Sf9CvnYN4AOOQaGOGrZVnLztmA9OCUVmSjHT2MzPOHy9iVEhk+BfxjnIudC?= =?us-ascii?Q?bCuy7mdkOAi0eJdOuDRs4h6gt27zUhrF2ChBBeUb48sf3xyZqd6bAyipldn1?= =?us-ascii?Q?WE1cYV+KKk0P7m8A8lQf1M4u5sgZ9U2+uSIpp1MO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23ae6fe4-ba93-43f1-01a8-08dba23d5faa X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Aug 2023 11:54:28.4730 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UCHlmt0Bfm1jBk6sccLNZRJDpsC7FkqhyIk++5fb0hyz46Y0SkrOtUZv+nkORP8JYxOJLms5VxIczliaZiAB5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5543 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: David Marchand > Sent: Friday, August 18, 2023 5:04 PM > To: dev@dpdk.org > Cc: echaudro@redhat.com; mkp@redhat.com; stable@dpdk.org; Wu, Jingjing > ; Xing, Beilei ; Doherty, D= eclan > ; Sinha, Abhijit ; Nic= olau, > Radu > Subject: [PATCH] net/iavf: fix checksum offloading >=20 > The only presence of RTE_MBUF_F_TX_IPV4 can't be used as an indicator tha= t > a checksum offload has been requested by an application. According to current implementation, actually the only presence of RTE_MBUF= _F_TX_IPV4 will cause IIPT =3D 10b, this scenario corresponds to an 'IPv4 p= acket with no IP checksum offload,' according to datasheet. So, I assume in this situation, the PMD continues to operate under the ass= umption that the application has not requested checksum offloading. Could you share more insight what is the failure, maybe we can perform a m= ore comprehensive investigation? Thanks Qi > Check that RTE_MBUF_F_TX_IP_CKSUM or others flags have been set.=20 >=20 > Fixes: 1e728b01120c ("net/iavf: rework Tx path") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > drivers/net/iavf/iavf_rxtx.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c = index > f7df4665d1..b9e2879764 100644 > --- a/drivers/net/iavf/iavf_rxtx.c > +++ b/drivers/net/iavf/iavf_rxtx.c > @@ -2652,6 +2652,9 @@ iavf_build_data_desc_cmd_offset_fields(volatile > uint64_t *qw1, > offset |=3D (m->l2_len >> 1) > << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT; >=20 > + if ((m->ol_flags & IAVF_TX_CKSUM_OFFLOAD_MASK) =3D=3D 0) > + goto skip_cksum; > + > /* Enable L3 checksum offloading inner */ > if (m->ol_flags & RTE_MBUF_F_TX_IP_CKSUM) { > if (m->ol_flags & RTE_MBUF_F_TX_IPV4) { @@ -2702,6 > +2705,7 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1, > break; > } >=20 > +skip_cksum: > *qw1 =3D rte_cpu_to_le_64((((uint64_t)command << > IAVF_TXD_DATA_QW1_CMD_SHIFT) & > IAVF_TXD_DATA_QW1_CMD_MASK) | > (((uint64_t)offset << IAVF_TXD_DATA_QW1_OFFSET_SHIFT) & > -- > 2.41.0