* [PATCH v1] net/cpfl: fix incorrect status calculation
@ 2023-08-22 1:17 Zhang, Yuying
2023-10-23 9:01 ` Xing, Beilei
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Yuying @ 2023-08-22 1:17 UTC (permalink / raw)
To: yuying.zhang, dev, qi.z.zhang, jingjing.wu, beilei.xing
From: Yuying Zhang <yuying.zhang@intel.com>
Fix the incorrect ingress packet number calculation.
Fixes: e3289d8fb63f ("net/cpfl: support basic statistics")
Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
---
drivers/net/cpfl/cpfl_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c
index c4ca9343c3..8c02c84c5b 100644
--- a/drivers/net/cpfl/cpfl_ethdev.c
+++ b/drivers/net/cpfl/cpfl_ethdev.c
@@ -304,7 +304,7 @@ cpfl_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
idpf_vport_stats_update(&vport->eth_stats_offset, pstats);
stats->ipackets = pstats->rx_unicast + pstats->rx_multicast +
- pstats->rx_broadcast - pstats->rx_discards;
+ pstats->rx_broadcast;
stats->opackets = pstats->tx_broadcast + pstats->tx_multicast +
pstats->tx_unicast;
stats->imissed = pstats->rx_discards;
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH v1] net/cpfl: fix incorrect status calculation 2023-08-22 1:17 [PATCH v1] net/cpfl: fix incorrect status calculation Zhang, Yuying @ 2023-10-23 9:01 ` Xing, Beilei 2023-10-24 5:26 ` Zhang, Qi Z 0 siblings, 1 reply; 3+ messages in thread From: Xing, Beilei @ 2023-10-23 9:01 UTC (permalink / raw) To: Zhang, Yuying, Zhang, Yuying, dev, Zhang, Qi Z, Wu, Jingjing > -----Original Message----- > From: Zhang, Yuying <yuying.zhang@intel.com> > Sent: Tuesday, August 22, 2023 9:17 AM > To: Zhang, Yuying <yuying.zhang@intel.com>; dev@dpdk.org; Zhang, Qi Z > <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei > <beilei.xing@intel.com> > Subject: [PATCH v1] net/cpfl: fix incorrect status calculation > > From: Yuying Zhang <yuying.zhang@intel.com> > > Fix the incorrect ingress packet number calculation. > > Fixes: e3289d8fb63f ("net/cpfl: support basic statistics") > > Signed-off-by: Yuying Zhang <yuying.zhang@intel.com> > --- > drivers/net/cpfl/cpfl_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c > index c4ca9343c3..8c02c84c5b 100644 > --- a/drivers/net/cpfl/cpfl_ethdev.c > +++ b/drivers/net/cpfl/cpfl_ethdev.c > @@ -304,7 +304,7 @@ cpfl_dev_stats_get(struct rte_eth_dev *dev, struct > rte_eth_stats *stats) > > idpf_vport_stats_update(&vport->eth_stats_offset, pstats); > stats->ipackets = pstats->rx_unicast + pstats->rx_multicast + > - pstats->rx_broadcast - pstats->rx_discards; > + pstats->rx_broadcast; > stats->opackets = pstats->tx_broadcast + pstats->tx_multicast > + > pstats->tx_unicast; > stats->imissed = pstats->rx_discards; > -- > 2.25.1 Acked-by: Beilei Xing <beilei.xing@intel.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v1] net/cpfl: fix incorrect status calculation 2023-10-23 9:01 ` Xing, Beilei @ 2023-10-24 5:26 ` Zhang, Qi Z 0 siblings, 0 replies; 3+ messages in thread From: Zhang, Qi Z @ 2023-10-24 5:26 UTC (permalink / raw) To: Xing, Beilei, Zhang, Yuying, Zhang, Yuying, dev, Wu, Jingjing > -----Original Message----- > From: Xing, Beilei <beilei.xing@intel.com> > Sent: Monday, October 23, 2023 5:01 PM > To: Zhang, Yuying <yuying.zhang@intel.com>; Zhang, Yuying > <yuying.zhang@intel.com>; dev@dpdk.org; Zhang, Qi Z > <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com> > Subject: RE: [PATCH v1] net/cpfl: fix incorrect status calculation > > > > > -----Original Message----- > > From: Zhang, Yuying <yuying.zhang@intel.com> > > Sent: Tuesday, August 22, 2023 9:17 AM > > To: Zhang, Yuying <yuying.zhang@intel.com>; dev@dpdk.org; Zhang, Qi Z > > <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, > > Beilei <beilei.xing@intel.com> > > Subject: [PATCH v1] net/cpfl: fix incorrect status calculation > > > > From: Yuying Zhang <yuying.zhang@intel.com> > > > > Fix the incorrect ingress packet number calculation. > > > > Fixes: e3289d8fb63f ("net/cpfl: support basic statistics") > > > > Signed-off-by: Yuying Zhang <yuying.zhang@intel.com> > > --- > > drivers/net/cpfl/cpfl_ethdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/cpfl/cpfl_ethdev.c > > b/drivers/net/cpfl/cpfl_ethdev.c index c4ca9343c3..8c02c84c5b 100644 > > --- a/drivers/net/cpfl/cpfl_ethdev.c > > +++ b/drivers/net/cpfl/cpfl_ethdev.c > > @@ -304,7 +304,7 @@ cpfl_dev_stats_get(struct rte_eth_dev *dev, struct > > rte_eth_stats *stats) > > > > idpf_vport_stats_update(&vport->eth_stats_offset, pstats); > > stats->ipackets = pstats->rx_unicast + pstats->rx_multicast + > > - pstats->rx_broadcast - pstats->rx_discards; > > + pstats->rx_broadcast; > > stats->opackets = pstats->tx_broadcast + pstats->tx_multicast > > + > > pstats->tx_unicast; > > stats->imissed = pstats->rx_discards; > > -- > > 2.25.1 > > > Acked-by: Beilei Xing <beilei.xing@intel.com> Applied to dpdk-next-net-intel. Thanks Qi ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-24 5:27 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-08-22 1:17 [PATCH v1] net/cpfl: fix incorrect status calculation Zhang, Yuying 2023-10-23 9:01 ` Xing, Beilei 2023-10-24 5:26 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).