From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9058742BAA; Fri, 26 May 2023 13:10:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 607A540DDA; Fri, 26 May 2023 13:10:24 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id D04A240A89 for ; Fri, 26 May 2023 13:10:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685099423; x=1716635423; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8FUN+A9TRjgiR2p3rShOV+jwRqPzIxkKXYgEGVn3Ewk=; b=BtmWjRxguUamgT9up+OJwhiwFHesTmnenSFzsr9A9/elmlXJMAjL5iLq vB1b9vUBeK8NGv6P3qhdHD0ttZcYIu0zpoIytIgThiPezCQ39R55KCHVe vD/4hakqW/PWSpFcnlUTvg+dHeaRdpyStmUDATg6vsddCu/MHYJtwWjkb UsIcEyn2g/3G3rmeT8MEUG4HGsRElLLu3pV/rIH0DgP55yyrunnJYqLtC t7upRenH18JZlXp3MUK8Tk18U/0q5EPrJkjB6Vnn6Wj35786evh4d1CDp G2GWhsGhKMLVeBohBAw/DcM/iL+EZfLW1YEBWqz6Nk0F8NQuUQ08vueDu g==; X-IronPort-AV: E=McAfee;i="6600,9927,10721"; a="334530399" X-IronPort-AV: E=Sophos;i="6.00,194,1681196400"; d="scan'208";a="334530399" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2023 04:10:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10721"; a="775061624" X-IronPort-AV: E=Sophos;i="6.00,194,1681196400"; d="scan'208";a="775061624" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 26 May 2023 04:10:21 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 26 May 2023 04:10:21 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 26 May 2023 04:10:21 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 26 May 2023 04:10:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vsnrjzt5H/FuKnPX+i+6PHTF746z6wMw/H0y09rxaILlUlUJzoRP39OrH/WSF6eop+jw+IGGCAXLIZKcymIlByuqPKo6P2Bdd4rtn/D/NhZ+HlZyvo2zZwV8hVmlxKQvAhUe4EDLitaDpXpzG2TS/Hj3xE/tSYES6esHve3LMNnl0nDYhI6WJ4KhM4Dj0IV3bjeXXCkVxkyaEMBllaXEH37ADB81ZuOMuWNMtMV0YzsTmZdMtz0uZz6ewrcOmtWPzJnNAF6irAKjH9D48bfbFIH+B0ac2RZy1Sd5DrL2rnRXVdYnwSqF0FmFNfeKTh/QXlcR7beQYTIbG31WMRGZ0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XzNsePiseFmn/naq6sIwRJR1Go2Zpg0xpIDB4a8yzW4=; b=YSaCkx7vo4n1pUH7wRgoMM9cyvHsdC89Ilw/xHBfr4m5yUU5AQCfKaDgTFWCIAdCDFrMYG8OsdzocQ5tMW+O7ymEJpkJ617NolyIWLk7SD4Mqz2UoyZ01BXIkXK3ZKeBNULLQwkhd76AuAsEgqYmgAKxAJP/ogLCR06P0dwakBVRwFeHJlYaHSPNIYBNXFLBIpCv+f0qhKqrGOmYDhH920mqvqo+MsxXmeruoOgdwxra5ogw+cThOozqPz5xTGDpdDRy0B0ywLduVm7yhvmomiDuBw2PMVZbCEYQO/pvl3alfwt8+5d2y8YWC7EOm1Lnjm6/YsusoTNubYvWWT/PUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SJ0PR11MB5917.namprd11.prod.outlook.com (2603:10b6:a03:42b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.16; Fri, 26 May 2023 11:10:19 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6433.015; Fri, 26 May 2023 11:10:19 +0000 From: "Zhang, Qi Z" To: "Xu, Ke1" , "Ye, MingjinX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Zhou, YidingX" , "Ye, MingjinX" Subject: RE: [PATCH v2] net/ice: support double vlan Thread-Topic: [PATCH v2] net/ice: support double vlan Thread-Index: AQHZgAMvxcRXGhgurEu/a3F8SQExnq9sdj4AgAAO2vA= Date: Fri, 26 May 2023 11:10:18 +0000 Message-ID: References: <20230420061656.140315-1-mingjinx.ye@intel.com> <20230506100443.215817-1-mingjinx.ye@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|SJ0PR11MB5917:EE_ x-ms-office365-filtering-correlation-id: 1c98acfa-4f25-4d78-71ca-08db5dd9ca5c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZZJdjbKhjYUN9EmIcQX7NHepNqWrev0TcEwRKCI3omjhhbdzlCHzwKC/2bQ2x++8ql6YT1OkZvDexqytNDfc4yctQ/W3glcYVgwj+sRwDvDrMwcM2MbjqIUppYOABTuRF60Y+ni5k7dSGLzBviWGKRRRie+H8M3TlywopjR+c6z6w7Ki+xaFIJBk/yNwmjNO146tJPU0wUdpmmPlZg6FEeY+Eg11ouFrVO1mzd2i1trSGZTEuGVShHVXNlqpiqYyGriFTNOa2TmAaA75X35XAgkncSYW/OT8qYPf28jVmVETtKwosJgB0SCi0xcw8glGTxdX+Qrl+NZMGhuHQha1/app/I5Bm2SQovFT3bgLFrmjayUXXROYXgOls5YRaeBHrp0o1G+hN1xMauK9NuAZbr6NZCURHqwLJjHUJz/bQ7Fbric+n6goPWUiHHIHj2vqVQegvf3BY/0RnmuC8ti19DfBuHp188wQaiDp+r1P3mVEpkpwxnhdSI0Cc+rUcofUwfR0/k1CBBU0gRzAp8AtqHlXqs9zBb+ix9CGPRIyWO57T6C80ImhzkqGFteoD/yzrzpArpGjeWLKd49EXsi1cRh5qKvlVjXuHQ8Ji2N9m3lqYbq+erYhlu3kOdD+JMsj x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(136003)(376002)(366004)(396003)(39860400002)(451199021)(86362001)(110136005)(316002)(54906003)(33656002)(4326008)(38070700005)(66476007)(64756008)(66446008)(66946007)(478600001)(76116006)(66556008)(71200400001)(7696005)(55016003)(8936002)(52536014)(41300700001)(2906002)(8676002)(38100700002)(122000001)(82960400001)(53546011)(186003)(6506007)(9686003)(107886003)(83380400001)(26005)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ebvttUhJENx2uxSJL4zuh9XrbjaLALoTG/HVjTD3cDc39Z6xa61OMQ1Si/aB?= =?us-ascii?Q?VUFp8zSWev5qw11k7C6a8jGisfyGsyrgxT+SWWhm4rxebxapHHqfQUir2ptr?= =?us-ascii?Q?Ivf7+lYvtSz/tTpljWqKirjYzmth7/mLhUO3aJTvzP0Wb1LCJD2Gt1bSRfns?= =?us-ascii?Q?BE9BITbhMVIVHW5obF4FHy80Fm9r11hQmiYF5+lxuTdg6cDSUIgMNtid7RFk?= =?us-ascii?Q?egQPbHQZTUfIQYH+drL48jYkBZo9QVHJK3KF+V6rmVbFkvhf7wH+l5EcvMRG?= =?us-ascii?Q?fKMOL1HjknuIHH3VCYgRemWizyiVUv6MswTDbKfoT09xNGYDsqfZcCwQ+Vej?= =?us-ascii?Q?VkthwOG4ik6b149vF95Ujn3WGMvBYEW1htFYebCjrX+zkyPINK8vWB6xaC2g?= =?us-ascii?Q?nPJIKkZVdNBM2wDXLgH7HKIZH2EXpjra12HNpmriRMyk1Jl2irS6tSIlmDyk?= =?us-ascii?Q?xQjbMokfk5Kjslkj3e2DZ4ihoKxhqaAiVlEqBfXmzAnwgCtn9q/08gOYAITX?= =?us-ascii?Q?JP13lptgJa+O2oDbPf2wFD5xMyb1bQDbuOcPbbzGRprq2AFDQES1N1dV6IFl?= =?us-ascii?Q?Jv/tfkCcnXTRw44IDmYHeBKfNt+NVndT2fncj3JTkxD8yQc+DAI9e2Bw/ezd?= =?us-ascii?Q?pmOksq/9c2rL2cGEl4SSowbRNrbmFc7LcVjVeW98E4zwhh0KCwh+jspHl/co?= =?us-ascii?Q?GwKRCVx8anTWtvtZrca5LySkbaQ7PlWmg8PUcaVK9p3Kbf1tQlK7q1+JEeTw?= =?us-ascii?Q?zTtPJzl78y2mNddMdw3syYBEDPOl98vExfN4XJRPWJh64P/d2L41WCb0hog8?= =?us-ascii?Q?Vvp2nJuDVx53FvT7Uw010QsI4Jq+sdnPlsrHRRmwscDj7lkpjr4ups6LfUv3?= =?us-ascii?Q?0mGmvBFvouZTYZW4KCdlrfFWx366QZycJEachx5pbzROfs5n1Ht8InAuGuyY?= =?us-ascii?Q?iTDNDGrX0xR6aca55K3pJg6KmzQxKDqKebbvH12xLROLDFR2URcpzBVaqAMD?= =?us-ascii?Q?EN7ugRgm2vC6HVqvY+LCXUw7upLS2JmsctWLfOlY3YuYKf8w1UMDxkCt0+Bs?= =?us-ascii?Q?sVMJJb0W7lP4Jd51DQOPpl3XOiICVTVhh6sb/bPzgmP4ayYQqsUhcIXNGR2i?= =?us-ascii?Q?5fatCdW/Y8fHUAD84vOaBMxrbuGjtEOwp+rysViyt9v3briyFEjw8nauVwV1?= =?us-ascii?Q?0yO8tzQ9oD/RtHL5Ti48IPZeFBo+ainIbsokWs2PXh1JlOff72x8eBAxJnqA?= =?us-ascii?Q?yOoIAE8o5dKJvikMeTxmByrE+thIeL7KkBTfe1jonRo2bZT7RvJ7txrTIQId?= =?us-ascii?Q?RI2+nA8FaN0XFDx4iN1wRO3AzxcxzGibH2xRS7dbl2MIxhAtr2G9Cv9se2Ok?= =?us-ascii?Q?vEPYXKg3euaFrdwJ+9se/Hth8S9n0N1jonIROZGKBJIUg5f6MB8NvmrEbUYL?= =?us-ascii?Q?jOy9sGcyWo/LSG5bYj7MucjjXE1vqijHQJbnBm6ueWY3JO5xsbIwjs1rWIcB?= =?us-ascii?Q?eETbtga++G725tZXUOGjApu28REIVFOPR3POY3+IDv6ps6k5IgiKYUTtiHhi?= =?us-ascii?Q?YWDasrpe20DaLjvCZo9cm2qFXDBEK9hfOzThSdSY?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c98acfa-4f25-4d78-71ca-08db5dd9ca5c X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2023 11:10:18.7056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Rd6zbzXQjOGe/aiRvJx2AYq438AadU56P2JHPpr5kUeDATEMzbCWLmQM7miujZpc40Agh5S11AcyjJEyWFQYQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5917 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xu, Ke1 > Sent: Friday, May 26, 2023 6:16 PM > To: Ye, MingjinX ; dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Ye, MingjinX ; Zhang, Qi > Z > Subject: RE: [PATCH v2] net/ice: support double vlan >=20 > > From: Mingjin Ye > > Sent: Saturday, May 6, 2023 6:05 PM > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Zhou, YidingX > > ; Ye, MingjinX ; Zhang, > > Qi Z > > Subject: [PATCH v2] net/ice: support double vlan > > > > Aligned with kernel driver, optimized for inner and outer VLAN > > handling in DPDK, and implemented double vlan insertion and stripping > support. > > NIC must work in double vlan mode(DVM), depending on FW/SW. > > > > 1. Adjust vlan stripping > > The vlan stripping enable/disable is applied to the inner vlan. > > > > 2. Support QinQ stripping > > The ice outer vlan strip is enabled/disabled by the mask bit of > > `RTE_ETH_RX_OFFLOAD_QINQ_STRIP`, and the user can use "vlan set > > qinq_strip on 0" to enable or "vlan setqinq_strip off 0" to disable > > the ice outer vlan strip in testpmd. > > > > 3. Support outer tag type switching > > Implement the ethdev `vlan_tpid_set` api to enable outer tag support > > to handle `RTE_ETHER_TYPE_VLAN`` RTE_ETHER_TYPE_QINQ`` > > RTE_ETHER_TYPE_QINQ1` outer tag types. > > > > 4. Support outer port-based vlan insertion Implement port-based outer > > vlan insertion. User can use "tx_vlan set pvid 0 45 on" to enable or > > "tx_vlan set pvid 0 > > 45 off" to disable the outer vlan insertion in testpmd. > > > > Signed-off-by: Mingjin Ye >=20 > Tested and passed. >=20 > There are several points need to be mentioned. > 1. Only Scalar path is implemented, needs force-max-simd-bitwidth. > 2. Not supported: StripQ. > 3. Hardware limitation: Requires different outer and inner VLAN type. It > means > setting outer TPID to 0x88a8 before double VLAN insert. > 4. Undefined behaviour: VLAN insert and TPID configured together is not > defined > in this new feature. TPID is designed to work with PVID now. Under this > implementation > changing TPID would not change the TX outer VLAN type of double VLAN > insert. >=20 > Tested-by: Ke Xu Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi