From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6422436E8; Thu, 14 Dec 2023 03:12:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5F9542F57; Thu, 14 Dec 2023 03:12:42 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id C123C40283; Thu, 14 Dec 2023 03:12:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702519961; x=1734055961; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=aObw1XT78dFbBF3jbck5WtJIvHVhb0DPKq03Iy3fdc8=; b=gT7Es0UNJ7BwclQL1/+bcssh28MXFgUv6P9r+8yKzJMHT2V+IOyQ/WbK NZHlcX1FD6cziOS0aP4UnkEtbUTW/zg+ZgXECnvPLtRVsdhH7I4xWY8GS aH1r5n3/C30gXZ/wsO8AGBqbe8gIUy/a4qEjDZPA6sHM5mejqxHmgX/lr EK1Yv8fkm/dGgysuyS17fXZjjOy2NPC3vNrs22OycVHQATQ8oKMk0QALl EmpGDre0xz84dfav/3IKKrZikc9NRkpQecbeJlQj1LaDjjkaUiWWJGEgW /r0gZZUNOtHJSXtakVjf4TA1+0L0tGQ5xUZIqCCZm1GRkQlq9gtH2p6JP Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="398893111" X-IronPort-AV: E=Sophos;i="6.04,274,1695711600"; d="scan'208";a="398893111" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 18:12:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="808404626" X-IronPort-AV: E=Sophos;i="6.04,274,1695711600"; d="scan'208";a="808404626" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Dec 2023 18:12:39 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 13 Dec 2023 18:12:39 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 13 Dec 2023 18:12:39 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 13 Dec 2023 18:12:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A9dsTiVnu5I4MMdbEqM8kOYw6n1A4BqGBKDWD49yE7SkpxTa2th6LBniQoyw82FfCmOqg+p8mCyeKlluCW9nBDBT9JDnJJhqnCMhQuSEkXIib9ggoSf2f8dltP2P0yolCvSdmAfxO/PMgV5u72gSuHRs3XYPBLVvvq2nChSgvcQaEIFyu0qpKStBz+ATFgdB2tytmmzYZZmWjhHdJgviMkmBcawK+inOdV3Dxb9Lobli3njWndofv8OQn/0TEMWMmjW+PF0uspm2yxtTVR6aQy7biu8IYaLit22QJUA2WOz7J1Yi/ddx+94Ga8cuQuRi8UdCtrJ2PcON1Jue6fsSYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k7FWpSLLYS1ygtgtJ+kMH0eq0AQLAMQXcvlplK6cK2M=; b=Dje2X2/1PrQHq90jfBzdWHNW59EMmxqX/KL9sKODAeoikXT5YruyKJILESmWQc6ObbhZ0nebK0NSrRAbMmCoCumv50xwmGGFPfDhKEj3epg/1pIpWyjZdMKSd0z+A3/KhaWjH/gz0duspfbtlLvri/WNINghH+dkQM++TI+yKVVtA6HNqQFvidc2EymbfIPZN0lb0U+9GDtr5H2HJzb3fe8f9TJsBRifnU+M/BEr/1C6dvxiJPVKFQ1/ixe7OVNs3Qm8koSnnCadUtg3SuaWTL0mUS1AsO02dByQz+GC87vytyWbiI9RW4eW1IU5Uvzuqzg33U9ihtiUaGor0jQpXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SJ1PR11MB6298.namprd11.prod.outlook.com (2603:10b6:a03:457::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.33; Thu, 14 Dec 2023 02:12:30 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136%7]) with mapi id 15.20.7068.038; Thu, 14 Dec 2023 02:12:30 +0000 From: "Zhang, Qi Z" To: "Deng, KaiwenX" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" , "Zhou, YidingX" , "Deng, KaiwenX" , "Zhang, Yuying" , "Xing, Beilei" , "Wu, Jingjing" Subject: RE: [PATCH] net/i40e: remove redundant judgment in fdir parse Thread-Topic: [PATCH] net/i40e: remove redundant judgment in fdir parse Thread-Index: AQHaHqoI8Eoq8CbtNECFXqMAI0UQTrCoKH4A Date: Thu, 14 Dec 2023 02:12:29 +0000 Message-ID: References: <20231124070103.1778196-1-kaiwenx.deng@intel.com> In-Reply-To: <20231124070103.1778196-1-kaiwenx.deng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|SJ1PR11MB6298:EE_ x-ms-office365-filtering-correlation-id: e0932ce9-17f7-4f0d-6762-08dbfc4a1fce x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KZPw1x/mfYAZfILXsPmSIz9e/8+UDTPlLxi74gxZePdsGBV+RcpvZ2yv9q3zgADg/1lLfp5cki/cHZ2Tn0r2hNEITgNrQOgAjo7qRWsLMJvmottwAow/a3gYOGKabxn+BWU5PfvvgBFeobl2CFuG5HywUF+Vh9XWEGQocgXVrK41R+on8jlngiWUNgIbYpbVwghfYzocmjKI2zWkKtFeV3WtRaQwGmn/CV8dP14PHFPc5KsGTR5SzkVDd51aP70/0LJ1UyMYSlLZuj+mJ+/JP/VzvH6/KMBizdVgAuPVe2pCsK/qWirUL0e3RHU8HlnSbQnno0WrLtHYDVjouOqFNBoMR1YS1fXaiNorF9JFqqkRYG4aB2bVD0B3fv/U4m/Cd056FBjRwZXQtMpEKyzGrR9o9bnS0ybjpabmzSPU0K5RCmxuxqek/mY9aRHnZ7XyEjeNc3znQDCF6vyFVqw1HGboGxnpuAybmqc74IGnfaACJ7R1yPo6u8qkMob7CDpZ92HHf3KO8tSdNB0K1ZEFtc1xCWOp0dzGrNNP/xoZRZ3G0ARRjkWDBDp0bcofLjz2pIQYo4p0AD+I2sXshhrfeV5DbIPGj4rmJFum9bKZ/lVXNYQWaD4ZLXz34q58lI1p x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(39860400002)(346002)(136003)(366004)(230922051799003)(1800799012)(186009)(451199024)(64100799003)(4744005)(2906002)(41300700001)(38100700002)(83380400001)(122000001)(110136005)(33656002)(86362001)(5660300002)(9686003)(107886003)(7696005)(478600001)(26005)(6506007)(53546011)(71200400001)(52536014)(54906003)(82960400001)(4326008)(316002)(76116006)(38070700009)(66556008)(66476007)(66446008)(64756008)(66946007)(450100002)(8676002)(8936002)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nVM7Z99OxcVzyahnci4V8HGyFi8tt2AYUWZwxkzxJKTbkw2gBN52rD59S0XC?= =?us-ascii?Q?TaZT49B1uTpJOnyE40Non6Bzus1LBmx2ticmeydw9vLWzV28QtI+TZiqmuVI?= =?us-ascii?Q?Zgabz3Y9hquUW5AlRl6AKX0aWtYgv5pc0QcBjOfYhM0Ce5v7yKMieuOeoMju?= =?us-ascii?Q?3X6KMTR32DfmPYd6y60I98i6TbuIyVeppQiYKnpBBMB/NLrerj9+2FaGwAHh?= =?us-ascii?Q?uUNnuMcL31A2T69Gq2yHCn8fPElqdUKgs6qZfJVPQMzP3pcrLAWinO20Bpuf?= =?us-ascii?Q?kRzwLWfEQhvxfc6GLE9XVcsu2QNywJQEhqUmEuKZGDpdmhiHRmTMi4CIeWej?= =?us-ascii?Q?Gh9fGSPr29zUaXMTO/tUr9yqjllGB8UzyctqydGWK1wDuhpXI5hz9ElVZ23U?= =?us-ascii?Q?YfYQRYQAPUrWfnDNm2/ovlV2kB1+m5BGtx4Pgtkf0VwU00hlpWORp7OQFe7g?= =?us-ascii?Q?oeeej96avY+4dQREru/vA0DFtGsyO8AdGV/8efhfUn80HG4RTrQGvEppHLOX?= =?us-ascii?Q?xJj1KD7ZpMkSipxlRsA42Hi/Sh3TEQxDHPwETQ6r5lL1rbvx1e5ngCSbDoYG?= =?us-ascii?Q?nsfyJnq53k3fyxcrOI9gELRtwhA9uwoW5XZNgD+nJK7ghZMRn2Zkfdkxpqku?= =?us-ascii?Q?mqycvgrXdw2zF0H+7RZlHzlkIxeMCQaJElocuw8ZFUjKnaQoibwHDIF1otAT?= =?us-ascii?Q?nren+cb9BvWhqk8zRWJ8CroMI+qa1mTEN9G4Xx31lgglvT2dsffwtKAPxuKS?= =?us-ascii?Q?if4GCZaE3vn7nnJP3rV311k+/49LM4PBEnclP+P+0rf0zYQcFdytUURf+Jn/?= =?us-ascii?Q?4aPv1dVvTh6+CXh95/6+AoBmPcjBUGMnvgDP8qPMJ9dyHcaVi5BMCQB0Bbd7?= =?us-ascii?Q?ptgRF/BmPiBzqIVhzJHlrVodZKRHXpARxFv8m1W8m57VVRgYS9aTd4334YHD?= =?us-ascii?Q?YpAx4bmzyjD3e+njUuFyl4DSrY75P9kE102ulEQ3dSwcd97UBETltK4lUNE9?= =?us-ascii?Q?1eryR1CvXPXPxaxc9VL11KP1/glii7ltuKI/5lxSEAXVKX3PPYH7nwoD2lcg?= =?us-ascii?Q?2J1Y3S+2fFq3+LWaQaEa7RaXbjn0Qj0xVltVBk+oNvLw3U7t9zh+6ASLCEKG?= =?us-ascii?Q?HYR11OAZoCX1AaGP+5KGdJrbqp41s0buDR+mJJJGfpQlm7pL5ATSwVNEZ2bM?= =?us-ascii?Q?kWxykyq6vDjCG/kbg/T8BSVhQQIB4+/OrkKetav/JXto5pM0sA73RLyINxX3?= =?us-ascii?Q?0K0ZCvdi7MZFXm31VToTc1bF8gnLyJAlZGwuNMr4KsZp7SdG6rTQKDEBksjW?= =?us-ascii?Q?Gqt1X6TgrLcyrPWmTd9auQDa/eDwPUD0j1nBduAT+ZUyNeYZ9vM4sB+kWFnX?= =?us-ascii?Q?i8lnGtdQ68PKYm0IQvI1t7JSS0kg7qM2wK5pl5RPsT0l682CuaRsqVd3sgc0?= =?us-ascii?Q?LHkcrXbCJ3MwDPx7EMXXQtKKjaNQWP+pVWO4V11l4wcP/GQXu0Q4MO4izmZ6?= =?us-ascii?Q?nUW6U6zuvXpw0X6Y8EudcYv9w5DzXavJBiVVdvmsDCENRi35mER8UL96oIce?= =?us-ascii?Q?cGTwgK6WJtQTu3tBswRcaxYOuQXHEeAkC5E6646P?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0932ce9-17f7-4f0d-6762-08dbfc4a1fce X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2023 02:12:29.4006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qY6w9maG8tdo76ET4RY2JcWW6AGV1qpJRT8YaPvL21+hDqZ4y3CdWx8ch6j9MUDXcTdSXejJG6jM2uVZbm4fnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6298 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kaiwen Deng > Sent: Friday, November 24, 2023 3:01 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Zhang, > Yuying ; Xing, Beilei ; Wu= , > Jingjing > Subject: [PATCH] net/i40e: remove redundant judgment in fdir parse >=20 > if (eth_spec && eth_mask && > next_type =3D=3D RTE_FLOW_ITEM_TYPE_END) { > ... > if (next_type =3D=3D RTE_FLOW_ITEM_TYPE_VLAN || ...) { > ... > } > ... > } >=20 > Clearly, that condition in the inner "if" is always "false". >=20 > This commit will remove the redundant judgment. >=20 > Fixes: 7d83c152a207 ("net/i40e: parse flow director filter") > Cc: stable@dpdk.org >=20 > Signed-off-by: Kaiwen Deng Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi