From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhou, YidingX" <yidingx.zhou@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Zhou, YidingX" <yidingx.zhou@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v3] net/iavf: fix error of virtchnl command
Date: Sun, 9 Oct 2022 06:03:31 +0000 [thread overview]
Message-ID: <DM4PR11MB5994E950FCBC6E812BA67178D7219@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221008084852.397649-1-yidingx.zhou@intel.com>
> -----Original Message-----
> From: Yiding Zhou <yidingx.zhou@intel.com>
> Sent: Saturday, October 8, 2022 4:49 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Zhou, YidingX <yidingx.zhou@intel.com>;
> stable@dpdk.org
> Subject: [PATCH v3] net/iavf: fix error of virtchnl command
...
> When the device is bonded, bond pmd will register callback for LSC event.
> This callback will execute some virtchnl commands in eal-intr-thread to
> reinitialize the device with interrupts disabled. In this case, responses to all
> commands not be received.
>
> This commit starts a thread to handle all events to fix this issue.
>
> Fixes: 48de41ca11f0 ("net/avf: enable link status update")
> CC: stable@dpdk.org
>
> Signed-off-by: Yiding Zhou <yidingx.zhou@intel.com>
> ---
> +
> static uint32_t
> iavf_convert_link_speed(enum virtchnl_link_speed virt_link_speed) { @@ -
> 293,7 +427,7 @@ iavf_handle_pf_event_msg(struct rte_eth_dev *dev,
> uint8_t *msg,
> vf->link_speed = iavf_convert_link_speed(speed);
> }
> iavf_dev_link_update(dev, 0);
> - rte_eth_dev_callback_process(dev,
> RTE_ETH_EVENT_INTR_LSC, NULL);
> + iavf_dev_event_post(dev, RTE_ETH_EVENT_INTR_LSC, NULL);
If we decide to raise an etherdev event from a separate thread, is it better to do this for all events ?
next prev parent reply other threads:[~2022-10-09 6:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 6:06 [PATCH] " Yiding Zhou
2022-09-19 7:53 ` [PATCH v2] " Yiding Zhou
2022-10-08 8:48 ` [PATCH v3] " Yiding Zhou
2022-10-09 6:03 ` Zhang, Qi Z [this message]
2022-10-10 2:02 ` Zhou, YidingX
2022-10-13 6:20 ` [PATCH v4] " Yiding Zhou
2022-10-18 13:18 ` Zhang, Qi Z
2022-10-13 6:21 ` [PATCH] net/ice/base: fix duplicate flow rules Yiding Zhou
2022-10-19 12:19 ` Xu, Ke1
2022-11-09 0:40 ` Zhang, Qi Z
2022-11-08 6:37 ` Zhou, YidingX
2022-10-20 5:00 ` [PATCH v5] net/iavf: add thread for event callbacks Yiding Zhou
2022-10-20 5:40 ` Zhang, Qi Z
2022-10-28 21:45 ` Thomas Monjalon
2022-10-08 8:11 [PATCH v3] net/iavf: fix error of virtchnl command Yiding Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5994E950FCBC6E812BA67178D7219@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).