From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A959A00C4; Mon, 30 May 2022 01:25:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F9CB40A89; Mon, 30 May 2022 01:25:32 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 6A02040A82 for ; Mon, 30 May 2022 01:25:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653866729; x=1685402729; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7V1D3/QotYaVFgR5+RYneQ9ovaa6ddaKQ/192qcfB+U=; b=TO8hOHWlp9oJWgoMvwtunww8VT7Jq3MJaauzWkwr9E7J1nby/mtGsL/r +gBFXL6ENo2VCjPla7uUM7vEQXo348+PJo3HXEL6Xixx2w0f5wlLogulB KZvJy5/5joshq5j9XCF1lm6b2Y7elrxj2793HwgIP34qltfZcyLQv58cL gTRH59NauAl6Fwu00ttuf7xR+wuRWEjPhBru/3o+auMiqltWjy6CR5q0+ zAxB8MmQkn+50Q5Xv8f2pmHTlH8WcW5TNSo2hY7zsVj3tbi8GWTso7A6j m4LnUrHnKmwk5Dck62xUDcatdPnb+U+2n5FjqOOhq7iUw65vRUCckppxU Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10362"; a="361230183" X-IronPort-AV: E=Sophos;i="5.91,261,1647327600"; d="scan'208";a="361230183" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2022 16:25:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,261,1647327600"; d="scan'208";a="678896379" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga002.fm.intel.com with ESMTP; 29 May 2022 16:25:27 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 29 May 2022 16:25:26 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 29 May 2022 16:25:26 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 29 May 2022 16:25:26 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 29 May 2022 16:25:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F/X+rDhOt5Q2IzVviVl2PW5cjVE5WAtwmpx9WdEoZgRONWOOY0bmxAaKqgBkRmTeniO7uinfluGe6cBIj2RvjV+2mnNbWS8UjuMVDOXhJIzD5nz2F8jdYWIWb8MLi5TmWrDNVCAe7gG3x85MJkYb0Pe7DjYdbUDYfKpj6gX8PYqKDxaKHjvn/tQQA3ual5Ji4n32We5C9fRWcIhutRUwqQOkVaFDKiwhnKYd7fEmXNsOjWstMzjAohzMoqdo7ZPwji3uhErUXPwyCbrpIB1TE5AgEiJw8d9TphO4gA9jnafvbwYya2LqkExlV3RZhF44V3G9J5+EI0K5jNcy1q5GAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gM8SeHWYwELbKFFm8K6Yne5B7gXpP+GENer5RzVy12Q=; b=Y0akrNGQU60jNsKX149hINaVAbOpnA9T3JTwj/bPk4lS54q6AqPI3lJvk0P01DkHs/W9CM67Nnm2xDrTNy6UETrg+1vh+XVuDbsyJMC9O9WwnAO27mTxq2qrh2tSwp2lab9FUxrZfby/nM2WMwdKEx1ovG9ewbNVtdTlXRFRNT3S4ZpJ2lLMTojsjlaFZVwmcQq0UC6uO78Q/QhjWfXdxa0KodHz/uSSjMWbSEgoDokw79syofC0ulAvj9wf7ocaX0gczN/qMJSQASQZKkI0xexkyGQyVCmBgRblCZKc9j+0e3NwKNJNzj9MvUCYd30f5SPOBX1JPGeR1J0TtLoPLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by BN8PR11MB3844.namprd11.prod.outlook.com (2603:10b6:408:91::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.15; Sun, 29 May 2022 23:25:24 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7%8]) with mapi id 15.20.5293.013; Sun, 29 May 2022 23:25:24 +0000 From: "Zhang, Qi Z" To: "Daly, Jeff" , "dev@dpdk.org" , "Yang, Qiming" , "Wu, Wenjun1" CC: Stephen Douthit Subject: RE: [PATCH 1/3] ixgbe: make link update thread periodic Thread-Topic: [PATCH 1/3] ixgbe: make link update thread periodic Thread-Index: AQHYa6umFAbG/VkoREKpkVbghxlZ7q02ibJQ Date: Sun, 29 May 2022 23:25:24 +0000 Message-ID: References: <20220519180248.23831-1-jeffd@silicom-usa.com> <20220519180248.23831-2-jeffd@silicom-usa.com> In-Reply-To: <20220519180248.23831-2-jeffd@silicom-usa.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 375c2b0f-3448-4053-9b9d-08da41ca81d2 x-ms-traffictypediagnostic: BN8PR11MB3844:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Lry5kjJltGjrejwclQh50V25ndvhf05+kUpYNsOgj7PnROzjvqjwEg4QSBN1Mk2QHKYx/ysT9X5/sdn++w/HZs2vhg3Y/AhQASFdJlz1oDE+ThjlsyUMB9uHL469/Fa4cjNm6sERIim3aqw0IXw/QxD7vGKgk91HDJy2VUn2z4qe7ijVG4sjBLpOmcfV/Qk6AZlVk+2FVUZgMTKcwVzesFhMYGklA+tkotxenr506O/b2ORjyhqVumkBMkd73WkEjMUp2PO8qTxXNPLQnpyAPkOdM008ES+l6kAfbqJdG/ptZaJqTtowvqCgM+2nsQAK5nCY+/yYIJbrzNMpqRsJFXbHdFMKtNiL8bVXQav1zXtzeaoGaljy0nSmmb1MEbzusKxbaOFVNdrb9KPLO5Tj9WInriu2RCUiRqa+n0bIdc9mgo8ZaxIi/2m/ZxLjTqm1svhpE3NKVOiXI7W4GGJ7+2J3SbdzjVfa3GUvHk5iQqXwRvfiuzZ+nJ0aocH6b5boEuBd0DGnUXCyeFOkqwUjNa0h7RcXs1ttxG0T8m7WscNtPiHWbaV6zeEXQOI6IqwWO4tNihTkyWLGdwutc5B085chwDrmZHj2vcGAYM6aDS3Pr5nk5CXB6GBuP596Jrl30gqD/roq9f0odTKAzwgqsjN2Tm9WJ6CPusAmlmj7M3p/dHyFk4eoYH0iuiVsSM96GM2UbsCBB/8ldzz+HjLHGQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(64756008)(83380400001)(66446008)(66476007)(71200400001)(110136005)(52536014)(66946007)(55016003)(66556008)(82960400001)(2906002)(186003)(8936002)(38100700002)(4326008)(9686003)(8676002)(26005)(6506007)(86362001)(7696005)(53546011)(38070700005)(508600001)(6636002)(15650500001)(316002)(5660300002)(33656002)(76116006)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?h8f4F/WlGD3CNSsfYUH5wIxcxEE9Uv8w3zXLfUi8MaWG1CSqmbhWoxS+rpeZ?= =?us-ascii?Q?RazPq4aaWkLwHyPb8lQB/nyyYRyfWR00RElmmf6HIrVjvPJoUyuQLG6rVHcX?= =?us-ascii?Q?rI1A1/SKlfbvEFifYiFbzHk1MKgEDH6NhSkbpOCYpmRbFIflH05wO2RQg1cd?= =?us-ascii?Q?Y2lDGZW5K4RdsvBqLNkMnkV/vuf82//8arFEv34V1pZ2+GSrCxFrInbXf1fv?= =?us-ascii?Q?DzH9VDE562HbvmLOdx2ZnuzImUXnp1Kv1LizEx/AzvjcfitZ5n5zXlGY0O+/?= =?us-ascii?Q?oV8+ycNH8ycDQ4crGvE4qwbXkq0+DxQeKdO2MOVYcKe65QJEMANPAcEwdfCK?= =?us-ascii?Q?5US37cHUB0IIryL1Vz5rnKuiUBHGAzWvToRKkrImsYkdn9CmedPNy27S7WC9?= =?us-ascii?Q?wIGahMvDhIxvH9C6Gt228/AY93N8P1LwKc4likK1I9jWONHJxIInG7NiO92m?= =?us-ascii?Q?suKq3msuacS79o5ejuK3tKvZ7fWaAaylDSda1zqhH7qS3g7sKWKQZi8NVcav?= =?us-ascii?Q?g9tDjKjIsk1D/KBIwscGD/HbuxnGsoiCzWR92gpxhEvDd9e7pc8BKCh+g8bG?= =?us-ascii?Q?Cffz2M5Y1lHsUsdtsRSmb/FD/EaqQ6mMlK05vTCK3g+KI2YTCzZ62Z5RsBDX?= =?us-ascii?Q?L+KGA1dpsYrLClv0y+4tCw60UvPuSJ2GwiR2myGG5fW4fj7b+agXyO68luJ7?= =?us-ascii?Q?5C8wS7OeOBKaRGm9PjERZ1maRLk5zVekQLIf+sr+mZ1khLCSCUT6p37WJFkd?= =?us-ascii?Q?EyJH+uxkIEpepbQUBSUmaxtUrQxCD1g+zBjhYxO1Jrd0RiXrTcGRtndxxu8E?= =?us-ascii?Q?+xnLxOX3b2NjZ+vflkckWD55Sdotko98e7u9aJ2ufpnKBfLdv4FQjqCwGcYB?= =?us-ascii?Q?aZ8w1LtB867YkCFEXYrh41ZNfuPb86dv/2SE+4e2AAkiTFnEllNSjqypTUx3?= =?us-ascii?Q?BQAz+chPhwrY8srG6+E54g7WonKdCfN4eeCYLyIC41QX5ZN1xi/NCEd7WTtM?= =?us-ascii?Q?dwe0wRrWQMnoHWAdTZeWDDNFy897stiad5Zdf+VC5UGG6DdMwwlJx0lqc59d?= =?us-ascii?Q?hfOEZz6bpqSaDk66+Usx51D4ELoIm5WRT+fXeZYYWPucCRBCNlR6kvbexcx4?= =?us-ascii?Q?MHjOoSoOZhixznNfF+i6zd5t/u8eLK3aOWOFDxJiQ1edNIuEhQ/7qX+0hGby?= =?us-ascii?Q?9XhdGOiXdOz4rWwhtWrfbm+o4MpEOzWPqE0jCy2p3qrOT5+CVJ1Uo+k9orrc?= =?us-ascii?Q?12d6yNVGVYPDknGlNNlNyzRONrZHIOrsB2V0/5Xi+FhhShiAyO3AE8cNH60r?= =?us-ascii?Q?bfKCUDgQLUVn373GXy98Y9Gn3jrMD3Uz9UtIUHPSWjOS9lEqiopB5qEuaq1m?= =?us-ascii?Q?gY907r0eYTEylAoHeA2FPoxTtpHBjU59d+r7+tuaWNNDcRRI9Ay+xqX8/4EB?= =?us-ascii?Q?jRMZGV5NguwXF4IxgVWBEQeurviP95AECsEElwAwO6/r4feLFd3Egs98j8Fc?= =?us-ascii?Q?Khpp+ZR1g9qNZotPjJtjzc1p6QgJHQqdnC1UK+SkvNbT2znjeljmtkEkrQJB?= =?us-ascii?Q?0IqgFGcFZWU0dryJUB/2oD25N6IfMwU11hR+ssgAJTHim11MSC/kgcnLAdiM?= =?us-ascii?Q?eoA12nEOlF0sLKVwJ+Zzne6+jkr4OHhEhN15OR8wgFnbBpVr9XeFUTlCiRHd?= =?us-ascii?Q?RPHaBsQzGll5kbOftBRuz4kte2GIe7sBQ4vgrvDLEBr35Q2JOvx72feFoEFT?= =?us-ascii?Q?irOKUbpdaQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 375c2b0f-3448-4053-9b9d-08da41ca81d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2022 23:25:24.3452 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: py34q8JSLVQE2mSI51QVovrPNHMuf4XXlzRzAqa0O1qs9BN0HvG3afLMUbScjmfUu4hH80O/mqz5fOTBwG6zrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3844 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Jeff Daly > Sent: Friday, May 20, 2022 2:03 AM > To: dev@dpdk.org; Yang, Qiming ; Wu, Wenjun1 > > Cc: Stephen Douthit > Subject: [PATCH 1/3] ixgbe: make link update thread periodic >=20 > Rather than run-to-completion, allow the link update thread to be periodi= c. > This will set the stage for properly handling hot-plugging. Could you explain more about what's the hot-plugging issue with run-to-comp= letion you try to fix? >=20 > Signed-off-by: Jeff Daly > Inspired-by: Stephen Douthit > --- > drivers/net/ixgbe/base/ixgbe_common.c | 4 +- > drivers/net/ixgbe/ixgbe_ethdev.c | 180 ++++++++++---------------- > 2 files changed, 71 insertions(+), 113 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/base/ixgbe_common.c > b/drivers/net/ixgbe/base/ixgbe_common.c > index aa843bd5c4a5..712062306491 100644 > --- a/drivers/net/ixgbe/base/ixgbe_common.c > +++ b/drivers/net/ixgbe/base/ixgbe_common.c > @@ -4154,8 +4154,8 @@ s32 ixgbe_check_mac_link_generic(struct > ixgbe_hw *hw, ixgbe_link_speed *speed, > break; > case ixgbe_mac_X550EM_x: > case ixgbe_mac_X550EM_a: > - sfp_cage_full =3D IXGBE_READ_REG(hw, IXGBE_ESDP) > & > - IXGBE_ESDP_SDP0; > + sfp_cage_full =3D !(IXGBE_READ_REG(hw, IXGBE_ESDP) > & > + IXGBE_ESDP_SDP0); > break; > default: > /* sanity check - No SFP+ devices here */ diff --git Looks like you change the behavior of link status check for x550. I'm not an ixgbe expert, but I know this is not kernel driver's implementat= ion.=20 So do you think this is a fix for both DPDK and kernel driver? if it is, p= lease move this change into a separate patch and we need to reach the righ= t expert to approve this.