From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhang, Peng1X" <peng1x.zhang@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v3] net/ice: fix DCF state checking mechanism
Date: Sat, 21 May 2022 02:17:04 +0000 [thread overview]
Message-ID: <DM4PR11MB5994EB6B5FBF85C6953A7CB8D7D29@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220520183112.26546-1-peng1x.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Peng1X <peng1x.zhang@intel.com>
> Sent: Saturday, May 21, 2022 2:31 AM
> To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; dev@dpdk.org
> Cc: Zhang, Peng1X <peng1x.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH v3] net/ice: fix DCF state checking mechanism
>
> From: Peng Zhang <peng1x.zhang@intel.com>
>
> DCF state previously checking mechanism cannot detect DCF state correctly in
> given situation,so PMD will report incorrect error code and mislead user. In this
> patch, DCF state checking mechanism is fixed through create or delete rule
> successfully or not. Then error code will be set as EAGAIN in given situation,
> while not EINVAL.
We should not assume the error code is always EAGAIN if any rule is rejected by the kernel PF driver, this will also mislead the application.
We need the kernel driver to return a clear error code, then DCF pass them to the application.
next prev parent reply other threads:[~2022-05-21 2:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 15:49 [PATCH v2] " peng1x.zhang
2022-05-13 9:56 ` Connolly, Padraig J
2022-05-17 7:35 ` Zhang, Qi Z
2022-05-18 6:36 ` Zhang, Peng1X
2022-05-18 6:45 ` Zhang, Qi Z
2022-05-19 6:05 ` Zhang, Peng1X
2022-05-20 18:31 ` [PATCH v3] " peng1x.zhang
2022-05-21 2:17 ` Zhang, Qi Z [this message]
2022-05-31 17:48 ` [PATCH v4] net/ice: retry sending adminQ command after failure peng1x.zhang
2022-05-31 11:51 ` Zhang, Qi Z
2022-06-01 1:48 ` Zhang, Peng1X
2022-06-01 1:53 ` Zhang, Qi Z
2022-06-01 2:46 ` Zhang, Peng1X
2022-06-01 3:22 ` Zhang, Qi Z
2022-06-01 5:35 ` Zhang, Peng1X
2022-06-08 10:21 ` [PATCH v5] net/ice: add retry mechanism for DCF " peng1x.zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5994EB6B5FBF85C6953A7CB8D7D29@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=peng1x.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).