From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13802A0093; Sat, 21 May 2022 04:17:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ACE7E40222; Sat, 21 May 2022 04:17:15 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 61A0C40156; Sat, 21 May 2022 04:17:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653099433; x=1684635433; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jX6vXFt+ARKSImjvhpH+zdVyzC5vPZw4WeKJkN3ZI6c=; b=ICXYUq0dTYfpI+B/+BnleldWRFsEm70eGYLYZdtcJSJvBEE0Vl+Lhbgh rqcOttRiePcwJ2DRgJikV3+tWYApvChpcaZJ0fuNK+WuF9C6+SLamjf/w VJ1NZpI7DVHmd7KEo8a3emRfSDAtjuvBDjq3Nn7oTEKrp1P15qwCDPQHf +6ctrMmpy323EWbUli6CLONnbPwnZEq44/VQbFeMq95ZfAqbG1whHGPWN PX8+TINbeN2B2mY8cmCneGEEBs3bTzO2kUMdYie1qC1YUoxd02c/xFTYz GQhau13b3q34MeokpYpCYK2+PEu9B7yhaGlT/EaKManMlP6q32NEsAlSj Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10353"; a="298105076" X-IronPort-AV: E=Sophos;i="5.91,240,1647327600"; d="scan'208";a="298105076" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 19:17:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,240,1647327600"; d="scan'208";a="640580055" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga004.fm.intel.com with ESMTP; 20 May 2022 19:17:12 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 20 May 2022 19:17:11 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 20 May 2022 19:17:11 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 20 May 2022 19:17:11 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 20 May 2022 19:17:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UYmU7jLo2RH9W8vdW35M9kTZDNWw5OHykKxpxorKL6m1Gr0lSFS4QrEETd67n9H6kZjVXf+0t3I9du0km1x83Bu+xyVlh0S89T4Vi9HD/JwEp2hWZ6a6l6yp5GI46aFcRgxCo2IYIkBKpaD2kwhTwHTPy9/ZsO05Q96ee/98hX9TIMlPT19DCV8ayWMoN/iB99C856MCJ/W4e1EghSQsJXGoit7gMxc98IDt1OutV2DTjuNMuC4ok7NaBIkvV18hnPxXpUtfM12WKfdE8DOMmW+xbacmrRCnBoL0XiJ1nLzGHSe74FQXso/J0F6wu2bJv8D8GG/BzkH2ok/obJxn+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jX6vXFt+ARKSImjvhpH+zdVyzC5vPZw4WeKJkN3ZI6c=; b=aQgQdBCmEv7ipX4rPNg+2dHg1lrKzUMZqDmn4cfS8HjYBVC/BQSK6lLDPtpOuiTZ0UcE0bwH8xDhmCRxH9zcY0uAg/owF7y1G6+xoyDuv6Jvl+pcE1WdN+ddQd/zQ9RfygxqYG7hDcxPWixPDxtsGBYGSA3YJfuPD1pHeY+Yt1jNr8wuBW+1VP49JlzSKSS2cWLp5CeYCGqOpsL6WMaOyiY9nUo3A4eMFF2ErELP8ghvQcTjHl/CZtGAgYcU3Td1Vbbcgf2REoe6IEhuYd9TTq8AImV/M/X4bZ9tpkb0ZPDJigwJaKVteyw3vklhyF3LTNloGCwzvUzqI5NoUIcj4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DM4PR11MB6384.namprd11.prod.outlook.com (2603:10b6:8:8a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Sat, 21 May 2022 02:17:04 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7%7]) with mapi id 15.20.5273.014; Sat, 21 May 2022 02:17:04 +0000 From: "Zhang, Qi Z" To: "Zhang, Peng1X" , "Yang, Qiming" , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: RE: [PATCH v3] net/ice: fix DCF state checking mechanism Thread-Topic: [PATCH v3] net/ice: fix DCF state checking mechanism Thread-Index: AQHYbDWqrElK6diVqkqYeYOBRA4hnK0omG2Q Date: Sat, 21 May 2022 02:17:04 +0000 Message-ID: References: <20220511154930.509436-1-peng1x.zhang@intel.com> <20220520183112.26546-1-peng1x.zhang@intel.com> In-Reply-To: <20220520183112.26546-1-peng1x.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1fd2ab6f-2e87-4870-64b7-08da3acfff6c x-ms-traffictypediagnostic: DM4PR11MB6384:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iK4dGDsGkfpITYqmE0Q6j6TFIguZgXUx60RE2dJqjql/crbC2Pyouk4ohVi6t5l9aX1dWPsevHfqRyA7N5D4Ic3cGfeH/w2YZbInQefcYySC7C6aZuJtMhAhvUei7lKZBO3YtUAHHF94IW1rRwo4PBECvKMt/Go7tZcENBKPT6IrQKD+MZP0jbDMB/HW0GM+DJE/GG0ZZgIupTs5KcwEfarn9iLhU1VxGmcGxmDSGSiPOYnsqImytC1MeYbaH7q3QVHrMiZMyUASQg7vz9uyej3efug+nv7cMo7ROukbeoqEqwMg64YsCmRRwFWaPskrcMrILpcEgqq1kYz4MSxBsXXmbXxktQmtExhsJriCWqWewOyL86F0ae49nDwxYlWfGwd9TLo9Z3q7Lt17QqdGDdhxHsKjOeQhwbIyIiJ4LrJ0zwtDxFszsIBqMCd0ABT2ae3WMQMzEMBKB+y/ohNwIx6thPT5+euGF6VwTRj9wsy0lapUAPVS/i+Lzv4M/ajE0uZWPq/pn7PtqR/jf+vTinBccsT/d3eT/Fs8FNcIKXKkwKHjTie6HqIX18mhYTUc2X5K42QFMzTTe0bd1PEWTCTLBhu7lOXdX1h0Q8Ct6pE7tNmNl6Z00Cikvo+sPJUmYq7a1KMpwkSqF2p7SkBtxZfGyl7lzQbU/FlGUPrECNAYekiPx5w0Cm49MmQsBAzqvBtXbdcEXUu9pUOviB9Pyw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(33656002)(4744005)(52536014)(64756008)(66446008)(76116006)(4326008)(122000001)(8676002)(38100700002)(8936002)(450100002)(5660300002)(110136005)(66476007)(66556008)(66946007)(316002)(26005)(55016003)(7696005)(9686003)(508600001)(82960400001)(6506007)(186003)(83380400001)(86362001)(2906002)(71200400001)(53546011)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Klm8luz8Zx3q2l2AGaejeck5J9mFaUoX5t6yqYIIY/qZl9oA4m10HJRXdko+?= =?us-ascii?Q?9y/22u24BnLG4XHyWZ9/4L6s/aoCZCl7YhFZeKO2vdDHZD4P8Vuyg59sMyMV?= =?us-ascii?Q?9AzzXTVXjq5mR3AwK9XjldWRYmLYQj7hV4uHmTjDH2FUb48UI9VPAN/pXvQu?= =?us-ascii?Q?+0xQxY66Dj7pIIaww94WOKX8ke7jPsTGO6y49XBeOvNsEva/lXPRHu+DSGLJ?= =?us-ascii?Q?H61KdhMDcg6vY3Dg+qVkyIvj+OjgBzzZ3TtKPR6d036I+cx3BAApxhFB5GBs?= =?us-ascii?Q?Ks2DaTdQixGJa/l6rlnTOINVAi6kaTv+yVonfkC9Gvp+N74GnwHRCLhCPh8A?= =?us-ascii?Q?ITaw7M6aeN7JnoUF4CUAYkYJAWmsE36nUKUv8zT9CBWSkrVm+wD15yIZslKQ?= =?us-ascii?Q?vCNyQMaz1uR9h1dRWDjFD2MyFuxbdYNXj0QXzzVKrkuSEK5THBv6n8A0e4+T?= =?us-ascii?Q?cx0KO4wDLMiCCJ15SMYmkOFGpI31O2yHp+qfueXShIrNbfeTZWASDdAie9Fu?= =?us-ascii?Q?nU72jEVPu7R0yhnE3YIrw9R8jJp8U/xQ9eBRwGT6SXZIh+eJuf+I7jVUNZC6?= =?us-ascii?Q?jsSAnUN8V8TH8mzRKM59AhO5APnJK7X6mMa9vwqaqZxu9HaliotJDZbz0CqM?= =?us-ascii?Q?bOdWKWJvnVS9IOpu6G/1FrRhw8TXD6cQ0mqXK1WZYynJZcfOXhuKMtbEeBKO?= =?us-ascii?Q?M7uwBrngSl+MT8avo8PIhjWQCX+zVkDiFLpOwPv5iuYr7D1L88uTHVsvT5W1?= =?us-ascii?Q?NSZWKRQlF+Rf2Y+OhV8v3Y94NwAzk0xO8rdAtqhOL6AJxAQrB6SwCmhZpenV?= =?us-ascii?Q?Y5VohG9Qy/Xub6xOamRHM4BeHFytJEVzOiaoaMc8Ro67WXUqFdul9Ffo7OOa?= =?us-ascii?Q?u90KNcinH2fJvQ6QE4Z/5BrriYSZ9HvKuOh4wOlbHwx0t1yccLrp6GeCcTjT?= =?us-ascii?Q?qwooKBhaY2ZlsV3DzOkAemSlWa6t9ApYT5Sp5uiuVulznXJe4s7iofdm46IC?= =?us-ascii?Q?M2o/PH4fs6lrKi49Ar6G0B3p3E1cP48YifKBuA1ZumUgTzmzT2VoTQXqA7Ua?= =?us-ascii?Q?hOn+8HNGnnqJynU00yCTTulxWyWBkSMxMRoSEStKd2KUvwrGIedUkiDDVXn4?= =?us-ascii?Q?3ZrMgYHyOZ3RBaJahlSFi+UofcxChTk7r1Cq3EDpP6CLpAAD2v16hLvmYjXR?= =?us-ascii?Q?kFLZK7RwMibz/sBZRDxbpkjRXy1xNvCNJrWebd5N9DJSRi3A1+1onCgeV4ei?= =?us-ascii?Q?tSu4A+0bsH9Gnd+yXT07DagMWX3Z1n7OvxyCy84goSsH5OcHfdc+riYdC8WE?= =?us-ascii?Q?MVOFwvr+ckmuRunMX+a9hfqnTg7iC01C3EAR9i1AmPug0/4PVoJ3bSwR9RYc?= =?us-ascii?Q?9MdcprF0DR9vcnpm/5qXFaKOqz68t9Lrn/WM7rK2YWObCLq0R4ewCcBBy+8p?= =?us-ascii?Q?gBSeja+fkEGOAuFTUT7HD09DJteHgIlr+5PEhkXUjboKJW4QRjyMgg2P6zqS?= =?us-ascii?Q?9DnXpCqkWqx6/h5kmEKm/6pHFUvqwK7zxMZeqHwQu1gn3yaLrE67D7TshFKj?= =?us-ascii?Q?SxzcBDuhG23me5t+mKEVZCkQRnRLRbv7egwKhVIAymu1NXpW0U90/8xji7Xk?= =?us-ascii?Q?2nD84jYJxmarts6BiIUY6DuoAw50ct08pMfBn4RRYnJJX5bCS7X7Mv7PYsUb?= =?us-ascii?Q?F/icz2WjJMURv7iVIHfSdXPZa17QayQpE0Ty41aIsOl30ncMtCIFRhdvxT6L?= =?us-ascii?Q?paONztL01w=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fd2ab6f-2e87-4870-64b7-08da3acfff6c X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2022 02:17:04.4125 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YtBi/dlQqk/zLYIcSJQ8n5sYhZu8EMXXPFHp4ti9wgQGYxFPaVzBeDe+yPT5OGK6F/7FVjRI7UwA5qX/swKiPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6384 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Peng1X > Sent: Saturday, May 21, 2022 2:31 AM > To: Yang, Qiming ; Zhang, Qi Z > ; dev@dpdk.org > Cc: Zhang, Peng1X ; stable@dpdk.org > Subject: [PATCH v3] net/ice: fix DCF state checking mechanism >=20 > From: Peng Zhang >=20 > DCF state previously checking mechanism cannot detect DCF state correctly= in > given situation,so PMD will report incorrect error code and mislead user.= In this > patch, DCF state checking mechanism is fixed through create or delete rul= e > successfully or not. Then error code will be set as EAGAIN in given situa= tion, > while not EINVAL. We should not assume the error code is always EAGAIN if any rule is rejecte= d by the kernel PF driver, this will also mislead the application. We need the kernel driver to return a clear error code, then DCF pass them = to the application.