RE: [PATCH v3] net/ice: add devargs for disabling default mac

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Zhang, Ke1X <ke1x.zhang@intel.com>
> Sent: Thursday, January 12, 2023 3:56 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhang, Yuying
> <yuying.zhang@intel.com>; dev@dpdk.org
> Cc: Zhang, Ke1X <ke1x.zhang@intel.com>
> Subject: [PATCH v3] net/ice: add devargs for disabling default mac
> 
> From: "ke1x.zhang" <ke1x.zhang@intel.com>
> 
> Add the feature that support to disable default mac which will be used by ice
> driver when setting dpdk_devargs config field.
> 
> Default mac is not disabled in default, user can choose to disable the default
> mac by setting ``devargs`` parameter ``default-mac-disable``,
> 
> for example::
>      -a 80:00.0,default-mac-disable=1
> 
> Signed-off-by: ke1x.zhang <ke1x.zhang@intel.com>
> ---
>  doc/guides/nics/ice.rst      | 11 +++++++++++
>  drivers/net/ice/ice_ethdev.c | 21 ++++++++++++++++++---
> drivers/net/ice/ice_ethdev.h |  1 +
>  3 files changed, 30 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index
> ce075e067c..860ed1430d 100644
> --- a/doc/guides/nics/ice.rst
> +++ b/doc/guides/nics/ice.rst
> @@ -105,6 +105,17 @@ Runtime Config Options
> 
>      -a 80:00.0,pipeline-mode-support=1
> 
> +- ``Default Mac Disable`` (default ``0``)
> +
> +  Add the feature that support to disable default mac which will be
> + used by ice driver  when setting dpdk_devargs config field.
> +
> +  Default mac is not disabled in default, user can choose to disable
> + the default mac  by setting ``devargs`` parameter
> + ``default-mac-disable``,  for example::
> +
> +    -a 80:00.0,default-mac-disable=1

At least we need to explain what's the typical usage with this feature in general.