From: Wisam Monther <wisamm@nvidia.com>
To: "Sean Zhang (Networking SW)" <xiazhang@nvidia.com>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Raslan Darawsheh <rasland@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] app/flow-perf: add destination ports parameter
Date: Tue, 12 Oct 2021 08:15:56 +0000 [thread overview]
Message-ID: <DM4PR12MB50397D3F8BB562D0229BF8E0A4B69@DM4PR12MB5039.namprd12.prod.outlook.com> (raw)
In-Reply-To: <DM8PR12MB5398F99D22C4DA2F5A5E312EA2B69@DM8PR12MB5398.namprd12.prod.outlook.com>
> -----Original Message-----
> From: Sean Zhang (Networking SW) <xiazhang@nvidia.com>
> Sent: Tuesday, October 12, 2021 11:14 AM
> To: Wisam Monther <wisamm@nvidia.com>; NBU-Contact-Thomas
> Monjalon <thomas@monjalon.net>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: RE: [PATCH] app/flow-perf: add destination ports parameter
>
> Hi Wisam,
>
> > -----Original Message-----
> > From: Wisam Monther <wisamm@nvidia.com>
> > Sent: Tuesday, October 12, 2021 3:53 PM
> > To: Sean Zhang (Networking SW) <xiazhang@nvidia.com>; NBU-Contact-
> > Thomas Monjalon <thomas@monjalon.net>
> > Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> > Subject: RE: [PATCH] app/flow-perf: add destination ports parameter
> >
> > Hi,
> >
> > > -----Original Message-----
> > > From: Sean Zhang (Networking SW) <xiazhang@nvidia.com>
> > > Sent: Tuesday, October 12, 2021 6:43 AM
> > > To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Wisam
> > Monther
> > > <wisamm@nvidia.com>
> > > Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> > > Subject: [PATCH] app/flow-perf: add destination ports parameter
> > >
> > > Add destination ports(dst-ports) parameter for port-id action, the
> > > parameter is only valid for port-id action. The parameter is not
> > > Must, and the value is 1 by default as before if not provided.
> > >
> > > For example:
> > >
> > > $ dpdk-test-flow-perf -w 08:00.0,representor=[0,1] -- --transfer \
> > > > --ingress --transfer --ether --portmask=0x2 --vxlan-encap \
> > > > --port-id
> > > > --dst-ports=0
> > >
> > > This command means the rule created on representor 0 with port 0 as
> > > destination, since the portmask is 0x2 and dst-ports is 0:
> > >
> > > $ dpdk-test-flow-perf -w 08:00.0,representor=[0,1] \
> > > > -w 08:00.1,representor=[0,1]-- --transfer --ingress --transfer \
> > > > --ether --portmask=0x12 --vxlan-encap --port-id --dst-ports=0,3
> > >
> > > This command means the rules created on both representor 0 of PF 0
> > > and PF 1, the destination port for the first represontor is PF 0,
> > > and the destination port for the other one it PF 1.
> > >
> > > Signed-off-by: Sean Zhang <xiazhang@nvidia.com>
> >
> > Do you think it's applicable to use the same option?
> > I mean, usage:
> > --port-id: means default.
> > --port-id=N,M: use the parsing ports?
>
> Yes, since the argument can be optional, your suggestion is applicable. So do
> you suggest to change to --port-id=N,M?
Yes after 2end look, it make more sense to remove the dependency of two options for same action.
>
> >
> > BRs,
> > Wisam Jaddo
next prev parent reply other threads:[~2021-10-12 8:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 3:42 Sean Zhang
2021-10-12 7:10 ` Wisam Monther
2021-10-12 7:53 ` Wisam Monther
2021-10-12 8:14 ` Sean Zhang (Networking SW)
2021-10-12 8:15 ` Wisam Monther [this message]
2021-10-12 8:22 ` Sean Zhang (Networking SW)
2021-10-13 7:44 ` [dpdk-dev] [V2] " Sean Zhang
2021-10-14 7:53 ` Wisam Monther
2021-10-25 19:40 ` Thomas Monjalon
2021-10-28 3:57 ` [dpdk-dev] [PATCH] " Sean Zhang
2021-10-28 4:01 ` [dpdk-dev] [V3] " Sean Zhang
2021-10-29 5:52 ` Sean Zhang
2021-10-31 8:44 ` Wisam Monther
2021-11-05 9:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB50397D3F8BB562D0229BF8E0A4B69@DM4PR12MB5039.namprd12.prod.outlook.com \
--to=wisamm@nvidia.com \
--cc=dev@dpdk.org \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
--cc=xiazhang@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).