From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A95FBA0C4D; Thu, 17 Jun 2021 13:40:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70D444067A; Thu, 17 Jun 2021 13:40:10 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2085.outbound.protection.outlook.com [40.107.244.85]) by mails.dpdk.org (Postfix) with ESMTP id 0D45540150; Thu, 17 Jun 2021 13:40:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G/OmfSaY/pDO1efEJ/JT2rSfYfVOh4J7uRNwU5bQid7Ji1h3xz53QYpUR+rAwc6sv2canE8eEhyWn1mwvznAvDZL31HgaHaX4AU2jaVelaLaNW3xjaCZrHxdS1Vu/mhf4ueng1qL8Z5vJb3BnLmg3R7cJ5+t4NEsoCZ3LCmIWUskaNfwv5tGOcTNtoWwQXTfPJFCvDkuGx6nPvCd5XQ1p6pd5n/amS2n2feBPndFRxaCFniinM8wsGeBtP4U4fdCg7tnhkptNPZn0pSTSlUyqzvWLUEskTbxD1b9nS9h0ar55T9TW2+muxcZKzWK2dLVMEa2WhDN4aKRgSezvTmqIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1BaqEphLz4soPHc5l2UCOEbVFNJhoxjKa6iaEgnX/sE=; b=Sy0VrQZYYrj2+9HIW+9m34gw+7IP8PXCiR6SAuxmuqIOtNBLEebMKCYQOfNlTsX2wA6JfVQkMFGY7VBmq2kQ20noN02ume6mDrfyher63RU9GpXU0DAXKrw5RkSmGWOkY8M1mu7U8Zvb0LTc7Fp7As+FIwtMGQ6jx5Pjqkc26d+f0sPYkMIa7OOmy6jCKdW2sa/mhVuzahDNPUKbPZIe/j205nhHUtY8o/wOSsV6Mvu686TEJPSy49tDrbwBwZaoggwKseQZMnX+eFWkBaSIognAvZ4AKySUxVYF+WBxFN6W7Y6fT75RGXlP/JCtXH4g64+SfZM7P6EUq4oOOEKcWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1BaqEphLz4soPHc5l2UCOEbVFNJhoxjKa6iaEgnX/sE=; b=JUQY9RNuQ8gr/QMbkTFN7kjzQBBpaKlYPUutrJdcNWRRTYN+sZmx3LxzbkdQmTVYojQF4swh89i6OjjsrDZbiGgrW7+umQ2+XAgbVhjyxsOs6dpP5HCPp42/7CthmfS7BlbOiEGUX3PVFkUe/2cveU9Ev7bgICPD3WU5ru/Wyqi/k278Lvkyk20g8Xt9Jw2dketzY3gU4po2+L88a1hVXHYiTnVZp6eAhudTxofvRlv4PV/3FJYSwYZKQpCq1ir2FIveCj9TsqLUuleyf5OdBJF+OVBmEtJInDnHh+oYSRu5IxTUmBILjOyja5im1Zg6iBW97jV3wvQ8cJtAdWZSuw== Received: from DM4PR12MB5054.namprd12.prod.outlook.com (2603:10b6:5:389::24) by DM8PR12MB5397.namprd12.prod.outlook.com (2603:10b6:8:38::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.18; Thu, 17 Jun 2021 11:40:07 +0000 Received: from DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::ec20:feb5:66f:ad50]) by DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::ec20:feb5:66f:ad50%9]) with mapi id 15.20.4242.021; Thu, 17 Jun 2021 11:40:07 +0000 From: Raslan Darawsheh To: Alexander Kozyrev , "dev@dpdk.org" CC: "stable@dpdk.org" , Slava Ovsiienko , Matan Azrad Thread-Topic: [PATCH] net/mlx5: fix modify field action order for MAC Thread-Index: AQHXYr3p4/WOWvUvSkG/HW7ydv+m7qsYFXxQ Date: Thu, 17 Jun 2021 11:40:07 +0000 Message-ID: References: <20210616144236.2802978-1-akozyrev@nvidia.com> In-Reply-To: <20210616144236.2802978-1-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.229.238] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1abae182-af49-44f4-2bbe-08d93184a83e x-ms-traffictypediagnostic: DM8PR12MB5397: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6zRXk4363qCOw32FKyKKRBiTbdSYVnBHY7SLogjxhiRnYW9GVG8AVhsa1Q1rFk+R5EYTA1d6hrJKypQU3dXf2WpbNVNyC5vRwT+ycL8nAX6w6czfzfQ5eGJixdJA9rFqSu1j/5OrgdmY+JSvf8mf8qqSKfgfdGCr62WA27dedAtBaB5QDwVZ82JotYo+Tpe5eVQ0H5auKiQl+KfvsVy4mFqGiswAb0rQH0AjMVFZj23jewODWqm51NYWxBp+X4MzkyPwk449hTah8xk+JecPLImD07tDAxC2SReZvx9tRuRO+r2UvAx0dOOdvIPUx4fnnXHpkg/RJifo2Lw4sf8tKUucU1glx6RbYDLMdAh7T0lG5hHRQxGDWVq3ZasETypYZZ2nvzEHqOf/M9Df185cLpS+wt2Z2O7Zi1cd6IKQrHZgqtLP/9KDmv3gDyrAeA+Z/nxivjfFp8mD3uHL5GjLck52z8oIdhbbquRGo8qJwZAtZLhkcwexOI1OMuLsqQY9C2FofXfguIAGNgU0Y3yy7xHFpsi/j8rgEITk15trzkwY7SgGY+9SZbcAvxFl7XqubxH7G6LFTe1ymnxid2Sf5NJwHzx0F9Tm3ZrT/7WcyTc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5054.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(136003)(39860400002)(366004)(346002)(33656002)(64756008)(6506007)(66946007)(66556008)(66446008)(66476007)(122000001)(38100700002)(76116006)(5660300002)(8676002)(53546011)(52536014)(54906003)(110136005)(4744005)(7696005)(2906002)(83380400001)(8936002)(55016002)(4326008)(316002)(71200400001)(9686003)(107886003)(26005)(86362001)(450100002)(478600001)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AH1s0IRsPV4kuervmIPKASFEwKpvV2kf9fl/V0YfpFt20fhBb8erW1IHGdKG?= =?us-ascii?Q?qPwouYRJpFWyzlGiFNCkpCts37/pjEQj/Ote8+P4kcrmgO/k8C8vZg/o8Y0D?= =?us-ascii?Q?o1wPIM1x5SSdiev+pgJs2cGS+M0at1fRxotndqXdwHHp2aRfT8V9UAx7gMQt?= =?us-ascii?Q?zZuXQIu8UDCKM+abZExDaYPCSSEGFdIYT7PWt3TVpV86fDU8f9LR3nXb5QCx?= =?us-ascii?Q?HxMIYNkfQBbrej0PGSkDezpOZ4mxXV1zNDDA6xr3hNGgcrvvKRgZxJ+MDFZ1?= =?us-ascii?Q?Xz93iD8IlenHTM2XJtpR35k2c96SXSWeVA0tUzY/7DJPZ1g0eYx8FXISX/Nc?= =?us-ascii?Q?7cDqdoQiTEAZQ1YO4QTwp3N8WkjszkTvZhxFmnSV2hKgaluipsCa2WOZDA9N?= =?us-ascii?Q?/uJn3UP5fq/WBImXXZNBn00pE1LuGQ+fW4k5WWHUQd2+VEgidv3xncFdbYaf?= =?us-ascii?Q?OEuBsVtG1beykmsD4zEHePh+KO1Xg6N3zl6I0hu7qucvn5yjWm3o6SkgijRy?= =?us-ascii?Q?XH6W5lyIJh1Y0H75H45wYk5aCWNVlR7EeMlR+W+p0+y0fSBHL/bwkm/f8Q21?= =?us-ascii?Q?nzNzYAlIWdpl6i7VWwb7+PqY0tq8rhMC4lO89ttYe8jbQVnpjhD/IuuceDQz?= =?us-ascii?Q?Qqgl+Ylw28WzpakJGn2w8CpCs8Y4tu3eiEuD/CA+X3pStFBJoKobDUcLECVV?= =?us-ascii?Q?zS+etyH6ITWij55SLVJnqAyOyqOuExU04NIZ+oG1xlcZex2Hwr21M9J0vxbl?= =?us-ascii?Q?PJRhZyH0emnrZiSiAKHujLUYvkLNi7AtOvIZxpRgyrSvBbHo60asbnvgfGik?= =?us-ascii?Q?P1F49r4Sv9573owUwk577m+6EYL6GoXQD1NM/NXWFH8XaKLZdoWwQt+fuzlF?= =?us-ascii?Q?hAdY4/9L6fGkCI55t3yo8H1vgW/RAgOCArKs1yvBPPwhlpT7l2MRNru/5/vh?= =?us-ascii?Q?pxQqT+TqCgSUjUKQtqN0MfMUC9+LG8x/WSK9hSFM1PGQt/AW4Uupp/dRPlt6?= =?us-ascii?Q?ahZAPBxc0XreAZs8mE44jczN8yLpwO1PFuX9PbzvtPVaFLd6S5M1gLHfStOo?= =?us-ascii?Q?5ah9+vkOR/EI5nqjRtqqSU/3evj+p/H32391hsxQvpr5JnYVWaTO9CV4UMs7?= =?us-ascii?Q?bev0bpua8GGX5D2Uze/1SaolSgEn/lvfRgo0kq60Ur5Kl5IZvSMVtbfuJ3D4?= =?us-ascii?Q?uTNL0VTvoQm6F+oUIuf05ZyNR7TtlENZCPL0lkzvRnbVg7VEMEFpIBhsrTqD?= =?us-ascii?Q?CLyDfHGYsnTVLtpQdlMWxF4E8KyTh97OuYWxiwSq0/H4PaJOpFgeBvCYOXY0?= =?us-ascii?Q?Puwgd3R5iA1bweJlxhsuuIKP?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5054.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1abae182-af49-44f4-2bbe-08d93184a83e X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2021 11:40:07.6770 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AgdU5sltDQnb2/tAR3QDOh44c4f0OEHVsMKGM+xlSydZJD2HUdnPw/IdNT7+dh2ADJQq2o7rFFJAEGCvFLRnKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5397 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix modify field action order for MAC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Alexander Kozyrev > Sent: Wednesday, June 16, 2021 5:43 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: fix modify field action order for MAC >=20 > MAC addresses are split into 2 parts inside Mellanox NIC: > bits 0-15 are separate from bits 16-47. That makes a copy > from another packet field tricky because any other field > is aligned to 32 bits, not 16. This causes unexpected > results when using the MODIFY_FIELD action with MAC addresses. > Track crossing MAC addresses boundary and arrange a proper > order for the MODIFY_FIELD action involving MAC addresses. >=20 > Fixes: 641dbe4fb053 ("net/mlx5: support modify field flow action") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh