From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A4A7A0548; Tue, 17 Aug 2021 11:48:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0946841198; Tue, 17 Aug 2021 11:48:19 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2057.outbound.protection.outlook.com [40.107.101.57]) by mails.dpdk.org (Postfix) with ESMTP id 9E3CA4014E; Tue, 17 Aug 2021 11:48:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F2iIZfAnkAOOXO8rDUJHmA0zcu2Q+DTJdOKBrZ6H62m/IonJEnIn5rhz2myhqg+ZXseAiDdxOUyPQ2iqBOlO1yB+tVCXVj/Q3K7+cPJP8yUNNPReW1BdUz9rZxxU6GEhtMST+GF53zIFF8hyTY4dvrVzrH0/uR9OMdQ+9jh2n7AMZjNTmnAwSUNuB3/Q4kxhVlJgqmUD5pRd4lbyUbUwAioiLUps5xKPqvyeeWbsT64Mitrzxf5ICROwhdF4ByM/gQa/CMXoJ3JYzxAEns2IOBjUR2Nl6vVOIzabK47CvILg2ssNKfStjJGyTvaGOzqnxk865pCBULXrJpfhjfmCeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sWyRarHXJzTjVY0hpStBNpmCxJNPx2oMs3pqGjKzVx8=; b=AUdi+r0xOSAlKajHQMBqduKIxKL6j7ZkvzxjnHOWuoVVrEyQBiZSkZnn8552XFpYC2UGLUU4mtG5klftdgs/hdMWgGvzazIMs/fo1gkqtS92/l2jOKRZNqoa7VzMCLEsxMuip8XrskqM+I/kSdDsdDiBBIZEAoT7k4y3QEIjWuAqo3V85qNDhuOu69N/NHzefbQArN11OOr206fypEGqMqGAK98ZFEemzCeREpo8H6BLjbgLGNEN61swLM1oM41ia6xYOEHurqjujNYssyaSAxLwiq1YR++7nrPGWu43iHAzCaSpIEo3HUtbDdBLws9u7Nozno08eBXDR/27vD4VFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sWyRarHXJzTjVY0hpStBNpmCxJNPx2oMs3pqGjKzVx8=; b=T1EFNJ1ABccmrbwHUbUCIlkIDMy+Y9Pbm5ROgToE53brlMOL8Ma5G9idDxII09PfME5qcZ0HU7cLzzlfJ+jzdkxb1D77PsSKDJN745hf232JktC6OC19HexX+AXuLURR42Vzk1hGPkMRpWgWxdoikIVay9AOrRICPFRJkqzPK996VrDbC7QpONaM0hVqFieaQikv1zFhA9kchbc3QKqT8SlCHB/b2V0mhxeU3NcsDc/IYd3/HiBmExKCckvuTerdnwdMu7fc2x05PGWZMwnmcdh7ZhkjIw83dB4tc8oL9RlyC78GBdEYIbzULoF1syKFcLrH+tHFHQcgXBJcISuFAw== Received: from DM4PR12MB5054.namprd12.prod.outlook.com (2603:10b6:5:389::24) by DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14; Tue, 17 Aug 2021 09:48:16 +0000 Received: from DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::803e:a800:9fba:4550]) by DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::803e:a800:9fba:4550%8]) with mapi id 15.20.4415.024; Tue, 17 Aug 2021 09:48:16 +0000 From: Raslan Darawsheh To: Alexander Kozyrev , "dev@dpdk.org" CC: "stable@dpdk.org" , Slava Ovsiienko , Matan Azrad Thread-Topic: [PATCH] net/mlx5: fix mbufs replenishment check for zipped CQEs Thread-Index: AQHXiPlHha/iWwAi50Kg33SOqF19qat3h/jQ Date: Tue, 17 Aug 2021 09:48:16 +0000 Message-ID: References: <20210804062316.1688851-1-akozyrev@nvidia.com> In-Reply-To: <20210804062316.1688851-1-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 366e54ad-b1bc-4227-0a75-08d961642325 x-ms-traffictypediagnostic: DM4PR12MB5373: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EMJYQylWlcdyc7t1vGu74yo29RLinhaKd8jX+IPb+XbgvKi+zHvUI8dpcgOckq0J+9Txl9a4tGnncQ4fAMu2uBTskK31PfdYgAzuuQk9LTgALvbIafvcER4BHx9xV2uMqkRY1YMM4v8iM508gnyWHmYI/b7JGUwR2w6aqcY/ypYI5t2P3uqGiCmRj94fO18WsICNG6geVVfjJ8AaznjsETJAbXDY0kDXjxVkCdsOSOzuW5Vdgu475ORyJh4jdNZNcYdD3chAODKfz2wuy2GZXDy/MhuzQZ1NncvpUx3oqTGMOA8njmQQTslGvsRKMN2oV7O0QT+Q2hFyyfsJYd0scGnl4pQGJexyvTWfdiWNH250ibyRq/ApbY1FTxaJ1Hzgv4wwZEgoD3RjHV1Vd55iFrWGTi5oXdulictbN8sC/37wGa81irBEE6WBR1HDoxCgi2vn7Y9II6pHoy/PJW7zfnqNMUOn+GCICgYBpGynpteFHRAf5DkX1wIrrwTNzyRfjzkLR4/aUY7DtkPXLD4hWX47hbsew3rfwdXzjdyJEYYCV+2axYljkL+MaqId8Q0pW3tKDDa5Bw4A4a4ORQ9GOEju7/QRmMgwEMlEqMOHWxAg8rZPPSoXpfo9qV2QpJ76lbCFleF8sz9tvQrnYQF28MwnwaBxfwfblH6ee3c1fjfaj2SJTHmswHsYNJQ4bwrPXHT05ph3Y9QME1BEK7ZOqQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5054.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(366004)(39860400002)(136003)(396003)(5660300002)(4326008)(122000001)(316002)(71200400001)(66946007)(55016002)(2906002)(33656002)(107886003)(38100700002)(9686003)(186003)(76116006)(7696005)(450100002)(53546011)(6506007)(478600001)(66446008)(66556008)(64756008)(54906003)(8676002)(66476007)(8936002)(110136005)(52536014)(26005)(38070700005)(83380400001)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EkWN3C3OnG1NP+lqV/llKlFox3cVlaFX6MawQhes2xHNYHsEY9a76yrSq/HF?= =?us-ascii?Q?peFwpLzhiukVEaunMm3tupHMrrz/SpyuHa7jU9pyLTcXC3wkWaCiD2Dr3abB?= =?us-ascii?Q?RGNkhmLBoffIVIOK26mVVSTdaCH7bXJkR007/e7SQ/6t1y0t54INzTZfr9Kr?= =?us-ascii?Q?SE8VVx90GYn0ZN5xafHIgbmWf/KAoSv7VzfBzk2852bVPEoARwyL5z7ViV1i?= =?us-ascii?Q?05ssJoA4O5tTQeZQ9s6c1+hdL27sZpxzGC2kULBU4aJ6n/egkr/+DvHiaarn?= =?us-ascii?Q?uLP+CKhw4bljCIL5FbDm2bHj/gT15wlLpyhvLCaKpSjF4Tujua835EfMwyXq?= =?us-ascii?Q?hRx4HuKnNNHah1UX6sRWG4FzJkADZEtF/+kfpXORyDn0X9aMoj8Uuf336ua3?= =?us-ascii?Q?C7U5qOxiEAjfGQhYU/+UakShK01icPyKW9q5uDDYFuCi3T06azhqK+WniG7b?= =?us-ascii?Q?xcrO0X7v+Yxm+W2l9s4WKS6f3G53h58OwV67XqVF7T2K+Hq67mexgMEu5KT8?= =?us-ascii?Q?NVREi9UJYxOhcLRNdKNU2t2HmDdOgZKGDyBaNifcNSxtbqd/xkkM3Hfwlogv?= =?us-ascii?Q?oegWVdx1tLiI0W+26DfkykpVZKewcc13JmyQdJQww6rzu2cOVpmDTurgW2Px?= =?us-ascii?Q?Z1z3srrkflX0Jk3HxzdsSHMYMTvBMCiO/6GUeOLh3MWLdbVJJqle1s45/76E?= =?us-ascii?Q?SgCmaD6IFKqgH+vZ0jv/zq/zvCsApYt5Z0cgp2RojgytM5m4ha09w39pNomV?= =?us-ascii?Q?ElQAP0TMRlBl3rVbYcmMNYv+B5O7Guc0pULeM3zp+vNgxPXrZtNybwGjCJ0r?= =?us-ascii?Q?kB3RDx7lUPwjv6oPmJE9yFR1teOytqMiRjYmmlB72QpF66tLojvLFO3mR3Xd?= =?us-ascii?Q?A/ZyuwvMbZuQqxWk56ZMfnJFtdkR/BT59wNRiOpuysmMSi40Us+OtYxaQEtg?= =?us-ascii?Q?ZWhKFAnj2OjIi41/82ECbyR31SbvCU1n8GRgvJ5p6PGYQIY8gzVew+YxVC1/?= =?us-ascii?Q?mXyw6iBF9BCMlfLks5iJWOPI0rGvieoyf8lUXwJYvUHTVpNFYK5T4FLBItcI?= =?us-ascii?Q?XuOAYmX6FIJrGg235C73u6xE2KXgHGDxX4BwV0mrsbl2xOozZYrQ3Mhe8xgK?= =?us-ascii?Q?m0raXirW8wDOdhB+uyhjQMF7fHkD/p0wEf7zpczW0d1BH7zn11tSq/hX4HPX?= =?us-ascii?Q?UOzTo2y8HiT2wPwtVEvKsmJ9BAA+cwKOBRlFJJskoilScmBRDtesNIru5Nvi?= =?us-ascii?Q?rpHBR7USqessWNBT4P4VOuU0KEQHabl0q2qKEe8zS3/S3vG0IbX3vSux6FBR?= =?us-ascii?Q?qhPXZnaXk3NigE0keHIit4tv?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5054.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 366e54ad-b1bc-4227-0a75-08d961642325 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2021 09:48:16.2854 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HyBKefIuZ9WS9GUC7wfQ48fcndMaOBiEciOS1SvPPo1IVYUeqYe1bUctedVfSYnDWs6wbPYNkYcVu2o1nYug5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5373 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix mbufs replenishment check for zipped CQEs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Alexander Kozyrev > Sent: Wednesday, August 4, 2021 9:23 AM > To: dev@dpdk.org > Cc: stable@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: fix mbufs replenishment check for zipped CQEs >=20 > A core dump is being generated with the following call stack: > 0 _mm256_storeu_si256 (__A=3D..., __P=3D0x80) > 1 rte_mov32 (src=3D0x2299c9140 "", dst=3D0x80) > 2 rte_memcpy_aligned (n=3D60, src=3D0x2299c9140, dst=3D0x80) > 3 rte_memcpy (n=3D60, src=3D0x2299c9140, dst=3D0x80) > 4 mprq_buf_to_pkt (strd_cnt=3D1, strd_idx=3D0, buf=3D0x2299c8a00, len=3D6= 0, > pkt=3D0x18345f0c0, rxq=3D0x18345ef40) > 5 rxq_copy_mprq_mbuf_v (rxq=3D0x18345ef40, pkts=3D0x7f76e0ff6d18, > pkts_n=3D5) > 6 rxq_burst_mprq_v (rxq=3D0x18345ef40, pkts=3D0x7f76e0ff6d18, pkts_n=3D46= , > err=3D0x7f76e0ff6a28, no_cq=3D0x7f76e0ff6a27) > 7 mlx5_rx_burst_mprq_vec (dpdk_rxq=3D0x18345ef40, pkts=3D0x7f76e0ff6a88, > pkts_n=3D128) > 8 rte_eth_rx_burst (nb_pkts=3D128, rx_pkts=3D0x7f76e0ff6a88, > queue_id=3D, port_id=3D) >=20 > This crash is caused by an attempt to copy previously uncompressed CQEs > into non-allocated mbufs. There is a check to make sure we only use > allocated mbufs in the rxq_burst_mprq_v() function, but it is done only > before the main processing loop. Leftovers of compressed CQEs session are > handled before that loop and may lead to the mbufs overflow as seen. >=20 > Move the check for replenished mbufs up to protect uncompressed CQEs > session leftovers from accessing non-allocated mbufs after the > mlx5_rx_mprq_replenish_bulk_mbuf() function is invoked. >=20 > Bugzilla ID: 746 > Fixes: 0f20acbf5e ("net/mlx5: implement vectorized MPRQ burst") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh