From: Raslan Darawsheh <rasland@nvidia.com>
To: Slava Ovsiienko <viacheslavo@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix timestamp initialization on empty clock queue
Date: Thu, 29 Jul 2021 09:45:20 +0000 [thread overview]
Message-ID: <DM4PR12MB505452D72DEC94E5F082A983CFEB9@DM4PR12MB5054.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210728142335.31324-1-viacheslavo@nvidia.com>
Hi,
> -----Original Message-----
> From: Slava Ovsiienko <viacheslavo@nvidia.com>
> Sent: Wednesday, July 28, 2021 5:24 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix timestamp initialization on empty clock queue
>
> The committing completions by clock queue might be delayed
> after queue initialization done and the only Clock Queue
Added missing auxiliary verb in the syntax,
Should be after queue initialization is done.
> completion entry (CQE) might keep the invalid status till
> the CQE first update happens.
>
> The mlx5_txpp_update_timestamp() wrongly recognized invalid
> status as error and reported about lost synchronization.
>
> The patch recognizes the invalid status as "not updated yet"
> and accurate scheduling initialization routine waits till
> CQE first update happens.
>
> Some collateral typos in comment are fixed as well.
>
> Fixes: 77522be0a56d ("net/mlx5: introduce clock queue service routine")
> Cc: stable@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_txpp.c | 21 +++++++++++++++------
> 1 file changed, 15 insertions(+), 6 deletions(-)
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2021-07-29 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 14:23 Viacheslav Ovsiienko
2021-07-29 9:45 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB505452D72DEC94E5F082A983CFEB9@DM4PR12MB5054.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).