Re: [dpdk-dev] [PATCH v2] net/mlx5: fix mirror flow split with L3 encapsulation

[Raslan Darawsheh <rasland@nvidia.com>]

Hi,

> -----Original Message-----
> From: Jiawei(Jonny) Wang <jiaweiw@nvidia.com>
> Sent: Monday, July 26, 2021 9:23 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU-Contact-Thomas
> Monjalon <thomas@monjalon.net>; Shahaf Shuler <shahafs@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix mirror flow split with L3 encapsulation
> 
> Due to hardware limitations, the decap action (such as
> VXLAN/NVGRE/RAW decap) can't follow the sample action in the
> same flow, to keep the original action order of sample and decap
> actions the flow was internally split into two subflows by PMD,
> the sample action was moved into prefix subflow in the original table,
> and decap action was moved into suffix subflow in the new table.
> 
> There is a specific combination of raw decap and raw encap actions
> to specify "L3 encapsulation" packet transformation - raw decap action
> to remove L2 header and raw encap to add the tunnel header.
> This specific L3 encapsulation is encoded as a single packet reformat
> hardware transaction and is supported by hardware after sample
> action (no hardware limitations for packet reformat).
> 
> The "L3 encapsulation" with mirror actions in the same flow was not handled
> correctly in the previous commit.
> The patch checks whether the decap action is part of "L3 encapsulation"
> and does not move the decap action into suffix subflow for the case.
> 
> Fixes: cafd87f62a06 ("net/mlx5: fix VLAN push/pop and decap actions with
> mirror")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> v2: update commit log
> ---

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh