From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15895A0C43; Wed, 28 Jul 2021 15:07:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8859040E64; Wed, 28 Jul 2021 15:07:39 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2085.outbound.protection.outlook.com [40.107.223.85]) by mails.dpdk.org (Postfix) with ESMTP id 6C5F140142; Wed, 28 Jul 2021 15:07:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eStkYaigMNQ5LSd2mmUfdmABt8aCWW8av1GXHIFT1QFBcZdWcPIkhUIFI4aABvLuaq4bmV7/R4yJCSelY7XgOeqo0uRGlLk/ME3aRTVGrIhqrWC+OXIPzACW6F8P93pMoE6zSdGqOLTr0tgQdHfeK8NdZk9oxP+z+KYrMQW5ziL98zmf2qAy+r80Xkq/wd+gg5aYU72K2gqFCwQ7/0mDDJdKxrPNBWvySs9/HgeTTkOV89vsHS/BgFFwnVCjGSTMjU0yTAiyTOrw8Qo4X9NcSwqBVmxAh1qZJATCsUlcegSAm/OWXsOfLMGJ5Vq6yY9Y6rmM8wEdvHFRk0rhOjzEZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wbgzNhJRi5qsOnF7BsGs6+rcO++1881WBj1Tz1ZPIOg=; b=mBLdiQLekvRwnJKtOGVMaJf3Q5VD0PwOvH4+q1q/xj2+kJVL1FnL7f5wQDssXmU0HZGVlcwqeqSLMXVh/Gm1wUnazmqTM1Dy9J7Ptw2f8bBYGfrAPXAKO0drLZp8hbGC9+Zpw/77nFLuDuOmOPxSt/AEyOdLA2lG+LOG94/dsD2ZJX9IdOMaRni5ka/ulF+316lze6VfAFeoaeVOHWhhFy0rehqh/BTmSa54RdC6OKsPBlHC218o5XpTFRZjICxuO7fPLwuQebFIMg9fVQAlwljYQE35w1I52nLvo8pMvGoDtvbk4MBDIMEhYwKvfXWNnuwY9TM+4R75mvMCObFxew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wbgzNhJRi5qsOnF7BsGs6+rcO++1881WBj1Tz1ZPIOg=; b=BFX4jQoHOxnWk+rdhvVE1y+790phbi3a3VhuIePj4juIW95pkuHWxPPGIstykmbtVRML/+LoC1B/D+xxdeMMDDaCMxSihFcta+hVwbbJpc23VCJfRSa9DwLLfccftLdJ1kz8V+ci4nkaROw7tNA1up917lYdmq+2AD/rpkNik2KB0W5mBdMCFkCcz+ooELoQwKCx0p8+WUgLbtMrlyVmgmFlyWxGASrZ6IQMo3A1P3shRbrfGEwhirOgyyBEP98uRHsoSeeNhJobF3ZlBTWZj/i9GBNTGVLgIWp4xlbiEE4AKii+rLb9UEhmUSOl0h9at+ubl/N0mZxnpeDoWc9p4w== Received: from DM4PR12MB5054.namprd12.prod.outlook.com (2603:10b6:5:389::24) by DM8PR12MB5447.namprd12.prod.outlook.com (2603:10b6:8:36::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.17; Wed, 28 Jul 2021 13:07:37 +0000 Received: from DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::584f:2720:1100:666a]) by DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::584f:2720:1100:666a%5]) with mapi id 15.20.4352.033; Wed, 28 Jul 2021 13:07:37 +0000 From: Raslan Darawsheh To: "Jiawei(Jonny) Wang" , Slava Ovsiienko , Matan Azrad , Ori Kam , NBU-Contact-Thomas Monjalon , Shahaf Shuler CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: fix mirror flow split with L3 encapsulation Thread-Index: AQHXgeat5f856luAEEKE5JSSXivgM6tYXyYQ Date: Wed, 28 Jul 2021 13:07:36 +0000 Message-ID: References: <20210723124338.18269-1-jiaweiw@nvidia.com> <20210726062233.30657-1-jiaweiw@nvidia.com> In-Reply-To: <20210726062233.30657-1-jiaweiw@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d3eaa9b3-d549-4a08-f337-08d951c8abff x-ms-traffictypediagnostic: DM8PR12MB5447: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:383; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8lSQkcqJZYdH/Hv2LosPr1bXOdJrz1nKSHsh05mQE7FoWx3/voBKWCN/iNyB64Kvu2TBIlvsAAj9vtt6dUyhx41NQJXXrStqlUxp0F2wG2c784ES6bzAJ89URPVFXvT2q0I7SzLG2Ff4OAVFu4FkmF4c8kcGO8uVB4T6Rpv5Inz8mg7pKJWeAYGV4p8N6zz/ksLSK72kgvCE8PtH1dgvauya6iA+/8+aRzNNAVEJRAoCV7gPjJXobSNQXvbg362DsH06+YIQxRXfZUBDrruOeisWnGFmr1dLiiIPC3Gj37wCdN5cqFx5OE4Rbt1+uIVkgEM1Zn8J2w5XBhhOpGyL3fvQetsoObNnN50+5HtRBS6OSTntd9Amn0ug8n20zdsW4FLiaHNa7ecKaZtigSIPMi5vrhJioYMfWikvJg/aGRFCe2/y/B+7IMIiybAYc/iuEivK4j1ebApa/9/hZnChoxsrMBRYdBMhh1unMwLuQM1Rt/Hh1w+5nxkwLxsx9n+AroPLyzD4H2lDP9oj98YIzZBTuV0RAE+tRK1LfkZMYun8yN5i4gyeoTOepu7Mf/3g8T5J8unDMrgbra2sChe4JC9eCfHmdb3gleCu3gv5OpjQjVRK2/nTBNxZQa737XbdgADZg1o8FywFawW3VhBECUoZKAEggE9pAtmT4lrQBv5E5c4w7pQoAO9+yV7CGg4+hp5RHo5v95F+0lCoYSUiJg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5054.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(39860400002)(136003)(396003)(346002)(478600001)(8676002)(66446008)(66476007)(64756008)(76116006)(53546011)(6506007)(66556008)(110136005)(26005)(52536014)(122000001)(2906002)(8936002)(66946007)(9686003)(38100700002)(54906003)(5660300002)(33656002)(71200400001)(316002)(6636002)(7696005)(86362001)(186003)(55016002)(4326008)(83380400001)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hqtL2BGLcLFIQ8JfrV+TdhzZKZsn+jw8gsw3j9Na3wDBQBVbLLz1mijZ4p+3?= =?us-ascii?Q?EE7nYX1mBzbTuxjSgBHfENkn8O9nZTinxOdRvw0CSeuj0ByHtHdWE5m4/WnX?= =?us-ascii?Q?RW/NQCTgcX2bX8FuWr2a/aYZ9dMOz4WLx2Iwto2g00bPrMem41Du960hzdDf?= =?us-ascii?Q?uap9cXCoXbD/iRpZFJn/eZf6TwO/kELQ6dioU+/110NJ8osoSkhuhQTz51SH?= =?us-ascii?Q?/bq9U7volWzmKykx1EAf1mtT0hRqwQq1TMyc+j4xb0DhxWgJBHFLeN0OodpD?= =?us-ascii?Q?r2gxpvWx8t8uOWvPjgYWhZl1bvD8bycuXKjk0jz21FAttwKhVABSJYEun8BK?= =?us-ascii?Q?t54TqmWqap0YtCO3GZgEI7PVieYyZqnYila1HW7pms0TW6Z1dbNW0PYE9gKG?= =?us-ascii?Q?Gl3PK2ZA/Eizei13or/Fa4k66O996C5MFkrc3YUQM46D9k7xCURW5m653FbM?= =?us-ascii?Q?yp2859fWK7P2LynHjPoXULXRn+H8xguhCbJ1ZAvD/V2wFIkxq+FdIxqIo42m?= =?us-ascii?Q?7OUDipSPAy7QmgTQicC/6LR4F+tO27b4Nwpw+3l69a29hIVrOP6Ti9FB/gJ7?= =?us-ascii?Q?nFQF7x75H/iqhOsG+VL6pPjHVAaZfGsL1TYHSifL/iqSpWX+KkRSGocynHtP?= =?us-ascii?Q?CeSbPq+3hh1cC4Uz+pAx+ZsGRE9W1FBTLO9sxaArJZPD9RnJUHhm9fe/TRjl?= =?us-ascii?Q?cKO/UYE6VUpK2bpLdH2iH6obbqN0qcu3HwEHjviXh/qul+hdXugrj5WUy7n5?= =?us-ascii?Q?n+oU0Ti++bwW2ewY8XMCoa2CoW5eCj5lG0B9MeNql87OwQ36cG2NPvUnNQsM?= =?us-ascii?Q?leqByY8+SM45KeTrNwyUO0XgH6HdMscuud6zUc0E9At22WBW7hngPbKbf653?= =?us-ascii?Q?0OGutCauFoBO52oKADi9zPC18y0DHydJhm/cJSGi1udc/NwvTNQr/5CU/xe8?= =?us-ascii?Q?75YFLGFE7b8XTwc0D1Ue0rdePXjuKHIWZ5RK92p0LpR+hX8MnU/My8t1GJVY?= =?us-ascii?Q?8FpsxnRWeS8SzBZM6jYipP6Rz4zfoUOi+9OrclVaaJ+rHfloHHUAPqZ8mh9R?= =?us-ascii?Q?t20mr+4ZZbuIkXAmVDzGANH/mD2hrKwLhvWkG8y908+BlEVGbXedn1S9Zb0a?= =?us-ascii?Q?pqiz8wn1GIziEpV/98Ug7DWOXnXcqbZ3LrME9Z8/DDazI0pDczVt1BmdMRde?= =?us-ascii?Q?4jL968wlgqsbvAtl7lLJrBm8ypGaKe+54zD3i8hFmTPW2ZlAeAhSS2Pqbw+1?= =?us-ascii?Q?M1VIut99AXZ4+CFIZaeG1yk3CKAx1d92Md36migGhkX7dqfet4pI56j4f3F7?= =?us-ascii?Q?1GM1wOg1B0iAOeuzC3rX82+t?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5054.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3eaa9b3-d549-4a08-f337-08d951c8abff X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2021 13:07:36.8302 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Z2o9m+vqnYJ8prrRmeya9LIZYwThUGorwnh3ltYFglC1Ma+O5UbV7Af7d4kIt0X5XmPjjvgtmu9ziZpI1KQ1+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5447 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix mirror flow split with L3 encapsulation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Jiawei(Jonny) Wang > Sent: Monday, July 26, 2021 9:23 AM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam ; NBU-Contact-Thomas > Monjalon ; Shahaf Shuler > Cc: dev@dpdk.org; Raslan Darawsheh ; > stable@dpdk.org > Subject: [PATCH v2] net/mlx5: fix mirror flow split with L3 encapsulation >=20 > Due to hardware limitations, the decap action (such as > VXLAN/NVGRE/RAW decap) can't follow the sample action in the > same flow, to keep the original action order of sample and decap > actions the flow was internally split into two subflows by PMD, > the sample action was moved into prefix subflow in the original table, > and decap action was moved into suffix subflow in the new table. >=20 > There is a specific combination of raw decap and raw encap actions > to specify "L3 encapsulation" packet transformation - raw decap action > to remove L2 header and raw encap to add the tunnel header. > This specific L3 encapsulation is encoded as a single packet reformat > hardware transaction and is supported by hardware after sample > action (no hardware limitations for packet reformat). >=20 > The "L3 encapsulation" with mirror actions in the same flow was not handl= ed > correctly in the previous commit. > The patch checks whether the decap action is part of "L3 encapsulation" > and does not move the decap action into suffix subflow for the case. >=20 > Fixes: cafd87f62a06 ("net/mlx5: fix VLAN push/pop and decap actions with > mirror") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jiawei Wang > Acked-by: Viacheslav Ovsiienko > --- > v2: update commit log > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh