From: Raslan Darawsheh <rasland@nvidia.com>
To: Jack Min <jackmin@nvidia.com>, Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Jack Min <jackmin@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix match MPLS over GRE with key
Date: Tue, 6 Jul 2021 11:42:02 +0000 [thread overview]
Message-ID: <DM4PR12MB5054C9B464787E983D5A067BCF1B9@DM4PR12MB5054.namprd12.prod.outlook.com> (raw)
In-Reply-To: <5cebc85325fbe3d9bcac626dd2838b8052c1c7bf.1625117923.git.jackmin@nvidia.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xiaoyu Min
> Sent: Thursday, July 1, 2021 8:55 AM
> To: Matan Azrad <matan@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Jack Min
> <jackmin@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix match MPLS over GRE with key
>
> Currently PMD needs previous layer information in order to set
> corresponding match field for MPLSoGRE or MPLSoUDP.
>
> GRE_KEY item is missing as supported previous layer when translate
> item MPLS, which causes flow[1] cannot match MPLS over GRE traffic.
>
> According to RFC4023, MPLS over GRE tunnel with optional key
> field needs to be supported too.
>
> By adding missing GRE_KEY as supported previous layer fix problem.
>
> [1]:
> flow create 0 ingress pattern eth / ipv6 / gre k_bit is 1 / gre_key /
> mpls label is 966138 / end actions queue index 1 / mark id 0xa / end
>
> Fixes: a7a0365565a4 ("net/mlx5: match GRE key and present bits")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2021-07-06 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 5:54 Xiaoyu Min
2021-07-01 7:46 ` Matan Azrad
2021-07-06 11:42 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5054C9B464787E983D5A067BCF1B9@DM4PR12MB5054.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=jackmin@nvidia.com \
--cc=matan@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).